Layer5 Meshery Development, 11 Jan 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Meshery Dev Meeting (Jan. 11th, 2023)

Description

Agendas of Today’s Meeting:

[Ashish] - Demo/Updates on Meshmodel API endpoints #6849
Few REST docs need to be updated
Switch from bool to string query params for order and search
Add asc,desc on order with sort
Add search on model level
[Antonette] - Fast tracking Next.js 13 upgrade 6865
[Abhi] SVG scaling problem in safari and steps to erradicate it
Steps:
Introduce consistency by reverting this PR.
When an icon is used directly from the libraries like MUI or font-awesome or something else, always specify the height and width prop.
Repeat these changes on the existing and newer svg components
[Pranav]
[Ruturaj]
[Ebi] Improve mesheryctl pattern list error message PR #6851
[Nithish] -
[Abdullah] -
[Harkirat] - remove the description for additional fields. #6861
[Ashish] Call for participants in CI call
[Future]

[Deepak]- update on the discussions-data-files-update workflow

[Pranav Patil] - “fixing broker and mesh sync hyperlinks ”

[Gopi Vaibhav] - Github Actions to tweet PR

[Harshit] - Dark Mode

[Subedy] - Latest Discussion post on integration

[Uzair] - GraphQL Subscriptions

Subscriptions for Telemetry PR #6868
Dashboard doesn’t update on detection of new K8s components
[Gaurav] - Snackbar/toaster use design system

[Ashish] - Cloud Events proposal in messaging framework

REST → Graphql migration for /api/events after finalizing event format
[Eeshaan] - Discuss Forum LeaderBoard

Initial Data
Parameters to be considered while making the leaderboard
[Deepesha] Writing program

[Franklin] - Discuss active user section on meshery cloud

A

Here we go live, welcome everyone to machine development. Meeting today is January 11th and before we begin the call make sure you write your name in the attendees list. I have already shared the link in chat. Let me share it again and if you haven't got a chance to say hi to the community, this is your chance um feel free to unmute yourself and give a quick introduction. If you are joining this call for the first time, I see a couple of new names in the participants list, so I would like to go first.

B

And yeah I'll go first, so I'm Chetan, so like I'm here for like to know more about the message, development and like how to be able to contribute to this uh open source and yeah. That's it for me.

A

Yeah, that's great welcome to the college Ethan.

A

So we are yeah.

C

Oh sorry, yeah, it's a great to say more um what what? uh What? What do you do currently do you study work.

B

No so I'm working in a startup, but mostly on the front end part but uh I'm like uh so I'm interested in the back and also so I want to be able to learn that be able to contribute to like back-end development, so yeah, that's right.

B

uh I've explored few open source projects, so a phone measuring and and I've joined it yeah yeah.

C

Oh yeah yeah, you know yeah right, you explored a few, but then you came across meshery and you know, and then here you stay so yeah good, yeah, good, there's some there's a little bit! There's different back end that floats around around here.

C

um Certainly some golang gets used um and then it kind of depends on and then and there's and then there's SQL uh there's a little bit of rust. There's a bit of C, plus that we haven't touched for quite some time.

C

um There's some GitHub workflows with some bash scripts and things like that.

D

C

Probably missing a few things, but uh yeah, don't don't hesitate to get your hands dirty one of the things that you might get your hands dirty with. As you look at creating that leaderboard is.

C

The extraction of data, so if, if um uh if you're, you can either grab data real time, Json real time from the discussion forum and display or maybe I'll drop a link to point out how it's been done in a couple of other areas uh where we pull the data first using a GitHub workflow, so at least that'll serve as an example for you, so maybe some back-end stuff there anyway.

B

Yeah yeah Tim hereley yeah, and do you have any dog or anything so that uh it would be like, like introductory, to be able to like, like some design dog, to be start developing to the back end?.

C

Yeah. Well, yes, that's a good question like there's a doc specific to the use case that to the issue that you've signed up for.

B

C

Yeah there's two of them actually and then there's like a hundred other docs for the other back ends that we have so there's a lot of projects around here. So but we'll get you those two links as a matter of fact Casey or Sue Betty.

C

um If they're on the call they can help with that.

C

So great yeah, sorry to interrupt Garth I just want to say hi yeah.

A

Thanks for introduction, Jaden and yeah, if any of them is uh if you're joining this call for the first time, I would also like to say that uh tomorrow we have um newcomers meeting in the newcomers meeting. We share all the resources and we talk about different projects of player. Five, so make sure you join and grab a project.

A

So next up I see uh Aditi, atharv or gurpreet. Anyone would like to introduce.

E

Yeah I would go uh hi. Everyone, myself and I'm currently pursuing uh beta computer science from Flight, Team, gwalior, India and I have uh expertise in a few of the languages like golang solidity. Javascript and I've worked with many of the Frameworks like react next year as cap p, and in the backhand side also, there I have explode many libraries and yeah. That is all about my tech stack and yeah I'm here to explore the open source world and to contribute in this community yeah and yeah.

E

Also I I'm here to discuss uh one more issue that uh gaurav said he wanted to discuss with me on the Demi yeah.

A

So that's great, you already have a PR.

E

A

Okay, so did I left any of any other newcomer.

A

Yeah, if not feel free to introduce yourself in chat with that I think we can go ahead with today's agenda items. So first up we have Ashish on demo of mesh model API. She should like to share.

F

G

Oh okay, so little bit of context this uh there is a pull request over here and then there is a subsequent pull request in meshkit as well and.

G

Okay, I did not create it over here, I'll have to uh created. First, the the changes are local, but anyway, so investing machine. There is a pull request, which is about um refactoring, some of the endpoints that you already have. So there is an endpoint docs that there is a link to that Doc in the first in my task in the meeting minutes- and this is that particular Doc- and initially we had these particular grayed out.

G

um Endpoints the mesh model, endpoints and mesh model uh is a new construct that we are just to give a little bit of context. Mesh model is a new construct that we have introduced to package uh the different entities that meshely will support uh like different kind of things like component definitions and relationship definitions, and these definitions basically means that uh this is just like in kubernetes, you have custom resource definitions that can further support your different custom resources.

G

We have relationship definitions and component definitions and then in future policy definitions that will allow machine to extend its capabilities to basically consume other projects from the cloud from the cncf ecosystem. So components are one example of that. Then there are currently there are only two being implemented. The components and relationships policies are on the on the Milestone. So initially we had the structure, which was where model was so.

G

The root resource was not modeled and model was an optional thing, but recently there was a change made and after that change, the construct of model is uh pushed onto the route and the entities that I mentioned like component and relationships and policies. All all of these will come under model. An example of model uh can be kubernetes, istio or traffic mesh or, let's say Argo CD. The these are like uh the definite examples of what a model can be and the one example of component can be under istio.

G

You can go, then the component can be authorization policy or, let's say, virtual service destination, Rule, and then relationships are mostly construct, so the relationships can be hierarchical, relationships, something like where you have uh all the like. For example, pod has a hierarchical relationship, let's say with namespace, so those things are defined um and under like these definition, files which are stored in the SQL database, and then these are retrieved through these endpoints.

G

So uh yeah, so the behavior that is described over here in the spreadsheet this behavior is uh verbatim implemented, although there are few things that are missing right now and these things are described over here, so just to go over the thing, real, quick. So at the root you have the model resource.

G

So if you'll hit this endpoint you'll get around like 424 models that we support right now and uh as you can see, these are all the models that we support, and uh here you can uh so I'll not go like uh there's the ph and Page size. Things are uniform across all the different subsets of these particular endpoints. So, like you can do page pieces, I don't think I need to like go over.

H

That one question is there some kind of swagger dogs that can.

D

G

Right, yeah yeah yeah this particular uh this thing is from my PR and uh there are some discrepancies over here. As you can see, these are because some changes are required in mesh kit. uh Some uh comments, so other comments need to be added on meshkit and then the release of mesh kitten, then over here so yeah. In my peer as like the first thing that I've mentioned is that few rest docs need to be updated.

G

So, although these really things like uh relationships and uh components are added over here, but as you can see, there are like the response is a little weird and there are some things needed to be added in the description. So these things are generated from Swagger and uh yeah. This is there would be Swagger docs for all of these things, so you can, instead of like uh reviewing the pr you can go and look up the slash reference list apis on the on PR.

G

So there is this or preview for this particular comment that, if that's already present and these tests are failing- because uh I'm referring to my local mesh kit uh in my this, this video, a PR and as I said there would be a mesh kit release required and for those of you who don't have the context, mesh kit is, uh is a common, tooling library that is used across most of the Misty projects. So every function every interface, every struct that is like common to every all the projects in Machi.

G

It's been pushed into meshkit, so um so yeah about that question, the rest yeah. The talks are generated from the from Swagger.

H

Okay, oh but they're, not they're, not like deployed with a local measuring instance, and you can like functionality with uh in with with swagger you can just like press try out run like is! Is that um something that comes with the local measure instance, or it's just deployed to like the mesh redox, with viewing capabilities only like there's no way of executing it.

G

On uh if by viewing capabilities, you mean uh like directly, what do you mean by viewing time from inside Swagger? uh No, that doesn't come like yeah that that's not present under Messi server.

H

G

These These dogs are separate.

H

G

Yeah, so uh I I won't go over what PHP says. So this is like these are all the models that you have and then you can um like under model.

G

uh Then the next you can have a component or you can have a relationship, but first you'll have to Define like tell what model so, for example, I say still then for for this particular thing it will uh give me the model information and then there would be a components array and then there will be a relationships array and in future there would be a policies array.

G

So all the entities for this particular model would be uh served over here in this particular array, and uh on this particular thing you can even have like some kind of a greedy thing. So if you, if you do I guess it was search equals true, uh then, okay, it is on per component thing right now, I think I have added this thing over here, yeah, uh add search on model level. So currently search is not present on model level.

G

In my in this particular PR I have there is one comment that I have to make so yeah. uh That's why this particular thing is missing other than that under istio. You can have component or you can have like a relationship for component. If you can have like these uh components, that I was talking about like authorization, policy and uh destination Rule, and so on so forth, and over here you can then search for you can have a greedy search. So anything that starts with auth.

G

Let's say for this: if I specify search equals true, then authorization policy comes in so UI can use this particular search equals true for uh things like greedy search, so that when users are typing it uh you know, I can really. It can do lazy loading and fetch fetch it from the server later on and again PHP size. Those kind of things are available and the same goes for relationship, so I won't go over each of the each of the thing.

G

uh The the description, um the this, the exact description need to be updated over here in the uh as uh Mario pointed out in the Swagger docs and uh like this, these few things are missing because of the meshed thing and oh, like yeah. So these things need to be updated. So I'll update it uh within like just after this call, uh so the Swagger docs and uh the other thing is yeah. So in order to be consistent, there was uh on on the image API endpoints this particular proposal.

G

There was this uh uh I guess or yeah this order yeah. So there's this query parameter order uh currently in my particular commit I have uh I'm, basically I'm, not specifying uh so, for example, you can do things like order, but order is more like at this point: it's like a Boolean, so you can order on one particular thing, but that needs to change. So on my PR, what will happen is that, on order, you can specify the exact field on which you want to order things.

G

So, for example, your component has a kind it has a API version, so you can specify order equals like kind and then to specify whether you want it ascending and descending uh over here there would be uh basically on sort, you can say ASC or d d e s. uh That thing is not over here in proposal, but yeah, that's what like I'm proposing, because that's consistent with uh other API endpoints that we have.

G

So that's the second change and yeah the Third change I already talked about search on the model level, which would be again I'll need to make some change in the mesh kit. So the after these three changes, uh we would be migrating to this particular uh to these new endpoints that were proposed. uh The rest are already like the rest are already okay, only two or three things are missing, which I already pointed out here. So any other questions regarding this thing.

A

I guess that's I know so. Thank you. Ashish.

A

So next up we have uh Antoinette on uh next year's upgrade and other mystery Package upgrade.

I

All right so um so my update is working on, didn't it uh to Get It upgraded to 13.. um This is basically a fast track, so that means um we're. Having some there were a couple of issues from the the CI I'll build uh that Mario had mentioned so I'm, helping with that uh PR at this moment to just try to get it. You know just get it to the updated uh version, but still applies from my other PR that have already been working on.

I

um Once we make this change, then we can go ahead and add everything else that I've already been working on onto um after that. So I can share. Where I am uh well, you can kind of see what the what it looked like right now. So, okay, so here there were a couple things that I made changes.

I

One is specific to the.

I

Tunic which we're on 13 and um and I forged the salt uh jsx to be at version 4, because it's a breaking changes when you change to five and.

I

Also um change around a couple of the uh of the scripts, so instead of using eslant, then you can just use knit and um since it already has built-in support for it and just kind of clean it up a little bit to where everything else doesn't have be at the day of 16..

I

As far as I can tell, it was working on my end, um but the uh the workflow wasn't going through um when I made the changes hold on um but anyway, so because of what I did uh there were a couple of temporary changes that um I don't like doing, but this is just only temporary until we get everything else moved. So one of the things to keep an eye on is this particular file.

I

This right here will keep all of the packages that are at the old quote, unquote that um that needs to be oh, go.

C

Ahead, sorry, I'm, sorry to interrupt um I wonder if you're sharing are you? Are you sharing the measuring dashboard right now, because that's what we're seeing.

I

Oh yeah yeah, so yeah I I am just so that you can see what it looked like after making the changes. So, as you remember from the last few phone calls that we had that the uh the icon was very large, so I found a temporary effect where it's smaller now, but um you will have to call the uh the actual class name so because there are other um Starling properties that are added to it, since it's combined in two separate classes as one. So um this is just temporary.

I

You can't see it, but you can see it here. This very tiny, blue down air. You can see it there, but um it's not showing here, but that's only because I have commented out the line where it combined two of the classes together, so once I get that fit that you'll come back up, um but in the meantime, when I didn't make the change, it also changed the uh the link uh uh color.

I

So now I got to go back and figure out where, uh where that change was made, so I'll just do what I do before create a new. um You know stocks and scratch and see where I made it uh made the change and then just figure out from there. But this is how it looked here um and, as you also noticed that a couple of the iPhones are black and I went back and changed the the drawer icon starting to to it to be white. Yes, question.

C

To interrupt you, and that is um it's coming from a place of ignorance and I'm, happy to ask from that position, and that is what does the next JS upgrade have to do with CSS and SVG or how are those getting impacted.

I

Right right, so what what? What happened was um when on one of the phone calls that we had whenever I did, do the upgrade to 13 it made some of the icons and some of the styling get all all uh wonky, and so, while I was trying to research the way to get the icon to not be so big, that's the the temporary solution that I found in that part.

I

um However, I know that we are working towards um creating our own SVG. So in the meantime we can you know that that can be another solution to bypass some of the little uh temporary effects that I've done so um but yeah. So this. This is just only just so that you can see what what by making the changes and then some of it was still breaking just a little bit so, but with the next yeah can.

H

We see that changes sorry, so we can kind of like see how one change like what what we're trying to do and then what what change you have to do, but then how that triggered like a Cascade of what is it like dependency Health? Do you feel like that? Like is this? That kind of like the case.

I

Yeah, um let me see.

H

Like you update one thing, but then something breaks, you update that and then that I think that's special with between xjs react version. Some other libraries, including webpack right.

I

But yeah, so it's it's one of those things that um yeah you can't just do a fluid uh change and then everything will work so yeah um there were a couple of the like I said: a couple of the packages that that, if you do uh mpm audit to uh Force the uh um the changes it will auto automatically upgrade some of the packages. So that means to break an API, and so that means you got to go and we redo the whole thing.

I

So, instead of doing that, I commented out on a couple of the things so it won't affect. But, like I said it's temporary and and in my honest opinion, I don't like doing it because I like to try to have it working and then, instead of having to come back later and then have to pitch it again. So, but um if you have any thoughts on that, um we can still go through that.

I

uh It would just means that I'll just have to um I'll work on it for the rest of the week to to get it working.

H

I just have one thought like like: is there some like? What's the the first, the topmost uh Library you want to upgrade and if there, if there's a specific uh upgrade like migration guide that you're following just so that everyone else is like able to follow along because, uh like else, we could review your changes, but, like there's not much, we could say like uh just something to get us up to speed with a the effort itself like what what's the the process you're following and what's the goal like.

H

Maybe it's kind of hard to get that like what you're all that you already know on someone else's head right, but at least some some documentation that serves a purpose like like, for example, what's what's the the first Library you were trying to upgrade it? Was it a specific to the mui, for example, because because I think this is already like initially like. Besides the Cypress errors, like I mean the other PR, you were working on.

I

H

Something about the svgs I think.

I

Yes, uh material Yuri, they do have an official upgrade, um they actually upgraded. I'm sorry updated their documentation, so they have like a really great uh document on it, but um I've mentioned before that's baby stuff. So we really don't predict. There's a lot to to try to change over um I did mention India, the pr that we can still use the um yeah.

I

I'm sorry showed a link to what I'm.

H

Sorry sorry yeah yeah the link to that VR like to the the pr for the all the upgrades. Oh um I, think there's another one.

I

H

I

H

Yes, that that the original one.

I

I

I

H

So the two goals we have right now is one to fix the the Cypress integration test failures, but but that is I think that's that could be solved by your original PR. Like the audio upgrades I. Had this one right yeah, can you share the link? I'll, take a look.

I

H

Okay, so that we don't consume them timely all the time from the beginning, I'm sure this is already well described.

I

Yes, it that my PR has not put into the latest changes, so it does not have to check uh sniper 12, but I can you know I have been doing um different uh directories to to test changes outside of my current PR, so I can do that and once I, you know, make sure everything works. I can add it onto this particular PR. So.

H

Sounds good anything anyone else wants to add or ask.

C

um Yeah two things for me: one is in the zoom chat. I, put a link to um a real, um an issue, actually I think it's linked right there, but it's in it's an issue that contains some similar details. So it's it's. The first hyperlink in the description in this PR issue, number 6680.

C

um And so um yeah, so this is a different thing. This is this is actually everybody who's on the call, if you're participating in measure, currently we're iterating toward a DOT seven release, and so there are open areas of need, some things that have been done, but but actually uh internet. If you go back to your PR there's the first hyperlink in your PR description says: hey, this set of work is kind of part, one of a larger set of work around upgrading on various Frameworks.

C

So it's 6680, the first hyperlink right there, the first hyperlink at the top of your description.

I

C

Yeah under notes for reviewers kind of over by your avatar, but then at the end of the sentence.

I

Sorry my whole window: okay, where is it.

C

Yeah, the first um I hesitate to say it again. Yes, here let me let me share um that is that so Anthony with that ER that she was just sharing, is a portion of.

I

Them! Oh, that one.

C

Okay, yeah it described in this over our overall issue: lots of details about various you know: hurdles um to to use, Mario's your terminology, sort of dependency. How um so there's a bunch of Frameworks that we use and libraries that we use dependencies that we use that are in need of being uplifted and it'll, and they all have you know, intertwining dependency, and so it's a whole effort just to upgrade them all between react. Node, uh next.js, mui.

C

Those are the like four of the significant Architectural Components to Mastery UI, and then they import and use any number of other libraries Cypress being a related tool, and it's upgrading, maybe related but hopefully separate. So the only other thing that I wanted to add here was one was just a link to this for those that are interested to digest. This information is ashmeet on today.

C

um He was going to look into Monaco further and collaborate.

C

What I don't see him on um just so so I'm, taking a note of a dropped commitment and just like a just I'm saying it out loud for everyone else on the call, because we it's like really meaningful when people show up to engage, it's really nice, it's nice to get to know people it's nice to go. Do some do some great work together.

C

So if you commit to doing something, um do it if you can't figure it out or need help, ask there's hardly any other community that's more helpful um and if, ultimately, you run out of time or something else comes up or you give up or you don't like it, it's not an issue just signals it like ah hey, you're, gonna, unassign yourself. You know no problem.

C

If you don't do that, then we'll just assume that you're super lazy or incompetent or don't do what you say: you're gonna do or no I just can't. No anyway it just uh just communicating set expectations so anyway, ashmeet I'll send him a message in Slack about that.

C

um So the thing I was gonna say is um internet. If we could, if, if you can do the smallest thing, we want to break this out in piecemeal, so you've done one upgrade already and which is a collection of things, perfect yeah. If you can, if we can this week's goal with like the next JS upgrade perfect I'm. You know it does look like you're using an older version of the UI. At least the version that was listed in your dashboard was like 5.66. So maybe that has an effect.

C

um I recognize that an upgrade of next.js means that you know styling and icons might be impacted depending upon other dependencies in other libraries that also have to be upgraded, um although I'm still surprised, assuming that you're still on the same version of mui4, is that right, you're, not upgrading any UI right now, right.

I

um uh For this particular PR that I was working on with Mario yeah. It's still on version, four, um the my other PR I have in between on four and five and when you notice some of the icons that are different color, that's because it's using the uh the the new one, um the default theme from yeah. So.

C

But this week for this week that's not a concern. Is that right.

I

No, it's not a concern. I mean I just need to fix a couple of the colors, uh but the icons I'm, trying to figure out. Why.

C

Let me make sure I'm doing good so actually for this week, with an upgrade to next with next Js yeah. We.

I

Can it's just I just need to fit the colors? That's all.

C

Yeah, so this is where I'm trying to get to is, how are the? How is how are the colors, so mui is staying at version four this week and then this is just my ignorance. So this is you educating me um how are um yeah, how we're using for some of the icons we use different libraries to pull those svgs from those icons and for The Styling? How does that get impacted, as next JS is, you know, interacts with mui, but if we're staying at the same mui version, how is our styling getting impacted.

H

Isn't it because of the react differences that both depend on from the reactive.

C

H

C

Also integrated this week, that's also part of the okay. Well, therein lies my confusion. I.

H

Don't know like maybe internet can sorry. Anthony can confirm I'm, not sure to be honest, yet.

I

Yeah yeah, no, it's part of that. The uh is part of that which we had 18, because 18 is different from 17. 18 is more strict, and so it's like right now. If you try to run it, the the console is very noisy, but you can turn it off, and so um in this uh configuration you can turn that off. So that's fine.

C

Make it much more simple: yeah, that's fine, so it isn't the case that just an xjs is being upgraded this week. It is also react and there, in my confusion as to how it is we would be our styling would be impacted because next year, I shouldn't have anything to do with styling. But so so, let's be really clear. This week's goal is next.js 13 and react 18.. That's what you're saying.

I

Yeah that's my goal, but I will let you know if the the siren become too much of an issue, then we really need to do the uh styling um in the meantime, so yeah yeah hmm I'll, do my uh what you call it a scientific method just keep trying and trying to see what works and then yeah. So, okay, all right all right.

A

Okay, so let's move to the next item: that's by Abby on scaling of svgs foreign.

F

Okay, so uh so there is uh two three problems with the SVG that we have right now and uh one of the major problem that we are facing, mostly in Safari uh I, mean most commonly in Safari, and uh what what you do is like, whenever you zoom in and out uh whenever you zoom in or zoom out right.

F

So what you see is uh the icons, don't get uh don't scale properly uh either they are I mean when you zoom at one of the highest level, the icon looks very small or when you zoom out to the very lowest level I mean the icon, don't Zoom or doesn't catch up with the rest of the things you see in the UI and that's somewhat creating the problems uh when, when someone is sharing their screen, I mean that's a common problem that has to be eradicated, uh yeah in general. So.

F

We uh there is a step to eradicate this problem, so earlier we have discussed it, some I mean uh in the past. We have discussed it uh where, where we get to this solution, uh implemented here by Krishna. So what what I mean the main problem? That I just told is that uh that the that the scaling doesn't work perfectly fine and it's most prominent in Safari, and you may have question- is seen Chrome or some other browsers, I'm, not sure about it. So yeah. So that's that's.

F

The fix that has to be put uh I mean that Krishna put, and uh that was discussed within the team and the solution has been I mean we. We went through this solution, so what it?

F

What it is doing here is that it is kind of uh we are I mean we are going through all the mui icons that we use, or all the photons of font or some icon, that we use uh and uh and and kind of using that icon, getting the code from the icons and uh creating our own directory of icons and using it uh and uh with giving you know some static, height and width.

F

In case you know, height and width drops are not there, so this is the way I mean we are doing things and that's, and that is that somewhat solves uh solved our problem. But there comes another problem of maintaining that same code because there has to be some line, I mean whenever you write code, you has to maintain it, so the time will come when you have to use the next set of icons from one of the libraries that we use uh just right now and you will have to just copy paste this.

F

The same thing that you can you know just use directly from the library into our own directory and this problem get worse. When you are, you know, doing or making changes, making any changes in the other repository that we have, which is called measuring extension repository. So that's a that's a Crux of the problem, so this approach definitely doesn't work fine and if it does work fine for the temporary case, I mean for for a very short period of time. uh So it's not very maintainable in a long shot.

F

So this is what we have to follow uh in order to you know, get out of the root problem that you are facing right now, so yeah, so first of all, like I, will start with reverting this PR because uh because, as I said like this, this is fixing the problem right now, but it is not maintainable or scalable and we have to use certain number of other icons, and uh this has to be you know there has to.

F

There will be multiple source of Truth and all the problems in the world that we can assume. uh After you know, uh yeah copy pasting, the same thing again and again from the UI leverages. Secondly, uh I mean the root cause of this problem like why this problem in itself is happening is because there is a height and weight property that needs to be you know uh placed or that needs to be put there on each and every SVG.

F

And that's what one of the pro thing that uh this component library that we have created does that like? If you haven't mentioned height and width, it will assign the 24 pixel or 20 by 24 pixel item. So that's the root cause that you are not assigning some height and which property, and for that you have, you can't take risk of you know just copy pasting whole of the library. So what we have to do is just whatever switches that we are using right now or we will be using in in the future.

F

That has to be going through a central framework uh that will assign the height and width property. So uh and and and then you know uh calling the I mean using the library, uh but it, but all the svgs that we'll be using or that we are using right now, will have the height and width property set to some value. That may be uh static. Value like that would be stat equivalent, of course, so yeah so I mean. If we do this change, then then we'll get rid of all the scaling problems that we have.

F

Maybe one of the problem that Antoinette was mentioning uh today uh about you know, moving to mui 5 and next 13, and there was a problem with the scaling of like icon, looks extremely big or very small, so I think.

F

If we go by this approach we will be somewhat I mean yeah, we'll be somewhat straight or somewhere trigid on what we are using and why this thing has been done, uh or why why the actual problem of you know uh you are seeing very big icon visually, so why it is happening because yeah we can just have get a proper control. That's what I meant to say in general! So so yeah! That's that's the thing, and uh with this like these two very minimal change, I mean it's not minimal, but very straightforward change.

F

I will be getting rid of many problems that we have around svgs right now. The third step would be uh to clean up the current test, which is that we have the the current SVG library in the Machinery UI. So this is somewhat messed up and there is lot of redundant svgs right now. That has uh you know, copy pasted, one again and again for no reason, I mean that could have been pasted for some good reasons of you know for a very short period of time. But again, that's not a good practice.

F

Let me yeah so so this is the uh SVG directory and you'll see a multiple of svgs are like they have just a change in Philly property like one of the color is blue and another is white so and- and there are multiple copies of svgs being used here and therefore node 407, so that has to be clean. So while we are, we will be working on this particular item, so it would be great if you can just uh also you know, move to uh removing all the redundancy that we have right now so yeah.

F

That was my point around SVG then yeah. uh Do we have any concerns? I, don't find any uh concern from my point of view around this approach, but if you do have like a piece.

A

Yeah any feedback or more question for Abby.

C

Are we are you're going to be posting this and sending it out for review.

F

Because yeah I have not created a PL, uh the pl just yet, but definitely like uh this I'll have to get some yeah.

C

I don't mean a PR I mean a design proposal.

F

The design proposal is somewhat this only, but I can just extend on the things that is written there, but yeah. Yes, okay,.

C

Putting towards what you just said.

F

I'll, send it further. You uh sorry.

C

Yeah, if you would put on in onto paper what you just said in words, that would be good. That's my outstanding ask for the last couple of weeks is like send out the proposal for review.

F

Yeah yeah, okay, okay, yeah sure, uh but the major Crux I mean with the hum or don't take away, is just these three steps or these two steps and that would be I I'll write it in more extended form uh and I'll. Send it.

A

Good, thank you Avi. So let's move to next item, which is by Abby on improving machine CDL pattern list, error message. So do we have MB on the call yep.

J

Yes, yes, I'm here, hi everyone, hey, hey,.

A

If you would like to share your screen.

J

I can't really share my screen because I actually have an issue with my PC.

A

See, oh no worries, I just show your PR and you can okay.

J

Thank you, yeah.

J

J

Yeah um I made the changes to the uh the pattern list, um error message so from the before now it displayed the um this get the URL stuff, so I just changed that mostly, but I realized that there are some issues with um with um when I created the pr and I think I need to sign. I need to get to style and stuff and stuff, but I I left a note there that there's an issue I, don't know. What's going on with my PC every time, I try it just shuts down.

J

Like I've I've tried that I know that I need to work. I read through everything. The error messages. I know: I need to get those things done, but every time I try to uh I can't test it. I can't test it. Every time I try to run kubernetes and Docker it shuts down. It can run D2 at the same time.

J

Every time I try to do anything it just shut down like it's I'm, trying to see if I can fix it, but for now like what I can do I'm trying to do that and I'm trying to get this. The signed thing done and uh I I tried yesterday it didn't work out like it shut down and I was thinking.

J

I'll, try again probably today and get that pattern, but I, don't think I'll be able to get everything like everything checked, because uh there are some part that I can't get done because of the issue that I'm having with my laptop.

G

Okay, so in a doctoral communities.

J

G

Okay, so yeah you can you don't need a doctoral communities? uh You can run the mix for command and run it locally on your system so that you don't have to run any containers. Okay clusters.

J

Can you repeat that.

H

Are you trying to run a like a user build like do you? How do you install the measuring CTL.

J

How do I do no, no I I've already installed it, but whenever I try to run um to.

H

J

uh Mastery CTL system start I. Think then I.

I

J

Messages and I tried to troubleshoot those names and from what I've read it's, uh because the um K8 is not running or something, and then, when I tried to also figure everything every the reason why I was getting that error as well, then I realized it wasn't running and it was running at first but then because I, updated messages and I think I think it has something to do with like the memory or something on my system.

H

Yeah, but you said you already: you already installed mesh residual, but can you explain what process you follow to install it.

J

I can't really tell you step by step, because I did that, like probably weeks ago.

H

um But I remember I, followed how like like did you? Did you use a specific tool like um Homebrew or like are.

J

You are you building.

H

The from source code.

J

No um I used. um um How do you scoop.

H

ah So that that changes things right.

C

Yeah, actually there is so uh heavy is.

C

um How do we make this concise, the the in the time that so hey it'd, be nice to talk I, don't think, we've gotten a chance to talk before, but lots of messages yep, you sound just as nice as in voice as you do in slack messages. Thank you. um Yeah yeah, um there I know in our interactions, there's been a little bit of confusion between um building the project versus running the like installing it so sort of yeah.

C

Putting on your developer hat versus your user hat and yeah I encourage you to do both like actually starting with your user hat is well. It should be a little bit easier um between yeah mem, if yeah, to run kubernetes like to run Docker in desktop or Docker desktop and kubernetes on your machine. It'll take a few gigs of RAM like it'll yeah, and that's certainly an issue that a lot of people face sometimes running just getting access to a kubernetes cluster.

C

That's remote is just as good that works just as well that way it doesn't consume as much local memory. I think Abby has advanced passed. A lot of this stuff, so she's spent some time installing meshri as a user.

C

She spent some time building Mastery CTL as a contributor, and now she has a PR up in which, um if I'm not mistaken, I, think she's trying to improve the user experience for specific commands so that users don't get presented back with, like this gobbledygook dial, TCP IPv6, uh 90 public she's, trying to improve that experience and let and like improve the response, and as she goes to verify um that the code change that she has made at Mastery CTL produces the response.

C

You know the desired as she goes to verify her bug fix or her ux Improvement. um At that moment in time you would all you know you would either want mesh Reserve or running or you wouldn't. In this case you might be yeah I, suppose that you're, not you actually probably do have to have mesh reserver running yeah.

C

It's a little bit deceiving from I. Think the title of your PR indicates that you would have to have meshree server running, because what you're the ux that you're trying to improve is that someone tries to like import a pattern and something goes wrong and when it goes wrong to like show back a good error message, the description of the pr points out that that, maybe you don't need meshery server running because maybe you're trying to prevent it from saying yeah that what you had said like air.

C

You know that that terrible connection refused message and you're trying to improve it to say: hey measure CTL can't reach Mastery server. Please make sure that you have Mastery server run and when you do you you're trying to tell the user here, here's a very helpful command to Mastery CTL system check, so it if that's all right, I! Think in this case you are, um you don't need measury's server. Actually, because when you go to run your test with Mastery CTL pattern, import or pattern apply because you wouldn't have Mastery server running.

C

You then, should be able to see your improved response. Did I get that right.

J

Right I think I understand what I mean so I should be able to get I should be able to test it without running December right without starting the server. So I should be able to get this error message displayed without uh without running the server.

C

You said that a lot more concisely than I did. Yes, that's what I said. Yes, that's what I mean right? Yes, I did yeah.

H

Oh so this applies for the pattern list and the import and like any command or specific one.

C

Yeah, for all I mean she's working on a specific one. There are like three or four open issues, and this is good for anybody. Who's looking to get into golang, I, think or pre, and we might have been talking about this- is it like? Measuring CTL is a great place to dip your toe into golang um and actually focusing on these ux issues is a great place to do it as well sure I'll look into it.

C

Mario I, don't mean to cut you off. um Yes, I think is the answer. Oh no you're.

H

Right, no, that's good.

J

I think I'm just going to do that and then um I think when I read through the old stuff yesterday, and it says that I need to also go back and rebase and then uh include the sign off and then retry. So then probably I'll also test it just so that I could get those things checked so that it would be able to um once you get it checked. Then probably I can do the pr request again.

C

Yeah another another approach is there's a lot of mostly friendly people on this call um who well like or preach, is an individual that would like to hasn't made it as far as Abby has on jumping into Mastery CTL. But if gurpreet has an environment with kubernetes and he can test out, he can review Abby's, PR and test it out. So that would be great because it would help Abby would also be great because it would help grape, and so what do you? What do you know we're doing matchmaking on this call? This is great.

J

Right I'll send I'll, send them a message afterwards.

C

Beautiful, oh yeah,.

A

Good thanks I'll be Abby, so um we have four minutes left, so her kids would like to uh show this erupted.

D

Yeah I would be really quick right.

D

Just give me one second,.

D

We have um so I was working on issue on removing the description for the additional page so giving context for someone new. So we use rjsf for a form component uh that that the form the fancy form that you see in design configurator and in the mesh map when you pull a node. So um for some no for some nodes, we were seeing the additional text, like the additional description specific to additional Fields.

D

So um yesterday, I was on call with RB, so uh so, with V5 uh with rjs and B5 uh I have predefinedly how how a field I would look in a in the UI right and that custom field template govern it and it rules like how the things are going to be look in the UI, but additional property again being a special case, uh so it uh I suspect a bug in rjsf and what I'm gonna do is like on the latest betas.

D

Let better release I want to just test out the entire thing and if it works, then fine, if it don't work, then I'm gonna pull a issue in there uh repo and let's see how that Community respond right, but I hope they will respond, because yesterday I was talking to one of the rjs ever and they said, like just pull me, bring the scenario and yeah. That's all about this, and just um it appear, don't merge level. So we won't merge this PR until I confirm things.

D

So that's pretty much about uh removing the additional description but okay, any question I'll be quarterly.

F

I I, don't have any questions. It looks good to me. uh There has been like some change in the field template like the field. Template construct is new to B5, so we moved from V3 to B5, so uh there had to be some regression uh coming along. So this is one of the examples.

D

Yeah, let me confirm the behavior and let's see if it's, if it's actual burgund there are just a repo and let me pull out those people like tell them like this is a specific issue right and, let's see how they respond right. Thank you.

A

Yeah cool thanks foreign.

G

Yeah, so just to quickly plug the call in there is a build and release call that happens every other week. So the second and the fourth Thursdays it happens on 12 a.m. Central time so tomorrow is that call if you're already not subscribed to the calendar, please do fill the newcomers form and attend tomorrow's call. So we talk about things like unit test integration test, some of the backend related things, some cool language issues as well about GitHub actions as well.

G

So if you're interested in any of those things, please make sure that you are on tomorrow's call. There are already the already people who have been who had been assigned few tasks. uh They have. Basically the some of the PRS have been merged. Some of the updates are to be discussed on the tomorrow call. Maybe you can get your hands on some of the issues, so yeah make sure make sure to be there.

G

A

You, okay yeah thanks Ashish for making our call so yeah tomorrow. We also have newcomers call. So if you are still not sure in which product project you should contribute so do join the newcomers, call we'll be discussing about uh everyday five projects in depth: So yeah! Thank you. Everyone for joining today.

C

Thank you three.

A

E

Thank you, bye, everyone. Thank you. Everyone thanks, bye.