Magento Adobe Stock Integration, 20 Aug 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Adobe Stock Integration public meeting. August 20, 2019

Description

Masonry and overlay Ui components extracted to separate module to prepare to deliver to corer
Refactored GetImageList service to reduce the number of asset data conversions
Keywords displayed on the image preview

A

Okay, I think we can start well. Anyway, we are recording a meter so I.

A

Posted a link to cloud instance with latest code that can be used. The chat I would like to introduce feel much for joining our project as a product project manager, I feel.

B

Oh I, nice to meet you I, feel said: it'll be involved and help out. However, I can.

A

Great and let's start with demo, who would like to be first.

A

B

B

Share my screen: let's start from there, can you guys see my screen now not.

A

Yet yes, okay,.

B

Drive so the pool request we want to talk about is the one I start. I think was two weeks ago something and it was about removing unnecessary conversions of asset when, as you can see here, loading it from the API I start working on this and I'm, then I've refactor this week following and some discussions we search a and at some point I got stock and and basically sergej helped me a lot to do these things you can see. Many glasses have been modified, I mean we have.

B

We have Jettas at least that have been concealed. The necessary code has been removed from here all the changes that we're done get assessed. This test was also modified to do after there. The changes in in get us at least this pool requests also affect guests. Get us at leads interface as well. At gave us it get. Image least they image preview.

B

Press the javascript file data provider using in admin, stock lobby stock image, arming UI.

B

C

The data provided.

B

They sorry the unit test for the data provider I'm looking for the JavaScript file was also.

B

There is image preview.

B

Image preview HTML get image, place, interface.

B

As you can see, it was a pretty big change in terms of it wasn't change the functionality, but the main idea was to do remove the compassion between.

B

Asset to solid document to asset.

B

A

It a grater I would like to add that the main a changes it's it's worth to pay attention to in this pull request is that gets image list. Api was changed and it's not it's now.

A

Returning their framework search results instead of asset search results and its operating document interfaces instead of our asset interfaces, and because of that, like our conversion mechanism from document interface to asset interface, changed some field names like thumbnail, URL of different sizes and currently, because we are not doing that conversion and we are using the data as it is provided from a lot of the stock.

A

In the document interface, some field names have changed like preview. Url is now toenail 500 euro I also Creator, that name so crater was a separate or odd object and currently eats greater underscore name, because that's the data structure for category. It's still an object.

B

A

Sister is a debug information that was missed and have to be removed as well, by console logs.

A

Okay, good things.

A

Okay, thank you. Alex.

D

A

Like to continue yes,.

D

Yes, let me share my screen, I think my we can see my screen right: okay, yeah, let's start so, I would say that the previous week finish it for me under the symbol of composer settings and integration tests. So, firstly, I would like to say that now we are able to use our dev packages I, couldn't along with the stable one.

D

So with this setting in Cooper for stable, true, which I tested under the current magenta version in our dev packages, we are will have next, so all stable, but I just include it into Magento installation and our Adobe stock.

D

Our double stop integration packages, so this is a requirement to run integration tests because integration tests can be run only with the stable version of the framework. Okay. This is a first thing and another two one. The first is just already merged its remove unused fields from database schema.

D

B

D

Fields and fields were removed, just interface changes, and yet maybe it was so quick and I also open a pull request with the first integration test. Safe acid keyboard I had a detailed description, so all tests and decision I made during this implementation and it'll be nice just if we will review it and post some comments.

D

Yet, maybe maybe that's all from me.

A

Okay, thank you.

A

C

A

Now I would like to share some pull requests that were done by contributors. It's not present on the call.

A

A

Share my screen.

A

Can you see my screen yeah yeah, so one change that was done during the last week was moving our extracting the other VI module.

A

That is containing some templates, the image preview and overlay components, Muhsin retreat and styles. For it, these module is going to be committed to the magenta core like extracted and much Adobe stock image. Admin UI is reusing the components like it. It's now extending the preview.

A

Image preview component, using it as a dependency and are in additional elements to the UI like license and save buttons keywords and so on, as for keywords, so Shankar added keywords to our image preview and currently we show five keywords by default. But we have view all button that reveals all the keywords present here: their keywords and.

A

And the image preview, a UI design was updated as well and.

A

A

Should look like that.

A

Yes, so probably we need to do some additional updates for the keywords to make them a bit smaller and display more keywords by default, almost like my session is expired and also.

C

A

Are starting work on see recent water.

C

Wake up short questions question about about above the UI model, so we extracted general logic, so I deleted collagen and now we are ready to move that model outside of.

C

A

Yes, so other bi is going to go to the magenta repository or genetic or another. The IMS is going to be moved out. The.

B

A

Okay, good good, that's actually needs from my side.

A

Does anybody has any questions or comments.

A

Good then, thank you. Thank you. Guys have a nice weekend. Talk to you later. Thank.

D