Magento Adobe Stock Integration, 8 Sep 2020

Previous Meeting

Next Meeting

⏯

youtube image

►

From YouTube: Adobe Stock Integration Public Meeting 8th September 2020

Description

Adobe Stock Integration Public Meeting 8th September 2020
Media Gallery Granulated ACL Demo

A

I guess we can start the stories demo, then uh so, a previous meeting. We uh showed the renditions. That was one of the stories from this release, the 242 scope, and there is only two stories and the second one is going to be shown today.

A

That's uh media gallery, acl uh granulated, salva media gallery, so I will share my screen and and go to magento.

A

So here you can see the media gallery that is kind of a bit lost its functionality, so you can still search the adobe stock and you can even still license the image and to view the details of the image. But, as you can see like, there are no way to uh upload the image to create the folder. Even if we select the folder, so there is no way to delete images and use other functionality.

A

That's all happening because I am logged in as a test user and the scene with the test user is that media gallery test user role is assigned to this user and that role has pretty much all resources except the new granulated resources that we have introduced so in the same place under the content media gallery.

A

In the acl roles, previously we had just media gallery and under the media galleries there was adobe stock permissions and right now we added a bit more resources here. So that's insert assets into the content as a separate resource upload assets, edit asset details, delete assets, create folder and delete folder.

A

So each each of these operations can be managed separately and by the way I haven't checked this, but actually this user has the permissions to update its own role.

A

So, let's see if it will work without the relogi, I'm just curious. If we'll go back to media gallery, you can see that now for now, actually buttons are active, so I can create delete folder, upload image.

A

A

And the context menu also has more buttons here, and the panels also have delete edit buttons that can be used. That's basically how it works. I would add one more scene, so the the acl is actually in media ui api module, the declaration so that you can use the api module to reference to the resources themselves.

A

They are enforced in the media gallery, ui module and media gallery. Ui module also contains the upgrade script that will will actually check. If admin user has the magento cms media gallery permissions and if the admin user does, it will give all the permissions for granular actions. So, basically, if admin user had the media gallery access after the upgrade, all the child items like the granular permissions will be given to the admin and if admin user role doesn't have that permissions new permission, permissions will not be granted.

A

That will mean that, like on the upgrade, nothing will change from admin user point of view in terms of permissions.

A

That's so it's that was a quite a short demo. I would say: do you have any questions on this.

B

No, that looks amazing, like it's funny that I'm saying like degrading functionality for some user, it's amazing, but this is exactly what we wanted.

A

Okay, then, uh basically, I guess that's it for today I have a question to discuss here, yeah great. So what will we do after the vista configuration? uh What freeze and just when will have not active development phase?

A

So the plan is to complete alteractive development by the end of this month. Actually, there is not too much things left. Some stabilization bug fixes maybe a bit more test coverage uh to ensure that the project is still keeping uh stable while we are not doing active development and for aggression purposes right and so after that, like the the repository will still be, public will be open for uh issues reporting and will be open for the pull requests.

A

uh Well, that's just the adobe stock integration right, the media galleries that we are working mostly on uh the last uh several months or even half a year, is in magento repository.

A

So uh the plan is to move like if we'll have some uh non-completed feature, requests or uh low priority issues that will not be addressed by the end of this month. They will be that are related to media galleries. They will be moved to the magento 2 repository because that's actually, where the code is and so yeah, I guess the crew of adobe stock integration from community engineering uh site.

A

We will also move to work on magento, 2 repository and help to like help to process the volume of the pull requests that is happening in magento.

A

So basically we are stopping the storage development. The repository is staying active and we are moving our forces to the magento to repository because it it really needs some more attention from our site.

A

Okay, nice so- and I have two questions left so the first one. um What will we do if the adobe stock service will change its api or will add new functionality?

A

B

A

The first scene will hope that adobe doc will not change their services in backward incompatible way if adobe stock does it probably then we'll need to adjust our implementation, and somebody will have will have to to adjust to the implementation for the district okay, but I I hope that no backwards incompatible changes will happen. Probably.

C

The stack can introduce.

A

A new version of api and in this case yeah we'll need to plan and switch to new version of api yeah. Thank you for this answer, but I'm worried about the php version, so I think that the main may be dangerous for this. Application is in the new php versions, which will magenta support, but this library cannot be compatible with it. So I would say that it will be great to check uh the roadmap for php upgrades and maybe just and check how the php library for the adobe stock service uh compatible with it.

A

So, for example, in magento, in future, we will have the php 8, or maybe the php 7.7.2, for example. Yes- and this version can be.

A

And the adobe stock service library, possibly will not work with it and we will uh be in a not so good situation.

A

Well. uh First of all, I would say that the sdk libraries that we are using a current version require a php version requirement for the library is, as far as I remember, seven dot star. So that's, basically all the minor php versions on seven.

A

If there will be a bump to major version that well for sure it will come in some time. I don't know when, but I guess that it's our common interest to update the library- I don't think well, hopefully, there will be no, not too many issues with that. However, uh from my experience I don't know about our plans, exact uh exact, exactly for dealing with php version upgrades, but from my experience each time magento update the requirements for php version. All the project, all the projects are imagined, are also getting updated.

A

So that's part of the maintenance of the project stage, so we will keep keep an eye on it and boss. Adobe, stock integration and sdk is actually open source. So, even if we'll miss something like you can always contribute and contribute and ensure that it's, it will be ready for future upgrades, sir okay, okay, nice so and I I yeah got it. Thank you uh now.

A

I am just not worried about the future and then sdk library, okay and the next question may be um from the company not from the community, but maybe from the business side. uh Is it possible to add the great graphql uh or I don't know, um rest supports for the next feature?

A

For some, some businesses allows customers to upload images, for example, for prints on products or maybe uh for making t-shirts with images and so on and so on. Is it possible to add some endpoints to use the adobe stock service on the front end.

A

I guess yes, that's from the magenta side from the box.

A

Well, the scene is that uh yeah probably will need. If you would like to introduce that kind of uh api for the front end, you will need to provide the specific service for the front end, because, basically, what we are, what we are using right now is just adm login from the admin site in this case that will be login from customer.

C

A

And I'm not sure how we would deal with these uh api and secret keys. Well, probably the configured secret keys can be used as this. If merchant agrees to use it so elena, do you have any ideas around that.

B

I mean that certainly uh sounds like a good idea for an extension. There is no plan for magenta product to implement that because, like obviously the use cases were limited to specific merchants and from the technical perspective um I mean, I don't know like how challenging that extension would be in terms of the implementation.

B

But, like my assumption is that adobe stock api should have some end points. It's just like a matter of how to integrate on a storefront.

A

A

Yeah, but that should be yeah. Probably there should definitely be a different module if you are talking about the graphql apis and the apis.

C

A

B

C

A

Ims, module got it. Thank you.

C

A

You can use api event from adobe stock module to load the pictures and stuff like that.

A

Yeah, but I'm not sure, that's probably worse, take a look on the way how api key secret key will be used. Is it suitable to use it for like open customer login like guest customers and stuff like that, and are there any security issues related to that?

A

A

A

Okay, good, uh then, I think.

C

I have a question regarding our previous meeting discussion like we have discussed that uh how we are going to handle the rendition image on the on after upload like how we are going to handle the rendition image. So have we got any solution for that.

A

uh Sorry sankara, I had a short network outage. I missed the beginning of your question.

C

Okay, uh I was uh I was talking regarding, uh I was asking regarding the previous uh meeting discussion like we are discussing regarding how we are going to handle our rendition images. So have you got any conclusion regarding that.

A

uh How we going to handle.

C

The rendition is like.

A

Oh uh yes, yes, yeah, so the discussion.

B

Maybe thank you.

A

Yeah, I think it's related to.

B

The previous medium.

A

Yeah, so we uh we discussed, like brains, had a brainstorm with uh alena and eugene, and we decided that probably it would be a best solution to make it the most clear make the most clear approach for the customer.

A

In this case, we are going to regenerate the renditions as soon as the customer changes of the customer, the admin user, I mean in magento changes the values in the system configuration.

A

So basically, when you change the values in system configuration and you hit save, uh we are doing this. The same way like we are handling the ring array index or synchronization for media gallery. We are scheduling a job in them in the message queue and it's getting executed, updating all existing rendition images.

A

Also, rendition images are going to be added, are going to be generated when you add an image instead of when you upload an image, that's how we are going to limit the amount of rendition images that we are going to have in the media storage.

A

So all these changes are actually present in the pull request to magento. With the move of the modules, I will share the link to this pull request in the chat, so you can see the implementation details and how it's actually.

A

A

So the main changes from the initial approach was just move the generation of renditions from upload to insert of the image and add their generation of renditions to the save of media of the system. Configuration.

C

Yeah, but uh have we checked that it's if it's going to create any issue with the performance like we like? If you have like a thousands or ten thousands of images, and if someone changes the configuration and hit the save rendition, uh save configuration in your configuration, so it will going to take.

A

Yeah yeah yeah yeah. I understand your question, that is, the operation of regenerating renditions is performed asynchronously, so uh that will not hold the user and system configuration page. It will be done as a separate job.

C

Okay, so, but it's like uh in terms of like a technical point of view, the rendition images which are created, which are generated uh which is like, if user is not going to use those rendition image, then it's just a useless uh just occupying your like a hard disk.

C

So is it uh like a issue like we are discussing in the previous meeting that uh if you are creating like a duplicate images, then it will uh like uh chunking the hard disk like if you have like thousands of image and if you are generating renditions, then it when it can fill your hardest like uh in just a moment.

C

If you have a limited hard disk.

A

Yes, yes, so to address the space, so the change of the generating renditions. Actually, the moving of the generate operation from upload to insert actually addresses this issue as well and ensures that the rendition is generated only if the store needs it. So only when you insert the image to the content, the rendition is generated. When you remove an image from the content, the asset the rendition is, is going to be deleted. So when you remove the asset as well, the rendition is going to be deleted.

C

But if we have changed the configurations, so then what's going to happen like if we change this size, width and the height of the rendition image.

A

On these, the existing renditions are going to be regenerated, so basically, the image that you have as a rendition will be updated with the new size. It means that, yes, in the content where this rendition is used, the image will be updated as well.

C

Yeah, okay, okay, yeah sounds like yeah. It's a good solution.

C

We can also have an alternate solution like uh if we can generate regenerate the rendition on fly like if we load up a storefront or wherever the images has been used, and uh if it's like a quite big, then we can generate the rendition on fly and just save it. Save the image on the cache like this can be like a most efficient solution.

C

From my point of view, like yeah.

A

You mean by proxy.

A

Using the kind of cdn proxy.

C

No, no, not proxy like if we have like adding a parameter like a height and with if we, if the image is greater than the size of the rendition image, then on the page load, uh the image will get uh the rendition image will be generated and replace the image in the storefront.

A

Yes, yeah, that's I guess that's that approach might be possible with with some proxies, but actually I think we decided not to use that approach, because that will result into the issue. We just discussed about the number of rendition images in the file system.

A

If we will support the parameter for the image, we will end up with lots of images on the file system right because, basically requesting an image with different parameters for width and height will generate in your edition and, additionally, we will not know if this image is actually used in the magenta right in the content. It's just a request for an image and we'll have to generate it and return it.

A

That's if we are going to store the images. As for the second, your suggestion to keep it in cash, I like to generate it and keep it in cash. It's it's. It resolves the problem with storing the uh this keeping the space. However, that's still that kind of exposes the cache for being like field with lots of rendition images, and it will also probably decrease uh the performance, the initial performance of the cash generation and considering.

B

A

The parameters can be changed in a different way. It will be really hard to warm up the cache before actually go into production because you don't know which parameters can be used for that image.

C

Yeah, I understand yeah. We can't use this workflow for create generating addition, because we are going to move like so like every user has like different perspective like if, uh if uh some user is using pwa, then it's impossible to create generate the rendition. For that.

C

For that customer like for that user, like uh generating and renditioning on apply, is like not a good solution. Yeah yeah, understood.

A

Yeah yeah- well, that's, uh let's, say that's more agile and more versatile solution. In our case, we went with the basic like very simple approach to rendition, keeping it conservative and keeping it like as much as we can under the control.

A

uh So maybe you have participated in the at the discussions about the renditions on some meetings. Like a couple of months ago, we had different ideas on further uh how their renditions can evolve. Actually, but so what's what we are doing right now is the essential thing like just to address the really high images that high resolution images that can stay in the media gallery and to avoid having those images in in the content, because they, they might might not be even even close web optimized right.

A

So we said the current approach will have somehow web optimized image in our storefront and that's uh that's the solution. Actually, that's the solution for the large adobe stock licensed images that are not uh processed or optimized, to or specific stores for specific content by the designers. That's a basic solution that magento admins can use without any help from uh outside.

C

Yeah yeah yeah, the the current solution that you give is the best for our for our case.

C

Actually, I have seen uh like uh yeah as in the implementation of the thumbnail generation like uh if you see like the old media gallery thumbnail generation this uh they try to implement like they are generating the thumbnail on fly. I haven't checked in detail, but I I saw that they they have some somehow they are generating some thumbnails on fly so.

A

C

The thumbnails for old media.

A

C

A

Well, yeah: the old media gallery is scanning the file system on the fly and so yeah. It generates the thumbnails as it scanned the file system right and we are not doing this. We are having. We have the synchronization process separately and we have so.

A

We cannot generate the assets and the grid on the fly, but in like that makes uh helps us to have the high performance grid with filters that we can use and that and with all the functionalities that we have on the grid. That will be either not possible or really slow performant. If we will work with the live file system.

C

C

Thanks for the explanation, sir.

A

Oh thanks for your.

A

A

Okay, guys, thank you very much uh as usual, uh I'm always open for uh to talk to you related to magento, not related in the slug feel free to reach out to me.

A

If you have any questions or if you have any ideas and yeah thanks for participating thanks for your contribution, uh thanks for participation in adobe stock project in general, that's uh that was a really cool milestone and we are almost almost completed it and looking back, I am like, I think, I'm I'm really happy with seeing what we have done, what how much we managed to develop in not so long time, and so basically how how interesting and joyful this period was.

A

I think that that was really really exciting, uh really exciting time. I hope that that will.

C

A

Will contin that will continue uh on other initiatives when adobe stock project will be switched to maintenance mod? There is still really interesting stuff that we can work on uh in magenta and we'll see. Maybe there will be other cool projects around.

A

Okay, thanks guys have a nice day and talk to you later. Thank you. Goodbye.

C

Bye guys thanks thanks, bye, guys.