Magento Adobe Stock Integration, 10 Sep 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Adobe Stock Integration public meeting. September 10, 2019

Description

Setting the file name while saving the image preview
Overlay component
Profile information
Code coverage

A

While there are a lot of poor requests in the queue just a couple of them, Verma marched.

A

During the last week, so since the previous meeting and the main features were developed by 30 runners, that is not present of on this meeting, so I will demo the functionality added by him or myself. Let me share my screen.

A

Can you see my screen.

B

A

Good, so there are two main features now. First of all, the overlay actually is not a feature, but a bug fix. The overlay was fixed, so now it's the overlay example doesn't come up the layout. The overlay example is just an example I quickly. We will use that component to put some specific overlay later or anybody using that a bistec integration can utilize the component. The follow overlay by default, it's disabled, so I enabled it in the grid component by changing the visibility of overlay to true for this demo.

A

If it's disabled by default, it will not see any overlays on the grid and the second big feature is our inability to specify the image name when saving it. So right now we are able to change the file name and save it with the name specified by default.

A

The by default user sees the generated name.

A

Generated file, name based on image, name and shortened up to character limit currently is.

C

It possible oh yeah yeah. This is what I was I was about to ask. Is it possible to change the file type as well yeah.

A

Right now, it's possible to change the file type, so I can change it to exert, for example, and save so we have it's not displayed on gallery, but the file is actually saved at the file system, so we have to come up with the validation idea, how we are going to show them messages.

C

Do you even show the file type here.

A

C

We save whatever file type is originally, and we allow to change the file name only right, so why we show that it's.

A

Based on mock-ups provided by future and ok,.

C

I mean: is there any like value you see in showing this file extension yeah.

A

I've, actually, the original implementation first, first implementation and by sergey I was without the file type.

A

Then we added the extension to merge the mock-ups, but, as you can see, if there is no file type it's it can be confusing eyes. I would say from my point of view, but ok.

C

I mean we can add that as like non editable extension into either like part of the field right or outside the field, just to prevent that use case, we need to manage.

C

A

Thinking about it like here, definitely it will be easier to maybe like cut the Hilton show file type after the field. So that's it's clear that this is a file name of the picture of type PNG or whatever, but not allowing it to edit the file type.

A

C

I, don't think so because he's in Ukraine now.

A

C

A

C

It possible to make the file extension part of the field, but not editable.

A

I'm not sure Oh, like.

C

A placeholder not like a placeholder like looking like a placeholder but not editable,.

A

I'm not sure right now we can try.

D

A

D

You mean Oh Leonard, you mean like a input field with a gray area.

A

Like dot back- and this is not.

C

A

Great, but not editable, but moving together is input. I think that yeah I.

C

Am afraid that if we add that JPEG is after the field, this lone field, maybe we just can make the field? No, so that's definitely for ujin kind of to figure out yeah.

A

We can we can make the future I think it will be hard to implement the move in extension part, but it will be much easier to audit somewhere at the end of the field and making the pop-up shorter probably will make the interface more clear, yeah yeah.

C

Figure out what would be like the best and cheapest option to to do and Eugene will update the mock-up based on that.

A

A

A

Anyway, I will create another task for the styling of that pop-up cuz. It needs some small adjustments.

A

Margins font, size and stuff like that, and probably as part of this task, we can also handle the extension. The file extension yeah.

C

A

So that's I believe that's it for the demo part, and there is a question regarding the implementation of account. Pop-Up, so I have the design for account of open here and it looks like we cannot get the avatar of the user.

A

There is no way to get the profile picture or Adobe user profile. Is it correct, Christopher or are we missing something.

B

Hey I can ask.

A

Yes, sir christopher sir youyou probably was on mute and now oh.

B

You hear me yeah, oh I said that uh I, don't that doesn't come from stock I, don't even know it's available, but I'll. Oh.

A

Okay, that's so, okay, good thanks anyway, it appears that we don't have any API, endpoint or API feel to get the picture of the user, and we have to think about displaying a static picture here or no, but maybe maybe excluding the picture from the pop-up all right. So.

C

Do you know if we can display the rest of the information that you gentle poses.

A

Yes, hopefully we can.

C

Okay, yeah so I think, instead of just like showing random picture, it's better not to show any picture not to confuse people. Oh.

A

Sorry, what you were breaking I hurt only the end of the sentence.

C

Okay, maybe that was the most important part I said so. I said that it's better not to show the random picture and show just no picture basically shift the name to the left to fill a space of empty picture.

A

Okay, okay, Thanks.

A

Good so I'd say.

A

Currently, we have 13 pool requests in the queue for March that are going to deliver functionalities like signing Lincoln's profile, moral from this model section and filters.

A

There is also a licensed and safe implementation and progress, and much more so the week was really productive. The only thing we will have to process all this pull requests and deliver to the develop branch.

C

To story-wise how many stories we have left to implement I.

A

Say that all the stories are in progress right now, so we can. We can even we can probably start confirming and closing stories since, starting from the next meeting.

C

In progress and what would be like that timeframe, we expect them to be done.

A

I'm not sure about timeframe cause. There are some full requests that are.

A

Going straight to development replicas that requires additional mm-hmm adjustments several times so.

A

Even though all the stories are in progress see, it can take like additional couple of several weeks to complete is implementation, but yeah I think that's too real. The backlog dealer in the stories of milestone two are in progress. We have to start grooming some stories from milestone three and probably start creating some some tasks in our backlog. For that monster.

C

Okay sounds great.

A

Good, do you have any stories ready for grooming already.

C

Not now so we have Eugene out for Ukraine and yeah. It would be kind of nice to have to have no jobs yet to groom the stories, because you know like mock-ups, can change some some of the requirements. Yeah.

A

C

I'll work with Eugene to kind of organize some free grooming sessions like to discuss with him, know the user experience and hopefully that will result in some mock-ups for the next medium.

A

Okay, do you think we can start grooming next at the next meeting like next week, yeah.

C

This is the goal right because, since you have all of the stories in progress, it's basically we are short in time. Then.

A

We probably can have there's three sections of the meeting next time like the first one. Is them or the second one is confirmation and we can start closing stories of mouse on to and the third part is grooming right.

A

One more thing: we also have.

A

Infrastructure work and progress, I mean stuff like testing, CI changes and got coverage implementations. So as for tests we currently disabled, the API and functional tests will need to change the approach or those tests, implementation and once once it's done and designed once it's designed and done, we'll return the web api and functional tests and allow them to run on HP request. Currently, it's just studied unit and integration tests and as for code coverage, I'm, not sure role. If you want to share something, if not that's okay, to leave it for the next meeting.

D

Can you guys see my screen? Oh.

A

D

Right so this is the pull request in I. Think it's out of date and there's the page.

D

Right so initially, today and I tried to implement code coverage using third-party decent, cold cold cold. This is the result. The problem with this implementation, or with this tool in particular, is that, for some reason, although we send in the the the coverage file we send in this is contains the right information for some reason it doesn't, it shows it doesn't show the right results. So I was reviewing this thing.

D

Last week, I decided to either try to another tool called cold climate and in cold climate we can see.

D

We cannot see the best coverage yet I'm working on that one ball, comparing two to the other tool. We get some more things, for example, calls mail duplications, many many things comparing to to the other two, so so I think you're gonna carry on using this tool implemented coverage.

D

The issue I have with the with the number in here it's something about discussing last week with the people called climate I call response from them today what was thrown and I'm gonna I'm going to fix it.

D

Basically, yes, so many of the tables of this.

A

Okay, thank you. It will be really interesting to take a look at the final results of code coverage and also that this no.

A

Additional suggestions provided by the let's try it and see how how helpful it is.

A

Okay, I think that's it for today. Actually, if you still have any questions or would like to share any ideas or any things feel free to do it now, okay,.

A

Good then, have a nice day or a nice evening and talk to you next week. Bye, bye, bye, bye,.

B