Magento Architectural Discussions, 1 May 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Architectural Discussion -- May 1, 2019

Description

- breaking changes
- raising code style tule level from 9 to 10 for unsecure functions (EQP)

Meeting minutes: https://github.com/magento/architecture/issues/142

A

Arrested those bosses and I guess there was discussion yesterday that maybe that's not the right thing to do and we just shoot should not allow any and it changes in any classes for releases I wanted to discuss it once again.

B

My question was about the children on these classes so like and like we considered the casement. For example, we have some class. We this class is marketers API. We had some optional argument and this class is like used for multiple extension. For example. One extension like doesn't know anything about this argument and other class tries to customize.

B

So in this case, like we can customize this optional dependency for some class because we don't have any constructor, we can't use the XML.

A

What you say, you should still restrict.

B

Like I'm, not sure about like from my person, children, we.

C

C

But is this really minor I mean like.

C

But you can see they're here.

A

Whether we want.

D

But okay, so my point is we rarely mark bosses? We should. We should never mark closet. You should only mark interfaces reservation, but the mark closes with a Libyan officials are up for extension and use. Those buses are extension.

E

Austin's fishermen for expansion- and we just have hold of manual control and visit us before.

D

The game every such changed: it is possible at least made the probability if such changes that somebody else changes probably how many courses we have.

A

This College will help us.

A

You should expect the characters only in the case. It's.

E

Necessary fixes, if you missed it, but there may be several occurrences when people came to me.

D

If you bring extensions and customizations.

E

E

C

E

D

D

F

Proposal, even in terminal so because number of examples that depends Motel, maybe I the same problem. If, if it's problem, you know also.

F

C

Was a reason for the demarcation not.

D

C

Because I agree that, like clarification,.

F

F

Can be done yeah and.

F

Improve the past, because actually, if our goal go home, update without testing is definitely if testing still, it might be bad, but are going to provide some tools that say it's okay to of death or not.

D

Given volatile for years now,.

F

You know Adriana say.

F

Mark my throat don't help virtues are both.

G

H

G

Terms want to work visit manual approvals and okay.

G

A

It's more about whether we really just keep ourselves for real reasons or just theoretical reasons, and we cannot fix some bugs. It can code easier.

G

Yesterday decision- and so this is pretty straightforward reason- this movie says it's okay: to extend your class and change optional plans. We can face the situation. That's one extension was another one for another popular, because the result is man you mentioned before. We don't have any practical situation.

I

For this purpose,.

G

To configure glasses into provided a new behavior through second position.

A

C

C

F

Was a different use.

F

Case but someone use it and actually a part of our community, a commodities, reflection or fix some problem in Magento core. So is the same.

G

Okay, because I have to oh thank you, think.

A

You can, if you want, we can analyze how many.

G

A

In reality, they.

G

G

A

B

B

Box design discuss this, was it won't work.

B

We propose to use like private members.

F

No bias is a problem we can use Spartacus.

F

Without optional.

F

So if you just add.

F

Optional so lets you do the same, but just.

A

We have the documentation, be communicated with the teams, then so I still propose if our project analyze the situation to analyze, how how much? How many exchanges people request in the request and how many of them are legitimate, maybe even write down our the use cases and then also analyze, important extensions at marketplace. We can walk up and we can problem this cosmas community to understand the situation is done. Might maybe I can go?

A

So probably this approach is not really good its blacklisting right, but it would be better if we will be filing the built by default, but we will have some whitelist.

A

Maybe we can. We can identify.

A

So everybody agree.

C

In the result will lead us to many other provoked by architect particular case, because in some cases feel that it's okay healing souls at the cost mark to.

A

A

But what I propose is still to the check. What is a real impact? Maybe maybe we even need to remove API from some classes or maybe need to somehow mention that those classes are not for expansion and in those classes we say that it's change just just tuned and see if we can simplify development, make sense.

A

A

It will be a long process.

G

A

Okay, so I guess we can finish this meeting.

A

J

Mean we already discussed last time just mentioned for all extension submissions. At the moment these are severe. E9 is a warning. We don't reject them, but now they do no actually reject, so we're going to make a severe just when I recorded, so that there's no I think we had. We had some recent RCE security issues that come in marketplace and they were actually using system.

J

Under skin parameters,.

H

Why is that I don't like to see if somebody.

F

Just some random for the use it in Internet and because different it means is insecure about his performance. The performance of good.

F

Significant welcome this function, you're saying.

J

We should be using the secure I mean the more secure Brad nation. What's a suit over to the right to call the the what that, ultimately, is the temperament right, which does a PHP function.

F

Is one is a security right and another just.

F

So we need really security around I mean just what possible generation in other body in most of the advice, it's okay to use. Yes,.

A

I think it's just for the tools, much more reliable, but it's easy. It's just easier to have a simple rule that okay, we don't use it because otherwise.

A

So we just analyze everything, then the next question is I.

A

B

To replace the rent.

B

But exactly but I've never, both and like on there, like ten million iterations, some huge performance on this like time execution or memory.

A

A

Memories, 75.

K

J

A

That's my question: I think most likely we want to patient.

A

It accepts an argument which is 500.

A

Again, it's probably like not the question that you have in writing.

J

I think we can still raise it and probably.

J

By the way, I just shared a link on the architects like to go more details of our. It looks like Brandis famous empty right now, but you're coming.

J

I mean some of our own internal applications. We actually use.

J

Electric generating IDs, for example,.

L

J

J

Nothing there's no objection right now: Venus, no okay! You need to find a new function in here. That I've says then I think if the core is using I, think I would take it already so yeah we want to catch those extension, but that's okay, at least extension is using a public API method or you know, and then and then we can.

H

A

Can you move your.

A

Okay, then that's all I guess we here.