Magento Architectural Discussions, 28 Nov 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Architectural Discussion -- November 28, 2018

Description

Topics:
- Technical Guidelines: domain vs presentation-specific logic (Olga Kopylova)

Meeting minutes: https://github.com/magento/architecture/issues/46

A

So, let's see I will share my screen as I haven't I'm the topics. I do I'm, not sure if another presenter will be here. Okay,.

A

So what I propose the change? I propose to add some new additions to our technical guidelines.

A

It's based on some conversation about where.

B

A

Business logic should should go and where it should not go in magenta. So what I propose to and I propose to technical guidelines to the presentation layer? One item configuration for the presentation layer should be declared in corresponding application area. This includes events and plugins that customize presentation, layer.

A

One exception I think configuration that applies to all areas can be declared in global area. So I don't know any any comments on that and I still need my team to reviewed by the way. Do.

C

You actually have any presentation logic which should be declared a global area. I, don't.

A

Know if you have like sometimes I did I don't know. Actually, if you can have it say Bravo, you say that this item may not be needed right.

C

Looks like we usually declare business logic in global area and presentation, logic in specific areas, not sure what it means. If you create presentation, logic in global area,.

A

To rest, see I just regular front and back yeah I, don't know I guess it would make for me to go and look what exactly we have and if it make sense and see if this is really needed, I'm willing to see if we should change fruit to most.

A

Any other commands to this item.

A

Okay, then, next one next one is in service contracts. So, right now we don't have anything published in service contracts. We are still working on the documentation here, but I still want to start from some of the items. So the main business logic must be executed on the service contracts layer, any customizations to the domain. Business logic must be executed on the service contracts, layer and soul must be declared in global area.

A

Make sense or should be revised somehow.

C

Yeah, it makes sense. I have just one note that currently, it is not always possible to do customization on the own service contract layer, especially when we have some API on models and API one service contract, and then you have to actually do customization in two places, because it is possible that model will be used directly or then service contracts will be used. It is related to a say, catalog. As far as I know, search party developers have to customize it in both places, not online service contracts, but it is probably desired.

C

State like like you described it is desired State. So.

A

Again, I think the most important thing is that it should not be on the presentation layer- and this is the biggest mistake that we have in this.

A

It can be in service contracts, it can be in models, it should be working, fine, I, think, I, don't know if I need to rephrase it somehow so that like it, should be on service contracts, layer or I, don't know, or should we just keep it like this, and- and this is what you want to achieve, and it's fine should.

C

I said the main layer, or we don't have the main layer.

C

A

Everything else is just the location for four other versions of the document.

A

Any other commands right now I would understand I just need. There are some concerns about this item and everything else is okay.

A

Then I will look at it and I'll send it to the chatterin. It's ready and I'll ask to to improve from I. Don't know what review again you guys! Okay, what else.

A

What else? Okay, we don't serve today, any other topics we don't have any any more topics listed anything else at work.

A

Then I think we are done for today and you have more time to do something else.