Magento Architectural Discussions, 9 Jan 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Architectural Discussion -- January, 9th, 2019

Description

* Promise-based implementation of requirejs
* Sniffs Consolidation
* URL Rewrites generation
* Technical Guidelines updates

A

Let's start there, today's meeting, we have several topics, that's the first one, maybe Andrew you can talk about it about the problem from his best implementation required. Yes, I know, I can show the screen. I just want to get some of that on what what are you doing with it? Yeah.

B

So that was a poll request logged by a Carell Martha, which I don't believe he's on the call right now, but there's a there's two pieces of content related to this. There is the open for quest, there's also an open issue.

B

The I I haven't spent a whole bunch of time looking at the implementation yet, and the reason is primarily because at this point for me, there's not a clear value. Add for what we get from this. The the thing called out in the for request was that it provides some performance benefits, I've put in a request for Kirill to provide what those like benefits are like to provide some traces, because if it has the performance impact- and we can do it in a backwards compatible way, I'd love to do it, but it it doesn't.

B

Look to me right now, like there's a whole bunch of value, add for the the risk that's involved with it.

A

And you don't do anything with it from our side. Yeah.

B

I I believe I have an open question on the performance stuff in the poll requests and then an open question in the open issue on it as well. Okay,.

A

Okay, then, the next one is from Jana about sniffs consolidation.

C

Yes, we can hear you, but not so well,.

D

What about right now, the same better, much better I had an electrical problem. Is that so, let's move to this proposal, the.

B

Main idea here is.

D

D

Right now, we've faced with such problem that they have different approaches for static or check. However, we use same true, for example, you use each people smoker for much as a multiplied extension validation as well as a I use in each. We could suffer for time or static a check, so the problem is that sometimes developers are confused about what console to use IDE, how to check their extensions because it have something in common. But there are a lot of differences and.

D

For example, but at the market place you just severity, so be assigned for each new.

A

D

Higher severity is this problem is so, for example, but image of the core saves all of the things the host needs to lead to failure. So even if just one small hostile, if you default it'll cause a failure, on the other hand, in magenta.

B

Marketplace on.

D

The severity time issues will cause extension of rejection and the idea here is to consolidate.

D

So it will be easier for for everybody to install use with some C ICT tools idea. The solution here is considered 8 all of the magenta to related.

D

Create composite locations of what this package to the packages Authority.

D

But the idea will says to use only one will set for all of the projects, so do not have several words at all set separate.

D

Support specific checks for different.

B

Imagined related.

D

Project but just different.

B

D

B

Actually also I.

D

Think that here I need that or some sleeves that for some that require magenta.

C

D

A little let's say they are dynamic. For example, the required reflection are basically teachers here. The best ways to use detector for all others needs.

D

Soviet, a static test speech he puts in her. If not then change the motion. Hp must effective.

D

D

E

D

Any questions, maybe somebody had any concerns about this consolidation.

A

If not I, guess we just move on with this project? Okay,.

D

A

Okay, next I have I, have couple items from me, but I wanted to jump into the item about keeping year old generation for products in category and share the screen, actually its proposed by one of our dev teams, and the problem here is that in case of many categories and products, when you do like rename, for example, change the category, it leads to a long time updating your other rights.

A

So the proposal here is to skip this step at the moment of saving the category and move it two to the front end one when the euro is processed by the router and identify the product you're at at that point, not the product URL but calculate.

A

What's the product being requested on the moment of the of the routing so I guess we have Antone Copeland, Cole and Enrique Xian. You have two different opinions, I guess about whether we need to should proceed with this proposal, or we should do something different to this proposal. At least. One big concern is that right now right now this situation like.

A

So they actually have label leads to the same right and it's hard to distinguish between them. So right now.

A

To fix it in that in panel, if we remove your all generation from this step, then this issue will not be discovered and I'm not sure what will be the behavior. This current approach, probably either a category or product, will be always shown.

A

That's one of the significant behavioral issues and another one is a concern, is performance that it may lead to some degree one on the front end.

A

Another approach is to generation to indexer, so it can run in background and do not block admin user, but it also doesn't really save us from this issue, though we might handle it by like fixing the URL when it's generated, so I would expect some input from anthem and country right now and I.

F

Believe for a long-term perspective, we have the same opinion both of approaches choose leaf together. The main question here as for me, that's.

F

Okay, I never saw a problem caused by amount of records in your elder right tables, because this is basically our hash map table when we have a key, which is our request and wrote, which is our controller, it's hard to imagine situation when amount for all since this table who caused the performance degradation at the same time as soon we start resolve or override dynamically. We we may one in some several performance.

F

We make out several performance degradations caused by, by effect that we have not only to resolve this role. We have to validate that this product really belongs to this category and that this product can be shown inside of this category, and this is only for routing. Otherwise, we have a pro. We know face a problem. These URL generation, its Ural generation for activity pages. When a category page has to generate URL for all product listed on this page due to factors we have a dynamic URL, resolving we will have a dynamic URL generation.

F

So technically we will all complexity caused by URL generation during persist, operation from persist, operation to read operation, one for wrote in operation and second one for URL generation operation on each product listing site. Also, as I remember, it will be a problem to identify a create breadcrumb for a product page. Do it effect? That's you know we have a dynamic region of our routine, so when product is assigned to several.

F

Several categories we all have to make an assumption which breadcrumbs we have to show what is this particular product at this page? So, okay, totally saying I, believe both of both of approaches should live together, because this is a good approach: how to have to resolve temporary temporary rights in time when we generate a normal index, but but the main way how we are managing. Also our system should be the same. We keep a big but pretty simple index which will be responsible for routing in our system.

F

Technican ISM four pieces: when we have a delay is innovation became imagine situation and we ground the ground. You are all vegetation. Mate may take several minutes. If, if some clients you try to access this product by using this URL during this time, we should proceed this request, but this is fallback. This is not a main mechanism for resolving this, because definitely this operation will be more costly than a basic, much of rewrite. I believe all of us. Ok,.

C

Visitant, when you say indexing what you mean I.

F

Don't say: I never said, Redux work.

B

F

We can assume that our system works in national consistent way. So technically we schedule a task to generate URL, rewrites, okay, I, don't believe the syndic service is good approach to resolve such such things. What.

C

F

Rights in background in a synchronous manner, which is as for me, boots. Okay,.

C

And includes safety jewelry, and is it help complete with another category? What's the behavior or system I.

F

Can give you more context and understood for.

C

Example, I have quickly heard of one with shock test and kicky. Very it's like test.

F

Collisions between right yeah, this is good question the same as we are doing right now. At the current moment, you know we actually.

C

We cannot do it right now. If you recite.

F

C

F

Explain to you how we can do this, we will require some changes in user behavior, but I became discusses product owner and easily approved because, in my opinion, a good improvement in my weeks where our system identifies that we have activation, we can provide imagine a possibility to resolve such collision by change in URL and by providing information. What is the cause of this collision? Because, right now, when we are saying this, we have a collision in right, we mentioned has no idea what the cause of this condition.

F

Let us suppose it's, okay, probably some Crowther category- is the same, but what's the original cause, maybe this.

A

F

A

We will show information what it collides with, at least we were fixing it at some point, I think I'm.

F

Not sure because this is technically not your relative right- this is URL key attribute, so this is not exactly the same and we don't match this right across all possible. Url providers. Okay,.

A

So what do you propose? What do you propose? So there is a process which the collision, what happens next, our.

F

Background process generate your relative rates. This will work for most cases, Oh for all most cases, all of users for okay for exceptional cases. When we ta collision, we we will use this stagnant mechanism, which is fallback mechanism. This dynamic URL resolved in for this particular cases. Only because this is costly operation and we will provides to merchants a possibility to see list of collisions and resolves these collisions menu.

F

Agreed, even not in a table with it grid with a list of collisions this possibility to open a corresponding entity, category or product whatever and change URL to resolve it.

C

Okay, but until the customer resolves the issue, this can be invalid state.

F

C

We have the same URL and one of the schedule will not work. Thank You, customer you'll know that is the any collision. It.

F

Is proposed solution because.

C

This process will have different behavior because first.

B

C

Okay, so because it's only effect case were functionality and to solve different were on different, that you were one product is enable, but it disabled, fir'd by default and all other changes for all other conflicts were produce. Particular first EMS Kunti resolve synchronous of current, purport it and not cows. By default. Any question citizens in system, oh, but.

F

If I disappear quickly, if we will use this solution as a fallback mechanism, be a pretty safe, yeah.

F

This is bad solution. This is good solution, fallback mechanism, but but not for a main mechanism for Euro resolving because it is most costly than original. You know it is opened why we have to move something from a common operation tree decoration without any any usable reason. Yes, you provide a good reason if something has a collision, this collision should be result in time, okay delayed reaction, so this is good solution for for such cases. In case, we cannot match something.

F

We will try to do this in case we can match sounds we will use the simplest way how to resolve your override.

C

Okay, so let's agree on next step, so can we March the sentence and then by work on next steps like introduce new functionality to resolve.

C

F

All the view comments will be addressed.

F

So, but but but but still, code should be changed in way to clearly provide the message. This is not a main mechanism to resolve rewrites. This is fallback mechanism and, as we discussed with Daniel, we found some several several wines. Of course, it definitely will cows performance degradation like a product load and some additional costly checks. They such places have to be Pradhan as soon it will be done. I'm Akay to merge this podcast as this with corresponding to lose it.

F

We have a story in our back book to improve not an option to to complete this story, because this is.

A

Proposed in this document right as soon as everything is addressed, all the feedback is addressed. It can be, and also.

A

Regeneration and you probably, the team- will work with product owner to figure out the priority for it, and you also as well. Anthony should participate in that.

A

F

We have we have a product of. Is there some involvement in this, because this is, if you can change in behavior, we don't have to update our a user guides by the way we all have to update user guides to live like this change, we all have to update our performance measurement test because we introduced a new scenario for your router, so this whole thing issue should be covered with the performance acceptance test to make sure that future changes will not introduce the occultation in this canary owns. All of this will be done.

F

We will be able to merge this. This is in scope of backward compatibility, the problem in problems, it's a significant change in application, behavior, which properly documented properly communicated.

F

As they know, this is manual performance measurements, but we need to change our performance acceptance.

A

F

Guys this position, because this treats the sensitive areas, Ural rights.

C

You know that this solution, currently functionality of use khaki, very cut quickie. Her name in product name, is disabled by default, but we still generate forever a writer all multiplication clicky variant, prod in storage and database. So if he enables this one tonight, all this record will be removed and number of record will be less than ten times with a roller right. So actually it.

B

C

Improve the performance.

F

Yeah, but this is not really knows it's the fact that we are doing redundant if you are all generation. This is another issue that can be addressed in Moorhead, okay,.

C

F

Mine issue other purposes.

C

A

To the other conversations- and you can work with product owners to prioritize decision created in the back pocket is not sorry.

F

The solution I believe okay,.

A

I just wanna know one I think we have some plan some kind of plan for this item. Let's, let's move on to next ones, thanks guys, okay, so I have I, have couple topics and I: don't know you, you feel free, probably to discuss it. I, don't know in any other community places like slack channel or Twitter or whatever I agree that it's important.

B

A

But I don't think you have like too many people like many people from community on this course.

F

At least one yeah Katie help us communicate this with community I. Believe you understood the value of this change.

E

The key yeah I will Trenton okay.

F

Thank you so much.

A

I'm day, two technical guidelines I was discussing some time ago, so basically a couple items that they want, that they didn't receive any feedback for those items specifically I received feedback for items which are already actually part of our guidelines. I will move it separate, pull request to not delay this one and I'm going to merge those ones. So the updates that they have is just to repeat.

A

First, one configuration for the presentation layer must be declared in corresponding application area. This includes events and plugins that customize presentation layer and then some updates to our new.

A

Services section that we have one is the main or business logic marks be aggregated on the service contracts, player and any customizations to the domain or business logic must be executed and the service contracts, contracts, layer and so must be declared in global area of configuration.

A

Any commands here in this.

A

If no comments, I will just proceed, it's it's. The spool request is there for some time already so I think and they didn't receive any update. So I will just move on with this one and another topic that I wanted to discuss is more from organizational perspective and how we use technical guidelines. So I have two questions. One question: right now we have technical guidelines and so now adult dogs website, which is, and it's it's different for different magenta versions.

A

For example, if you look at basic programming principles, there are some items which are which are specific to the lightest PHP versions, and if you go to magenta 22.1 to that one, some items are skipped.

A

You can find only one item, so my question is whether it would be better to have just one document, not version 3 can do it in in some documents, but instead mark some of the items with specific magenta versions to indicate that, for example, this item is applicable to magenta to the two and newer, like 2 plus 2, to 3, plus something like that, and possibly we could move. Probably all coding standard section 2 on the damn dogs, so I, think technical vision and technical visions are not really specific to magenta version.

A

It's our vision, like future vision on the components, that's why I think it makes sense to move and about coding standards in general. Probably they are also not very specific to Magento version. So the question to you: do you think it makes sense, or is it easier to navigate if it's done like it is right now.

A

A

Nor questions- maybe it's not clear what I mean.

D

So, do you mean to everything on the.

D

Entire architecture.

A

D

Be still Doc's.

A

It will be still on them, dogs, it just won't be versioned.

A

Easier to navigate one.

D

F

D

It's really helpful documentation to navigate by changing my chapter.

A

D

A

Tool so the same.

A

E

The main issue right now is it's difficult to maintain it up to date,.

A

Very difficult you can maintain it, it shouldn't change. So often me, one of the issues is that there can be some gaps in the middle of the section or we will have different numbers for different items. So, for example, if in the middle of the section couple of items are not applicable to some magenta version, then either we have to change enumeration here, but that magenta version or we will have a gap here.

E

So for my, but if it is in general better to have the single version, because it is vision, it is not documentation for specific version of magenta. This vision for how you should develop extensions and this vision changes over time, but at the same time, in most cases it is applicable for all versions. You know Dennis Lee. Sometimes we have references to features which exist in, let's say just latest release, but it is more like an exception and in most cases I would say that the vision is the same for all versions.

G

If we can, if we can select version on the page and maybe have some JavaScript, that would hide and show like content, that is specific for particular version now it will have problem is enumeration I.

A

G

A

If it's more convenient to use it like it is right now, I, don't think this maintenance cost is so high.

A

Trigger for you, it's more convenient when it's, it looks like MOOCs as it is right now correct me.

G

I I, don't know I rarely look for documentation for older versions and I. Don't know how many people actually do that okay, I like for technical it. It might be more important for other documents, but for technical guidelines, probably less important.

G

A

My plan is to collect more feedback, but for now I don't see the reason to change anything.

A

Another question: another question is to.

A

Move guidelines to our repository, discuss all the documents, but for the users it should. It should not change anything. So the docs website can just fetch this document from our repository and publish it, as it is right right now on their website.

A

The question is whether we want to have it in our repository as the source of this documentation, or it doesn't matter, and we can discuss it as we discuss it right now, just create just on these meetings and still referencing to pull requests in the docs repository.

A

Does it even matter for anybody? Does it work? Okay, as it is right now.

G

Not a big problem for me personally.

A

G

It's in a separate people.

H

H

Move it to the.

H

A

H

A

H

A

Okay, so I will probably change nothing right now. It's just some questions that they had mm-hmm. Anything else that you wanted to discuss. I think I went through all the topics at least requested once anything else.

A

If there is nothing else to discuss, then we are done for today and we'll have a recording shared on YouTube and I'll, put it in the slag channel as well. Thanks all bye.