Magento Async Import, 21 Nov 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento Async Import #4 - On Topic (Nov 21, 2018 Community Meeting)

Description

Join in Slack via https://tinyurl.com/engcom-slack
#bulk-api

Today's meeting summary:
- Open PRs
- Discussing specific issue with new topic names: https://github.com/magento/async-import/pull/21
- Status update of Async Import moving to being the default import mechanism

Attendees:
- Alex Lyzun
- Riccardo Tempesta
- Alex Vasiliev
- Igor Gorin
- Anton Kril

A

Recording has started good.

A

Okay, tell about status, be a currently working on still working on the implementation of the import module from our side. Alex started with data model for the product export, but he's still in progress. We had paid auto start here to do in-house, so we didn't make too much on this on this step.

A

I also turn a quite nice point now, for we have an interviews in a company sometimes, and we have a test like test Tom's that guys have to do, and now we are giving them a simple tasks, and then we can see like if they're capable to do something or not so yeah. We still working on it. On my side, I'll work on a file import itself and alex is working on a data model creation.

A

So as soon as you have a prototype, we can generally publish it and then invite like more people for extending it and adding new features, and so on. That's kind of status of this. Although I think you bought module from architecture, poor request, there was still no reviews, no comments, I know Antoine. What is the best way here to proceed.

B

Then let just Majid Pingala got to match it. No comments. Okay, so they said it's the comment: they're, not pretty cool, since we are discussing here. If there will, if you will, if you didn't discuss it, I would ask forget to assign someone to review, but I don't think it's needed in this case, good.

A

Ok now I'll write your message to do it: cool okay, then, for us think about the journey all for now. They still have some issues open on general project board. We have to pull requests which are which we're already used by me and Redeemer generally, which I'll share my screen that will get better and everybody can eat is here which, which window to see you see the empty Chrome Widow.

A

Right, you can read your yes'm. Yes, that's that's fine! That's that's!.

A

Good, then, let me show what we have for now. We have to pull request open. That's right, operation status, poke you in radius; it was really used by me and Redeemer and Artyom who is working on. It currently have to apply some some changes, but I talked to him here, also quite busy in his new project.

A

So he will do it, don't know when he will not that touch it in night next couple of weeks, then we will try to promote it at somebody else finished it, although finish it all itself, that's here it gets quite for a long time already and we have also we have to pull request which on hold I will not guess, explain now why that was discussion before that we will not do it currently and we have still one pool requests which are open and it's still valid and it's like nice to have it.

A

The idea was that we changing the topics for whatever P I seem to use. Currently it's using the roads. So generally you have.

A

The topics looks like this: it's have a sim prefix always in before then be what I was the our version and then come in the road for the end point and then a method like post, food or jellied here, and this changes was proposed by eugen to Lika before, and it was done also some time ago that we changed the topic from this implementation to have to use the service contract name for the naming, and it was done on contribution day in Barcelona, and there was discussion that it will not be released into industry, and if we will merge it, then it will appear in through three one and is it backward and incompatible to do it, because some messages may stay in a inner rabbitmq with the old topic names and if we will change like it was a customer will do an update to three one and their new topic name will be used.

A

This means, though his messages and RabbitMQ will be lost, but we discuss it with Vova. We are honestly not sure if you could pack but incompatible in this case, and we didn't turn it got any other feedback except our two discussions. So with we discussed to the step that it's fine to update them and that's not really Beckett incompatible changes, but we didn't get any other other feedbacks and if somebody here have something against it, I would honestly propose to to accept it, but I need some time. Also. Another opinions.

B

You can, can you scroll, operated, understand the title, but.

A

Original issue.

B

That's quite short, yeah well kind of make sense, at least.

B

Did Alex Parrish look.

A

At it good question, I guess not.

A

Now it is ephemeral correctly. He was not on this meetings. Ok,.

B

Please assign it to him, let him let him Majid, he should responsible, he should be ok, you should accept it Majid or provide some feedback and basically finalize the Sportacus.

A

Good then, that's almost Aricent. We have also full requests in bulk API. This line china overall repository of this project, but it's it was proposed by Rick and he generally came to this idea while developing the MSI, because they using the bulk API for source assignments, and if you will do it currently, now we are the backend for for MSI project.

A

You will get this message they're like task topic and then come in this topic, name which we define in item has been successfully updated and he said in his journey right that it's not really user friendly for back end users.

A

It has no idea what does the topic name mean and the idea was to have some user friendly labels here and he made a pull request, which was not really good from the architecture point of view, and we came up that we have to make it like general, that we need to define the description inside of XML file so when, when we describe in each topic, which we generated with some logical and nicely done description, but we favor the problems that the topic names are generated in communication, XML and communication is ml is generated by Web API, no bias, internal support, against extension, so in any case they're generated based on end points of web api and after discussion with war, we came up with ideas that we can extend.

A

The web api XML told gender by BPI XML with description field which not backward incompatible. That will be still nice to have I mean the descriptions which describe in the end point and what is it doing and then, when we generated the communication XML, we can use this description and then deliver the description in this error message with not error. Message with the success message which appeared after the operation is completed in what general pagán to.

B

Me would be good, so basically we add this field to web api scheme. Xml schema and communication XML schema right yeah. It's.

A

B

To add it manually border and yes, but the only comment from me would be to to change the title field to success message, because that's what it will be and to avoid that that just user interface comment I, know that what you had seen would say: messages like task was successfully processed. They they feel dumb, they feel dumb. So it's much better to just write will say we must assign must assign that product sources.

A

This text, inside of this success message tag yeah.

B

So, basically, just say what what to tell the user, when this operations executed successfully. Ok,.

A

In this case, it will mean we must assign the products or I guess we still need this. One items has been successfully updated. You can, you can add the product.

B

With remember, we did review the there were a couple UX reviews of our messages in Magento by UX architects, and that was one of the most common comments from them like you should avoid this robotic messages and make them more user-friendly.

B

So it's better it's better to allow a developer to define whole message that will be H shown here. Yeah.

A

That's not generally, we can use this percent s to define like a folder.

B

A

Amount of items and have a user phantom message.

B

Think about it will probably require more more thinking on how you how you declare what variables you will need and different, or maybe you.

A

Don't need it yeah I mean for this case I. Guess that's okay, because we need only amount of items here, at least currently for this operation, Status, Messages, okay,.

A

That's for now on forget it good yeah I talked to Rick. He will he will. He will be happy to finish it. He just could not join today. I, don't know it. Maybe he joined while I'm talking but yeah. So this one is still open. Good, then, for now that's all yeah. We proceed our work on this internal support. Extension from our side and, let's see what we will get to next to next meeting.

A

If anybody has something to add welcome, we can re this here.

B

Hello, I I'm, just like problems in starting blue jeans.

B

We declined all of your proposals already sorry, ok,.

A

But I guess I, don't know if you.

A

B

A

B

We have done with everything if we're done with this meeting. If you guys have five more minutes, I I would like to walk through some code with you. I did some reviews on web api called wanted to wanted to discuss our performance.

B

Yeah, it's unrelated to web api are saying it's related to our synchronous, API implementation, I think we can stop recording and just say, ok sure.

A

Giggle, can you finish Oh meeting yep? Thank you, everybody I'm, stopping, recording and shutting it down.