Magento Community Engineering Hangouts, 21 Apr 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Community Engineering Hangouts. Apr 21, 2021

Description

Agenda:
- Support of PHP 7.4 for Magento 2.3 by @fascinosum
- Magento Quality Patches tool overview by @vtymchynskyi

A

Oh okay, guys welcome on the community engineering hangouts. We will have two great topics today. uh The first of them is support of hp7.4 for magento to the series list. Fine and the second one is mkp2 overview like use cases and so on. So let's start with php 7.4 upgrade so much go ahead.

B

uh Yes sure one second: can you confirm that you can see presentation.

A

Yeah, I can see it.

B

Okay, it's great, and you can hear me as far as I understand, and we can proceed so hi everyone to every month to anyone who does not know me. I am software engineer core software engineer in adobe and this presentation will be about adding php 7.4 support for magento 2.3 and, as you know, we expect soon to have this release in, if I'm not mistaken in week or two.

B

So, let's proceed and first of all, I wanted to describe why we are doing this backwards, incompatible and kind of breaking change for all magenta 2.3 customers- and this is the explanation why we are doing it.

B

So, as you know, end of life, this publicly publicly available information, end of life for php 7.2, was on november 2020. uh Previous state of to the three release line was declared support for php, 7.172 and 7.3.

B

It means that after november, it is not recommended to use php 7.4 anymore and the highest version of present, uh which was present in to the three release line, was php 703 and active. Support of this version ended on this in december 2020 and we was in a position when we and we still need to support 2-3 release line for some time and we critically needed to add support of php standard four and end of life of php standard four is uh november, uh 2020.

B

B

So uh what uh what approach we took this time? As you know uh previously, we did uh we added support of php standard four for magento 2.4. This was a huge amount of work. We already did it once, but this time we needed to add the same support for 2-3, and we decided to do this in a different way. What is the difference? So previously we tried to do all at once. We tried to deliver all this huge change into a 2.4 release line.

B

All together I mean tests and code changes and for 2.3 release line. We decided to do two steps upgrade. First, one is upgrade of php unit and second one is really adding support of php 7.4.

B

Which uh also resulted in, in necessity to remove mftf framework, mtf framework, sorry mtf framework and mtf tests. We don't have framework and test in 2.4, wheels, release line and right now we removed it from 2.3.

B

This, I would say, may be breaking change for someone or by an incompatible change for someone who will upgrade to the 3 7 plus version, but there the decision was made, and this is kind of uh right now we have more consistent state with 2.4, but this definitely kind of breaking change for two to three. At least, if we are looking on testing uh area the next one. Huge change was the removing web setup wizard. So right now, magento 2.3 can be installed using only cli command.

B

There is no installation or upgrade using admin or web ui, and it is obvious we removed a declaration of support, php, 7.1 and 7.2 from composer files.

B

As you know, there was a case when accidentally support of php standard 4 was broken for 2.36 p1 release.

B

So right now we just you know, reflected it properly in composer.json declaration, as I said before. Previously it was done accidentally, but right now we had intention to remove php standard two for reasons I showed you before, like there is no security support anymore for this version of php.

B

Let's proceed so first step, as I mentioned before, was upgrade from a previous version of php unit to php unit 9..

B

Last time, when we did this upgrade for 2.4 release line computing community helped us with it, and there was uh approach uh which widely used this team who worked on this scope. This time we did this upgrade by our internal resources and we used uh two tools or yeah two set of tools for for this.

B

One is friends of php, php, uh good, sniffer fixer, and we had a list of bash scripts, which we already used for a fixing of some tests for 2.4 release line, and we did not use erector or recommended way like rector and all other scripts recommended uh in the article uh written by lukas um about uh approach which we took. When we upgraded test for tool for release line, I there will be link to this article.

B

Why I mentioned it um when you will be upgrading your instances uh to support 7.4 or uh support new version of php unit um using the scripts and approach resurrector from that article may help you to to do this upgrade really.

B

So what areas uh was affected and we needed to fix- I would say most all- of the tests, all type of type of tests- api integration unit web api- I would say almost all of them were affected as well as mftf tests, but mftf tests. We needed just do small amount of changes because they are real declarations.

B

The biggest part was work on mft framework itself. Also, we updated all php unit, xml declarations and php unit xml disk files as well, and there was some changes to the code of test frameworks.

B

It was uh caused by changes of api in php unit and some when we extend functionality of the testing framework. We need to make our implementation compatible with a new api, which is obvious if you extend our test framework or modify them in any way. You could also may be affected by this change and some small statistic, like a short statistic about it, uh what we can see it resulted in about uh 50 case of uh changed code uh rows and six uh 6500 files were affected.

B

uh Just want to mention to you one another number. uh When we did this change uh for 2.4, everything was to get uh done at once, and there was changes uh related to php unit and p and uh php standard four, but that time we had about 100k uh code of rows affected.

B

So when we completed this php unit, 9 upgrade deliver it to mainline. We proceed with a real, adding support of php standard form, as I mentioned before, the biggest change was to magento to mft framework and we released version 2.7, which supports php unit, 9 and php 7.4., and also like adding support of php standard. Four was uh much easier after we updated and made our codebase compatible with php unit nine. We need to change about 1k of rows of code and just 275 files, and about 200 of these files was updating, composer json declarations.

B

So there were not many code, changes real quick changes or fixes, but we will talk a bit about it about code changes. So here is the list of the most common issues which we face it in magento code base, and then you will do update for your code base. You may see similar or maybe even more.

B

You can find all the information what you need in the article on php.net website. I will give you a link to the article how create to php 73 to 704.

B

There are a lot of changes, uh many of them like deprecations and other stuff and new functionality, but uh I want to briefly explain what what this change is about. I mean this small list of changes which we face it in magento code, so, first of all ari style access to non-arrays. Previously you may call kind of you was able to get value, even if you call us if you treat as array null boolean in flawed or even resource so right now, you will get noticed and your application will be failed.

B

We did some adjustment to avoid it and check some data conversion to handle this problem. Next one is nested ternary operators without explicit parenthesis, this about best practices. So if you previously follow the best practices, you will not find you will not face with this issue.

B

You know this is kind of obvious next, one array k exists previously. If you used it on objects, you was able to get proper result right now. It is deprecated and you need to use is set or property exist instead and next one implode with historical parameter order. So you know that the proper order is implode.

B

First argument is glue and the la and the second argument is part, but uh implementation supported another one another one way before you may specify parts first and glue second, and it worked uh used to work very great, but right now it does not work in this way. So that's about best practices as well.

B

um Comparison of date intervals objects, it's also described there. Previously you was able to compare date. Interval objects. If some object is smaller, greater or even equal right now it results in false all the time, so the recommended way to handle it is convert uh like get timestamp from your date. Interval object and uh not from date. Interval object from date, object, uh get timestamp and compare two timestamps.

B

If you need it this one of the possible solution, you can came up with any other and the last one is change to reflections. So reflection, type to stream method is deprecated right now, and the recommendation is use, get name method instead.

B

Yeah just want to mention one more like we was able to. There was no backward and compatible changes to magento api.

B

We expect so I mean there was no any backward incompatible changes catch by our tooling and uh the only backward, multiple change we aware about if changed default value for one of the action groups of mftf tests, but in scope of this work we updated a list of dependencies root dependencies of magenta, which also make a result in some blc changes for you but mean for some projects, but we did not do not think about it as backwards and compatible changes and yeah. Here is the list of additional resources which I mentioned before.

B

Once again, there is article written by lukash about community effort of upgrading php unit tests. You may find you can find a lot of useful information there and you can use it in order to do upgrade for for your test.

B

It is about magento 2.4, but it is applicable for 2.37 release as well and another one just a link to official documentation, phpnet about upgrading from php center 3 to 7.4 with described changes changes in there.

B

That's it from my site and I opened open to your.

B

Questions: okay, if no questions, thank you for your attention.

A

Yeah, I I don't see any questions so guys if you will have some just put them to the chart and marx will be able to answer.

A

So thank you max for for the great presentation for some platform update news.

C

Thank you fox impressive immigration.

A

Yes, thank you.

A

C

uh I can start.

A

Yeah yeah go ahead.

C

Okay, hi guys, my name is victor. I'm software engineer from magento l3 support department, and today I will talk about magento quality purchase tool.

C

The purpose of this tool is distribution of quality patches from magento support, I'll start with a demo record about mqp usage and then share with you, some mqp numbers benefits and plans.

C

Let me share my screen.

C

Are you able to see my screen.

C

Thank you, let's start hello and welcome to the short demo of the magento quality patches 2.

C

I will be covering what magenta quality patches is, how it can be installed and used by our customers.

C

Magenta quality patches too, is a composer package that contains a set of patches and commands for working with them. It's intended to optimize distribution of quality patches across cloud and on premagento customers.

C

The general flow looks next support. Team creates a page and push it into mqp repository as soon as the next version of the mqp composer package is published. The patch becomes available to cloud and on-prem customers, customer installs or updates mkp composer dependency and gets the latest patches compatible with his magento version.

C

Customer selects and applies patches that are needed for solving his issues.

C

Let's take a look how it can work for on-prem, magento customer. Imagine that I am happy owner of russian-styled fancy magento store everything is going well until one day I face several core issues for demo purpose. I'll, add some issues to.

C

Instance, so I have three issues and I'm not happy anymore. I'm calling to magento support and asking for help support tells me hey victor. We are happy to inform you that your issues are known and there is a magenta quality patches too. That will help you to fix them.

C

If you are on prim customer, then you should require an mkp composer package using a command composer require magenta quality patches. If you are a cloud customer, just update, magento ece tools and you will be all set.

C

Okay, let's try.

C

I will make a small modifications in the command to get the demo.

C

Package need to wait for a while until composer updates the dependencies.

C

It can be not not so.

C

C

And here we go now we have magento patches script located in vendor bin folder.

C

This script provides next commands. Statues shows a list of available pages, apply, perform spaceship line and reward performance. Page reverting, let's check the list of available pages with status command.

C

We see the table with next information. Page id id is the same as jira issue number page title short title of the page type form prim all patches are optional for cloud. Some patches can be required, statues can be applied, not applied or not available when we can't identify status due to the sun conflicts and details contains the list of affected components and such information like required patches. We need this feature to solve possible compatibility conflicts.

C

So, as customer I see that page mc1 fixes issue 1, page and c2 fixes issue 2 and page mc3 fixes issue 3.. It's a good news for me, because I have all these issues. On my instance, let's apply a first.

C

C

We see a message that pashu has been successfully applied and let's check a status table.

C

And we see that mc1 page has applied status.

C

Let's refresh our.

C

C

And we see that issue one was gone and was fixed by patience. One patience, one works. If I changed my mind and want to come back issue 1, I can reward the patch mc1. Let's do.

C

C

We see a message that page fc1 has been rewarded successfully: let's check status table.

C

We see that has multiplied status and after refreshing, the page we see issue 1 is on a place now. I want to apply two patches at once to fix both issue, one and issue two. Let's do.

C

C

We see that both patches has been applied successfully.

C

Let's check status table.

C

Purchase mc1 and mc2 have applied status and after refreshing a page we see both issues fixed and now I changed my mind again and want to revert all applied patches. I can do it with command option.

C

All reward and option all.

C

Let's check the status.

C

C

Now you can see that all pages have multiplied stages and, let's refresh the page.

C

After refreshing, the page all issues again make asset troubles next case you will be applying a page that has dependency on other page. It's a page mc3, as you can see it requires mc2.

C

The original dependency can be modifications the same lines of code by both patches.

C

Let's apply it.

C

Tool tells me that patient c2 is required for mc3 and passes confirmation for quiet as well. I give my confirmation- and here we go- both patches are applied. Let's check our page.

C

As you can see, issue 2 and issue 3 were fixed and the page mc3 and mc2. I changed the same line of code.

C

And the last case I would like to demonstrate you is a page replacement. Imagine that support want to replace page mc3 with some improved version, mc3 version 2.

C

for demo purpose I'll. Do it in the page configuration directly on instance,.

C

Let's check a status.

C

C

Here we can see recommendation to replace ms3 with ncs3 version 2 and we see the temperature screen has type duplicated now. Let's do it.

C

C

Necessary version 2.

C

The tool asks confirmation to revert, duplicated page and applies a new one.

C

Let's check status table.

C

Again now you see that duplicated page m63 disappeared from status table at all, so it's not available anymore. Let's check our page.

C

And we see issues 3 was fixed by a new page, nc3 version 2.

C

That you know the many features of magento quality. Batches too. There are some differences of usage for cloud customers before applying selected quality patches. The set of required call purchase is applied automatically.

C

It shouldn't make any trouble, since all optional quality patches are compatible with required cloud caches and since cloud has a redundant file system finishes, are applied during the deployment process by ece tools. So a customer needs to set the list of patients as environment, variable a magenta and female file and commit the changes.

C

It looks um like that we open magento and vmware file and add the list of desired patches here quality pages and commit and push changes into the remote branch.

C

After that, the process of redeploy will be started and applied all the species on fault instance.

C

I hope this demo was informative enough. If you have any further questions, feel free to reach out to me thanks for watching.

C

Ok guys, let me share some numbers with you about.

C

Mqpm uh so for today, magenta support added near 160 patches during 20 mqpm releases. The most part of quality patches has a related articles in magento knowledge base.

C

So 136 articles with splash description and issue steps to reproduce are published on supportmagento.com. uh You can quickly find the article about patch using apache dss-uh keyword on supportmojento.com.

C

Here is some benefits free early access to the documented patches for magenta support. All quality patches were created by magento commerce, customers requests.

C

Many of them have been reported to different magento versions, so you can take an advantage from using ready to go patches for your magenta version. Mkp release is coming every two weeks, so you can get fresh punches. Pretty often, conflicts between patches have been resolved on a pull request stage by magento support, so all patches are compatible with each other purchase support.

C

Some patches can be deprecated or replaced with improved versions over time. So in this case you will see a warning message about applying a duplicated patch in sli output or it can be find in the logs. Just don't forget to update magento quality purchase package to stay tuned.

C

A backlog current goal is to minimize the time required for developer. To answer the question: does mqp contain the patch for my issue or not to achieve it. We are going to introduce push categories and create a landing page for mkp categories will help concentrate developers to have better navigation experience.

C

Developer will be able to find faster patches, for example, related to performance payments, web api issues etc, landing page for mqp. It should be a well structured online resource, as that explains an easy way. Watches mqpm contains the list of released patches like this option to filter them by magento version and bypass category.

C

Also, it should contain a links on documentation and kb articles.

C

Mqp headhub repository is public, so feel free to report issues there and make your contributions.

C

That's pretty much it from me. Maybe you have a questions.

A

uh Yes, victor. Actually, we have two questions, the first one. How do you check quality patches status from cloud.

C

Start we use like drive around, we are using dry run to check.

C

Apache status, if they apply it or not, apply this dry run.

A

And the second one: is there any method by which we can update for new patches.

C

C

Currently, maybe no, you should like update the composer, magento quality purchase, composer package and see what is new. uh Also you can use a page where we are publishing release notes about mqp.

C

This page, like is available on magento dev docs.

C

Currently again, there is only such way to know what is new, but we are planning when we implement this mqp landing page. uh Maybe we introduce maybe some notification about new patches and so on, email notification, something like that.

A

Okay, guys, I don't see any other questions so much about it.

C

Okay, thank you guys.

A

Thank you guys see you on the next video bye, bye, bye.

B

Thank you, bye.