Magento GraphQL Community, 30 Aug 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 30 August 2018

Description

Agenda:
1) Change account and newsletter info (Updates) (PR #162, @nuzil)
2) Adding simple product to cart (Updates) (@roma-glushko)
3) Authentication validator for Cart Mutations (@Yaroslav Rogoza)
Hosted by @roma-glushko

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

Okay, warnings on.

B

Hello guys, we start our weekly traffic ransom cup and today our host will be paramount Pushpa from ethics. So it's some small recognize it so wrong. Please continue yeah.

C

When welcome guys today, we have a weekly demo for graphical project and as far as I see, we have four points now agenda, which is basically means that Alex Yara and me will be talking about our progress since last week and last meeting so yeah. Let's get it started, yeah. Regarding the first point in the morning, I usually read Twitter to feet, and this time I read about tweet from Alex, where he told that it was his first request to this project and now I'm happy to pass word to you.

C

Alex so tell us, please how it was. Thank.

D

You at least somebody's really mad. It's that's already made my tape.

D

That's very cool yeah. The progress like the functional of the poor request, I met I, showed the last last meeting was recorded. If somebody interesting you could watch it sign that it's not so many time to develop something you but I can rate and show you so journey. I made a pull request with this functionality. I made some code clean in. There then checked that everything works again else to request. If somebody don't know is related to the two issues for my account notations.

D

So when customer can change his subscription and also when customer can update his first name last name and email address and email address, update is only with passwords required anybody yep generally the food, the pool request that was made, which contains for now only the schema and their resolver itself, I I plan to make a test for that also I'm, not sure.

D

If I will do it in this pool request, cope I would maybe we'll wait till this will be done, and then it will make it with an additional four requests after it, and we already discussed with Valerie the failed Travis which mostly related to the static test. So I will reorganize illogical, Remora factors or main resolver method and we'll put this functionality to to another class to make the less dependencies here. So they look sexier and much but implemented from the static test point of view, yep the generate all from my side.

D

For now, if you have any questions, ask me, but generally I guess: I showed there wasn't last time from the functionality point of view.

C

Yeah good, thank you and that's probably a good step toward enabling email marketing yeah for PWA and why a graph, QL API so yeah. Thank you for your input and yeah looking forward to the next full request. Yeah that will come come sound good. At least this recording is enabling and.

C

E

A commitment now yeah you got to do it no.

A

Way: okay, also plugging in computer before your battery dies.

C

Yeah, if you guys have no question Alex I can move what actually me and sure my screen at this time so yeah this week, I had a chance to work on, add simple product to cut feature. So basically, this is the first task in adding product to the cart topic and yeah.

C

What was done is I move and review proposed schema regarding this topic and move it to basically right now. It's I have two models that related to this topic, and first one is what graph QL, which was, which was before me, and here I, add additional schema and yeah.

C

Here we have a cart item in the face which will be extended in and will be extended for simple products and rest of products, but my topic will be touching only simple one, and also we have here type resolver, a custom park, type resolver, which will which will yeah that which will which is enabled yeah and also it has yeah concrete implementation that choose exactly what type of cart item should be choosen, while all output of graph QL API is collecting or returning and from my simple product, a fuel model which is new for this request.

C

I'll add in a new new mapping, which means that simple product will be mapped by simple cart item in the graphical schema, and here yo. We have this one yeah and also will have resolver for this product specific fields like estimize, herbal options, yeah and yeah. Probably there is nothing new and interesting. Just a new mutation and a couple of input, interface and output interfaces here and couple interfaces to support customizable options and right now, I can make it to add simple product to the cart and remaining stuff.

C

I need to complete is to make sure that all types of customizable options are enabled by this API and also make it so that the output data enable showing edit customizable options for simple single products: simple cart, items and yeah. This is my testing testing results from my testing of this feature and also I'm gonna. Add this bottle to my card by a graph QL and now at least one type of customizable options. I enable it, which is a drop-down options and also I'm gonna check the input slide here.

C

Close this also date types and the rest of type that Magento sports and also have couple questions to Alex Parrish, so probably I'll be able to ask them after the meeting since he's not with us right now so yeah and also gonna add a couple of tests for this functionality and also perform some factoring the code, so I'll be having something to show on the next demos. Thank you. Do you have any any question about this? One.

C

If no, we can go ahead and um let me stop sharing and pass the word to yarrow and yarrow was working on validation for card mutations. So we are, please go ahead with your updates.

F

F

I'm showing my screen.

F

All right, so, during working with the shopping, cart notations, we have faced with the authorization problem, so the reason is while working with mutations shopping carts, in quote the new scope of graph QL project. We work with hashed card ID instead of real card ideas, so I have talked about that and my previous in so when we work with shopping carts with core functionality with Web API, especially with rest. We use hashed led for gas cards and we use the real integer part value for the customer card ID.

F

But if we work with the hair skirt ID, there is one problem: if we create a value, a hashed value or some gas card, ID the weeds and gas type ID or customer ID, there is no verification on the course ID which which detects that some card with some hair side- it belongs to some customer. So, for example, if we create an empty card or card with items for some customer using graph QL, we can perform operations with this card or from another customer or as a guest, for example.

F

So, if I create some shopping, cart with some hashed ID I can log out and use this hash tidy for performing the operations, and it's like not very good practice. So we decided to introduce a separate interface that performs check that current card belongs to the London customer. So it's a separate interface. We might rename it in the future. It's just a concept. So this interface and the implementation. Basically checks gets the code from the database with the provided hair study.

F

It gets the customer ID from this quote and compares this customer ID with the ID of the logged in user, and if it's the card has no customer ID it's a guest card. We can proceed working with this, the same functionality we have in the core and if, for some reason, the customer ID in the card is not the same as the customer ID of the element in user. We get holes here and we can proceed as one we can throw an exception or so and these interface.

F

This implementation also can be reused in other shopping, cart, resolvers that we use within a scope of your project. So I really hope that Valera, we will have a chance to merge this request as soon as possible and yeah. For example, let's say I have shopping, cart already created and this shipping card belongs to customer. So now I have like authorization token. It's correct, I haven't generated it like ten minutes ago, so I can apply. Shopping cart, apply a coupon to the shopping cart.

F

So from the response to see that the coupon is correct and, let's say I will remove the token and try to perform this operation as a guest and I have message that operation. This shopping cart is not allowed for me and the same station is for removing coupon from shopping cart. If I perform the celebration. Do not allow me to do that yep. So that's it. If you have some questions, please let me know I've.

A

Just got one comment: real, quick and in the error message, I think, there's just a small typo. It says card with a D I think it's supposed to say card.

B

A

F

Almost yep yep good point good spot. Thank you. Okay,.

A

Yeah and and I've got one quick question too about this, just just so, for my understanding is I understand that this validator is supposed to be reused. Whenever a user wants to take an action on the cart yep, is it designed to be called every time that the user wants to perform a cart mutation, or is it designed to where you can check it once and then use it for.

A

F

Actually it's it's designed like we can use it everywhere at the moment. It's used on the resolver level, but we can move it to the upper level, for example, to execute it on every cart mutation in the future. So it's really possible because it's like it doesn't have some some relation to resolver or so it just accepts a port ID and return boolean value, so we can use it everywhere.

F

Okay, we can think together. Maybe we should create some like intermediate level layer between resolver and the upper level to perform this check, so I will be glad to help with that. Okay.

A

Yeah I was just thinking that, if there's no reason to if there is no reason to call it every single time so that we can, you know, we don't have to have the impact performance and whatnot, but we can yell, let's think about that, a little bit more yep. Oh thank you.

C

Yes, thank you yarrow, and the last point in our agenda was supposed to be from Alex Belarus, but he didn't appear. So, let's move this point to the next demo in a week, yeah and.

A

Yeah Singapore was.

C

Too much fun that he didn't.

A

G

High-Five, he definitely will come back. I should I, you know, nobody knows.

G

Maybe maybe we'll see.

C

Misha I just wanted to ask you where you with him in Singapore. Maybe you have something to add on.

A

This now I know I wasn't in Singapore. I was on. I was on my own trip last week, but I. We got an update, basically that I I had somebody else talk about the event, and they were saying that you know they had several people working on graph QL specifically enduring contribution day. I. Think we've only seen one or two PRS come through right now, but we'll see if there's any more kind of outstanding ones.

A

Maybe people will be finishing them with time, but so just the update that I know was that people were working on graph. Ql people were the mothers we're working on PWA, I, believe, and so these initiatives are gaining more awareness and more excitements. I think it'll be it'll, be great. If we get you know other contributors on these things, it'll allow, you know Magento to be to be bigger and better. So these they're, all these are all great updates. Yeah. Thank you guys for for the work from last week.

A

You know the Roma, what you're doing with adding products to cart, obviously very important fundamental ability that the PWA will be able to use on and same with, adding and removing coupons from card. All these things are extremely important and very valuable. So we definitely appreciate your guys's input and we'll get will give we'll get Alex to give a proper Singapore update next week, yeah.

C

Cool you know, let's make it together, yeah and.

A

C

With that passing War 2 era, Blair, do we have anything else to discuss? Can we wrap it up? No.

B

I can only thank you for a great presentation for great question. Thank you. You're welcome.

C

Yeah, let's keep it a go and yeah. It was great to see you all guys and see you next time have a great one, bye great.

A

Work, everybody see you guys bye.

F