Magento GraphQL Community, 3 Oct 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GraphQL: Bi-weekly Community Meeting - 10/03/2019

Description

Agenda:

- Fixed bug with static block fetching and other schema improvements
- In-store pickup GraphQL schema
- Improved address consistency and shipping address validation
- Test coverage updates
- Single mutation proposal and error formatting

A

I'll tell everyone thanks for joining this meeting. It's been I think a month since we met last time. A lot of things were done. Thanks to your work and contribution.

A

Let's start from Evgeny, he will present his work and some bug fixes and schema improvements he introduced and he made.

B

Everyone, let's start in a few months, I, will share my screen.

B

Do you see my screen? Yes, yep? Okay, let's start talking about related to wish list. First of all, I.

B

A

B

This you should create a new type with name is list based on previous type wish list output, and we remove name from this type, because in open-source different, we have only one with this per customer. Instead of her commercial different, where we would create multiple with leads and.

B

B

My changes we create new type, duplicated old, builds and wrote new Zoeller for save record compatibility and show how it works. I have customer customer as one item in this list and we so the simple way put get these items, products and additional information about wishlist.

B

Also, this query was courage with other functional tests.

B

Maybe corporation.

B

Okay, let's go to nosy, show uh that's the issue. We have a bug related to growth, kill.

B

It was reproduced with the nest in the next steps that mean we need to create some test, static, block and add a template to it. For example, I have created one test, static, block added another block into it, and.

B

Without fixes, we have empty data. As you see, we haven't.

B

Any content of this study block with fix.

B

B

B

This book was related to home and gentle will pass to need file when we build aquarium and modern get some content on in content. He tried to build past your file related to area code. When we build graphical queries, we have graphical Paracon and in this case we could not get aisle.

B

We have empty that.

B

No sorry have some.

A

Problem, maybe it is wasted.

A

B

B

We have some mistake with wrench my branch.

B

B

C

B

Yes, as you see, we get right content with.

B

Some data with correct data: we have some some text and we have a blog template with testing plate where we built with some simple data.

B

These these poor pesos was scored with functional tests. Any question.

A

Great thanks: that's.

B

All from my side.

A

Okay thanks, so the next one will be Alex he he wants to say something about in-store, pickup graph, your schema and some improvements. He did in order to extend.

A

Shipping addresses am I, correct.

C

Yes, so hi, everyone I think it's the first time. I visit this kind of code, usually a wizard calls related to the multi-source inventor. You know, usually, I am working with this store. Pickup I will start sharing my screen. Probably you should see something yeah, this story of how I get to disk all started. With this pull request, which causes we shall name something like how we can add pic application information to the quote: throw the graph kill yeah, and actually we did.

C

We come to the schema and, first of all, as we have a new schema, we need to add it to the architecture repository. So it's our service contract and it should be there. Unfortunately, I have found that the scheme on the architecture repository is out of date, so I was forced to update it to the right to the latest version, and fortunately, I was smart enough to make it in two different commits and last one is how he worded the information which is related to the pickup location code.

C

So it's directly related to the shipping address, put data and in our case and the user of this service contract could pass or customer address the ID or address and pickup location code in case of a pickup location code will be passed. The oreo address will be replaced with address of pickup location.

C

Even if customer pass address, ID and we'll just load address we'll talk, some information, like name first name last name and telephone number and replace with epic application code and of course, if we can locate or write something, we need to read it and the type of shipping current card address is also available. Pickup location code field. So if someone to do query and know if the vocation code is used, he or she can do it.

C

It's I think the half of the problem schema is pretty cool but unfortunately to implement the implementation of the schema.

C

Just give me one second ago: I ended.

C

During the implementation of the schema, we was forced to make make customization with that a bad word preferences. So we fully replaced the resolver for mutation of quote: address yeah I'm, just yeah, so is it I just shown in the past the whirlpool request we replaced.

C

A resolver of 4th mutation and in a result we come with the bad experience and doing it because something was changed in that resolver in original resolver and in our preference set resolver.

C

That changes was not available and in result it resulted to requirement to synchronize it one more time. So this is our preference at resolver, which is such shipping address on card, which will pronounce the responding interface and yeah. What you do. It's get shipping address, assign pickup location if it can end as a sign shipping address to the card.

C

So after the incident we understand that preference is something which we really would like to avoid, because something can also change in future and we will be forced to fix it again and again, and we can that weighs somewhere should be available extension point and actually becomes that this reservoir is responsible for two operations.

C

First of all, it's it provide the shipping address from the input and second one it used to assign this shipping address to the card. The decision was just to divide these two operations to the different classes, and it is this this pull request, which was merged two days ago. So now we have like two classes. First, one is get shipping address and second one is said: shipping address card from this original one was removed to logic with which is responsible for receiving shipping address from the input. So now it looks like you get.

C

Shipping address, execute on table and second one is just responsible to to provide the correct shipping address object.

C

It will be reused in the in store pickup, so we will remove our preference and just create plug in to the get shipping address clause, so everything should be okay.

C

It's it is it with code and second one is currently in progress and something which need to be discussed. It's about graphical schema, so we propose it. Our view of graphical schema how we could search Depok applications, it's pretty big.

C

It provides possibility to filter by different pickup location, attributes, also search by distance filters, add sort orders and etc and yeah pretty big and Alex polish have proposal with the graphical scheme which, instead of twenty and one filters, we will use on the search term, which which looks much simpler from the customer point of view and it's something which need to be discussed in the future. So how long it is it.

C

Thank you for your attention probably have some questions.

A

It's like the huge improvement Alex. Maybe you have something to add regarding this proposal from the architecture, team and I know that you discussed this with product owners as well.

D

Yes, basically, we had, the discussion is Mark Brinson, who is product owner for store pickup, and we looked at the original schema was bollocks and we had to reduce it a little bit because currently, the proposed schema provides a lot more functionality than is exposed the moment, and we agreed that it makes sense to limit it for now and we'll extend in the future if it needs to be extended. That's the main reason: why would say filter by distance was removed and some other additional filters will move now. So.

C

D

More like product decision.

C

Okay, a question it's related to the search term, so it's supposed to I, don't know, use full text index under the hood to work with search terms or it's supposed to like in Google when you enter the address drink.

A

And Google.

C

Provide you a deal on the address the latitude and longitude on the map.

D

Here was to replicate functionality which is currently available on storefront and so forth. User can only enter one string cannot enter any address or zip code or anything like that which is use. The.

A

D

Functionality is currently used.

D

According to by default distance from the user, however, it should be configurable in admin panel and at the same time it doesn't make sense to allow user to choose certain order and certain arguments at least currently it is not possible and product owner says it. We don't want to allow user to do that as well, so it should be completely based on admin preferences.

C

Tickets, which we could discuss separately, these.

D

If comments here- and you can also mention mark Brinton I mentioned him in my pool request summary, so you can mention him and ask for clarification, but it is a lake. Mostly scheme reduction was due to product requirements.

C

I actually the main point which I would like to support is we can filter by my z address? Is it described now so just search called this pickup location to the nth root address and the second possible way is when we actually use the name of the store and we just entered the name of the store so its first case. This looks like some thing with.

C

C

C

We can do it with.

A

The next item in our agenda is about address, validation and consistency. Among we'll say more about this.

E

Hi everyone. Thank you. My screen do see my screen.

A

E

Okay, I want to show you two issues: I've done the first one is related to a shipping address. The bot was that we could add shipping address to the quarter without all needed validation. So you can, you could put some address and then you could try to get your cart again and after it you will have or something like this. So we need to throw this exception to show this exception in these steps. So I prepared.

E

So here we have a certificate rest on card I prepared already my card and only the information. So now we have a dress without region idea and it's outpost code to know when you are trying to sell shipping address on your card. You have a lot something exists.

E

Actually these two errors should be separate, but now we'll graph clear doesn't provide for us disability, so I created separate tasks to do this, not like one error, but it should be two separate errors. So this was one my task and the second one that we needed to duplicate and the ID field in customer address and use country code. Instead, I prepared these two. So actually we had this, for example,.

E

So now we can, we can do it with country ideas and this country. What actually country idea now is duplicated, and here we can see this so now. I can use country code instead and we need to do it so now. I change the country and used country code, and, as you can see, we got no country like it should be. That's all from my side. Thank you.

A

Thanks, if no one has any questions to this I want to also add sorry. Thomas I probably will go next because it's related to to to the error handling that Ramon just social miscreant, okay. So hmm right now we have an issue that for input validation, even when the aggregate exception is thrown with, and we can set multiple exceptions because of this, because graphical input exception it's extended, implements except aggregated exception, interface, or something like this and the only one. The only last error will be shown in the in the response.

A

So this is the issue and because of this issue already have few implementations that just implode errors to show in the response, I think it's pretty critical and that we need to fix this in order to use the functionality I wanted to show the example right now. It's the array with only one element but like the expected behavior, would be as many array elements as error appear during the holiday ssin. The same approach we would like to use with the cart errors.

A

I know that yogini was working on this issue, so we expect to have the same. The same behavior there I will work closely with you regarding this, because the the ideal situation it's to fix this issue first and then like merge. Those pull request was with multiple with possible multiple errors, hmm I hope like yeah on the same page with everybody and everybody knows, were faced already with this. With this kind of issues.

A

Okay, if not I will move forward with and not not the topic. It's single mutation for aging product apart this proposal was already merged and was discussed during architecture meeting, but I just want want to double check that that you are aware of this, and you understand what's going on right now, there is already support for single product, like add single product card, add at inaudible, ad, configurable, etc. But when we started to work on wishlist, it turns out that it will lead to to another, like add sample, to wishlist its it configurable.

A

Then move simple from wishlist to cart and and so on. It will like it. It could produce too many redundant mutations. So this is how the proposal was single mutation was born. The idea here is that it will be only one entry point, not one entry point, one mutation that.

A

The name will be at product cart and the schema will look like this.

A

Product to cold.

A

Yeah, so if we want to add, you know that you need to have school wanted here, parent school selected options entered options. What is this values? The most interesting ones are entered and selected options, so selected options. It's the array of customizable configurable, downloadable options that is base64-encoded.

A

Why it's needed, because we want to move to the UUID in future. So in this case the array of selected. This is one element and it's base64, encode configurable, 20, 24 42. What's this so 24 is option. Ad 42 is option value 18. This is how we want to pass to pass the selected option. Well, you need to understand. There will be two types selected option, something that customer can select like checkbox drop-down, anything like that entered options. It's something that user will.

A

Actually they need to type it or upload like file or some text for entered options. There will be again idea for like custom options and value also by 64, but this is just the some text that will be printed on this product. First, it is in this example.

A

In order to make it happen, we need to return these values when we render products so all possible, all possible combinations, all possible customer customizable or configurable options. It's so. In order to achieve this, the ID should be added to the customizable option, interface and once it will be available for fraud front end does not care about encoding and decoding. This value will be, will be returned from the products according for the rendering of catalog.

A

So the same idea for all of the types products, for example for downloadable, it can be the type the type of option downloadable for like again customizable what it will be customizable and so on. So on I know it's like hard to to get so quick this idea. So if you are interested, please go visit. Architecture repent read this proposal, because this is the main goal we will be working in the nearest future. Oh.

A

Maybe some questions concerns what I believe no concerns, because it's already knowledged.

A

Okay, if no questions so Thomas will go next and say about test coverage.

F

Hi all do you hearing this in my screen. Yes, okay. I will talk today about increasing test average. So, as you see, I started to create some issues about increase, to cover some exceptions or just to extend test coverage.

F

We already have instruction I modified it today, because this instruction was for those who have engines usually I work on with the patch and I scared. My experience here we can talk right now and I will show how it works, and so we have not installed magenta.

F

F

Well, it will, in so I, can show what we are expecting. What I expect in the end, as so the goal of that our goal is to get this table and to have ability to check out what is covered and what is not well.

F

When I create these tickets, I show the lines which are not covered. As example, we can go to quote graph QL and see what is not covered there.

F

So, who is we see that some exceptions are not checked by test to get this working where to get this table way and need to go step by step on this tutorial, so the most important that you have to install it's the bug, because it's have a role of a driver for this for the coverage.

F

The first step is to create folders. These folders will be used later in this step, I just getting the environment variables from the patch installation, so I need to know, which is the patch run user. The meaning of this line is just for this odd and after this I will have proper permissions for the photos for that folders and I can start doing next.

F

F

Here you see the modified index.php, it's the main index.php file in the root directory of Magento. There are some, as it were, changed.

F

Though the index.php differs between magenta and anjing's, they are different, so don't copy from here. If you have a posh, the.

F

Interesting moments that you can't just run tests on payment methods, there was work to implement payment knocks box for payment gateways. You need to copy them from this pass it's in dev, test at functional files.

F

So, and now we have four except G for authorized, not accept GS, Braintree, FedEx and USPS. The PayPal is work in progress after you copied those folders. You need to upgrade your Magento installation and then, if you have configured your Magento instance for running a functional test, you can start so this comment should work for you by this comment. The test coverage for the downloadable product graph, KL they'll, be generated in the folder bar bar coverage reports.

F

When it's done, you can navigate to this folder get the library which converts coverage files into the HTML format and run this around. This comment to have this after this, you can just navigate to this. Is that folder and open in your browser.

F

Let's see if gently is installed, no, it's not.

F

So it's already installed, as you see in my terminal window, I have not enabled extra backup. Let's start it, let's do it. I.

F

Will check it so now, I have it's the back installed and working I can close this and go to the steps. So, as I described my steps I'm going to visit this folder I am in it create some folders, for it does.

F

F

Will copy the mocks.

F

So we need to wait pop great. Maybe you have questions at this moment. Does anybody has.

F

F

It's completed.

F

So, assuming that I could have now configurated.

F

Happy functional goal test I need to change each period file. You can find it in the official official documentation. I will not do this now because it will take some time but running this commentar should give you the final result in case. If you have configured a functional test, run I.

F

Think it will be all from me. I will check instruction today, one more time and I will publish some message in the general chat or graph to yell at those people who want to get the coverage by themselves.

F

A

Was really informative, Thanks and also wanted to edit that, based on Thomas research and after the measurement of graphical test coverage, we have about I think in total by all, if you count all graphical modules, it's about 85 percent right now,.

A

But again thanks you, you are creating new tasks for for this coverage, so I I think we'll we are doing well with this.

A

um Any any questions about this or any like other questions to each other, maybe.

A

Okay, so thanks for joining have a good day or have a good evening.

F

Bye, bye, good bye, bye.

D

C