Magento GraphQL Community, 13 Sep 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 13 September 2018

Description

Agenda:
1) General updates to Pr's (@vnayda)
2) GraphQL-167: Add support for '@magentoConfigFixture' annotation on GraphQL API-functional tests (by @Vitalii Boiko)
3) GraphQL-129: Retrieve Customer token (@tkhamlai, implemented by @Pablo Fantini)
4) PR GraphQL-175: Improve graphql product pagination (@tkhamlai, implemented by @Daniel)
5) Open Questions - PR GraphQL-162: Change account information and Newsletter subscription (@nuzil)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

Cool yeah, hey guys, yeah, we can start I've started the recording, so Melanie, please my god. Firstly,.

B

I can give congratulation with programming days and, let's start a show, more steam.

B

So, first of all, a short update from my side, two greens this week, reemergence about twelve open to request, finished or best, and especially it's great that we merge pull request along scholarships resolver at the time, because this pull request contains backward incompatible changes.

B

Yes, we still. We still have a lot of open to request. I reviewed this podcast and mostly we need to finish it. A lot of pro requests has problem problem like his broken test or some problem with build so on and I think we are going to have focus on new functionality, but this open pull request because I don't know do you know we have some feature freeze and it will be great to notion as as a lot of poor requests before feature freeze.

B

So my proposal is to help focus guys if you have some open pool requests. Please review check the man's from my side so on okay,.

B

Next, our point: it's from the tally book Vitaly Buckley's mister today, but he provided video and I going to share this video with you.

B

If you words about this tickets, rehab problem with a defeat share at the config fiction in web at the functional test and boy crossover, this problem.

C

I see historical things, I I've tried to quarry by API factional test in ordered.

C

The config fixture, but unfortunately was wasn't support and Valerie. Neither gave me.

C

He'll see it support, support different stores.

C

The after-school request we merged you can use it in your tests as well. Thank you. The.

B

Tip Thank, You, Italy and I can say that this functionality is next to much because I think it will be useful, moto de Graaff Creole, but also for forestry or salt test.

B

Okay. Next, our presenter is Thomas. He will demonstrate functionality from a few guys from different countries and share some result. So much oh I am sorry him, hello,.

D

Wait a minute! So, okay, can you see my screen? Yes, so now I will show you one of the it's another, so we're the first request is about retrieving customer token.

D

Here you see the pull request. So, let's just test it so I have a customer with customer example.com and only field I a gave for the request. It's the email and password also I should require the what I want to get it's token.

D

So here we have this token we can use for managing waste card and another stuff that is connected with customer. Another request is about.

D

It's about improving the graphical product pagination. The only change we have is that now we have total pages in the page info. So let's mate acquiring two such products.

D

If you go to the front-end, you can search, for example, this, but you can't, for example, search in this and graph key. All works is the same.

D

So, let's find other that has the simple in the name, so we have five products. For example, if we change query to five five five, then we will find only one product and where it doesn't have enough a length, then we won't get any results. So that's all from me.

B

Thank you guys, and next our topic is from Alex. He has some open questions related to newsletters of subscription.

E

Yep everybody I work to date on the poor request, which was submitted quite a long long time ago. I made some real factor in the ah I worked. We have a contribution day in mid-march into Poland.

E

Sorry, nobody wanted to take a skilled tasks. I was only one who worked the whole day on it. So I covered some some tests for my own poor request and the current open point which we discussed today also was very that we have a wait. I'll show you, it will be better. I'll share my screen.

E

We have the mutation call for customer update, we define in the data and the main question was: what do we expect to receive back because currently implemented souls that you can define in the same way like when you get customer here, you can define one you wanna back is allowed like to receive back the same data as you send them, so the first name, first name last name and email, and it's subscribe. Tech, oh yeah.

E

My first question is: is it ok if you receive back those data or we expect something like TRO false and that's all.

B

Let me share some next question to you.

A

Yeah I'm trying to I'm trying to make sure that I understand. So your question is that, after a mutation where you modify the subscription status example yeah no matter, it can be.

E

First name last name, email or subscription status here.

A

Okay, is this just exist a list of available fields or is that's.

E

Now, a list of available fields to return and an exact, if is the same as the list of the fields which you can change, you.

A

A

Don't I don't remember off the top of my head, the list of same fields that you can change, I thought they were in the final store. You know, yeah.

E

Yeah, that's correct, I mean the question is not about this, which we could change. So I can just show you the full the full schema here. That's like this, and you have email here.

E

So that's that Journal in the full request and the main question is like what do we expect to receive back like do? We expect to receive all only like trough, all status or or we expect to receive the full list, like all those requested parameters,.

A

I actually mean I mean to me. It seems like the list of parameters. A list of parameters back would be good just so you can confirm whether you know what was changed and what it looks like if, in case you need it right, correct.

E

That will journey my might feel sad about it, but then I have another question. Only about the parameter is subscribed. If you have a double opt-in enable- and you said, send the request is subscribed. True then general, you have to first confirm that you are subscribed via the email, so you have to click the confirmation email this mean whatever you send this subscribe. True, it always will return. You subscribe false.

E

A

Correct okay, I see we're saying so: there's you're saying there's three statuses. Really, there's there's like you are subscribed, but unconfirmed. You haven't, subscribed and confirmed. Okay, I, don't know if there's values for this and in the you know in the rest of Magento. But to me it would be helpful to make those explicit and and say you don't have have separate states for those things and say: yeah you're subscribed, but still unconfirmed or maybe maybe you know, there's a separate field that says confirmation received or not something like that. Yeah.

E

I mean in a subscriber table, for example, you have the status, is there, but currently reoccur agent with customer object and out of box. This is not implemented there, so we have only the status like true or false. You subscribed yeah and then it's a good questions and maybe I would propose such we can now withdraw false here and then like propose a new issue where we extended, then the customer object was the also the status about subscription.

E

A

Potentially we'd also, don't you know, we don't want to have too many fields to where the client is forced to like write, custom logic, to figure out what is happening here. Josh, you know suggesting subscription status I'm.

A

Assuming are you suggesting that that's that filled in to replace is subscribed so maybe subscription status instead of is subscribed and it would be like an enum with something where you have more granular statuses of what's happening, exactly yeah, yeah I. Think that's I, think it's a good idea again. I would I, don't know if anyone knows off the top of their head.

A

If this is a problem, that's been solved previously in Magento I guess it doesn't sound like it, since it seems like it's modeled with a true or false, and it doesn't really take into account the confirmation, okay, well yeah, I. Think I think this is a good suggestion and we can you know we can try to. We can try to make it work that way. So let me let me like formalize that in the in the story, but I think effectively, a subscription status with several different values would be.

A

Would be good sounds like what there's consensus, that that is a better approach. Okay,.

F

Yep, that sounds good for me. Yeah.

A

F

A

Know consistent.

F

With what we are doing, when we add products check out to cart, I mean we also get full course. Information.

F

Okay, good, this in general, just allows us to build page based on response from mutation, so say if you keep and.

A

F

Can immediately get honest information to render the next page? That's why it.

E

Makes for a quick, let's make.

F

Sense yep adjourn.

E

I guess looks like like default: Web API, where you making the product or customer request in your getting backed. Also a customer object is all day today. Yeah.

C

E

Good thanks yeah sounds great.

B

So okay guys looks likes. It was a lot stop it for today, Alex Misha. Maybe you have some updates.

B

Now, okay, so I should repeat next week we're going to have focus on knowledge of current October requests and it will be great to repeat the result of this week. I think that's all.

A

Awesome yeah good work, guys and I won't. Just just one note that happy to see you know new contributors here from even different countries, so welcome. You know, welcome to the project, those of you who are just starting to contribute I'm glad to have you guys, I'm looking forward to working with you.

A

See you guys next week, bye.