Magento GraphQL Community, 19 Jul 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 19 July 2018

Description

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

My record pleased enabled okay.

B

Yeah I login from the from the room. Okay, we should be good to go. Okay, guys.

A

We start our weekly graph demo and today our host will be a slob ragazza from Alex, who is one of our more active contributors, so Yaroslav in T. No, please yeah, Thank, You, Vera, hey.

C

Guys so today in our agenda, I will tell a little bit about the small image and major gallery properties within the scope of product attributes and Vitaly back home. I will tell about store configuration implementations of coverage from the graphical perspective and Bartek will tell us about the product. Stop datum and Martin will talk about regular expression loop. What information about the fix for regular expression, one filter in biodegrade, ID so I'm about to start to share my screen.

C

Okay, so we have an issue reported by Andrew Levine. It's regarding the image information of the product. So in our product interface we have a field called small image and if we make a request for this field for the small image rockyaha current graph, QL implementation will turn as the relative path to the image inside of media directory.

C

So sometimes this value is useful, but mostly if you make some operations on the background, if you work with images directly, but if we work with API, for example, it might be not very useful because you do nothing with the relative URL. It can be useful if, for example, you use your your Magento installation as the images storage, but in many cases you can use CDN or other storage.

C

So you can't guess the exact URL of the image so as an idea here was to provide an additional field or rename the existing one to the small image URL and provide full URL to the image. It might be very useful.

C

For example, if you, if you use PWA application- and you want to show product list on your page or so- and you don't want to up to parse the relative path to the image and just have a direct URL, so we have added an additional field here that called small image URL and this field returns the full URL of the small image of the product and, as I said, if this property is used for some product listing, is also useful to return the configured placeholder instead of just mu.

C

If, for example, if the product has no smoke image, so I have here an example product with no images and if we check the small image property it's no. But for example, if you want to build like product lists and images and use just a configured placeholder in your theme or a default magenta placeholder, it will return to place over. So you can decide to display it or not by the small image value. But you have Europe always have a Europe for this placeholder, so I'm not sure about. So.

C

The main idea here was to rename the small image to small image URL, but I'm not sure we should rename it sometimes the small image. Well, you can be useful and maybe some people already use these these properties, so just by removing it, it will be a little bit confusing. So my idea is just to add an additional field and use it for just buy back your own and that's all for my site and the next. Our presenter is Vitaly Boyko poet, please feel free to share your screen and guys.

C

If you have some questions regarding the implementation place, let me know.

B

Then make sense to have you know, additionally, to a small image and I believe we discussed this possibility as well, but we didn't modify requirements so, okay, good.

C

D

So, as you mentioned, I was working on stockin v coverage, a task. Let me share my screen.

D

So here is a kid created by Alexander: listen.

D

We have to implement grab, you know, coverage for stock, on fees and endpoint. Let me jump, let me jump into how it currently implemented in drastic guy to show. What's now here we have a store module.

D

Bpi and here we have service API, which provides us I'm. Sorry, why does interface to get store configs? This method gets turkin fix.

D

Let me jump into the service, so service hundred tunes array of digital objects, which cost or convened interface and except one unnecessary parameter, which is thoughts to filter, exactly open fix so well. I show you how I implement what how implement it in in graph.

D

So I I wanted to schemer as a query type, which is exactly except one: unnecessary, parameter, store, calls and returns type store, configs, which is a kind of wrapper for store, config object which contain all needed field fields based on fix. So let me, let me show the implementation here we have one resolver, which is token figures over.

D

In stock configures over we get data from that data provider data provider. We use same interface as web api in this store, config manager and in the same way we get data from store, config manager and just hit write it from object, type to nested array and return back to configure solver.

D

Then let I show you how it works here. On my system, I have two one website to store groups, and we saw each one has store store within.

D

If we not define.

D

Z-Store codes, we're gonna, accept all store views with the store countries later on.

D

As you can see, we get them, so let me define the store codes.

D

And now we're gonna get one, and this is pretty if from my site, Thank You yarrow, and thank you for having me. If you have any question, please ask me.

E

Yes, I have stunts, Intuit, looks cool, really useful. We will allude to the future. We had discussions with magenta guys related what we need in a face in a sculpt that we need a store configuration from magenta and we do that will I mean we need it initially. We needed for PVA implementations and we will define in addition, the fields that we need for PVA. So we don't wanna, for example, to all store conflict, but there are also another one which is not covered by current Web API.

E

So we will provide the list of the fields that we need for now for PVA, so will be nice. If we can extend it, then also, in addition, we discuss it. It will be nice to have some XML configuration within a Magento where you we can define those lists and then, if the developers you know we will develop all the all extensions in the future can extend it easily. So they just define in you config parameters in a XML file and it will be delivered back by craft.

E

That's one more point and turning from current implementation, I have one question. I mentioned you transferring the store called in like a parameter there.

E

It's me if I'm wrong, but I guess that in grad, QL you're transferring usually the store code in a header like if you want to get the data from another store, yeah.

B

That's right so, actually in any graphical and point in any graphical query, you can specify store and then the store header will initialize store manager and you'll be able to access current stole from your resolver, and at least it was supposed to be done this way initially, if there is use case for getting values from multiple stores at at some time. Do we need this, because if we specify store code in header, then you cannot get like reg.

E

Well, I mean I mean for now, I, don't know any cases. If somebody can tell me we can discuss.

F

For front end friend can only have one store in scope.

B

Yeah, so, and and for what Alex mentioned regarding specifying white least for now, we wanted to whitelist Vij configuration. So you don't. So you cannot get like arbitrary, constant values, but it will figure out like what exactly info PWA will enable those and then, if somebody needs more, they can extend it in the XML from from the extension. So it should not do like very complex to correct current implementation, but Louis you need to adjust it a little bit. We.

A

A

It's create separate test tasks for this functionality, because generally process looks like ready for match and my proposals move step by step. I.

E

Would agree generally I would propose it. Maybe maybe we can align the store code so that we are not using it like parameter, but getting it from current store which transferred in a header. That's only one changes which will be nice to make in a scope of this pull request, and then we can make anyone already with the like fine. We can make a new issue and then a new poll request for the additional changes.

E

Thanks a lot, the trailer will help us because we are waiting for this implementation already for delayed.

D

C

That was a hot discussion, yeah Thank, You Tali, and our next presenter is Bartek vortex. Please share his career.

G

Hi guys I show my screen. No, so.

G

According to my current task, it was certain products, stock data and, according to description, I had to add fields related to product of data. One is representation of in stock and out of stock, and second one is depends on configuration of trace, hold configuration when only X left is set and our quantity is below that value. It should.

G

It should show us a quantity and if only X left is disabled, it should show no.

H

G

So in my graph, QL at Abbott to field stock status and.

H

G

X left in stock and, as you can see for now, I have a produc number. One and current stock status is in stock and only X left in stock is said to move because of our product has quantity set to 20 and in our configuration stores, configuration.

G

Catalog inventory, currently only cleft result is set to zero.

B

G

Is disabled so back to my product? I will change product quantity, I, set it to zero, safe product and from now.

G

We have quantity, zero and stocked up status out of stock, and we run this query you can see the stock status is changed from in stock to out of stock. mmm Of course, I had to allow to show products that a is out of stock in configuration two.

H

G

Back to this configuration.

G

G

I change only X laughs, Chris called for now for about 55.

G

Run query. Of course nothing's happened because our product is currently out of stock, so I had to up I have to add stock for it. I.

G

Set it to 20, set in stock, save that product.

G

Okay from now is 20 is in stock, so now our product back to this stock and only X left in stock Shaul 20 for its quantity and for the implementation. Of course, we have testing scenarios that cover all two fields.

G

One is from in stock and another is for the out of stock. This time is 4x life in stock. One is disabled or enabled.

G

G

The base interpretation is I defined in product interface, two new fields and out from these two resolvers and stock status, is based on a known in stock and out of stock. So for for now it's all from me. Thank you.

C

Okay, Thank You Bartok for the great presentation guys to have any questions to attack.

B

Like it's great implementation, I don't have any questions to implementation. I just have one question to all of you guys garden requirements, so we have currently situation when, if you disable drawing out of stock products on storefront, you will still be able to get this stock status like in all City. Basically, all products will have stock status in stock. Like from my perspective, it should be useful because if your PW implementation, like storefront implementation, doesn't care much and you show like product status all the time, you don't have to write any conditions in this case.

B

On the other hand, maybe it will be useful to return like now is, but, like I personally believe that current implementation is good, but it was some like conversation around this and if you guys have other opinions like feel free to, let us know when we may I create for work tickets. If you believe that this is not like really what we want but like from our perspective, I believe this is. This is good. Okay, I.

G

Got there are you, okay,.

C

Thank you you, so our next presenter is Martin Martin. It's really nice to see new faces here, so welcome to the team hi thank.

H

You you guys hear me get yeah great alright, so let me show my screen.

H

All right, so are you receiving my screen now, yes cool, so the this pull request is about fixing small registration when you try to filter categories from a gentle, so the thing is.

H

All right here in the category and the get three method we have a small slash of the bird beginning. So when you try to to get the root category is one one. One word to kill us from the database. The root canary doesn't have the first slash, so the fix it's about changing of that registration on this field.

H

So when we receive a number one get to the root ID, we will be using great expression. We have the first slash right. So let me just comment this out and try to get.

H

The root get it won't work just the first last person so to enable the validation we can hit again and it will be returned in the entire categories and add also children categories now that all the child. Currently, the request is failing.

H

It is Travis validation which I have fixed here, but that's pretty much it it's kind of an easy fix, but it's my first contribution, so I was kind of nervous now, but I hope I hope to you know resolve that Travis test. So we can.

H

Write, you have any question guys.

B

So maybe just one suggestion, if possible, to do please also modify existing tests or write a new one right.

H

B

Yeah, if you need any help like setting up environment, if you know like run tests or like questions about tests themselves, you can ask myself I'm Alex powers or you can write to valerian Ida, who is also from gentle, and we can suggest you how to how to proceed.

B

H

That would be. That would be awesome. Thank you. Yeah I would take that offline, yeah yeah, it's I, don't have any test environment setup so movie great. If you guys can give me a little hand for that. Thank you. Thank.

B

H

That's all from my side.

C

So you have the best background pass home. Thank you. Oh, it looks great okay, guys so I believe. That's it maybe some words to say no.

A

B

Thank you and feel free to reach out. If you have any questions thanks, thanks guys bye, everybody see you next week.