Magento GraphQL Community, 6 Dec 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Magento GraphQL Community Meeting, 6 December 2018

Description

Agenda:
1) GraphQl-237: Multishipping coverage (@Vitalii Boiko)
2) GraphQl-258: Product Layered Navigation filters return duplicates (@vpodorozh)
3) GraphQl-248: Create customer account (@Stepan Furman)

GraphQL Community Project Wiki: https://github.com/magento/graphql-ce/wiki
Mind Map: https://www.mindmeister.com/1094880388?t=a5LVAQ71Vq
Backlog (with Zenhub): https://github.com/magento/graphql-ce#boards?repos=128075669&showPRs=false
Backlog (without Zenhub): https://github.com/magento/graphql-ce/issues

Zenhub Chrome Add-on: https://chrome.google.com/webstore/detail/zenhub-for-github/ogcgkffhplmphkaahpmffcafajaocjbd

A

Hello, everyone and we start our weekly sync up. I share the screen.

A

So you see our agenda, we will talk about multi shipping, creating customer account it's true in water topics for pitiable way. And finally, we will talk about some bug in proto, clarity, navigation and first, our presenters is Vitaly buco. He will talk about multi, stripping, Talley.

A

Little you do a muted.

B

And now, can you hear me? Yes, yes, much better hello, everyone, hello, everyone, so I meet Ali and I was working on setting setting shipping undressing.

B

Was Mary should to proceed with I was proceed with multi shipping, so, let's get to it so I will add product. Why stir phone because I not handle have to be by interfere yet so I'm? Sorry for that. But anyway, as I say, product.

C

Let's add some water.

B

As you can see, our login in and because mojo chickens works only with slog it in customers.

B

One's like steaming Philomath, my laptop, very hard.

B

It's in its debug, no no swish, swish dog I believe.

B

C

B

But it works say recently too much faster without the streaming, so I believe with string houses, issues with performance.

B

Let's start another one.

C

C

B

Anyway, one product: it's enough for multi shipping, because it's going to pop one teacher, let's check, let's.

A

B

The idea furnace but item id is 340 sound. Let's keep this product oozing multiple addresses I have a customer with two shipping addresses and I'll show it because it's gonna take more time. Just believe me that one has to be not desk as ie4 and another have is real. That's cheaper, 24 trillion products, three items and two shipping address three two items. So then I gonna take it from this customer.

B

B

Let's I reload the application.

B

So now I should serve them and runs it. Larry.

B

Oops I should get the actual actual card move.

A

Looks like you should you need to create.

B

And add products once again, very bad.

B

Because if I create a new one, another one will be as far as I know,.

B

B

Nope it's worth haha yeah, it's worth great. As you can see, we have two shipping addresses assigned to to a cart when so, let's jump into limitation.

B

Initially we have a single address implementation, so.

B

We have an interface said, shipping addresses on card and it was implemented, but why it's that ship and a single shipping address of the card and in multi shipping module I'm over eyes. This I have arises.

C

B

A multi shipping implementation and this isn't how it works. When we get a single address, we will around all the service simple shipping service. Otherwise we run in mucha shipping.

B

Just well I have a lot of issues to be so mentorship in model plus it was implemented only for I would say it was implemented in legacy way and the issue it wasn't covered by any REST API, so I need to do it. I would say from from from a scratch, so to use multi ship in motel. First of all, I need to prepare it for using via graph QL. This means that I need to create customer session because without customer session it doesn't work.

B

Also I need to assign a customer for this session, but pay attention. The session session I mean it's kind, it's kind of rapper, it's not pure session, as we know in in server-side. It just is just a container so and then also I assign the customer to session and I assigned a quote to multi shipping model, because if I, don't I, if I didn't do this miss Shippen model, just troll what effects a lot of exceptions.

B

So after preparations I assign the shipping information in from what needed for mateship and model which was prepared in shipping items, my popper and looks like that.

B

It's awry and the array contains card item, ID quantity and address ID and also start going to the moocher shipping model and very very processors, so.

B

If you see mature shipping model, it doses and assign add our addresses to to itself and also I found weird behavior along with assigning shipping address else. It's also all the time assigned billing address for some reason, because I don't know why. But this logic implemented here.

B

And somewhere here so if I add here.

B

If I had here, which is shifting I'm sorry billion others, it also will be assigned.

B

Here, as you can see, billing address was assigned, but if we use simple single mode, I'm sorry sing to address, let's say to.

B

Try trying to fetch the very loud whistle- oh it's already outside I- need to create a new cart. I need to create empty cart.

C

B

Don't know for now how to correct how how correctly to show it but billion others do not be added if for a new customer, so it's different behave and then I don't know what to do. This is for now and it's a question to hear from you from architects and also I would like to show that I divided.

C

Because, before.

B

Here was just cart, addresses but I divided into analysis and be in a dress, because it's different entities in and it's too much convenient work with them separately. Also I also would like to clarify. Is it correct or I should remove these changes?

B

Thank you also. I have to mention that the this pull request is not finished yet because some tests, fault and and I need to add some other checks for validation. Is it it from my side? Thank you and any questions.

D

Yeah, can we can we summarize the what I guess the points that you need help with so there's there's a question one, whether whether it's okay to divide to break out the billing address suffered from the shipping addresses array. So that's a clamping second question you had was something about setting a billing address when the shipping has been said already yeah in.

B

Simple shipping flow we in single shipping floor, slow billing address are not set by default, but for multi shipping is being said every time for now because of implementation of shipping shipping model.

D

D

Can you do you mind, leaving like a comment on the pull request with those questions and so that we have a record and then we'll well-well that we can discuss or maybe schedule like a one-off discussion, yeah.

B

D

Okay, well yeah.

E

Thank you thanks.

D

For showing that that's that's yeah, it's good stuff! Thank you for having me I have.

B

To know why so bye, bye, okay.

A

Okay, the next our presenter is religious love and he will show some fix in proto clarifications.

F

Hey guys, do me yes,.

D

F

Nice, let me share my screen.

F

Okay, do you see my screen guys? Yes,.

D

F

Nice, thank you, okay, so the bug was in case you're running this graphical query. You will get the footers. That does not correspond to real situation. So in fact you want to get the products tutored by category and you want to get the filters object. Yeah in this selection, and in case you will open that front end. You will see this filters this cocoa filters, but in fact the result of this query will be not these suitors, but much more filters like with duplications as well, much more filters.

F

Yes, so what I have find out? First of all, there is the two problems, the worst two problems. The first problem is duplication filters. You see three styles with style filters, but in fact, in fact it's not a problem. It's the way how the filters who drew name are retrieved. In case sampled seems simple.

F

Data are installed, three style attributes, product attributes are added and all of them have the same label style, though it's like miss configuration that on taboc is the first problem, so we do see style bottom footer with the label style and reduced e style bug, style. Bikes attribute with the same label style so, okay, the first problem is not a problem. It's not to duplications, it is a different attributes, but the second problem, the different amount of filters from the exact amount of filters and I, find out that the problem is simple.

F

The problem is in.

F

Is in catalog player yeah, let me find this change. I'm student. Let me open the yeah, so the problem was that.

F

Catalog layer object used to use default category, but not category that was used as a future parameter here for.

F

For future screen, so in fact when we are saying okay, I want to get products with a filter it by category D, 28, yeah, magenta, say: okay, guys, I appreciate it, but I would like to return the filters for the category for the default category category with a d2 for about yeah. So my solution is as simple as the door.

F

It's let me let me show to you it's like here's, the products or Zoeller. We.

F

We are getting the category the future here and just putting it to this transfer. Our re data transfer, re and in case somebody from other souls that we will be included and executed after this resolve will need this category D future. That is present in filtering a query.

F

They will just get it and use it so yeah I've placed it here and after it's I have taken it from layer, builders, resolver yeah and put it it into future data provider and these futures data provider.

F

The same is just transferring this attribute value to the metal gate futures from filters provider that is itself setting the needed category ID for the layer layer is older.

F

Yeah, though it was the first part of this of the solution for this problem, and the second part was the solution for this problem. It was temple logic, as I said, that is used in a PhD mountain plate of content of viewing filters. It's like in case there is no items suitable Artemis in your future. Then there is no need to show it, though there is a simple check.

F

If there is don't products for this future present, then we will include it in their filters all right, okay, snow, then sorry, we will not use it yeah and.

D

Is there yeah, what's a little bit clear to me, is if there's three there's three different styles style filters that are that exist for the for that result set you were showing that there's a style, a there's like a bag style yeah.

F

D

Style, if something some some other style, what is it? Is there logic in the P HTML template to read to somehow resolve those three filters or just pick one of those, because you on the front end, you only see one of those styles right.

F

In front of you see on the one of this styles, because only one of this styles I use it for this category, category 28, it's like, let me show you here- is a category 28 yeah. We do see style base layer, a basic conversation stock. It is a remember it's a bottom. Yes, it is a tower bottom. A trip. Okay, I, see.

D

So the other observer.

F

Is no logic should.

D

Not be coming back.

F

D

E

F

Be a products that will be that help that will have a attribute value from another style towel bags- something like that here. This filter will be present here and it will be showing like style so we'll get at duplications. I, see.

D

I see got it. Thank you.

G

E

Like attribute said.

D

E

D

For but this could be a problem for search results, though potentially.

F

Yeah, but it should be fixed, it I think in a sample data. It's not like a blog of Magento. It's all this bug of management.

E

Yeah yeah yeah understand that and.

H

I believe that in the search result we all look for or a while will use not for attribute names right.

F

Yeah yeah, so we will look for the values from the attribute options base layer, basic conversations not but not for style, yeah, exactly I.

I

E

I

Resort issue: okay,.

F

Okay, so yeah, let me show you, how does it work? You know maybe doesn't hold so the same query. You know it's like 2080 here we are running and we do see the filter name style. Let me make it be named style ties.

F

We met roller yeah and pick a collection, and in case you will compare it with the this category on front end, you will find out that it is the sample just yeah, so it works. But in case just just let me return to the your question in case we will put the check ready to default degree default category, we'll find out that there is a three style attributes: yes, style, one style, two style three, but again this that's just because there is a label with the name style. Okay,.

D

Do we need any additional attributes to to be able to resolve to what the attribute actually is.

F

Like attributes, don't worry, I didn't get it. What do you mean.

D

I guess my question is: do we need to in the graphical response? Do we need to return additional fields so that the client can differentiate between those different styles like that I? Don't.

F

Think so we just need to go to the Kofi's, go to manage labels and boot style. Thanks yeah, and let me save this future and we will gonna see step.

G

G

A tomato same table unless you created category, which has multiple different products, which can different yeah.

D

So what I'm saying is it's not necessarily wrong in sample data to to have the same label applied at four different attribute sets you.

F

Know what we can return there at also the attribute code? Sorry, that boy ain't right.

D

Right, yeah, that's what I meant! That's what I'm asking whether that would be a convenient thing to return so that you can differentiate yeah.

F

I think it will be bad yeah to add, attribute, go because, like good, unique definition for the attribute. That's.

D

And it should be present.

F

For such responses, you know.

H

What I'm going to do with this attribute code, I'm going to show to.

H

The potential customer isn't will be better.

I

H

Name it and that's all.

D

G

I, don't think it should be like the case, but let's assume that we have to start attributes such as valid case, yes and the question how to use the meat filter. Actually, when you try to filter the result that should have done today, because you know like how do you submit the filter do provide named as the filter or what would you provide.

A

What we can ask about the test, yeah.

G

Looks like we can.

F

At the moment, I'm trying to find out, if you can no, we cannot here with the definition layer filter. It has only name request water filter items, count and filter items. So we need to add this functionality here, guys.

G

Yeah because it may be that unique or Birbal.

F

Name of the future query today: yeah. Let me edit and go check your gear. Okay, it seems.

H

F

H

F

Is what we're looking for, but why does it go old so.

H

F

G

Yeah I assume it's probably inherited from it exist. An internal implementation, I assume so.

E

D

Okay, so then the question still the question is still stand, so we have this probably worth renaming. That's that's not the biggest issue, but is it? Is it possible today, I don't actually know? Is it possible today to apply a filter as this graph? You will allow you to do that.

D

But what does that look like.

D

Is that is that passed in the filter for products, or how do you do that? Nothing, okay,.

E

Okay, I just haven't tried, I, haven't.

E

D

It's been a while for us, sorry guys, okay, so so it's good it's great to see that it was so it's fixed. Now to where at least the query for category reflects, you know the filters that come back or the same as what you see on front end. That's that's awesome and then yeah, it's yeah. It looks great so and it looks like yeah that we had. We have the attribute code, which actually is just returns in a different field. Actually.

G

Maybe some other field, which is called request, variable yeah I need to shake okay.

D

Okay and then we'll buy these filters here.

F

Okay, guys I'll take a look at it. Requests for requests for what does mean and take in case it is a attribute code. I will just rang your name, okay, guys, because it's really unclear yeah.

D

That's great! Thank you. Okay, okay,.

H

Yeah no yeah, could you please show the code where you set is manually, set this category particular ID to the filter, yeah, so you're just trying to find out what will be if you will not help this filter at all. Did you check this.

F

If you'll not have this filter at all, there will be yeah, but if no yeah.

H

Yeah I can see now yeah, so in the end we will have like a basic category ID. This is with the ID right. Yes, yes,.

F

Okay, just okay, it's you know, I'm, sorry, rich yeah,.

H

E

D

Good work thank.

F

You any questions: okay,.

A

F

A

Would like to ask you all some covers from certain activity, functional tests and of course, we will have additional contribution points for this request. We will provide some this yeah.

F

Are already working on it and.

A

Can ping me on Coco channel? You can find example of group called testing dev test, integrate.

C

A

C

A

Quail folder.

F

A

A

Next next presenter is Japan and he will demonstrate base functionality of customer creation via Bravo.

D

Pick your muted yeah.

H

Yeah, hello, everyone I just told that first time contribute to graph key. Also don't judge.

I

And just tell me if you see my screen, yes,.

D

We do it's very small.

H

Still so small.

G

Increase what font font size.

I

H

Okay, I'll just switch to another screen.

H

G

Option you can just enter presentation mode. Probably there is under vision based on the presentation mode.

D

Yeah, that's better.

H

Yeah, so everything is okay, okay, so my my task was pretty simple. The creative basic functionality for customer registration, who the graphical so I have added is the new mutation and with the customer import and customer output yeah, you can see here that we can add the almost holes it all existing all existing.

H

You attribute that we need for procreating and means here the crop, ID and website, because you know, because it depends on you, we can't mean we can't manage it from the front end, because it's just registration from the front end by the customer. So we don't need to subgroup, it will be stated like default cool.

H

So here is the resolver and they also faced with the the one with the one new for me is a setup context, so once I created in new account, so usually we create new account generated token token and set it to the to the feather and right now. I have to just create a new customer and instantly get EEG data so and know that we need to set additionally set the contact here.

H

Also, it's usually just ID and customer types. Nothing, nothing special is here. So it's it's a pretty console and let me show how it works. So here I prepared, worry with the name last name, email, so random, the the required and some random attributes. So let's proceed this request. Oh.

H

Come on the same already exists.

H

Okay, let's have it much better, yeah, much and so, and the only issue that we have to write up if that I, don't I didn't implement here or the validation of all this attributes, like you know, require required, are not the type of the data and training can input and all the stuff that is stored in the database in different in the different tables.

H

So we decided to be do whatever we decided to change, to create another Kulik request for this and for setting the values for four different stores, because this functionality is just only for enterprise for commerce, for commerce agenda so and I, don't have converse magenta, so yeah and and I already started to do some function at the functional testing. It's not called right, 404 now and but I think I will finish soon.

H

So that's it from my side. Questions.

A

Could you show functionality if password is miss? It.

H

Ability to don't set a password, and in this case we the customer, will receive the email really with a proposal to serve this password. Let me show you a little: let's create a new user without.

H

Okay, got it down and I have two of the emails. Okay.

H

But view the second.

H

So much hard to get.

H

A

Step I think it's not important. Even my question: it was how it works, coax, like it's work,.

G

To create account on storefront without second password cause, I believe this is admin functionality, usually, when you create as an admin customer account, and then you actually test America, no.

H

We just choose everything for, for usual customers, yeah.

G

So the question: can you do this from storefront, not specify password I, don't think it's possible. Is it why.

H

Not maybe maybe no I actually actually I, don't have right. Now. Somebody business business watch it for this, but I believe there are disability. So it was some.

E

G

What I'm saying currently this functionality is used from admin panel only when Edwin creates customer account and I don't remember. Maybe there is some configuration and then panel, where you can reconfigure behavioral storefront, but by default and pretty sure that you are required to enter password on stop okay,.

H

But I don't know exactly I need to investigate, but maybe maybe some something like you just completed your checkout and you will be offered to create an account and something like that. I, don't remember exactly.

H

D

Dig into it, it will investigate on our side and we'll just leave comments. This.

G

Isn't this is more like product question how it should behave.

H

Yeah, okay I'll check it out. Thank.

A

A

One notice Enterprise Edition provide only UI for management of customer edibles, but in scope of community edition we can't emulate some additional custom attributes. We had some test features and we will postpone this functionality and separate tasks as I mentioned, and we will add, possibility to provide some additional validation for customer choice and we will add support of customer attributes and separate tickets, and we don't need for this Enterprise Edition, because Enterprise Edition on the few iPods it can emulate this Community Edition.

F

As sorry a question about custom attributes for the customer, so you're going to include it in Magento, Community Edition part in a different task. Am I right to include this possibility to use custom? Ok got it thanks.

A

Though whoops like the tool.

D

I, don't think we have any updates from from the room here.

C

Two great guys.

A

If we don't have any questions, we can finish everyone. Thank you.