►
From YouTube: Magento MSI Open Demo. April 27, 2018
Description
Today’s Agenda:
1. Adapt Returns (SalesInventory). All returns should happen on Sources used for Order Fulfilment
- Issue: https://github.com/magento-engcom/msi/issues/377
- PR: https://github.com/magento-engcom/msi/pull/1021 (@seruymt, @vadimjustus)
2. Notify Quantity applied to Product in Advanced Inventory on Product page in Admin doesn’t work
- Issue: https://github.com/magento-engcom/msi/issues/878
- PR: https://github.com/magento-engcom/msi/pull/1003 (@roman.kis)
3. Cannot Place Order with Configurable Product on Custom Stock.
- Issue: https://github.com/magento-engcom/msi/issues/1015
- PR: https://github.com/magento-engcom/msi/pull/1016 (@roman.kis)
4. Validation failed during saving created a simple product with ‘0’ qty on a source
- Issue: https://github.com/magento-engcom/msi/issues/991
- PR: https://github.com/magento-engcom/msi/pull/1017 (@pavlo.bystritsky)
Additional topics if @larsroettig, @iminiailo and/or @joshcarter could attend out meeting:
5. Remove the First Implementation of Source Selection Algo from Admin UI
- Issue: https://github.com/magento-engcom/msi/issues/998
- PR: https://github.com/magento-engcom/msi/pull/1022 (@larsroettig)
6. “Qty Uses Decimals” doesn’t work for simple product
- Issue: https://github.com/magento-engcom/msi/issues/774
- PR: https://github.com/magento-engcom/msi/pull/1000 (@phoenix128, @iminiailo)
7. Returning void on method makes the whole class unable to use plugins
- Issue: https://github.com/magento-engcom/php-7.2-support/issues/33
- PR: https://github.com/magento-engcom/msi/pull/993 (@phoenix128, @iminiailo)
8. Need to remove all cross checks between Inventory in catalog regarding verification that SKUs being operated in Inventory exist in Catalog
- Issue: https://github.com/magento-engcom/msi/issues/889
- PR: https://github.com/magento-engcom/msi/pull/1019 (@joshcarter)
B
B
Creating
credit
memo,
so
in
this
case
we
have
two
different
cases.
For
example,
the
orders
already
are
shipped
or
not.
In
both
cases
we
can
create
a
credit
memo
and
therefore
we
need
different
behaviors.
What
what
will
happen
with
our
reservation
or
our
already
deducted
sources,
I
created
already
to
simple's
here,
I
attend
two
sources
and
I
add
every
everywhere
ten
pieces
of
products
there.
So
now
that
we
are,
that
is
easier
for
us
to
calculate
better.
B
B
B
B
Of
the
creating
the
invoice
can
create
a
credit
memo
for
this,
so
first
of
all,
I
will
create
a
credit
memo
for
just
one
piece.
Each
and
the
expectation
here
is
that
we
we
will
create
for
focus
and
come
parity
for
a
reservation,
so
we
release
from
from
our
given
reservation
P
speech.
So
here
we
are,
we
see,
reservation
was
created,
our
source
items
are
still
the
same.
There
are
untouched
so
far.
We
can
also
see
in
our
product
grid
that.
B
B
So
now
we
can
see
that
our
sources
are
deducted
and
we
can
also
see
that
there
are.
There
were
reservations
that
the
positive
reservations
there
so
now
we
create
a
second
credit
memo,
for
example,
for
three
pieces
here,
and
one
piece
here.
So
our
expected
result
is
that
at
least
only
one
piece,
each
SKU
was
really
salt
and
away
from
our
stock.
B
There
the
sources
were
increased
again,
so
our
saleable
amount
is
19
each
yes,
so
that's
so
far
from
from
this
implementation,
it
works
so
far.
There
is
still
an
open
question
or,
for
example,
what
happens
with
SKU,
which
was
shipped
from
more
than
one
source.
So
the
current
implementation
would
recreate
the
sources
in
the
same
way
like
they
are
shipped,
but
this
is
probably
not
the
way
how
the
retirement
will
will
happen.
So
therefore,
we
need
still
a
new
issue,
I
think
and
need
to
implement
an
additional
logic.
A
Yeah
mark
your
mic.
Also,
we
already
discussed
that
with
mark
and,
if
I'm
not
wrong,
mark
wanted
to
make
this
process
to
be
an
intimate.
It's
like
we,
no
matter
how
many
source
has
been
used
to
fulfill
the
order.
We
always
need
to
make
a
return
just
for
one
particular
source
and
that
source
supposed
to
be
used
in
this
order
fulfilment.
So,
for
example,
if
I
had,
if
we
had
ordered
particular
sq
and
that
is
key,
you've
been
delivered
from
the
source
and
the
source
be
no
matter
that
there
were
two
sources
used
to
deliver.
A
B
C
C
C
So
now,
as
we
can
see
from
the
grid,
I
have
only
one
the
full
source
enabled
and
now,
if
I
go
to
the
product,
I
will
see
the
default
on.
My
gentle
UI
is
without
a
messiah,
let's
create
a
simple
product,
so
in
the
form
of
gentle
a
we
here,
Stan
we
have
in
advance
inventory
is
a
field
which
is
named,
notify
for
quantity
below
and
let's
set
it
to
5,
let's
save
it,
so
it
should
be
saved
from
for
the
default
source.
C
C
Now
go
to
the
pro
and
refers
a
page,
and
now
you,
as
you
can
see,
they're
notified
quantity.
You
showed
here
it
is
five
as
we
saved
it
and
it
is
a
not
use
default.
And
if
you
go
to
advance
it
inventory,
you
can
cannot
see
this
field
because
it
is
absent
here
and
now
we
can
repeat
and,
for
example,
set
it
to
use
default
here.
C
Go
again
to
the
product
page,
we
should
see
again
the
default
UI
and
if
I
press
advanced
event
area
I
sees
notify
quantity
below
again
and
it
is
use
config
settings.
So
that's
all
about
notify
quantity
field.
It
was
small
issue
and
the
another
one
is
I
can
say
that
it
was
critical
issue
because
we
couldn't
place
all
the
risk
of
the
variable
product
on
custom
stock.
So
let's
enable
source,
3
and
source
2
and
save
it.
C
C
Next
and
place
order,
so
now
order
should
be
placed
successfully.
Ok,
that's
good!
Now
we
can
go
to
the
admin
panel.
Again,
we
can
see
this
order
in
our
grid,
and
now
we
will
try
to
do
shipment
and
invoice
this
product
can
invoice.
Let's,
for
example,
invoice
for
items
submit
invoice
as
you
can
see
invoice
what's
good
to
hear
we
have
in
roast,
for
and
under
it
five
let's
go
to
create
shipment.
C
C
C
B
D
Quantity
field,
as
you
see,
is
optional.
We
can
save
product
about
second
quantity
field
and
it
will
be
become
zero
and
stock
status
will
become
out
of
stock,
so
I
have
implemented
same
behavior
on
a
source
model
with
just
multi.
Sauce
I
was
unable
of
second
source
to
reach
the
witches
or
small
that
previously
in
multi-source
mode.
D
D
B
B
A
The
update
I
would
like
to
share
is
the
is
a
cool
request.
We
were
given
and
deliver
it
in
the
scope
of
the
preimage
in
hecatomb,
and
precisely
I
would
like
to
highlight
the
contribution
of
Riccardi
Tempesta
from
a
specialist
and
he
labored
for
pull
request
both
to
magenta
and
some
of
them
both
to
magenta,
poor
and.
A
Let's
start
from
the
beginning,
the
first
of
historic
glass
was
devoted
to
to
quantity,
increment
support,
and
actually
it's
pretty
strange,
but
since
magenta
hooded,
all
to
that
one
and
to
the
to
our
quantity,
increment
assumption,
ality
support
just
integer
values
and
it's
not
possible.
It
was
as
possible
to
specify
a
decimal
value
as
a
quantity
increment
and
actually
did
not
feed
for
such
businesses
as
a
drugstore,
for
example,
or
or
cooking,
for
example,
where
they
were.
You
need
to
specify
some
fraction
of
value
as
a
quantity
increment.
A
So
let's
see
how
this
particular
feature
has
been
implemented
and
have
been
brought
to
msi.
So
here
here
you
can
see
here
you
can
see
a
product
in
the
product.
Let's
go
to
the
advanced
inventor
in
the
advanced
military.
We
enabled
we
already
enable
the
quantity,
increment
and
specific
wanted
to
increment
this
one,
so
the
the
integer
value.
Now,
if
you
go
to
the
shopping
cart,
we
already
have
this
product
in
the
shopping,
cart
the
simple
product
and
we
can
update
according
to
this
increment.
A
So
here
you
see
that
update
happened
and
we
are
not
aligned
to
specify
a
decimal
value
because
you
can
buy
this
this
product
only
in
quantities
of
one
at
a
time.
So
the
here
we
violate
the
the
check
by
the
increment
this
why
it
was
not
possible
to
date
our
quad.
So
now,
let's,
let's
change
the
quantity,
increment
value
and
specify,
for
example,
one
and
a
house
and
save
product.
A
A
Actually,
this
is
the
first
pool
request
and
the
first
feature
which,
which
was
provided
by
record
at
intestine
and
another
another
pool
request,
which
is
very
very
useful
for
us,
because
you
know
that
on
msi
we
we
are
going
to
support
HP,
7.1
syntax
and
the
Bartok
Bartok
was
involved
into
this
activity.
But
actually
we
stuck
with
several
blockers.
One
of
the
blocker
was
our
outdated,
outdated,
called
sniffer
and
the
mass
detector
we
use
in
our
static
test.
A
But
the
only
issue
which
prevent
us
from
using
PHP
7.1
syntax
was
our
code
generation
mechanism
and
actually
main
reason
for
the
code
generation
mechanism
was
that
we
don't
support
at
that
time
before
the
before
the
pre-major
hackathon,
we
did
not
support
plugin
ization
and
the
code
generation
for
intercept
interceptor
on
class
with
method
which
returns
the
void
as
a
as
a
as
a
type
and
in
the
scope
of
his
pull
request.
A
little
card
updated
our
code
interceptor
generator.
A
Now
he
he
added
as
a
possibility
to
check
lair
whether
the
message
so
based
on
the
reflection,
whether
the
message
is
returned
void
or
not,
so
we
will
add
on
not
add
a
return
to
our
to
our
final
final
function,
final
interceptor,
which
is
supposed
to
be
generated
here.
So
you
see
this
return
is
an
optional
here
and
that's
why
we,
they
are
not
getting
any
more
fatal
errors
if
they
are
plugin
isin
method,
with
a
void
return
type.
A
So
after
accepting
this
pool
request,
our
activities
on
peach
on
moving
MSI
on
a
pitch
P,
7.1
syntax,
is
totally
unblocked
and
I
believe
in
in
the
next
demo.
Bartek
will
I
hope
are
because
I
can't
commit
commit
for
particle
if
he
is
currently
not
on
the
meeting,
but
I
hope
that
will
finish
the
activity
of
moving
to
peach
peace
and
that
one
very
quickly
with
this
requested
board.
So
this
actually
a
main
update
from
another
another
another
important
stuff
that
we
finally
finished
the
decomposition
and
segregation
of
inventory
module.
A
And
now
we
have
inventory
and
inventory
it
mean
API.
So
that
was
this
was
last
not
not
last.
We
still
have
inventory
in
module,
but
that
was
like
another
another
module
where
we
made
this
segregation-
and
we
are
also
pretty
close
to
finishing
the
story
of
segregating
UI
out
of
business
project
with
her
own
system
and
another
and
another
another
update
we
finally
removed.
A
We
finally
are
I.
Don't
have
created
order,
but
we
finally
removed
the
tabulation
with
with
the
initial
implementation
of
of
source
selection,
algorithm
and
all
that
functionality
rotated
mark
and
me,
because
because
we
don't
use
anymore,
but
some
guys
who
start
to
use
project
bin
to
track
and
start
like
starts
looking
on
it.
So
we
finally
removed
and
Lars
from
tech
division
fix
this
issue.
I
believe
ours
will
show
it
showed
next
meeting
because
it
really
wanted
to
make
a
demonstration
by
himself.
B
A
It's
a
song,
so
we
can
just
describe
what
Josh
actually
implemented
so
as
we
we
like,
after
as
a
result
of
matched
items
in
Italy
between
between
Marc
wedding
of
Adam,
and
me
where
we
discussed
whether
we
need
to
support
support
referential
integrity
between
the
catalog,
squ
and
the
inventory
is
queue,
and
we
agreed
that.
Probably
there
is
no
sense
to
to
check.
For
example,
at
the
time
of
inventory
import,
there
is
no
need.
A
There
is
no
business
need
to
check
whether
the
SQ
we
are
importing
exists
already
in
the
catalog,
because
in
this
case
we
actually
introduced
in
there
the
dependencies
between
two
type
of
import/export
and
is
potentially
a
merchant.
In
fact,
with
the
situation
when
he
made
an
expert
and
after
that
you
can
make
a
new
import
afterwards,
that's
why
we
agreed
that
we
will
remove
existing
existing
check,
and
actually
that
was
the
main.
A
That
was
a
main
idea
of
contribution
or
judge
Carter
who
eliminated
existing
check,
and
now
our
import/export
and
all
the
all
the
operation
we
have
with
the
source
item
are
not
not
dependent
on
excuse.
We
have
a
catalog
so
actually
catalog
responsible
for
presentation
of
askew
and
inventory
responsible
for
for
quantity
and
the
stock
management
of
squ,
one,
not
an
issue
if
some
squ
would
be
mentioned
in
inventory,
but
wouldn't
be
mentioned
in
in
catalog.
B
A
Everybody
else,
thank
you.
What
demons
Thank
You
Sergey
you
actually
made
this
show
and
made
them
happen,
because
I
was
totally
distracted
after
imagine,
and
I
would
not
be
able
to
to
conduct
this
demo
by
myself
so
say.
Thank
you
guys.
This
is.
This
is
actually
how
how
self-driven
community
and
how
like
a
community-driven
projects
supposed
to
be
supposed
to
happen,
so
I'm
really
satisfied
and
I'm
really
enjoyed
it.
Thank
you
very
much
good
evening.
Thank
you,
mr
so
dude
yeah.