Magento Multi Source Inventory, 6 Oct 2017

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: MSI Open Demo. October 6, 2017

Description

MSI Weekly Demo:
- Implement Reservation Clean-Up
-Default Source and Stock. Creation of Default Source and Stock for it. Including admin UI
- Import/Export of Stock Sources (new functionality + admin UI)

New Functionality of Source Items (products available on physical warehouses ) Import/Export presented.
https://github.com/magento-engcom/msi/wiki/MSI-Roadmap

A

Hello guys, sorry for the delay and had some technical problems with my recording and of this, my zoom, so I can see that we can start the today's demo and show what we have were what we achieve during during the current week.

A

So, according to our agenda, we we can start from the story which was implemented by Bartok but unfortunately Bartok and drawing today's meeting, so I will make a demonstration of what's implemented so I will start sharing my screen and, first of all, let's reinstall magenta launching this command so actually and while the magenta would be deployed, I will open the roadmap.

A

So actually the story I am going to show. You is the default sourcing stock creation of default source and stock. So the main idea here is to is to provide for for merchants who will have the MSI onboard, but for those who don't want to use a multi, stop functionality not to overcomplicate their user experience and follow the requirement that look and feel for this merchant should be the same as before when magenta was a single stock system.

A

So, actually, what we need to do with during the installation we need to install the default source default stock, make linkage between them and actually run the indexation which will create the default default.

A

Default index for the first to stock item fields described and.

A

Yes, so we are still in story on magenta and actually doing that after the magenta would be installed. We will see that the some default source is created and- and we have a linkage for the default stock and we no need to introduce any additional logic. So actually it would be pretty pretty helpful for for those who still use this new stock system and for those who don't who would like to use a multi stop functionality, they they would have an ability, thread more sources and introduce more linkage to another stocks and make another decision.

A

So we are strolling.

A

Yeah so now we can get the URL of of this newly created system and follow bite.

B

B

A

You you you, you.

A

So now we can go to the managed source grid.

A

A

And see that we have up and running before sauce which is enabled, and if you go to the manage stock, we supposed to see here default stock. And if you will edit this stock.

A

A

Here we see that there is a linkage between the stock and source and.

A

And if you connect to the.

A

A

We can see here that, after the magenta installation, we also created dynamically the index table, which name is inventory stock item stock, one which supposed to be an index for this default stock.

A

So this is part of the of this story.

A

Which, which is supposed to be implemented for the defaults orson stock? Another part of that story is that we need to prevent that default. Source and stock should be deleted, because if we will delete this- and actually probably just this equation to mark how it's supposed to be implemented, whether we need to prevent the leader of the story source on a single stock system, because actually, if you will delete one actually, that will break the whole inventory.

A

Should we provide this prevents this deletion.

C

Yeah I think it must be prevented. I don't see another way. They can't go to the point that they have no stocks remaining through the admin mm-hmm.

A

And actually one more question: we wanted to ask in this couple this story so because there are potentially two possible ways: how can we treat this default source? Whether we can treat this as a role, so we can reassign the Dafoe source to to any of the sources wills, health or whether we would we would use this like pre, pre hard-coded and, for example, like magenta default website, which is not supposed to be reassigned to any other website.

A

So should use this additional complexity with with assigning a role of the default source and stock, or is it okay to have there like the first first ID ID ID, one of the source should be default. One and I give ID one of the stock should be default, one as well yeah.

C

Your second idea, I, would prefer to have less complexity and have one that is we're not able to change the role, because it's much easier for us to cover all the cases where it could be deleted. If it's more just on the default, like that, okay.

A

Cool, thank you that makes sense for us, so I'm stop sharing! That's for now! That's all regarding the default source and stock story, and the next presenter would be Alessandra. We will show you a reservation cleaning up system and how we supposed to clean up our reservation. Storage.

D

Hello, everyone.

D

This week, I managed to complete my first integration test that colored the clean up. Actually that covered the stock calculation feature.

D

I have to say thank you to last, because I had some issues with running my integration test, and so he allowed me to to move on.

D

I'm sharing I'm.

B

Going to share my screen now.

B

D

Basically, I was blocked on because I didn't know that during integration tests and in during testing Magento Christy's, temporary files and I didn't delete them. So I had a situation which was compromised on my testing, environment and I couldn't manage to to run them I.

D

Can show you how the tests run and actually the test covers to use case the get product, quantity in stock and the each product in stock use cases, but to perform these tests the cleanup the cleanup service is used, and let me remind you what the cleanup is. The cleanup is that procedure that cleans our all the reservation that are bound to the same stock and product and whose sum gives zero, because at that point these information is as no is meaningless, so can be removed.

D

There is not so much to see, but there is something to say about these dysfunctionality, because we had a lot of discussion. First of all, let me say that the work that were that did is really useful because since I was developing, I was developing my integration test without the default source and the default stock I couldn't use the reservation. Fixer files because reservation reservation are depends on the stock index table which isn't created, isn't created as fixture file, but is created by indexation, so I couldn't use and I had to create reservation.

D

Let me show you at runtime during the during the test.

D

So, for example, here the first thing I have to do is running the indexer, just to be sure that the table is created, the stock at the excess stock table is created. Then I create the reservation that needs the the stock ID and then I can execute my my I can create reservations and execute my tests and my assertion, and there is also something not very clean here. That means that, to remove reservation, I have to unreserve the same quantity.

D

They are that I reserved and during teardown of the tests, I call the reservation, cleanup method that will remove these records from the DB. This is done for two reasons. First of all, we don't have a method to delete my reservations in our resource models, because we don't need to. We don't need them, so we can call directly something that deletes our reservation from our source models.

D

But another thing that will be refactored after merging of vertex module is the fact that we can move this creation of reservation from from the test into fixture files, because at that point we will have the full source and other full stock and which we can rely on this stock ID identified by ID 1. So this test will be a refactoring and cleaned up and I I will be more proud of it in the future.

D

Next steps, we discussed together about the next steps and we will probe and we will for sure, a new model that will be created and will be called inventory sales likely because we have to. We have to take into consideration that.

D

The fact that the product is in stock doesn't necessarily mean that the product is saleable. We will have to take into account, for example, the pack orders, but these are all topics that belong to another domain. They are not related to inventory domain, they are related to sales domain, so we will just like we did for inventory catalog in which we created the default. The birth tax create created the default source and stock for a single warehouse management.

D

We will create the inventory sales module, which will implement the logic to inject the idea of the quarters in in these kind of checking's about availability of product.

D

Another step I I want to take in the in the very next future is that of also testing my way baby. I because I I've seen unit testing and integration, testing and I'm actually missing my first web api test.

D

I think that it's all I don't know if a girl wants to add anything or someone has some questions actually.

A

I just want to add that I already know Bartek request everything already in the develop branch.

D

So I can proceed with with their factoring on this test. Then I can I can begin working on on the inventory sales module.

D

We discussed a current I discussed about this. This feature this module. If you have any any concerns of considerations about it, please talk with us.

A

Okay, so the next subject for them would be would be presented by Vitaly.

A

E

E

Today, I try to explain a situation regarding our indexers I think not need to share my screen, because I have only some ideas for.

E

Deliverance diseases: we have some cases for invalidation our index setter.

E

It's can be during change count of our products in the source of that assignment to some stocks or bar by assigning assign sources for this talk, enable/disable these sources and.

E

Foolery index for all stocks, and this, these cases must have three different indexes for handling.

E

Our index for this situation and now.

C

E

E

Some little decision for create credit in texture that will be show in admin panel, but.

E

Physically, we do have three sub index first, for these three cases that the.

B

E

Work with separate entities for, hmm for example, source items in case for change, count of products for sources, stocks in case of assign an assigned sources to stalk and disable enable sources. And in this case, we work with source entity in indexing. And this problem for.

C

This problem I not.

E

Care and the last decision- and maybe somebody know better approach for this and can help me this.

A

Okay, so I will summarize what we Talia just described so because we're having pretty complex Indies- and actually this will be the first multi-dimensional index because we will have a. mmm We will have a dedicated dimension for each stock item and actually the dimension would be represented as a independent table in the database. So we and we have several cases when we need to invalidate the index, so the first one when the when the sum product count is changed on some particular warehouse.

A

So actually this is source items update another thing, so in this case we actually need to find all the stock tables assigned to this source and update this data, for particular excuse make the recalculation another case.

C

We need to consider.

A

When, for example, there is some problem with our physical source and we need just to disable it because, for example, there is a hurricane in Texas this one, the warehouse in Houston had some damage and we can't make it Libre from it. So we are temporarily disabled. So.

C

A

Case we need to find all the stocks to which the source is assigned and also make a full indexation of of these dimensions instead it'll bit another kind of indexation and the third one case when we have the link assignment between source and spoke, and this link is changed. So we need to track three different, three different and and depending on these changes, we need to make one or another kind of three indexation.

A

So actually, typically, this kind of work implemented as a independent in this, but we don't want to over sophisticated and the UI, for example, adding three different industries, because it wouldn't be so very understandable by merchants. That's why we would like to introduce and compound index, which will include all these three indexes and we'll run all of these three indexes.

A

So from the user like from the merchants perspective, there would be just one index in the UI and one index comment which he can he can run from his CLI, but actually that comment will lead that three indexes under the hood would be wrong. So this actually is a problem we are trying to solve in the current task and- and we have to working on it, because there is no any any similar example in magenta, yet solely we're trying to implement this new solution and I.

A

Believe after that, we can deliver it in the magenta to core. As a as a general approach for multi-dimensional indexes.

F

Ego one question: we discussion us in Munich with sub services or sub elixir. I think the first case is already implemented because we have some performance optimization for M V. If you will change the quantity of one product yeah the immutable will get information. Okay, the product red t-shirt, has changed to other quantity and I. Think the for the first case. It's not necessary to implement some yet.

C

F

Index and for the pool and the second k for the poo and the third case- okay, I understand but mu. We are thinking about okay, we troll event and okay, it's neat to reenacts all or most of the items and yeah I know, don't know what, in.

A

Munich we yummy implemented actually the first kind of lorry indexation when the great change in the source item and we need to find all the stock stock items which will be be affected. As a result of this really big thing. But because, like.

A

In the quality, but it's still not understandable what actually should be green. This make Florian fixation and, at some time launched in the share like comment of the cron comment, because it's not clear yet what what actually has been changed because we have to potentially we can have too many dimensions and we no need to make the full realization and reindex the full dimensions, but we probably need to change some of the dimensions, for example, for the stock one and stop, but stock 3 and 4 would not be affected at all.

A

And for this to track these changes, we need to introduce some more materialize it with you to drag different entities. So actually we can. We can schedule another meeting just for for compound indexation topic and discuss that subject separately and.

A

Today's presentation and I don't know Lars over dean.

F

Very very centered state of the ticket because he prepared something: ok,.

A

G

So I I prepared a small demo for this feature. I hope it will work. So life thing was always a little bit. You know how can I share this screen. I found it.

G

So here we go so what I prepared is just to demonstrate one of the imports we are currently finished with our finish, we are so far. We have a working append and update behavior, and the next steps will be to implement tests for all these cases. I will show now, but it works so far. So in my tests, I have one product with the SKU test which to assign sources and with different quantities and I have small CSV, which also imports for the test SKU for free sources.

G

So the expected result is we have a third assignment here in the sources and also the quantity should be change. Our CSV is have four columns so source ID, SKU quantity and status. So there's also the expectation that the source ID two will be cut out of stock, so I will import the CSV file.

G

The name of the import is stock sources. Currently at update behavior select this file. Thank you.

G

So datian successful and we will import it.

G

Refresh the product.

G

So, as you can see, source 2 is out of stock. We have a third one and the quantities are changed, so we also can add, for example, our fourth line with any not existing source. Eighty, for example, in order to show the validation.

G

So as we conceived radiation, the sorcerer G isn't a valid one, so we cannot import. I will also show a little bit step into the current architecture. We have so we decide to create the import/export as a completely new module here and the reason is we have a heart dependency to the current import/export, which is quite legacy, and so the current implementation is that we have our source entity for the import, which depends which extends the abstract entity from the legacy code. But we try to avoid as much depending a legacy code here as possible.

G

So, for example, for the validation part, we have. We use a pattern which is already used in other inventory part currently, so we inject here a valid data chain which have an own validation interface, and so it is possible to add own validation, steps with by by extending the validator property via XML and the next step, which is new to import/export, depending or in order to the other current implementation in magenta.

G

We also inject the behavior processes here so for delete, append and replace we inject own commands, and so it is also quite easy to extend them or replace them by our own.

G

Another I think nice to see part is, for example, this you realize, say here Jason this class, which is dip deprecated, currently in magenta and about but still and necessary, for the abstract entity. So we decide to create a new legacy, Jason helper interface, which provide us the information about the legacy, methods and use new and old interface in order to create a proxy for further current deprecated help, so I think also really interesting part how to handle with legacy code.

G

So so far for me, the next steps we will add or what I want to work in the next week are the tests for this validators commands and also the integration tests for the whole import process.

A

Thank You Adam looks very nice mark. Maybe you would have you have any questions during the few functionality which was presented for the sources import/export.

C

No actually I doubt it look very good.

A

Okay cool looks like it was the last bullet in our agenda for today. If there are no any other questions, probably we can finish our today's meeting.

A

So thank you for participation and have a great weekend.

A

Thank You, Franco, bye.