Magento Triage, 13 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Community Contribution Triage 07/13/2020

Description

Issues triaged in this video:

https://github.com/magento/magento2/issues/12225
https://github.com/magento/magento2/issues/29097
https://github.com/magento/magento2/issues/29098
https://github.com/magento/magento2/issues/26214
https://github.com/magento/magento2/issues/26976

A

Yeah for today, I prepared five issues.

A

Let's start from first one.

A

Hey yeah, this ticket related to the taxi when facts.

B

Please don't share your screen. Oh sorry,.

A

Was that I miss it.

A

Yeah this ticket related to including and excluding taxes, enterprising, so step to reproduce. We need to go to the taxa and enable a functionality a to show excluding and toxin.

A

After that we should go to config herbal product with a people's content, and we will see is price price, but we can't see excluding price price leave is excluding tax. I mean you just about this ticket.

A

Don't have ability to see.

C

C

Yeah I'd be curious to see how often this happens, I mean I think otherwise we will probably defer to probably a standard p3 s3 on this one I was looking. It looks like we've had this in for a long time as well, so yeah I mean I, think it'd be nice to have in certain situations, but it's probably not not terribly common, but I. Think it's a worthy, add so I think I. Think a p3 s3 is probably probably fine for this one, but.

A

Okay, next one.

A

Yes, this tickets about the success of message. Usually when we add some product to our shopping cart. Tvc is some message like this one who added blah blah to your shopping cart, but if we will add support to our shopping cart for more recently or ordered product a widget or wish list widget, they really will not see this message.

A

Without any message.

C

Got it yeah I wish, listen in general is probably not tends not to be a very high priority, but I think it does fix some parity between wish list versus non wish list, and so I think this one's also going to be a p3 s3 as well. So it's an improvement I think it's a good find, but but not doesn't necessarily have to be fixed as early as possible.

A

Yes, this issue.

A

Great product page apart and since we can't on all pages where.

A

So we have ability to gazebos this guy selector and we see on there that it is grazie, it's disabled, but we still have ability to play community and yes like to see like I'm, easy, so yeah, Wayne Barker, because yeah we just see the styles.

A

Yes, life is disabled, but really it's not.

C

Yeah that would be that would be confusing, so I think that ones I think it's still a p3, but I think you could argue that one as an s2, so probably p3s two on that, one again if it appears disabled, that's gonna. That's going to confuse some on this one for sure.

A

And yeah it's about a logistic, a default validation on the product with dynamic price, so that they'll produce. We should create the product room.

A

Firstly, we should enables a dynamic price functionality, after that we should create. After that, we go and disable dynamic pricing and we will see a.

A

Presentation of price per usual some errors, and it's okay. If we took off dynamic price but after that one way again enable dynamic pricing, the validation name should be, but in our case the validation is enabled, and we continue to see errors in cases. Price is enabled.

A

So usually, when we enable dynamic price is the price validation is absent because the price is dynamic. But in our case, when we disable and enable again, we don't our products will go through validation,.

C

And remind me again: the validation in this scenario does that it's if there is validation needed, do we prevent a save or post action on that one or is it just a.

C

That's what I thought with a different priority, then so I would say on this one. So if we're gonna get those issues, I would say this one's gonna be a Pichu.

C

That's a p2 s2 on this one.

A

Let's go to next one, the last one.

A

Yeah, it's a bar customer groups um and placing order by specific customer groups um so step reproduce. We should create some special additional customer group different from default one. In this example, we create some additional custom groups, limb and we try to place an order when we look in there to some members of this group and the place ordered by this user, and when we will see our order, the order will shows that it places by people group were in default case. It's admin group, but we'll really.

A

We place this order by our member of our custom group. Customer customer appear, but we'll just create, and so all orders that our place. It is a buy, a place it by default from the people group. It doesn't depend.

A

It's some another group, the custom group, etc.

C

Yeah I'd be curious to see how often these these groups are used, but I think an absence of that I would say probably a p3s too, so so I think it does, make things more usable. You know it's not urgent, but it I think it would be a good fix for for those who use groups.

A

Okay, please it's sweet from my side put a day guys. Do you hear some? Yes, I.

B

Know, unfortunately, I don't have any peers.

A

C

Yeah also, there next time.

A

We're efficient.

C

Thank you so much.

A

C

Right take care of you all right, bye. My.

A

Punch combo is good at least eons ago.

A

B

A

B

Can just finish the Legion, which you will connect.