Magento Triage, 22 Jul 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Community Contribution Triage 07/22/2020

Description

https://github.com/magento/magento2/issues/25990
https://github.com/magento/magento2/issues/27569
https://github.com/magento/magento2/issues/15273
https://github.com/magento/magento2/issues/25192
https://github.com/magento/magento2/issues/12594
https://github.com/magento/magento2/issues/26333
https://github.com/magento/magento2/issues/25747
https://github.com/magento/magento2/issues/25956
https://github.com/magento/magento2/issues/25211

A

Closer, let's go.

B

Yeah, hello, everyone. Let me share my.

B

Screen so today I have couple of issues for triage as usual.

B

Second, let's.

B

Start first, one issue: it's more probably about user experience, improvement and let me explain in the product page in admin and in the category. We have attribute description, so we can put some description and so on, but it has limitation the length like this number and it's quite reasonable.

B

But in case, if admin user decided to feel like a lot of texts, a lot of symbols very huge amount, the text will be just cut and an admin will be not notified and this bug about not increasing amount of symbols allowed but add some message to notify. Like admin user, there are some limit of symbols in this text box, product description and category description.

B

Oh, as you know, probably this user experience could be in like a lot of place like twitter. When you try to use like modern symbol, you will be notified, but it will not be just you know.

B

For me, it makes sense. I'm sure it's not like p0, of course, but nice to have nice to have.

C

Yeah, I think this one's probably a good, a good p3 s3 right. So I think it's it's a good change, but yeah, not necessarily a p0.

B

Yeah this issue is short about translation. We have a message like when user tried to apply invalid coupon. The message on the shopping, cart on checkout will be shown like the coupon code is not valid, and but there are a problem to like apply translation to this message uh by recommended way. So user add this line and the variant in german in the correct file for translate, but it's still not applied on the checkout and seems something called this message that allowed to translate this phrase so expected results.

B

uh When user use incorrect coupon code on german locale, it should be display like in german, but now it displays on english.

C

Got it yeah? This would be, I mean it's I mean if you're, if you know german, that's going to be a tough one uh for you or you don't know uh it's gonna be something otherwise so I'd say probably p3 s2 on that one. So.

B

Yes, I think it's not only about german it's about right. Probably this land in code is not like something. Market is translatable.

B

Okay, go to the next.

B

One, it's probably I don't know, is it dev experience, so it's like main magento flow. Okay, let me explain in magento cli in consol, there are common lag setup upgrade and usually it use when we add some model or change some model or just to upgrade magenta from one version to another, and this command setup upgrade has like defined it. Arguments like verbose.

B

It means that if any error occurs, it will be shown detailed, detailed message. What is going wrong and should help developer to understand and fix, but on the fact this uh this argument doesn't work at all and very long, very long, very long. Three.

B

Very long example: yes and admin user use this, not admin user developers whatever who is upgrading, uh use this command and receive. Like general error message, type error occurred in blah blah blah some intersection. It says nothing to be honest for person who work on it and.

B

And the expected results it just use it as it should work and display like detailed trace. What is going wrong, which general exception that we can find in system local exception log for this issue. Only about uh fix this verbals argument.

C

Yeah this one, uh this one would probably be a a p3 but probably an s4, because it's not necessarily customer facing, but the p3s4. So.

B

Yay, thank you.

B

Just one issue yeah this issue about import export functionality and again improvement messages.

B

Let me describe, for example, we are going to do some import export and we prepare csv file with products and this code and we have url keys for it, but during all huge amount of records we have some duplication of url case, so it's not valid for magento, and this file should be like rejected and at least notified for admin user and expected results.

B

There should be some friendly message like what exactly going wrong with uh sorry, vs, uh usqo and urlk, but in magento we receive some not readable message like undefined something it happens, because when magento prepares this message to display this logic cannot find product name, and actually this notice error message that admin user see its result of sorry. I cannot prepare message for you if they in common.

B

So the proposition is like fix this message and add more valuable information like product sku to this instead of product name, because name is not required in csv file. But sql is unique and you know.

C

Yep that makes sense uh yeah. I I definitely I think this is. This would be a good good thing to get fixed. um You know this doesn't happen very often in terms of imports and such, but I think it's still worth a a p3 s3. uh Actually, my ocp3s2 on that one. That's it's a bit more, a bit more annoying than just a simple text fix uh because it does prevent that so.

B

Yeah agree- and it probably is the main flow to like, add huge amount of products that could be prepared.

A

B

Third party system and.

A

B

B

Next, one about functionality, rss feeds and it's a quite old issue, but anyway the steps to reproduce is the next enable rss feed and, for example, to notify about new products and special products, then go to the storefront and open the rss page and click get feed. Get this information and after first attempt to load it user will be sure, will be c, like exception error, but after refresh the page like press f5, it will be as expected.

B

So the problem only when we just first attempt to load this feed.

B

Gotta show how popular this functionality, but probably nice to have it fixed.

C

Yeah yeah, probably I just I would say just your. I think your average p3 s3 on this one as well. um It would be good to get it fixed. It's.

C

But, like you said not a.

B

B

Oh, it seems all from me for today meetings uh over. Do you have something.

A

Yeah, I have no few more issues. Okay, please proceed. Can you please stop your sharing.

B

A

We have four issues.

A

Again, the first issue related to configurable products and yeah. As you know, we use the hash and some query parameters when we open some configurable products to predefine the color and other options.

A

If we will go to the url just with a hash without additional queries. Query parameters like this: we should get to the base page without any selected options, but in this case options will be selected in some.

A

A

So in general, if we just put additional cache to url, nothing, nothing should be changed. It should be a base page without any additional specific.

C

C

Yeah I'm trying to get a sense of how how frequently this will happen. I mean it is configurable product um which is just quite popular. I would probably, I would say, a p3s s2 on this one.

A

Yeah, graham, I'm not sure it's pretty common situation because it can happen just in case, if someone add many of this hash to the url, because by default we don't use this hash. If we just open configurable product.

B

But you know, probably our integration of some other logic, try to prepare this url to get the product and something goes bad and information after this hashtag is just null, for example, and this integration give me this project product and receive some result and this integration could support it valid result. But you know, I think you got my example.

B

I'm sure it's like critical, but technically it could lead to the incorrect result and possibly some user will receive not expected product with different options size. So but again, it's probably very age case.

A

Yeah and there's something similar q is really good for this issue.

A

C

Yeah, let's give it that so maybe yeah. I think that makes sense.

A

Okay: let's go to the next.

A

One yeah: it's uh also back in hours. It is it's the import functionality. So what exactly this is, but about when we upload some serious sv file with some existing product. After that we change the category for the product or add additional one.

A

So, as example, a product one has assigned category a after that we upload the csv file and we change that currently product assign it to category b instead of category a after that, we import this csv file to magento, and we see that uh magenta will show that uh currently product assign it to two categories to a and b, but we really in csv file. We removed this category, so we should keep just getting the production design just for category b, but uh really how it works.

A

Now it assigned it to category a and the category b. At the same time,.

C

A

So from this in general, from the csv file, we can we can't remove all old assignment category.

C

Yeah this one, I I would say, is good candidate for a p3s2 again like this is unexpected behavior. um It does inhibit downtime and such, but uh but it is more than average for sure and something we want to get right.

A

Okay: let's go to the next one.

A

And yeah this issue related to shipping.

A

I'm not fully no correct behavior that should be, but currently we have two options for dhl, it's document and non-documented, and the contributors say is that he discusses questions with their shell team and if we select a known document option, we also should have some options for send the document. But in our case we have this.

A

A

We should delete some delivery. Tab present the documents with the background documents method. I don't know what behavior is correct.

B

Participate in some discussion about this bug a long time ago and.

C

B

There are some like requirements from dhl side about this, except this case and seems during magento, has several options per select and so on, and since this combination is not like supported or incorrect from the dhl perspective to communication, so you just missed this case since in implementation, and it's supposed to bug describes a behavior that, like dhl, is supposed to work with these options.

B

It's just high level, as I remember.

C

I don't get a sense of frequency on this one, but I think you know it sounds like they've done some some work here with the hl, I think, probably you know also a p3, but then an s2, almost one so let's say get it right, but not necessarily above other other work.

A

Okay and the last one.

A

Yeah, it's a pretty old bug related to the review grid and in general, to all our old grids. So just for some information.

A

Currently in magento, we have two type of the grids: it's a new, a new grid based on ui components and the old ones that was developed before ui components, library was created and yeah in different place. We have the different grids and this bug related to the old grids uh yeah. The main bug is, we have the button select all, and in this case we should select all items, but we select uh just items on current page.

B

A

B

New grid was added like select all.

A

Visible and select.

A

We have two options select all. That means that we will select all items that we have and select all on this page and the same with deselect, but in our old grids. We don't have these options. We have just the options, select all that selected just items on current page.

A

So at least from my point of view, we should align this behavior because yeah from the user perspective, he don't, he shouldn't see the difference between our greats. They looks the same and see they should have the same functionality.

B

In ideal world, probably all old grids should be converted to new one, but I don't know: do we have this task in backlog or not at least for now? Probably it makes sense to to fix it.

C

Yeah, this has just been around a long time.

C

Yeah, I would say, probably just I mean at most a p3, but maybe even an s4 right, there's good reason why we haven't really touched this in a while, um not opposed to it. uh It doesn't. It doesn't hurt anything, but um they lo very low severity.

A

uh Okay: okay! That's it from my side since that's it for today,.

A

Thank you for the time great.

B

Thank you so much.