Node.js Benchmarking Working Group, 18 Dec 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Node.js Benchmarking WG Meeting - Dec 18 2018

Description

https://github.com/nodejs/TSC/issues/622

A

So welcome to the no Jess community benchmarking team meeting for December 18th 2018 we'll follow our standard agenda I'm just waiting for the oops.

A

Starting for the stream to not start, which is perfect, okay, so I'm pulling up the issue and the minutes talk.

A

You, okay, see, you already add yourself room, which is good.

A

Okay, so any announcements to start off with.

A

No okay, so the first issue we have on the list is investigate the time taking a number of benchmarks in core. So I guess we still don't have Gareth.

A

A

Guess Snead I'll just say we need to follow up see if he is still going to have time to look at this. Okay require cash, perf much lower, so I know you were looking at that and had made some progress last time.

B

The framework the run framework, but if I change order of the cash and the new okay I do get the expected results, which I also can confirm when we run them separately. Okay, looking going on the way this run, benchmarks stores those two jobs, I know at the first one and then I'd required would cashed and it's something going on. I couldn't really understand the JavaScript code exactly but I.

A

B

That independently, as well as changing the order that we took it so I, don't know if it's easier would be the change order in the code. I guess.

A

At this point, it's worth changing the order, so we get the right results and we catch any regressions right. Yeah.

B

So I can I can make the pull request and you can look at it and yep. So that should start the job. I mean job is already running, but you have okay. Today, okay,.

A

Which will it's the results? Yeah I mean at least like gets us back to you know the coverage we had before. We know we didn't have a regression which is good and and since it seems complicated to figure out the full answer, or you know, maybe it's better spending time on other things, all.

B

Right I mean yeah yeah yeah.

A

Okay, ghosts, I know was next on your list, but it sounds like that'll probably be next on your lists, yeah. So what.

B

I'm gonna do is we have a person joining another team? Look at the ghost I just asked him to so. He also gets kind of involved with some other open-source war. Okay, that's what I'm gonna do so, but I think okay,.

A

It's that somebody who's gonna join the meeting or your so just join, represent.

B

So I don't know exact arted. Will his band new to the whole just give him some time to kind of wrap up and ramp up on the knowledge and the self sure, and then we'll go from there if he wants, he can. Let me join and I'll ask him: okay,.

A

Sounds good thanks.

A

So the next one is 155.

B

A

Opening that one up.

A

Right you open that one about simplifying some of the scripts.

B

What's his name Jamie Jamie yeah, he said that he'll take a look, looks like he's. Not here so I, don't know exactly right.

B

Okay, I can probably start making at this one. Okay, Jamie comes over I'll, try to kind of connect with Jamie and see whether how you wants to okay. You see with this.

A

Like to proceed, okay, you may have cycles to forward himself. Okay,.

A

Okay, yeah, that sounds good, be good. I was thinking we should catch up with Jamie see we haven't heard from him for a little while see if he's been waylaid by something else or what's going on on that front, yeah and then the other issue, candidate, benchmarks, I, think that was back on the agenda, because Jamie was talking about making some progress on that front right.

B

Yeah those last two were his items right.

A

Okay, so hey Jamie for an update Toofer till next time: okay, okay,.

A

That's the end of the things which are tagged for the agenda. Did you have anything else you want to talk about this week, yeah.

B

I had one question about that: the module discussion you were heading I, don't know. Is this the right place to talk about that or not um jiff jiff? It depends how big a conversation, but if you have some questions sure why not? The quick question is I. Remember the modules you proposed to just look at the JavaScript NPM modules: did we think about what about the node.js dependency? Other projects, like your ICN, your rasili, we know, is very active, but I.

B

Remember I I've been looking at the Zilla for for a little while and I realize that the zine, if we have you know no chase, is really old one: okay, if it is not maintained, currently open source version. So how do you? How do you think about looking at those also, along with in.

A

Your modules, so that's certainly an interesting question, but I not in the scope of what we were talking about under the package maintenance side of things, I mean that it's a different issue, because there are things that note itself consumes directly, and so it's that's like I think if we think there's a problem with them being out of date.

A

That's you know we could open an issue in node core to sort of start that discussion there.

B

Do some optimization I have we have some optimization in-house I want to, and I was just trying to get them and they're, not upstream zero right, so is he live like just not being maintained at all anymore, or is it that it looks like the current maintainer looks like he said that he does not have a whole lot of time to continue his work right.

A

B

So I just wanted to know you're right Headly raised the issue and see how we want to tackle it ya.

A

Know what that's because I guess you know there's a couple ways to go with that so sort of like I, mean I think we've had to kind of we're still using, even though v8 doesn't use so we've kind of had to take over as a project some work related to that it's not necessarily actively maintaining it for general use, but you know we need to do whatever we need internally to keep things going.

A

mmm This could be a similar case where you know, if you know I, don't think we necessarily want the project to now be maintaining Z Lib for everybody to use. But then the question is like: okay: how do we make changes to it? I mean we could just say if it's totally unmaintained should we now say that effectively our version and notice the master version? We can make changes to that right right now. I think it would be we'd want to be pretty sure that you know at some future time.

A

There wasn't going to be a new version which then you know we'd be blocked by taking because of the patches. We floated on top right, yeah, but I think I think that's like a much that's a simpler discussion in a way in that you know, we've included the code in node core and it's it's a matter of having a discussion among the collaborators to figure out what we think. The best answer is. You know.

B

There's enough.

A

Agreement like if it's you know, I put in that issue, all the information that says hey. You know: I've talked to the maintainer. It sounds like it's unmaintained I'd still like to make these changes, because you know they bring this value, but I can't get it into the upstream. So you know, is it the right thing to do to land it in our branch, even though they can't go into the upstream? Alright.

B

And- and so this could be just a general topic about all other dependencies just for the make it future-proof I guess there should be some process if that happens, or how do we keep track and things like that right, yeah, I might.

A

Start with the smaller discussion yeah okay like and if you can get consensus on that, then it's like okay! Well, if this is the right thing to do in this case, you know, should we make it a policy that says well. If something becomes unmaintained, then we will accept changes in our own sort of brand, like I'd. Just be I just caution a little bit about making too broad a question because you may get it may make it harder to sort of come to a conclusion.

A

Right, it'd almost be good to come to a conclusion to like what is the right thing to do in this case, right.

B

A

Now can we generalize that into what the you know if this happens again? This is general enough that we could use this as the pattern kind of thing. Okay,.

B

So then, just I just have one more thing to say that if we decide to and I've talked to the core maintainer, could you do mine, adding me to the discussion.

A

While I was thinking, maybe if you should open the question like open an issue in node core saying here's, you know here's the situation. I want to add these things, because they, you know, help us accelerate or whatever I've already you know. I know we normally want to put things into the upstream. First, all right talk to the upstream maintainer x' and you know if you have emails or whatever you can share in terms of them saying. Well, it's not really maintained.

A

You know include that and says, but I can't, because it's not me, it doesn't seem to be maintained. So you know, can I get the okay to landed in core and and effectively?

A

You know we're we're already in the state of not maintaining it but like if something broke, we'd have to fix it ourselves, because if there's likely know where to get changes back into okay, okay and then, and then, if you CC me on that, I'll try and help participate in, and you know if there's questions or clarification since I've under I can at least help share my understanding that I have from having talked to you directly. Okay,.

B

A

A

Okay, so I think that's it for this week, then yeah. If you catch up with Jamie, if you can, let me know where he's at and what's going on, I think that would be good, otherwise have a good holiday season and I'll talk to you in January. Probably you.

B

Told my ok you next year, thanks.

A

Talk to you later, all right.