Node.js Node-API Team, 2 Mar 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Node.js N-API Team meeting - March 2 2020

Description

https://github.com/nodejs/bootstrap/issues/114

A

Welcome to the nodejs and API team meeting for or the second of March 2020 will follow our standard approach of going through the issues which we've tagged for the milestone and but first of all does anybody have any announcements they'd like to share.

A

B

A

So I will flip over and we can take a look at.

A

Okay, everybody should be able to see that now.

C

Yeah, okay, so.

A

The first one is: do we need some additional async worker variants? I know Genda casts been working on that I saw last week that there are a good number of comments from Gabriel. It looks like she listened to Casas addressed. Most of those. It looks like.

D

D

Some so I'm waiting for gross.

D

A

I did wonder too, and I thought we could get niccola's opinion as well.

A

The the documentation adds the doc for two classes into the same file and I was just wondering whether we should, whether that that makes sense or whether it's better to have like two different files and I thought. Nicola. Maybe you'd have an opinion one way or the other I.

E

Prefer to split in two different files, because I have one single point could create confusion on you, end user, and so this is my my my opinion. 212 two different yeah places and.

E

That's it so I'd say we always followed these. This patter, so III prefer continue in that this way, if you agree.

D

Yeah I think might be better to follow the connections.

E

Yeah, even if, because yeah the API could evolve in a different way, you know so we could create confusion. This is a this is the main, the main reason for me to split the documentation into different files.

A

E

A

I was coming from I think you can prefer like if one is basically a delta to the other. You can probably refer to the other one and say here's. You know it is the same as this other one with the link. But here are the changes or something like that trying to avoid duplication, yeah.

E

Yeah yeah I agree and maybe in the future, if, if there e there isn't not these overlap with these these API, we can just remove the link right.

D

A

Okay, so yeah, if you can just I, guess update that then I'll take another look too and I was just waiting for I figured since Gabriel had looked at all. Had a bunch of comments, I'd wait to look, I'll, try and look later this week again: okay, I guess. The next issue is SQL light and API port. Yes, thank.

F

You yes, this week, I did more extensive testing. None of the failures are reproducible, however, after running them, a number times I'm seeing patterns in there and including segmentation faults. So my objective this week is to be to do some aggressive testing to see if I can make it fail on my development system. Okay,.

A

So it's in the POA like in the CI a--, fails but never on your local machine. That's.

F

Exactly right, oh, it never fails the same way on the CI, either. Okay, but but I am seeing I'm, seeing similar failures across all platforms and across all node versions, so that that implies to me there's definitely a problem in in this code: yeah.

A

There's something there that it's intermittent double freeing or renting memory related, probably now.

F

Michael I had a question for you if, at some point, I need to build, say a debug version of node yep. If I build a debug version of node, does it does it come like with a debug memory manager or is it just including symbols? I.

A

Think it just includes symbols. What you can like you're, looking to see like the thing I would do first, is to try and run it under Val grind on Linux. Oh.

F

Okay, good because.

A

That will actually like track memory. Tell you if your, if your double freeing things, okay,.

D

A

Can give you a pointer to okay.

D

A

Let me just paste it in the chat here: cuz I, just a few weeks ago, PR din to the guy. It's like! Mostly it's it's to help you find memory leaks, but it does have these other things that it does to check for memory. Other kinds of never thought. Okay, so the guide will talk about how to run it, not how to run it to look for those other things. That's an extension. I want to do, but I haven't done yet. Okay, hey.

E

E

Are on the Mac OS right? Yes, you can.

E

Well: okay, when you implement an idea on, you can create Xcode project, yes, and you can use the debug of Xcode. That is very useful. Okay,.

F

E

Bug what happened in the C code and later I I will post you some some reference that I used last week to the bug my my native at dawn, to discover so some some some problems. Yeah.

E

It's better than the debugger that you can have on vs code, but it's it's myopia. So maybe these cool I'll help you, okay,.

F

Very good, very good yeah.

A

The link I pasted the link in the chat you.

F

A

A Linux machine to do that on though cuz.

F

Yes, you know, and I can I can make that happen. Yeah.

A

F

Awesome: okay: this has been really helpful.

A

Okay, anything else before we move on nope.

F

Not on that one, okay, so.

A

The next two ones we kind of have our like the issues raised by module owners or in the node repo. So does anybody have any which are kind of ones that they think we should be talking about just.

E

Finally, be creeped in National, Forest inti at dawn, so yeah I, finally merged my work and publish and I think lost last week last week: okay! Well, that's.

A

Good excellent.

A

Any issues, and no doubt on API or node core that are in APR related the people think we should look at I can oh.

E

Yeah, oh no, they don't API 673.

E

If I well, Michael.

A

E

I cannot see the.

A

Okay, sorry I didn't get it I, some hopeful that I'll hold on there. You go so.

E

What understood here is that.

E

He won't extend the Weibull that is exported by object and then use the the needed update that he just override in the object, so I think that easy. This is not the right way right or I misunderstood the request. Okay,.

A

So let me just understand here, as reading through.

B

She wants to override.

A

So he wants to have new ones that call the original methods is that right.

E

Yeah here in the comment, ice I see calm, I drove a bus set up needed.

B

E

But my durable extender, oh.

A

Sorry I think you went on mute, yeah, okay, sorry, yeah.

E

Sorry yeah so here I I'm, reading called microwave setup needles, but.

B

E

My terrible accent throw a bow so I don't know how to to do that.

A

Right but I'm just trying to think if there's any reason why this is any different from a like. If you were doing this in JavaScript and you should be able to get the like from my drawable, you should be able to get the prototype methods on draw all.

C

Yeah yeah and then.

A

All those methods, yeah.

E

A

Except that's why right? So that's right! So my drawable setup, so yeah so I have to look at why. But you think you should be a way to just be able to get the method on drawable and call that.

A

Now the only thing is there: if there's something special about extending native wrapper class.

A

In that, like you know, some of the I have to remember whether, like things that we wrap into the object itself,.

E

A

Just have to try it out yeah.

E

I I don't know how to assess to prototype. So this is my my problem right from the native side. Let.

A

Me just look I'm just gonna. Do a quick.

A

Right so that's.

A

So from this I'm just gonna paste it in the chat.

A

From this sorry, this link, it seems to just say.

A

E

So after I we've tried to follow these and I will answer in the issue: yeah? Okay, if you can try that.

A

The the the only thing that, like the yeah I, think it's worth trying the only thing I could see. Is it the like there's some possibility that, like the calling it in the context of the current instance might cause some grief like because we wrap things into the object itself that are hidden. So if you call that on a parent class, it could cause some some issues anyway. I think it's worth trying that it.

E

May be, another idea could be as the object in the cost structure of the the the doorway ball and not use the inheritance, but yeah use just use composition, so I I can propose this to solution and yeah.

A

That would be an alternative yeah.

E

A

A

Although it's a little bit harder than cuz you're gonna have to like, create an object and then create the wrapper every time yeah.

E

It's too expensive, yeah.

A

Ya know I think it'd be interesting to try that out. Okay.

C

A

Then see off to see if there is some gotchas because of the the native wrapping that we're doing.

E

Yes, so yeah I, with try and I post some example and if I found IIIi, would find some some.

E

Problems, III really illustrate yeah.

A

Okay, any others that are good to talk about.

A

No, she was in the cast. You wanna talk about this one at all,.

A

Okay, so I see that.

D

Was just let's see, comment from the Cabrillo that cuz we? Currently we keep a people reference that real put out very pointed, and we can facilitate.

C

A

Yeah, it's kind of an idea of something to test out.

E

And Gabrielle asked us if we won't introduce guitar want properties in napi six. He opened an issue on a be stable, node, Rico I, which.

A

One is almost maybe.

E

No enable stable, node.

E

Just one second I want a copy and I.

E

The link is in in the charger car.

A

D

Kind I know that the landed on the tan staging, so the problem might not think list anymore. We can see the nautical or property names to other experimental if we, if we are going to come to the Napa version.

A

Okay, so basically it sounds like the last one that he was mentioning has already landed right. Yes,.

D

A

Basically, it's like.

D

A

Are ready right.

E

F

E

Agree if it's a it's all landed in in tank, okay,.

A

That's good, so we can cut any pi/6 and hopefully get that back back to the various versions.

A

Okay, any others. We should talk about.

A

Okay, so that's good! So if we don't have any other things to talk about, we'll call it for this week and thanks for everybody who attended and we'll see everybody next week, actually I I won't be here next week because I'm off at a conference, so I'll I'll, look for I. Guess Gabriel's set up to do the streaming, so I'll send an email to validate that he'll be able to make it do that.

C

Okay sounds good, alright, guys see.

D

Ya, later, bye, bye.