Node.js Node-API Team, 11 Nov 2019

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Node.js N-API Team meeting 2019-11-11

Description

https://github.com/nodejs/bootstrap/issues/114

A

Okay, preparing.

B

To livestream the webinar setting up your webinar for YouTube live.

A

Yeah, it's it's like. You are online.

B

Okay, welcome everybody to the no GSN API meeting on November 11th, sorry we're late. This should have been two hours ago, but here we are nevertheless. So let's get started with the agenda for which I shall have to not stop the livestream. That's a bad idea, but instead share yeah.

A

B

You desktop one, yes share, screen. Okay, so right here we are. This is the agenda. First up tracking issue for modules, we've noticed or ported. Have we had any.

A

Yes, Vincent updated its his his list and I'm working on this race to select some good models that we can.

A

B

B

A

For for for for the posting for for porting activities that we we want to to promote in the workshop.

B

Yep here they are: oh okay. There are a few more now. That's good yeah.

A

B

Done a good job there, and, and so have you I was I- was just looking at the list as well, and I noticed that there are for at least a few of them. They are basically waiting for no gs8 to like drop off the edge of the table kind of thing yeah.

B

So it looks like we're. Gonna have a lot more modules porting to an API in the new year, which is yeah.

A

B

Think so, too, to sort of remind them in case they their schedules are too busy. You know maybe have another one.

A

A

Can you hear me yeah.

B

I can hear you what's up. Oh.

A

I for a moment, I can't hear you sorry and.

A

The Crypt is an example, because it's all set for.

A

The porting is ready and they decided to delay the switch to an API after yeah after December, when the eight will go out of maintenance. So I'm searching on the list that we.

A

Did and try to.

A

To find a model that don't have.

A

The porting or maybe issue.

A

Opened about these about porting about an API port, yeah yeah, okay,.

B

Okay, all right, that's just.

A

A quality in the list there is a node sauce, for example, yeah yeah, and if you go on a be stable node, we have an initial porting that we documented yeah and read me.

B

Got an issue here: no.

A

No, if you go in the read me yeah in we have a section.

A

Yeah an API enabled models, and there is a note sauce. Oh.

C

A

But I, never never you pushed it upstream. Yeah yeah, so I think that this is very old. Now yeah.

D

A

Yeah we need the two to work. Maybe, and what do you think about? Because no SAS is a big big module. Yeah.

B

Definitely should go with it. Yeah I noticed it's one of the biggest native modules that there is so yeah it would. It would definitely be worth it though I don't know. Who has the cycles to do to to update it?

B

Would you be willing to take this on.

A

Okay, I can take a look because here we have the same four node as right: yeah, okay, so I can take a look at all these. These modules and maybe I, will update the status on this table. Okay,.

B

Alright, thank you, okay. So then, let's see okay, so that's that okay cohdon learned session, yeah I, don't know if we're gonna have a code and learn at at the conference, so so I'm not sure if I'm not sure, if we can, if we can do this yeah.

A

B

A

I follow it, they tried on the on the admin and yeah. I saw that maybe we.

A

We don't have because I love busy us right.

B

A

B

Well, what we do have the workshop right, so so we can. We can just sort of take it offline afterwards and and see see how much interest we get, because it is gonna, be during collab Simon right, so we might be able to get something going but yeah whatever code and learn it. It might be difficult because there is not really a good time slot for it. Okay,.

A

B

See what we can do in the workshop and and maybe get people interested and you know, then they can approach us. But.

A

Maybe we can, we can write a gweat to to write to to to add the tests. Oh no, they don't API right.

B

A

These we can do this and.

A

Info tides on and if someone won't want to won't add the test, know how to do yeah.

B

Okay, yeah! That's that's good idea. Okay! So then, let's see.

B

Do we need additional async work of variants? I think we could have used Kevin on this one, but we did land. We did land. Some right like we were. Lucas was working on the async progress queue worker and last time the the state was that he would look into just using a queue size of zero for it and I. Don't leave made any progress on that, but let me just make sure is I: I haven't had a chance to look github ojsc.

B

Here the icing progress, cue worker here.

C

A

Now we have bomb, oh.

B

Yeah, okay: it has this landed, no okay,.

A

The test yes, but these cannot be.

A

Five: eight nine yeah: this is my understanding.

B

Yes, yeah I'll open that in a second I'm, just curious, create what where's the third safe function. Oh, it uses the top one. Okay, okay, wait: wait. Does he still use the cue here cuz, because the idea was that he would not use the cue but rather use the thread-safe function?

B

Okay, okay, so.

B

That still using the queue size of one, which means he needs to do his own queuing, seem okay, alright, so I, don't think. We've had progress on this one, but okay, but this is the one that's going on now, let's see yeah, so we need we need. This is this was the one to five? Eighty nine, a oh boy, I need to I need to review this. Okay, I'm gonna leave this open because I need to review it. So let's see, does this thing of the smart thing? Ii know it does.

B

Okay, so that was facing dog rescue worker and I. Think okay, so we have the on work complete. This is going on is in progress, worker just document all right, yeah.

A

Yeah, it's uh it's uh III just thought. Did the reference to read me yeah.

B

Because the that one is already in if I'm not mistaken right so so, then so then yeah just add the readme and we have the a seen progress, cue worker in the queue so to speak, and then we you should pretty much be done with the with the variance right. So where were we done? Yeah.

A

B

Here: okay, so that's what we have on the variance the workshop.

A

Here yeah III have a question. Maybe.

B

D

A

Bottom bottom, you know: Jim wrote a section for the workshop where he.

A

Reference and yeah about the week reference I.

A

Think that these two points.

A

Essentially, are the reason or the week reference, but I'm, not sure about the side. One.

B

Well, yeah I mean it's it's a valid point, but generally for the purposes of the add-ons.

B

You know the the add-ons usually don't have cyclical references right, I mean yeah, I mean you're, saying there is valid, but it's most often not the case with add-ons right because they just they usually just have a list of things that that they that they need weak references to, and they need to be informed when it gets garbage collected if they have like if they wish to mimic the the JavaScript memory management model in a native code right, yeah.

E

B

So, if that's the case, then then you would use weak references, but generally generally, the fact that objects- reference objects is not it's not as relevant. On the native side right, it's mostly relevant to the garbage collector itself right, mm-hmm.

D

B

I think I think what is most important for for for for add-on. Authors is to realize that if the reference is strong, then then it will never be garbage collected, and so the memory will never be freed right. Okay,.

A

B

Weak reference so but which is not which is okay right, but but then, but then they have a choice right either they have a strong reference and they provide an API for explicitly indicating that this object is to be released. You know like the example, for that is like set interval right or set immediate right.

B

You know you, you would set interval, you get back an object right and you have to say clear, you're, clear interval, otherwise the object stays there forever right. Yeah.

A

B

So that's one, that's one option and you have to to api's want to create the thing I want to destroy the thing. The other option is is to use a weak reference and then and then the garbage collector decides want to destroy the thing right and then you have you, have you have the opportunity to find out that the thing was destroyed?

B

So in one case you remain in control as the add-on author and you expect your users to to explicitly release resources, and in the other case you you, you you let the garbage collector, decide right and so so I think the most important point for add-on authors about about weak versus strong reference is this right. Is that.

A

B

You have a strong reference. You need to provide an API with which to release it, otherwise it will never be released or you can have a weak reference, in which case the garbage collector lets. You know that, okay, you know you do what you need to do, because this object will never be used again in JavaScript right. There.

A

B

Want to free the memory, but yeah I mean in terms of circular references. Yes, you you can you know you can end up in a situation where, where you have circular references and if they're strong, then they will remain that way, whereas, whereas if they are weak, then the garbage collector can can still destroy the entire, sending the entire ring and and inform at each point about the native memory. That also needs to be freed. So yes,.

A

B

Is a very good it's a very good point on, although you know it might be, I don't know if it's. If it's the right point to make to add on authors right but yeah, you can certainly make it so I'm good with that. Okay, okay! So so that.

D

Gabriel before before we move on, is there an example that that, if you have a strong risk? Okay, if you have a strong reference that it shows how the how to provide the API for release yeah.

B

Set interval is a perfect example for that right.

D

B

Set interval provides an object right that is opaque right on the JavaScript side and and and in case of nodejs. It is, uh it has like a native equivalent right and so so that object. That object is not free right, so the function is keeps getting called until you call clear interval right so so clear interval basically does not delete the JavaScript object, because you have no control over whether JavaScript objects are deleted or not right. What.

A

B

Can do is is store it in a variable, which means the the JavaScript side now also has a strong reference to it, because it's stored in a variable and then you pass it to clear interval, in which case you know it clear interval goes goes to the native side. Freeze all the related resources, like the event loop handles and everything right, and then the JavaScript object is still around. But at that point it's just a sort of a hollow shell and and and sooner or later the garbage collector is going to garbage collected.

B

But at that point it need not do anything on the native side, because the native side will have been taking care of explicitly right right.

A

B

Set interval is an example of that, and things like file descriptors are another example. You need to like, say: F s, dot closed in.

A

B

It to actually go away right, so if you don't close it, if you don't close it and it'll, the file will remain open forever, because the native side will not will not do anything right. So you're open, FS, not closed anytime. You have these sort of bookend api's. You you, you have. You have strong references.

D

And in what circumstances would would a programmer need to use a reference? What would be an example of that? Well,.

B

One one very common example of using a strong reference is, is when you, when you have, when you declare a JavaScript class on the native side, the you know, if you, if your API provides, provides instances of a JavaScript class which are created on the native side right. So you so at at the add-on.

B

Initialization you, you declare, you define a JavaScript class right, so so and then at some point later on in the life cycle of the add-on, you start providing instances of that class to the JavaScript side right and you may even expose the constructor to the JavaScript side so that, on the JavaScript side you can like say. You know, instance of you know, is this instance an instance of that constructor right.

B

You do type validation, and that kind of thing, and- and so so you need to store a persistent reference to this constructor because because later on, you may want to do this instance of check on the native side as well, right and in order to use instance of you need to have the constructor right, but you've already given the constructor in the init right, and so you need to persistent reference to it to check later right because you don't get it back from JavaScript.

B

So you have to keep it around sort of outside the JavaScript world, but still valid. You know.

D

B

That's that's a that's an example of a strong, persistent reference, but.

A

The same means for the simple example of object, because.

D

A

Are creating a JavaScript object and you need a reference, a person, reverence of the course structure. Yes, exactly.

B

Yes, so yes, so defined class is part of object, wrap right, so, yes, you were right. I should have mentioned. I should have said object right because that's the the topmost class, where this is happening, yeah.

A

For gman idea was to show the the the the simple example of object.

B

Yes, I actually have it here.

A

Yeah you have the constructor at the MOE structure is a persistent reference to a function, so it's a functional reference that has a reference count set to on so and and the suppress destruct right.

B

Yes, yeah, yes, okay! So let's see here so basically right so initialize. So we have this class here right boom. Where are you? Where are you okay class test? So this is. This is an object, wrap example from our tests right, so you create this class test right and.

B

And let me see where do you persist the constructor, so initialize? Okay, this is the static one. You call this from the actual add on, and then you define class right right here.

B

Okay and that's just static, okay, but yeah. So let me see here: I, don't think we actually I.

C

B

Know if we actually persist it in this case, so this may not be a good example right. I, don't see that we do. What is this value here? Just this is a context.

A

B

Is for static, okay, yeah.

A

We have the test, we have the example on documentation.

B

Okay: okay, the test is not a good example, because we are persisting a simple object: we're not persisting the actual constructor, okay yeah, so so, okay, so yeah, we don't have a good example in our tests. Then I was hoping that the object rabbit, but but they are in the in the case of the object. It's not typical usage right. So normally, normally the value returned from defined class yeah. So normally the the value returned from defined class is the value that you would do. You would persist right.

B

You would store it in that, be persistent, so that so that ya.

A

B

Instances later so, then so then you would store this in a persistent and then you would say like that: persistent dot new instance and then you would return that to JavaScript so that that's the typical usage in a real add-on.

C

B

So does clarify things yeah.

D

That helps and I'll work on it. I'll continue to work on the narrative and in Nicollet it is you. Would you be able to create a simple example.

A

For for for the observer, op.

D

Know for for a strong reference to a class to a constructor, if not I can definitely look.

A

At it, yeah we'll make a comment, so you can use like you want. Okay,.

D

I do later: Eureka, okay, okay, okay, thank.

A

You okay, I, always sent all by me. Okay,.

D

Thank you. Thank you very much. Nicola.

B

All right, so that's the workshop. Okay create matrix of tested methods. That's the next issue. Where are we on this one? Let me see: okay, let's do this here.

A

Sorry I'm I'm working on tests, but.

A

A

The work is on.

A

If it's a it's, not complete so.

B

Okay, there no worries the words.

A

Iii, in some other times, okay.

B

Okay, no worries no worries, let's see so then: okay, SQLite, let's see here yeah.

D

That's that's still on my list and my time has been going into getting the workshop material altogether. Okay,.

B

Makes sense: okay, no worries, alright, okay list of issues, node, repo, okay, let's yeah I opened this already in some time. So I probably have this open a few times, but yeah there's been there's been a little bit of activity here.

B

Yeah we had. We had this thing, which was caused by this thing.

B

So yes, with this crash here is, is, is something that has exposed an issue with with the core API, which is that we cannot distinguish between between when when the environment is shutting down and when there is a simple pending exception, and so I'm discussing this in in core, did I open this here, yeah so trying to get some consensus on how we should do this because it you can. You can consider this to be a semi major change right to have this and to change the way change.

B

The way the the nappy preamble works to no longer return that be pending such a because that the problem is right. Now we have right now in core. We have this here right, so so you know. If so, you know either either the last exception is not empty or you cannot call into GAA jsut return that be pending exception, but that's not entirely correct right, because if you cannot call into Jas but otherwise there was absolutely nothing wrong in terms of exceptions.

B

Then, if you returned that be pending exception, then, when you, when you retrieved, when you attempt to retrieve the the last exception, which is like nappy, get and clear last error or last exception, or something like that, when you do that, you get back undefined like the JavaScript value, undefined right and.

A

B

We know that on API we try to convert that to an error right, but but but our errors are our subclasses of references right and so.

A

B

You construct the error object. You are actually constructing a referenced object, which means it calls nappy, create reference at some point, but you cannot you. You cannot have a reference to to JavaScript undefined. You can only have a reference to an object right then undefined is not an object, and so sooner or later.

A

B

It dies with a fatal error, yeah.

A

B

That that's the fundamental problem now, even if we even if we introduced this a new status, then we're still gonna have to be very careful about how we deal with it, because you know it's easy to just fatal error out of the of the add-on right and then just bring down the whole nodejs with you.

B

But that may not necessarily be the right way to go right because, ideally, if you, if you are aware of the fact that you cannot call into JavaScript, then you should still be able to handle that situation and maybe maybe release resources or shut down in some way right other than fatal exit right. Oh so, I don't know, I I believe it makes sense to introduce this without semver major, because because this here this here is a bug like this is wrong.

B

Like you, if you cannot call into j/s that doesn't mean you have a pending exception. That's just wrong right, but but given given that we have made some pretty strong, a bi-stability commitments, I'm, not sure if, if we can still fix it right so because you know part of our commitment is that you know in response to a certain situation.

B

Our status will be this right now if we change the status and that is technically semver major unless it's a severe bug right, in which case we can probably fix it so so I'm trying to figure out and trying to raise some discussion on whether we should consider this to be a bug or whether we should consider this to be some ver major, because if it ends up being somewhere major, then we're probably not gonna fix it. Now, of course there is a workaround.

B

So so you know if you, if you do retrieve the last exception, then then you you can check if it's undefined and if it is undefined, then you can. You can behave differently right, so mmm you you need not make the assumption that that the last error is always a valid sort of exception that it's it's. uh You know it could be undefined. So so we could handle this on to know that on API side and then basically basically status of nappa, pending exception, plus last exception, is undefined. Equals cannot call into Jas.

B

So you know we we could do this. We could do this downstream, but it would be good if core did it for us, because that's that's correct, however, then this discussion starts. So so that's where we are with this thing and still talking about it. So we may need to make some changes in I know that on API, if this turns out to be semi major, so that was one thing I.

D

Need to get off the call I'm! Sorry I had skipped this when the meeting was scheduled earlier, yeah I'm, sorry.

B

D

B

D

Okay, no worries Gabriel and I'll be back in my office next week. All.

B

B

D

Thank you so much shirt doing the college. Okay,.

B

No worries no worries talking.

A

B

B

That was one thing that sort of crept up because that's a crash and that's always that's always pretty severe and intrusive. So then there we had a few. We had a PR for this thing and it needs work, so it needs like documentation and and tests and also needs to not throw an exception. hmm So I think Lucas already commented on that. So then yeah, that's that's pretty much the major, but if you minor dark changes from Michael, which I think we talked about last week, if I remember correctly, yeah.

A

Then I I found the other inconsistence and I.

A

Fergus and Michael already addressed the updates that I.

D

A

And got Billy I'm working on not be on two zero; nine three, the set length property of oh.

B

Yeah yeah yeah, so.

B

A

Okay: okay, here you made some comments: I mean about the the documentation yeah.

E

A

That but I was waiting for you.

B

Okay, uh if you need me to review it, I'll review it once more. Yeah.

A

Okay, okay, so yeah I need the review for for the documentation and I hope to turn the test this week and yeah I will okay.

B

No worries no worries. Oh, how do you do this again there we go, what no jump! That's what I wanted? Okay, okay yeah, so you need to add the tests. Okay, you got the docs and the changes and just the tests. Okay,.

A

B

No worries: okay, cool excellent, okay, I'm gonna. Leave that open and.

B

Why'd you do that I want you to come here, okay, so right, oh yeah, this okay! This is gonna, get fixed in 7.8, so I think we already have this in some places. Okay, so we we've worked on this this one. We've we've agreed that it will be obsoleted by this guy I. Think yeah.

E

B

Nap to get module okay, this is probably not gonna happen. I'm just gonna leave it there for sort of reference, all right, yeah, okay, some long-standing issues, but these are pretty much the new ones.

B

Okay, so then that was the core repo and now now module owners right. That's the next one: okay, module owners, I, don't know. Have we had we've had a bunch of discussion on uh no that on API.

A

And there is a guy that opened an issue: I try to have him and I. Don't know if you have another solution that.

A

Could ya issues yes, which.

B

A

It's the last I'll, probably wrap okay.

B

A

B

I was kind of keeping an eye on it, but not very closely so.

A

Essentially, he has.

A

And in this observe has a list of elements and he won't create another object.

A

Another class so and he he won't use.

C

A

It was of disgust from jealousy if you see my example: I I I tried to yeah. Essentially he won't do this and in the in the second, in the second class, my item class and he created a method called that essentially created the the the use, the constructor and rate or the the the the rapid orbit. I, don't know if it's the right thing to do in this case.

C

All right checking checking okay.

B

Yeah yeah yeah yeah yeah yeah, okay. My first observation is that and then this is very academic, but still okay, yeah try try to try to avoid using global variables right because they are not thread safe. Oh.

A

B

It gets complicated without them, but yeah we should. We should try not to give examples with global variables anymore. Unfortunately,.

E

There's there's.

B

No easy way to replace them. You know so I'm, actually working on that that whole add-on class thing to try to make that easier, so that we don't use global anymore, but anyway, that that so that's another thing that that that we need to talk about. But but anyway, let me let me look at the actual thing, like okay, yeah get items, yeah.

C

B

Exactly so, let's see you're my class in it my class, my class.

B

Okay, yeah, okay, so this is a constructor yeah and now, when you say, get items yeah, okay, my time, you, okay, wait a minute where's. My item.

A

B

A

B

Exactly no I mean you're doing the right thing. Right, like you need to JavaScript classes, you need one for one that returns the array and then each item in the array is itself an instance of another JavaScript class, so yeah yeah.

A

Okay, because you need the constructor for that class and use a button now he or she is asking for something like this, but I feel that it's not possible, or maybe there is okay. Oh okay, I didn't so the last. Oh.

B

Wait a minute elements I, which is just an integer right, so so my item new instance. Well, no, no! You can't right because new instance is supposed to be okay, I see so he wants to. He wants to call the directly the constructor of the native class.

A

B

Yes, ah well, no, but sooner or later you need to go through. Sooner or later you need to go through the through the JavaScript constructor, because I mean you're constructing a JavaScript instance yeah.

A

Yeah I need to.

B

Go through the JavaScript constructor, which means you need to you need to wrap it into a JavaScript value. Yeah.

A

It's it's mandatory so but I don't think I kind.

B

Of I kind of get their point, though right like. Why would you do that? Because then you go back so you you wrap it up into a JavaScript value, and then you end up calling the native side, which deconstructed back into an elementary value right. So.

D

B

Yeah, it is kind of backwards, but that's only because you're supposed to be able to call it from JavaScript. You know so yeah, it's yeah. It is what it is. But let's see, let's see okay well here, so he did solve it. Then. So.

C

My item is item because TMP value, what the.

A

C

Is that oh okay.

C

Please tell me he's not passing.

B

Things through through a global variable.

C

C

B

It correct me if I'm wrong, but but it looks like looks like they're they're setting it here and then using it here.

D

B

Thereby avoiding the creation of a JavaScript value.

A

B

It's kind of okay ish, but but it shouldn't be going through a global variable like that. That's like yikes,.

A

A

At this point, why he won't create a class, so he can seem simply return an object from it.

B

So you you were cutting out a little bit. He can simply return an object from from.

A

From from its first object, wrap class yeah.

B

Like a plane, object, yeah.

A

Like a plane object, he don't need to create these. These second object class, because my thinking was that okay, he need to do something with this method. That I call it get item here yeah, but he only need to read data. He just he can only return the the plane object from the first meter, first that he here he he he implemented in the first of the class yeah.

B

I'm thinking like maybe it's that you know the code base might be more extensive than this and yeah.

A

B

A

B

Might be a good reason why the the objects in the array have to have their own methods right, so yeah I mean, but basically returning an array of instances of a different type that that's a valid use case. But then this is how you have to do it right. That's just the way.

B

It's done so you know constructing them like this is actually not the end of the world right and you're, avoiding you're, avoiding wrapping things up and then unwrapping them in in the in the in the item constructor, so yeah but I mean for performance. It's probably better if the arrays are large, I think I think maybe performances is in the background here, like the reason why they don't want to. You know like say, like nappy number new.

B

You know you know in in in when they make the array and then and then you know, value in the constructor. You know I think that's!

B

That's probably why yeah, and in that case yeah in that case, there's there's not much else that can be done, there's not much else that can done yeah, so yeah yeah, the only the only the only thing that that I can think of that could be done here is to is to not use global variables and then just just use like a class instance that gets passed around you know, and then here in in that we call back in, for you, do like info done, data cast that as the class and then retrieve TMP value from the instance rather than from a global variable.

B

But that's that's the common pattern for for for add-ons in general right to avoid global variables. So that's that's. The only thing I can think of here.

D

A

B

Know if it works for them, that's fine, like okay,.

A

B

Seems that it's working and so yeah.

A

But he he he was afraid, he's afraid to to to. Maybe if there is some problem, yeah.

B

Well, I mean it's it's it's it's it's single-threaded and it is synchronous right. Yes,.

A

B

It there should be no problem right because, because you know TMP value, you know I mean he's setting TMP value here right and then and then he's immediately calling you right, in which case, in which case it will be, it will be red, so it should be okay right, it's just not a very it's just not not a very good way of writing it because you're using a global variable to pass things around. It's not kosher, but well it's a solution right.

B

If you want to avoid wrapping things, but but actually it's it's kind of yeah, it's kind of uh yeah, yeah yeah, no, there's nothing! We can do here. I mean the only other thing that we could do is is to use an external right like you could construct. You can construct new with an external and then the external has all the native data in it. And here you retrieve the data from the external right.

B

So, instead of wrapping a number you're wrapping, an external which means you could pass any number of things in there right, you could pass like a giant structure in there and the structure wouldn't have to be heap allocated. The structure could live on the stack here, yeah.

A

B

Would be the only other solution, but you still, you still have to you still have to call into the engine to retrieve the item. You know there's just no other way.

A

A

On what kind of data here really want to pass, because, in this example, is on integral yeah.

B

But I think I mean I'm assuming I'm, assuming that that's just that's just a placeholder for something for some.

A

B

Application data right I mean just an example, but basically the example illustrates the pattern and and yeah I, don't think they have a better choice than this. You know because this this really this solution does avoid converting to JavaScript values and then converting back to native values. It does avoid that step right. So then, so then, the only thing that you can do if avoiding that step is important, then the only thing you can do is make sure that that that it is synchronous right so that you know so that.

A

B

Don't get like you know you you set it here, but then something happens. It changes the value and then you end up constructing with the wrong value. You have to make sure that it's synchronous and it is so in this case it should be okay. So okay I can comment saying that you know it's not like yeah.

A

B

A

It's it's okay,.

A

So I was thinking that yeah you're right, it's not ideal, set the constructor like static and but maybe I can I could use a structure, a suit to or a class to wrap the the structure and pass it around yeah.

B

Hold on, let me let me see that there was an example somewhere hold on. Okay, think it's on the its I think it's on the v8 side, but bum ba-bum dogs, 12.

C

C++ add-ons context-aware.

B

Yeah, so yes, this this is. This is an old example, but I think it's still relevant and it's also relevant in in in napi. So so, yes, you have a class called add-on data right, mm-hmm.

D

B

In module in its euu heap, allocate one you store it in an external and then, when you create the methods you pass, you pass it. As the data see see you pass the external here as.

C

B

And then and then the binding will have will have that data and then they can each and then in the see in each binding. You do this so so this this is the way to do it, and- and this should actually work now, because we've landed the that patch, that that deletes all the references you know when the environment quits so that has landed now and it also landed on 12.

B

So so, if you, if you, if you create, if you create a structure on the heap in your in your add on in it and then you and then you wrap it and then you attach attach it to the exports object with a weak reference, then then it will be freed when the add-on is unloaded, meaning when, when the environment quits, it will actually be freed. So it won't be a memory leak.

B

So so then, so then, after you have that pointer, it's your responsibility to basically create all your functions and and basically decorate your add-on using using that pointer, so so make sure that all the Nappy property descriptors they have it in the data field. They have the pointer in the data field and when you Nappi create function, you passed, you passed the data, you pass the pointer as the data and then and then in in in your in your accessors and in your callbacks.

B

You just retrieve it using like and dot data, and and that's it or if you're or if you're, in in in in napi chord, and you know nap, you get CB info and then give it a data point or, and then you just cast it and you have it so so that would be the way to avoid it. It's not it's not as convenient, but it's it's the way to go and and actually and actually so you know do you know for object, wrap. We have. We have static methods and we have instance methods right.

B

So if you think about it, an add-on if we wanted to create a class, that is an add-on right, and so you do su so to have you avoid having to having to pass these things around like that right. The solution, the solution would be to have like an object, wrap something that's similar to object, wrap which doesn't have anything, but instance, methods right, an instance accessors right and then and then what you do is you give it?

B

The exports object, and it defines all these instance methods and instance accessors on the exports object right and then those instance methods are not really javascript class instance methods. They are your bindings right, but because they are instance methods they have access to this right, mm-hm and then, and then the pointer that you pass around becomes becomes the this pointer. You.

A

B

The the C++ this pointer and then you can store any and then then, instead of global static variables, you have like class member variables which you, which you have access to in your bindings, because your bindings are. Our members are our instance. Members not static members right. Yes,.

A

B

That's that's the basic idea that I'm trying to that I'm trying to do, but basically I, have to copy the object, wrap definition and then I have to like cut out all the static.

B

This static that static, the other thing and and just and just make people understand that it's not even though it's instance, it's really static right, because it's not it's it's it's instance on the C++ side, but it is static on the JavaScript side right, it's not a class, it's just an add-on, so yeah lots of fun, but but anyway, before before, before we go, there's only one minute left I wanted to ask: how are we doing on 2.0 point O.

A

We need to land some other things: I, yes, okay and.

A

We need to modify the the package.json, but.

A

It's it's it's another done API. You are gonna, be stable. Oh yeah,.

B

A

B

B

Yeah I was surprised. It should be somewhere on the first page right.

A

A

Yeah, we don't need to update the JSON format on Pocket Jade. Oh I I can do this and I will check, but.

A

A

Think that the.

A

Micro yesterday merged these. Oh no, we need to merge the documentation here. The five eight eight five, eight.

A

An updated package JSON I.

E

A

Watch yes, but I think that.

A

That cabin needs to work on.

A

I, don't know Tracy function on blocking call.

B

A

Because kevin has different okay, this is the the the the para cast that he needs to work on the that odd.

A

A

Michael I think that the manager this weekend yeah yesterday yeah so maybe a calving now on this week, will work on on the other thing. So this Tracy function and non-working call so yeah I think that for the next week we can start to to yeah create these annuities sweet.

B

Okay, that's great.

A

It's a it's a lot of things. Yes,.

A

B

Good, it's gonna be a good release. Yeah.

A

Yeah sure, okay.

B

Alright I think I think that's pretty much it right. Yes,.

A

B

Alright, then, let me go back to stop share and.

A

I think that it's it's all and I hope to to.

A

Hear you next week or before? Yes, yes, yeah all.

B

Right talk to you then yeah.

A

B

A