OCI Weekly Discussion, 23 Jun 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: OCI Weekly Discussion - 2021-06-23

Description

Recording of the OCI weekly developer's call from 23 Jun 2021; notes/agenda here: https://hackmd.io/El8Dd2xrTlCaCG59ns5cwg?view#June-23-2021---NO-OFFICIAL-CALL

A

Oh double, muted,.

B

Open containers.

C

I can post somewhere if others want to join hey guys. Is it.

B

C

Today, it technically was, and then a few of us were like well we're actually we're planning on being here and so now we're gonna post to the list of like.

D

E

Yeah and I've always got back-to-back meetings for me at this time, but I try to squeeze in and either get to be a fly on the wall only or like today. My other meeting got canceled, so I get to actually be here, be.

F

A

I think we're mostly triaging github issues for the distribution spec, so it may not be the most entertaining call.

G

I also got weirded out that it's being recorded, it's fine, it's fine! Now that I know.

C

It's just so we can capture that face josh and the hair, the coven hair and so on.

G

Oh, that's, that's fine, but I was having a private conversation with jimmy, so maybe someone can.

C

Well, we'll handle we'll handle it in post.

H

Oh, I knew it wasn't private. I was just trying to get youtube good stuff.

C

Jimmy's always in for the scoop y'all.

C

This new email client doesn't.

I

Masquerade, sorry, one second.

C

Okay, um does anybody want to share their screen.

A

Actually, using out.

B

A

D

C

Not a joke jimmy! This is a sensitive topic.

C

I haven't touched windows in 15 years and I'm using windows right now, but I'm sorry I am. I am very tickled that they've actually like truly I've, already been on several like plugged right into several different groups across the company that are they're, prioritizing being able to have like linux as a primary. So even like on our team. um Everybody got got like their laptop hardware and stuff that could run linux and have good driver support so because they're expecting even about august, that folks will be able to just like reinstall and use linux.

A

Yeah, I wonder at red hat, there was kind of this thing where they basically gave you laptops, and then they would be pre-provisioned with linux, with whatever they wanted to install to lock down the machine. But oh yeah. They called it the csb the common standard, but.

C

The first thing.

A

Everyone ever does is completely reformat, so it's.

H

A

uh Okay, I wonder if microsoft's gonna be in a similar place, so they're like yeah, we.

E

A

It down, but then uh everyone just free formats.

C

And I understand that a lot of teams that do work on upstream stuff do dislike.

C

But um they they they've actually got some a lot of stuff locked down to where, like you can't even you can't check most of the systems or the sites or whatnot even like for hr stuff. You can't get to it unless you're.

I

On the vpn and all that kind of stuff.

C

I actually ran slackware for most of the years that I was at uh red hat. At some point, I switched over to the door.

G

um Can you all see this thing? Yes, yep.

G

um All right, so really quick. Should we close all of chris's um maintainer.

A

I mean, I think so I don't know if that's going to piss anyone off but like we unanimously basically agreed that we didn't want to just open a floodgate and that we would instead vote individually.

G

Well, I think um I think what was discussed is porn. There was a issue about it and derek made a pretty good comment. I.

I

Think don't find it.

G

Maybe it was on tv, but it was basically like. We don't need maintainers right now. I do see. I do think several of these people would be good.

G

Particularly john johnson is like all over the spec.

G

So I don't know, do you want to move on or.

A

Yeah, I I think I don't know I I don't know if we should close them all out right now or just ignore them. um I definitely fall in the same boat as you or I'm like.

A

Oh, we don't really need maintainers, but if I was going to add someone, it would be john right.

I

Those are ah no.

C

Full requests. Well I mean, but that's that's where, like jason hall worked with him, hey what I've worked with him, um he's been around for a while last car's, obviously been around for a while. It's one of those like this was more of a conversation on the image spec yeah and I think.

A

Yeah, the other thing is like: do you need if you're on the toc? Do you also need to be a maintainer? I mean, I guess, technically, to apply.

C

A

You have to be a maintainer right.

C

Technical, the technical group or the tdc, or whichever one that is the poorly described one.

C

Yeah and even john said 13 days ago, can we just go ahead and close all these.

G

um We can reopen later right.

A

Yeah, that's true: if someone complains you can always reopen them, let's close them. Closing for now, I'm suede.

G

Are you doing that vince.

F

That started on it.

G

F

C

G

This is yeah, you can blame this. Just the comments.

C

Yeah he pasted it on all of them.

G

Yeah I sent it to you all right. um Go look at some real stuff, um really quick before we just go into issues like I.

G

Oh people added more stuff into here.

A

Like 40, but I'm scared.

G

No, it's just an issue with no contacts.

G

It's um no one has pr this yet and no one has given certain opinions or talked about it much.

G

Oh, I you may have been missing the slack uh stuff, but.

A

Yeah, I haven't been in the slack and like freno died and I was in irc and there was an irc bridge, um but I don't think someone set up a new irc bridge. So I.

C

A

C

Up not for new new free note, I don't think anybody's going to free mode is dead.

A

No, no, I mean it used to be on every.

D

A

D

A

Six of us in uh in the libera channel.

G

Anyway, um yeah there's there isn't there isn't a pr for this? I just what I was trying to get at is like as we're doing this grooming like, should we prioritize based on what we want to get released.

G

Or I don't know vince, this is your your. This is kind of your jam here running.

C

This whole, uh even sometimes some of these just kind of sat around for a little while and just needed other lg tms yeah. I just opened that one up, but it's got like a few comments, but did it? I think they all got it.

A

H

A

Pretty cut and dry this one.

A

Dependencies explicitly check like checked in, I should probably do that.

A

Yeah, I mean the only thing: controversial would be like whatever the import path is and as long as it matches whatever the image. Spec is, for example, or anything else that has code. Then he updated, he updated travis, and I think we.

C

Need to take travis out back and it's true.

A

Oh there's that one, the new owners of travis already took it out back.

G

Hey there's not there isn't one in the root of image. Spec.

A

It might be an ear tool or something like that.

C

They nested it in the.

G

Oh wait. Oh. That was some something that we asked. I think that's that's. The whole thing is like that was the whole.

I

D

J

See this is my comes back.

D

C

Initial, oh, that's cool.

I

Authorized pool.

J

C

uh All these bots, they are great when they work and they are a pain in the butt most of them.

J

G

Maybe I can take 10 minutes and just get us from travis to github. Maybe.

B

Do it live coding with.

G

A

Can we run through everything else? First, just because, like there are certain like, I think we can bang out a bunch of these like, for example, the oldest thing. The register, like the proxying yeah, that was discussed a lot, and I think we came to a consensus on it yeah. This is actually a thing that, like derek and I went back on and we ultimately agreed on. It needs to be rebased and derek probably needs to be here to do anything on it, so that can dangle um the extension proposal thing that is some contentious.

A

I'm not gonna lie. um I don't know what the current state of that is, it's nowhere near being merged, though, although the way I look at it, this pr is probably the best place just for people to like wax intellectual on it. Yeah.

C

I I I keep I like we, I thought we talked about it and then I mean, while I posted it there, like, I found out that people were actually like looking forward to that, and I was like oh, I thought it was dead.

A

Yeah, I think it's probably in the critical path for us before we start uh adding new things to the spec like I. I think this would actually be probably something that we need to agree on and get merged for uh a 1.1.

C

Would you should, can we open this up uh open up a go, go to the.

G

C

Yeah, because I don't uh I mean I could open it up also, this literally is nothing.

A

um The one right after that is like expand the allowed status codes um is that that's literally just changing the actual go code. I think this back right. We don't.

G

I'm gonna so peter's no longer working on this stuff and I think.

A

I think we settled all this stuff already yeah.

G

This is, this is settled.

A

So we can just close this.

B

um That was easy.

G

G

Or do we to then so, are you going to retract your approval here or.

G

Or whatever I I don't understand what this is.

A

And turn it on there: okay.

G

I don't understand, though, is this clock like is this just am I just seeing that or is that.

C

No, no, I know I just like signed in and clicked through and went all the way to pull approving it. Yeah.

A

We can just disable bulletproof because that's built into github now.

A

Like you can set a branch like a rule in the branch or whatever.

C

To approve yeah because we used to we used a comment match on lgtm, and now we use the code review thing.

A

C

We can just use.

F

The built-in github one now okay, so so uh I think I have some settings.

G

um Basically, when you're uploading using chunks, uh there's apparently some ietf way to do that and um you have to specify the units of like. Are you using bytes kilobytes and it's every implementation has just assumed bytes and basically doesn't follow the this rfc and we shipped 1.0 without following the rfc, and I I don't see a reason to break everyone just because of the uh rfc.

G

I don't know if you disagree.

D

A

I think that's right. I don't think it would have been a breaking change if we included something that, like abided by it right, what is the default? Usually if it's not lights, indexed by bytes.

G

No, no, like that's! That's all that anyone supports.

A

Yeah but oh I'm confused like there's two behaviors, there's the rfc and there's what registries do right.

G

Yes, yes, exactly and registries, if you look at this package just bites, if you look, if you look at distribution, it spikes and what is the rfc using.

G

It wait no, no the whole. The whole point of the rfc is that you say.

G

The number and then the units, so you would say, like 40 b instead of just 40., I see.

A

Yeah I mean it should be optional.

I

A

Okay, I mean, I think, going forward just making it optional makes the most sense, but.

G

Actually, this pr was for the conformance test. So can we should we just ask him hey? Can we change this? Can you redo this in the markdown instead of um or should I just say, close it and if you want redo it and the test is optional,.

A

uh Do we think this person is alive still like this? That's.

G

The thing that's what I'm saying I mean I hope so, I'm just what I'm saying is like. Should we close it and say please reopen.

A

um Okay in this package, it doesn't look like they really responded or interacted after just the initial pr right, um they yeah it looks like they just work on their own registry. They found that this was the behavior fired off a pr to fix it.

C

I'm I'm not sure we what to do with this go mod. Now that I'm looking at it like there's.

A

I looked at the other thing they referenced like the runtime spec and I don't see their gomod either so well,.

C

But yes, we do have a specs.go directory, our specs dash go directory. That would make sense to go in, but we also have a test and a dot tool and the conformance has its own go mod. But there's like two other directories that have source code in them.

A

Yeah, um the dot tool doesn't matter. It imports this library right correctly and then it's only the standard library that has dependencies on. So it's not particularly useful for that, um and then we have.

H

A go mod already in.

A

H

We have uh there's test pkg.

C

Off paul it just imports from what it actually imports from test.

C

From the open containers, distribution, spec, test, pkg, dist p, so there's like other things that get imported.

A

Yeah the the specs go is the only thing that doesn't have a build mod right. No, no, no.

A

Actually, it doesn't matter.

C

Either it almost like it makes most sense to be at the top level directory and conformance would have its own go mod.

F

I I think the way that go works so is that one.

G

A

Yeah, I don't think there's projects in go modules, yet I'm pretty sure that, like that's coming the last time I talked to filippo about stuff, he was like you're gonna, be able to break down and just depend on like subdirectories of a whole module.

C

So if we put this go mod at the top and it clobbers the conformance one yeah.

A

A

But if we put the conformance, one will have the same path, though right, it's still going to be open containers, distribution, specs conformance.

A

The only difference is like when people just want specs specs go, and they just want that. Those types they're going to be forced to also really include.

E

The transitive dependencies.

A

That are used in the conformance yeah, which is actually a lot of.

B

Yeah they'll say: there's.

I

G

uh That this 227 is like way out of date. Hey, I don't know if this was actually.

D

G

Fixed on main or not.

C

All right, um yeah, let's close it like get out of here, get this corn out of my face.

B

G

uh I'm cool with I like apparently already approved this one, which is.

G

Capturing um sebastian's table of.

G

Fallbacks for content types, I have no problem with this.

D

What is the bring over.

G

The sorry 226.

A

Yeah, I just cracked it open.

G

That file is basically a sort of limbo.

G

Sort of a workspace anyway,.

I

I

A

A

The content, negotiation thing.

A

I I I need to like look at the actual rendering of it, because.

A

So so uh john's thing is how he does his convert, how gcr does their like backwards compatibility um and I quay also does similar but like it, also supports v1 and not just schema one which even further complicates, um but I have no idea well technically, technically, quays fills all the boxes, I think like we check them all, but it's all really jank how we do it uh if it makes no sense right so.

G

Just um I don't I, uh what am I going to say basically like? I don't think we want to lose this. It's obviously an issue somewhere, but um the first word in this document is to do so. I think someone does need to take a real pass at this as a real document. I just it's not being used by anything. It's not so I'm in support of just putting it in.

A

I mean having a to do in the spec is not so great. No.

G

But it's not in respect is what I'm saying it's just a one-off. It's.

A

Just in a file in the spec repository next.

E

To the specification.

C

It was technically not in the specs you're correct here, y'all, both lgt on that pin we'll go.

H

um Yeah, I actually think this is fine, though, uh what's your what's your hold on go 116.

C

Hold on, why did it it didn't save my my change hold on hold on hold on hold on hold on the path's, not.

C

C

I'll get commit, I forgot a.

C

C

Okay, um it's not beef with there's no beef. I have no beef technically. I don't think that this thing even needs to have a different. A newer go module version. It really should be whatever the oldest version.

A

That supports modules yeah, I think 115 is the first one where you didn't need, like some kind of environment, variable to do the right thing and because.

C

There's nothing in the code that, because it, the only only beef with choosing the latest, is that if there's really nothing about the code that stops a prior version, then don't do that.

A

There is here here we just backdoored some into this back. It did not back door. Anything jimmy.

J

A

That have to pay the maintainers of this bag.

G

All right back door is merged.

H

C

um Hey I'm on these, I'm gonna share a screen now boom. Take you out of them.

C

Oh all right, let's take over um okay, so I was just looking at you know we're on the pool, approved discussion and got to look at the branch rule stuffs here. um So branch rule pattern or branch pattern.

B

A

And it's also like, if you press the button like, if you do anything in the github ui github like signs it on your behalf, which is also awful and totally it ruins that workflow negates it yeah yeah. So it's actually pretty bad because then you get merge commits that are like signed by github's key on behalf of your user, which is strange. um This is also a thing by the way we're gonna have to deal with signing in container specs.

A

So that's why I created multiple routes of trust when we did um uh which we'll call it. uh What's the signing spec, the tough, when we did tough, we did that so like you could trust quay and the person. At the same time,.

B

A

Sign commits is kind of useless. uh What you really want to do is check the first box um and then it will ask how many yep dismissed.

A

That means, when someone pushes a new commit, it's gonna discredit, it'll, throw out all the approvals and make everyone reapprove.

C

Which is useful and annoying yeah, I'm kind of on the dismissed scale. I.

A

Kind of yeah, I think that in general, like if somebody just comes through.

C

Well, I I'm all about it like there are a few times when it's like. Oh, this is a simple rebase or whatever, and it's frustrating, because I'll just approve it again, but other times when people are iterating on something and you're like actually I'll just change something significantly.

C

You want to go through the approval again.

A

Yep um from code and owners yeah, so you can actually have a code owner's file. It's basically a github enforced maintainers file is this? Is this like the owners? I mean like.

C

Is this the farce park.

A

ah It's it is literally called code owners in all caps and you can either put it at the root or in the dot. Github folder um claire uses this uh and it like auto tags.

A

uh It like auto, assigns you in the git repo too, and it was just spamming. The living out of my github notifications, I had to like ask people to remove me from a whole bunch of stuff because yeah they uh because every time it forks it would any pr anyone ever opens.

A

It would just assign me immediately and give me notifications on it and I'm like if you actually need me like at me and I'll I'll, see the issue that I need to jump on, but instead I just get flooded with updates, but because of because of forks, uh not just forks, just pr's in general, I mean I don't work on claire anymore, so I was like, if you need, if you need me, I don't want to see all the notifications, um but if you guys all sub to it like I have no, I don't know, but it also would require us to change like what that file is called right, because we have a maintainers file.

A

Already, it's not it's not in that format.

C

A

Yeah, this is like your github user. The cool thing is, you can kind of subdivide the repo too, so we could have like different maintainers for the conformance and stuff.

H

um But yeah hardships.

A

I mean we might not want to check that because uh we have to get rid of the pool we have to get rid of a bunch of yeah have to kill travis and stuff.

G

By the way, I'm working on this kill travis, uh while this is going on.

A

Oh right, that should do it now. You can probably go in the integrations and disable just like pull approve or whatever other.

A

A

Yeah, I don't know yeah what: how do you disable it?

A

What the hell's.

A

A

Virtual actor framework: okay: this is a different thing.

G

Vince helped: um can you look at the travis yaml for a moment.

G

Line, I'm good with all this line. 1617 is travis commit range, something that they give you and.

C

G

C

But but but that's that's that git validation tool.

C

Which I have a personal interest in or something.

C

And I just recently did a thing to try and handle github actions.

C

So also I was trying to work around travis.

A

What actually is travis even running?

A

What do you want? What is travis even running like make install.tools, I didn't even know we have a make file in this. Oh, like what I didn't even know this was here. What is this even doing? It's? Oh, oh! This is okay, so this is generating the the yeah. We got a mic file, no, it generates a pdf or whatever. This is all your you're crazy doing. Well,.

C

It it does a few things, because it checks for like white spaces and subject.

A

C

A

um That that is nice. Do we still have to have the pandoc thing that generates like some other version, because don't isn't there a pipeline that builds this and puts it on the website.

G

There's a release one, um this validates that the I mean this does that and then it also the conformance target will make sure that the conformance thing builds.

C

Right, so this pipeline does not build the docs also we could make it do.

I

C

Is that what you're asking jimmy that a github action to just build the pdf stuffs.

A

Yeah I mean if we still even need that, because building the pdf is that actually important. If we publish it on the website, we already have a release.

G

Well, I think it prevents is like, if you put some crap in the markdown.

A

Yeah, oh I see you're saying but, like I guess, does the requirement for the pdf still exist if there's like an html version as well.

G

That it's all part of it.

C

Not I mean it does it does the same thing: pando generated the same html also, but if there's a pipeline that produces that and doesn't, if there's a pipeline or action whatever that produces the html and would fail the build if it's like some bunk formatting, then that would be pretty decent I'd get rid of the pandock. Also but yeah I mean so far. All the specs are using the same pandock image or should be so. This is one of those like image. Spec runtime, spec yeah can.

A

We trick another spec to do this work and then bring it over to ours.

A

Like now that we've acknowledged there's a thing, can we like open an issue on the image spec and be like how come you guys, aren't using github actions and then have them? Have them fish it out.

C

Because I'm on both of those specs, that just means no jimmy. This is not your therapy session.

A

I I am just the one that maintains ci for so many things I'm like. If I could not do that in my free time too, that'd be nice.

I

C

Did he do this before 1.0.

A

Yeah yeah he did because that's gonna.

B

Be basically, it's stalled.

A

Yeah it stalled because we were like this is going to happen after.

C

Yeah, okay, what are we waiting on now, elizabeth hack on.

C

A

There's a couple other things in here too right.

A

A

Did I miss us looking at 228, there's literally a section of respect, that's like to do.

A

uh Do we want that.

G

Sorry, I'm I'm like not paying attention.

A

I'm just going to give this the rubber stamp.

G

That was removed, oh no, this must be rebased. I think.

A

Well, can we just delete it? Can we close it that to do still, it doesn't exist anymore right, it's bad well, go to resolve.

G

Conflicts because I'm pretty sure just close it is it mine.

H

No no hold on it's mine, I can close it too. We can all close it.

C

Race, please see okay, so I don't I well there's some to do in the conformance section, but the only other to do is in contact negotiation.

C

um All right, oh I hold the content, negotiation topless.

C

I

A

Should we merge your content negotiation, I don't know. Are we going to sit for a second, because.

C

I, like left even the word to do in there, because, basically, I was I mean we already talked about it. I was just cargo culting stuff that was already discussed before and we had consent.

C

Consensus around it, but it still was like I want somebody else to like.

B

G

Yeah input device is not a tty.

A

Cool you trying to run this on nada, shell,.

G

No, that evaps magic, docker thing.

A

Oh yeah, to get docker to work and github actions. You basically have to enable it.

G

No, I think it's I think it's they changed that.

A

Yeah, let's see yeah input device yeah. This is this: is pandock heating, painting life.

G

It's pretty dangerous that you could just modify the add github actions and they just run. I think I think, there's a new flag to like first time contributors or something.

A

Yeah I mean that I mean that's always the case with travis too, you could be like I'm opening up a pr by the way, my pr changes all the code to just cat the secrets.

G

Yeah, well that didn't what was that uh coverage thing that just happened.

A

There is you're it's running again right now. It's just point on.

A

A

So I looked it up in orbit, looks like it's a community thing. It must be like something the linux foundation installed in the github work.

A

All right ran more, I think, find some more stuff.

G

Oh, I I did a bad thing. I I go mod hates it.

G

I think, when I did the last release, I ran into this issue and didn't fix it on main I just fixed it locally.

A

That's the spirit.

I

I cannot determine that first or strictly.

A

Oh, it's because dot tool is not doesn't have a go mod.

A

G

um I guess I can try this here.

G

C

Tools or dot tool doesn't have a come on.

A

Yeah, that's the error that just happened in the last one.

G

Well, if you look in the make file, I added some wacky something wacky. It's.

A

Still running bulletproof.

G

So if you look at like make header html, it's doing, go modding it and go run tool header. I think I added that gomadi knit, because I was.

A

Very confused yeah, we don't need gomod in it or, ideally, we shouldn't have to.

G

A

Do I edit the whole or user settings hold.

G

On I'm downloading a 280 megabytes.

A

Repo settings there we go, how do I tell it to off? Oh, we have to get rid of the dot pull approve.yaml delete repo from bulletproof. That also works. Should I do it.

A

I'm going to delete pull up. Proof like the spec revo on pull up is that, okay, with everyone.

G

uh Yeah is that are you talking about this internal error.

A

No like when you look at it, do you see how like on github it says we three pending reviewers are like like we're, gonna use, github's review and not pull up roof.

G

uh If we are, I didn't know, I didn't know if that was a legal thing, um no.

C

It's fine chris chris is chris and amy are usually pretty amenable to like. This is useful. This is not useful, it's just. They just need to make pretty much. Their big thing is just making sure that dcos are signed. Hey that gcs are correct.

C

And at least there's some kind of approval framework in place. Okay, it's not it's! Not! It's not foul!.

I

Shot have full approve, has been removed from pull up cool.

A

They're, like you uninstall it yourself great, I'm just I'm going to delete the travis webhook too. I'm in.

I

J

You want to do release branches.

A

Well, I thought you broke up a little bit.

J

uh You guys want to do release branches, we're only on main now.

A

I mean typically you do that when you need to like diverge maine from a release branch, I think so far being linear has been fine um yeah. If that becomes a problem, I think we can talk about it.

A

I

Include administrators, save cool, sorry, that's working from a console, just click old stuff.

I

This this is silly about the.

C

C

Conversations like.

J

A

How does it know who who is allowed to give the green check mark? That's the real question.

A

um Because it might now just be anyone with admin access on the.

B

A

All right, my vote is: we should try code owners, even though I complained about it earlier.

G

I really don't know: what's going on with this github thing to.

E

J

What's wrong, josh.

G

G

If you here, oh sheridan, our chat here.

F

If you look at so now with travis removed.

I

A

Are you sort of traveling.

D

Did you just do this right now.

A

All right, I deleted their one book.

G

I think we're all doing different stuff right now.

C

Absolutely well, but that's good: we can break it early. Sometimes it needs to be broken.

G

uh Vince, do you think that'll fix what I'm doing here.

C

I don't know, but it it it. It's definitely related. This is what I was saying when I, when I was looking at and pushing it into the subdirectory, is that you know that some of these other directories that didn't have it.

I

Would meet it so now, with this.

G

All right, let's uh jenny or mike, if you can, we try and getting that in. So I can see if.

J

I think he's moving it to 116, like not 115 vince, on go.

G

Yeah I just I did see that I wasn't gonna mention.

I

J

uh You're 285 he's using go 115, I think we're consolidating to 116. Was it seven? Why why why huh no, I'm just checking the other pr against yours, no bueno 115 slide.

C

The only reason I mean like, if there's no reason to make it enforced in a place like this, a newer version like if you're not actually using code, that requires newer version yeah, then you can use it. You just use the oldest one that that's possible for the format of.

A

The file yeah, in fact, that's legitimately how, um when you create a new repo and like you, let go automatically figure out your dependencies. It finds the minimum viable version. Basically, so it's always looking for the oldest thing, which is actually actually really annoying. Sometimes um so I just opened a full request: uh basically, dropping pull, approve, creating a code owners and uh fixing my.

D

A

That one should should make it so then we don't need bulletproof anymore.

G

You mean you, should you should buy a zlin ski.

A

Is that ski a thing? The problem is, I I did.

B

A

B

I have this weird.

A

E at the end, because they up spelling the name at ellis island.

G

Right, I know, but it's better for being anonymous. I have mine's ski with a y and I you chose it.

H

Wait so you're, like he's intentionally telling you to choose.

A

The wrong name.

C

And eventually, eventually, future generations all have eventual consistency.

A

No, no but mine's not even supposed to end in a y. It's supposed to be um z, I e l and they said like no, no, um an e after an I before the e and then they did at the end. That's I think, that's the story.

A

They put the eye before the wrong e. They put it at the last d and not the first.

D

C

Hey uh your your.

C

Subject is way beyond what you do in the commits pal.

A

Hey, that's fine.

A

That's part of it.

A

J

Would be bad you're supposed to just approve.

C

If we could just uh make this a a quick thing like that,.

C

So we only maintain it once, but then people want to find it. Did you make.

C

Because this is like a group that's maintained by chris and amy, I wonder if the at, whatever code owners could expand, which is.

A

I mean I yeah, I don't think we change maintainers enough that it's gonna be a big deal.

A

I'm gonna force push after you approve the bats and it's gonna drop you from the code owners. It's silently kicking you out.

G

All right, it's my mine's still broken. I need to go. Did.

I

F

G

I just did you know.

D

I don't understand it.

J

Is it broken in your uh your private fork or is it broken on, though,.

G

uh Well, yes, it's broken in my fork: um hi brandon.

G

Yes, it's broken on my fork, but that's the change. uh I'm I'm running those exact names locally and I don't have the problem.

D

Do you think it's a 116 something four so.

C

Well, since we removed my comment on the push and pull since we removed travis, we need to.

I

I

G

So mike the reason uh didn't mean to cut your offense the mic. The reason uh I don't know if we care or not, you can have a badge, that's tied to a specific um action and if you don't keep them separate, then if, like a pr fails, the badge will turn red. If we don't care about a badge, then.

G

We can have just one file.

G

I'll just comment that.

G

G

um I need to run everybody if you send me a message for, like hey, put a check on this I'll, put a check on it. Okay, all right.

C

I

I

I

Which, I think, okay, which second was vanessa,.

C

C

C

J

Oh he's got a rebase.

A

Got it I actually just clicked back in the zoom, I had no idea that you were sharing your screen. The whole.

A

Time yeah, it looks like the approval stuff works, so that's a nice dependency to have.

A

C

So now, oh you did turn this one yep.

C

So does that mean it's gonna assign it to us every time.

A

Yeah, I think so.

A

But if you don't do that, this is why I even just made that pr, I'm pretty sure it's just like anyone with admin on the repo um can approve them. So that means you can get some like drive by um like runtime spec or image image, spec maintainer, proving something um yeah.

C

Well, I've kind of wished we had some of that stuff because, even with you know, if there were some directories that actually somebody else owns that part of it. You.

A

Know I mean we can do that with the code on our stuff, but um I guess my point before is like someone on the toc or someone with multiple repository access can could accidentally approve a thing. I've definitely seen like random people just like submit their approval like to be like oh cool. It looks good to me, even though I'm not a maintainer. I was giving my feedback on this thing, thus I'll stamp it when I think it's good, which I don't want to discourage.

A

I think that's actually useful if you're working with someone that isn't a maintainer, but I also don't want that to like.

A

Trigger the criteria for the approval process for the pr, if it's too chatty, we can figure out something else, but for.

J

Now this was derek going to come on and.

J

Max make some uh some comments about possible new maintainers.

J

Was derek gonna sign in? I can't.

C

Oh, no, no! No, okay,.

I

No we're over the hour mark so travis is.

I

A

A

Purging all the.

A

A

Cool is there anything left that we're going to work on now, uh no.

C

I don't think so.

H

All right, I think, I'm going to drop them. Yep super useful yeah. I think these kind.

C

H

C

These things sound warming up like let's get on grooming, but it's not like sprint grooming, it's just occasionally shaking shaking some stuff off.

A

Yeah, I mean I kind of wanted to do this because I haven't been able to go to a bunch of the meetings recently so seeing the state of the repo or like going through. It is probably useful. I probably need to read through the the notes from the meetings too, though,.

H

But yep all right guys. Thank you. Everybody bye.

C