Open Telemetry Uncategorized, 12 Oct 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-10-12 meeting

Description

OpenTelemetry PHP SIG Meeting

A

Hey there, oh hi.

B

Foreign, how are you I am well, you are well that is well.

A

Yes, what's amazing your world.

B

uh My son, my daughter, brought home a stomach bug from school. That's been fun, oh.

A

No, oh, yes, have you got the mug.

B

uh I think I'm getting over the I've got over the worst part of it. So welcome back to probably 80 operation right here.

A

uh For 80 cents, my take these days so you're doing all right. I'm.

B

A

80's, probably Peak for me now.

B

You know, look the next developer times point a times point. Oh, oh one times, yes, we're somewhere.

A

Around the right number, yes,.

A

It's gonna be a very short meeting, it's just you and me, oh here we go foreign.

A

B

Most valuable PHP is like this.

B

Give it a couple more minutes and I will I'll share a screen and we can go over everything.

B

B

A

B

All right: well, it's eight or five, so we can get rolling. Now, let's take a look at our open. Pull requests looks like you have one for the otlp for otlp exporter, refactor I,.

A

Do so after I managed uh my devices today, I just had to read integrate uh that that we're closely related. So there was a bit of work there, but I think I'm think I'm happy with this. So I'd like this to be uh reviewed. Please.

B

Yeah, it's in my it's in my it's at the top of my pinned queue, so I'll get to a direction of the meeting. All right uh Tobias, it looks like you had self-diagnostic metrics for to batch band. Processor Brett looks like you've reviewed this already um I.

A

Think it was just waiting on a merge conflict. That's right.

B

I'm happy to fix that merge conflict to merge it if you'd like to buy us or you may fix it whatever you'd. Rather it was fun. I'm, sorry, wolf,.

A

Is fine uh if I succeeded, maybe at the end of the week I guess.

B

Then I will resolve the conflict and murder. Today, let's.

A

B

um And then it looks like you had a this. uh This is ready after every base same thing, but I think the rebates you'll have to do so. You can, if you can do that at the end week, that'd be cool.

A

B

All right this and then let's take a look at uh sorry, the out of here corporate garbage, uh I, guess: uh I! Guess we're gonna start put. We don't have anything in here. That's important I! Guess we gotta start for the auto instrumentation open PR's in this template too. Don't we foreign.

A

Yeah we should um and I don't think we're getting notified in the slack Channel about those either.

B

Okay, let's see if we can fix that, while we're, while we're here.

B

Let me open pull requests for that. You said um no we're not getting notified in our slide channel, for that would say Okay. So let's see go into slack and change. This um subscribe.

B

B

All right so now you will be. According to this, we will be notified for issues those commits releases and deployments all right. Thank you all right. uh What open box.

A

B

We have uh php82 support right, looks like you had talked about this one.

A

It's just yeah I just wanted to get in early, because I know when I had to work on protobuf 381. It just took a really long time.

A

All the PRS are in I'm just waiting for someone to notice me. Oh yeah, it's a bit like that. Actually, oh, is that what we did last time did you have a Google contact.

B

I do I can reject them.

A

Yeah, that would be great, just poke someone because, like I just took it I, don't know how it works. I just took a guess, but.

B

B

That's this is all yes, I will I'm going to do that right now before I forget, because I will forget.

B

All right, I have asked.

B

Okay, um oh bugs is that's not a bug, but it's an open thing, so maybe we should take a look. uh Maybe one of the things we should do today is take a look at the issues backlog, but I will leave the agenda open for other agenda topics if other people have things that they would like to discuss. Besides, uh we also should probably talk about the Beta release today.

A

B

So let's go here, this was uh I think this is the only required for beta tag. Tobias. You had DM me about this and I um and I just wanted to get your opinion on it. Before we did anything, were you able to see this.

A

um That's pretty much what I had in mind just to move to automatic taking of 38 minority attack. Temp I, don't think we can automate this in any way, because we have to decide what's a break and what's not a breaking change. So yeah.

A

Pretty much what what.

A

uh Yeah I seems reasonable um yeah. We, where we need to take it offline and just document how we, how we think it should work well and prove that it works as well. um I'm, not sure if it gets split replaces things you know. Is it destructive because the the the the mirrors are meant to be read only so money's just playing around with that, so that we don't blow away all of our tags in the um the um in the splits.

A

um Yeah I think we'll just need to. We need to experiment with it.

B

I made a thread in the hotel that we can talk through that in an offline, because we don't need to talk about that right now. Right, yeah,.

A

Oh all, right, probably beta, might be a good time to test that out. um I wouldn't want to be discovering the Kinks in it. um You know once we've done an actual release anyway,.

B

Okay, um do y'all have any other agenda topics you want to talk about before we take a look at the backlog.

B

I, don't know what's going twice all right, uh oh so this one was part of the maintainers asked for a standard user agent string to be emitted from the otlp exporters. Oh Brad looks like you have this as a you. Have a yeah I got it okay under control, that's good!

B

All right! uh Doc's! On opentree.io! You have a little bit better documentation here, but we're gonna wait for the beta. For this. We should probably have like a post beta label too.

B

I guess that's required for GA would be the label for that right.

B

Let's make that a yeah.

A

An EGA one.

B

All right documentation for instrumentation interface looks like Amber's taking this.

B

B

Success responses for otlp export services.

A

Like I think, that's it's actually probably noticeable. Now, if not go, if not. Now, then, certainly with um with my my PR- that's ready for review but I think Tobias has pretty much take care of that one already.

B

Okay, so should we close it at this, we gotta wait for that.

A

Otherwise, uh it'll all don't close when.

B

All right! Well, that's good enough! For me: um let's see Hotel resource attributes.

B

It's like thank you, it's working on this, but and thank you for pinning this breath. That was good, read news. Those are all um documentation, and this is this is probably I'm going to put these as good. First issues.

B

A

Yeah yeah, they probably are.

B

Said I want to say myself.

B

That's just a matter of meta ticket for this other words.

B

Instrument uh instrument, issue template for instrumentation request ideas; that's oh! That's for the contrib repo. um That seems pretty easy. I'll. Do this I'm just going to take you all off the um okay I'll do that this week.

B

Let's see open census and open tracing shims Dev track Baseline.

A

I I'm not sure if the importance of those yeah are they required and what do they mean.

B

I think that the the fundamental thing that they want here is their ones. They want um the the maintainers that we were an easy transition from open census or open tracing to open telemetry.

B

So what I have like a sort of shim that you can use with open, Telemetry PHP that will, uh you know, take in the record like taking on the open census or open tracing?

B

um That's the word I'm looking for depending I guess, like sort of like a dependency injection but like they want to make sure that it's easy, but you can always use the collector if you need to. So it's not like to me. This isn't super duper important, but.

A

B

Eventually, it might be somebody you might really want this someday, but not right. Now: okay, depth track.

A

Mod I I spent a couple of hours looking at that and I think it probably is a bug in depth track awesome.

B

A

That's uh cost but internal annotation.

A

Across if I remember correctly, the only one is the look.

A

This is something like in the SDK, depending on the API, without the spin, depending on my recording Spin and not recording spin as an internal application. If we drop the internal annotation, this should be reserved I, think.

A

Is currently annotated with internal, which makes it not available to the SDK or anything outside of the exact namespace think that trick text exact namespace for the internal annotations.

A

And that's interesting.

A

Okay, I certainly didn't didn't get that from any of the output uh from Death track, but it sounds plausible.

B

Yeah: here's the this is the Baseline yellow for it, but.

A

uh All right, well, I'll, I'll, take another look. I just says it works.

A

B

So that so I guess we could say that, should this should be simple.

A

Maybe I'd still be tempted to submit a bug report on depth track, just because that seems very non-obvious.

B

B

Refractor otel SDK extension.php, refractor configuration.php.

B

Configuration is like better information about that. It's like you, must understand himself but see if we hear from him about it.

B

B

Refactor span context group tests.

B

Integration.Us pressure, small contents, it's like Amber has us assigned to him. It looks like it might be completed.

B

B

Still, don't even try all right, so we just have one more move. Integration tests out of unit test thing here.

B

Like you're talking to somebody about.

A

This yeah I think the option was: is there are probably still some in there, but it's not it's not as dire as it was I yeah I suggest we probably can't just close it.

B

Okay should I say: we've decided to close this because it's good enough for government work because we're sick of looking.

A

B

Done Zapped all right.

B

um Excited us examples: we should have somebody from ABS. Do that read a symphony debug one dog. Basically,.

B

Okay, let's search the first page, then we'll do the second one. Aws examples are broken. uh Okay looks like we could close this one and redo it, but it's been a very long time, so we're just gonna leave it as it is, um create a symphony. Debug bundle.

A

I yeah, so I I think that he's taken care of by a merger's request. But the author of The merch request.

B

Oh, that's right.

B

I did an idea about this.

A

A

Second country, could we just merge it.

B

Let's see if there's that.

A

B

Certainly for instrumentation bundle, so this was actually being worked on and closed. Oh you close this. That's fine, I. Remember him saying that there's an Elena Elena, yeah I have everything except time.

B

uh I, don't know why he well he closed this, but we should probably still.

A

It got close to being stale, so we can reopen it, pin it if, um if you'd like yeah.

B

That's the label depend.

B

Or did I just I can't remember dad right, pin.

A

uh Yeah I think we do. We probably just never used that tag in this repo before.

B

uh Let's see I'll make sure they do this the right way, but it's really hard to find one. So it's still about.

A

I think we could configure it and I chose pinned.

B

A

No just the tag and on the on the issue.

B

A

Yeah or label yep.

B

Earth, oh because.

A

Yeah, you just have to create it because it's um pinned the p-I-n-e-d. Oh.

B

Unbelievable all.

A

A

uh Let's see this one.

B

B

I think, that's all that's all the first page I should go into the same page.

B

All right, that's the kitty button, though I'm just gonna open them up with it probably easier.

B

All right make configuration handling better maintainable and reduce technical that that's pinned to title same thing. A cak button will only offers configuration of trees, components through the SDK. It should be the same automatic component. Good metrics label need one.

B

No, it's different make sure environment variables be referenced in the configuration as intended. It's not fully tested yet.

B

B

We marked it as a good first issue, so hopefully someone will pick it up. uh This is assigned to title um Amber's working on this one.

B

Thank you for getting this one that was working on this one safety trick on this one. This one is aside to you and to my Brett.

A

So I do I, do have an idea. This is the next thing I'm gonna tackle and make the last thing that I'll do before beta, but um I was just reading through how some of the other seeks have tackled it and I think we were trying to do more than anyone else's stuff. So um I'm thinking, it'll, just I'll go look again at what the other Sixers don't, but um Java I think it's ticked this off just with an SDK Builder and called it done um so. I might okay, I might copy name.

B

Yeah, the Java is the best, probably the best to copy the ones that are that have the most research that have the most resources under the furthest along, so they're, probably good practice to follow. Yes, all right, but I think that's all of the open issues. Congratulations on the back of all grooming. Everyone.

B

Required for beta, so the only things that we need for required for beta are that and uh we're talking through that other issue. In slack, the separate yep.

B

Package so, okay, that's all the agenda topics that I had does anybody else have anything about to add.

A

uh Did we want to talk about Auto instrumentation uh pressure Mark? Have you got anything that you wanted to bring along today.

B

No uh I don't have.

A

Nothing new from my side, so probably I will have something to discuss some next meeting because currently I'm working on this on preparing these hooks. As we discussed uh last meeting for this demo, service I will have result of this work. Probably next week. Oh that's.

B

A

Okay, yeah and um remember that Tobias has a um measure question for requesting um that will help whatever instrumentation as well so I think once we get that done.

A

um I'm, not sure if this has to happen before beta in terms out some instrumentations.

B

Yeah I think we'd decide that that's right but GSM, but it's still super important. So uh whenever we're not gonna block you, but whenever it's ready we're happy to review it and make it go.

A

B

Okay, well then, if that's it I guess, we can adjourn for today thanks everyone.

A

Thank you good meeting, thanks for coming, everyone hi.