Open Telemetry Uncategorized, 31 Jan 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2023-01-31 meeting

Description

Instrumentation: Messaging

A

A

B

A

So, as if I see see your update uh on the sandbox um is, do you mean the the pr that you have open still needs more work, or is that something else.

C

um Yeah so, although all the extra commented out um packages so effective, I'm, actually locally uncommenting, those and running them and I haven't quite got all the tests uh working um so I'd like to do that before I pushed it in um because once I get the once I add the CI task. It's just going to start spilling over well. I could split it like if you're happy with. What's there I haven't tried it with just the API to make sure I haven't broken the API tests.

C

But if that works, we can push that in and we start the process. But until the sandbox has more packages, there's no real sense in creating branches. Yet because it's the full set of branches that we want to like, go off and start printing branches for.

C

That make sense.

A

So so the tests that you need to write is for the for the change for the pr that you have open right now.

C

um So the tests aren't for the pr the tests are, the script automatically add um worker tests to everything.

A

C

And some of the packages as I as I'm doing them, those tests don't pass um like there's a couple where I have to explicitly disable node tests now, as which is a new plague, that I added um so really I'm, trying to have the full set of web packages that we want to import and get the script to a point where we can just uncomment them all, and it would just say, but that would just all work.

C

That's ideally where I'd like to be, because until I get until we get to that point, creating a branch to go, start minification or start doing anything else, because I want other people to create. Other branches is less useful um because really I want that SDK web, at least to say how? How big is that bundle which I can calculate the bundle? But so not all the tests are working.

C

um I haven't even addressed the examples. Yet I was going to do that with a pull-up one, um because I want bundle sizes for those examples and actually usage, because that's going to be more meaningful than just the SDK okay there's more work to do. We can't do it in bits so um that way, it's minor updates to the to the script. That's there.

A

Okay, so so regarding the current PR, um it's so large that I've honestly had trouble like reviewing it. Yeah um I tried running it locally and I'm still yeah.

C

A

After your change, I'm still having issues um so I'm I guess I could you could continue like if you could help me and like get it running locally and I can continue? You know, testing it locally, but I can also, uh you know just say: okay, I trust that it's that it's working on your you know from your side, um and maybe we can just uh I, don't know like if you merge it now like and and run it like, is, are those what it does. Is that reversible like?

A

Could we um or does the script need to? um You know work perfectly because it's like.

C

Oh, it's is it reversible, reversible in, in the sense that removing what it does? No, because it ends up in in GitHub history, um updating the script so that it can fix any issues uh yeah we can do that, which is what I had to do. The previous script I had to like it wasn't until after I started, merging merging in the country group, where I had a bunch of additional issues that I didn't expect. So I then had to modify the previous script to say once it moved everything.

C

It then did a file compare between what it expected and what was there and if it was different it just manually copied over the top.

B

C

So we can do that. The downside of that is. We would lose history for that particular thing, because it becomes a complete blast copy over the top, but as long as the file's still the same, the previous history would be there um in the in the case of the previous one.

C

Part of the problem was the way, the contrab repo and and get figured out the file, and it was actually moving JS files into country and Country files into JS. So we actually completely lost history because it got confused because the files were the same.

C

um There's no easy way around that one um so yeah we could push it in. We could get the API going. We can get the CI going for for API and then do just do minor updates as needed um as we bring in more packages which hopefully would be follow-up once we activate the CI job um the script. The way it's working is Rush will just automatically add the new package directly to the CI pipeline, so, uh which is why I've been trying to automate it so that it just comes online and just starts working.

C

As we add packages.

A

Okay, so we could, we could merge it now and just have it working for the API and then lay, but at the other repos later yep.

C

Yep, so what I'll do then is I'll, run a local test with the API and make sure that the build and the test works, I think the build Works make sure the test pipeline works, and that does and you're happy with that. We can push that in and start that process, because I haven't quite yet done the full okay. Now, let's update the the the merge repo, the merge branch and then merge that merge Branch into into API, that's the next step, and we can only really do that once it's there.

A

C

But yeah as I've got my update. I've I I have a bunch of planning and releases to do this week, so my time is now well. It'll probably be like Friday before I can start spending a decent amount of time, but I can I can run it in the background for the just checking the build.

A

Okay, okay sounds good, so I'll I will wait until then, but I think that I'll I'll give it like one more look and I think I'll be okay with merging it. Yep.

C

Okay, yeah I'll I'll ping. You once I've validated that uh on slacker.

A

Okay, um if, if we had don't have any other topics, would you would you be okay, uh just looking at the command that I have and see like if I'm running it correctly, yep um yeah? Let me share my screen.

A

A

So this is the command that I'm running yep.

C

No prior origin, user review, yep.

A

Okay and I am so I do have your your I think everything yep.

B

A

So if I run around that, I still I'm still getting an error here, so it does something.

C

Okay, so it's cloning, the main where you put the main branch, which is what so all the auto merge temp, is end up being main. So just cloning Main.

C

I guess the other issue I run on Windows, where you're running on a Mac, so you could have issues there too. Oh, why is it asking for your username yeah.

A

So now it's it's! It's asking me for my for that.

A

A

And then it does, does this.

C

uh Report sure not found, oh, it hasn't put your username in there. It says github.com yeah.

A

C

Okay, so that means the origin user didn't get passed down; um okay, let's hack up both of these. For you. um If you load up the script.

C

uh And if you go to Hollywood yeah.

A

C

In sandbox tools.

C

uh When I put it, it was in uh GitHub I think.

C

Yeah and then the github.ts, in fact, I think it needs to be both of these I think this one gets partner gets passed down the override user scroll down a little bit.

C

uh One give him a fork uh record Fork. No, oh then I'll put it in.

B

Where did I put.

C

Us uh you know there was a get user function, I'm going to get user function. We want to find um under git. It should be user.ts, not the git folder.

A

C

The git folder this one yeah and that should be yeah user details.

C

Okay, yeah scroll down so where it says name and line 72.

C

um Just hard code, your user ID there, and likewise in user head code in both of them there, because yeah name will come out as a Martin space, um and that was the problem so effectively the way this sort of gets around. That is that, if you already have a fork lines, 59 to 68.

C

effectively look up the remotes for the current four um yeah put it also in um line 74 as well, just to hard code that.

C

Looks like it'll load, the override users should be doing it, but yes, it's just hot good. For now and.

B

C

Yeah I should do it. So if you're on the script again request, your white prompted you probably because I couldn't find your usernames. Therefore I'd ask the username, but that might get happy, but not the script. So the script was still creating uh the URLs, based on the nothing that it had.

A

B

A

Still asking me.

C

Okay, let me uh luckily.

A

Response now, let's, let's put again in there so now it's it's there, yeah.

C

No, it's got up there, um but it failed Authentication.

A

C

Okay, so this is where git doesn't think the current user that you're playing with um has access to your repo.

C

C

Okay, so you've got my branch.

C

I, don't know it's just yeah get saying no go away. um You could probably also fix this. You currently haven't got a haven't, got a talk of the sandbox over you.

A

C

That would be the other way to do this if you go up and manually, so the script is supposed to create the fork for you, which is how I got it to create the the open Telemetry box for, um but if you've forked it. That should also fix the problem.

A

I think I do check.

A

I do actually okay.

C

um Okay and it's your clock that you have locally or did you just grab my PR.

A

uh Just your PR.

C

Oud, okay! So if you cloned your fork uh and then so as part of cloning, you should have access to my branch in there, my PR, and if you then check out that that should work uh actually go back to your folder and go get remote list.

B

uh Expressionist.

C

Was it whisper I, don't remember the command.

A

um There's only one and I think it's the yeah.

C

Yeah, so you just don't origin yeah. So if you know um yeah so you've closed the open, Telemetry one directly yeah. So if you calling your fork, that should make the thing happy, because when the script does here, it will actually say uh you're, one, not.

A

Okay yeah, so so, when I, when I run this successfully like it's, is it gonna just copy files locally to some folder.

C

um Yeah, so you saw it already started to in your Dev slash uh dot, Auto, merge, temp, so I think it creates a clone. So it should be back one level uh because test is on by default. Currently.

A

So it's going to be upload one level from this correct.

C

A

C

I did that to make vs code happy because vs code kept locking it if it wasn't up one level um so yeah it, so it creates a DOT uh Auto Dash merge folder one level up uh in there. It creates temp, which you should already have, because it it already cloned that one um once it clones that one it'll then go and create a temp Dash merge at the same level.

C

um I'll probably just start to the dot and you're running in the mixer Factory. That's yeah, okay, yep there. It is um so yeah, so sorry to grab the champ it will. The second step is to create a temp merge, which is actually a clone of the merge uh branch that then munges the merge branch and then does it get merge from that uh temp merge into temp, and then it creates its PR from that effectively.

A

Okay, okay, so I'll trade with the fork and my fork and see where I can go.

C

Yeah, it seems to be getting lost in the in that second stage of saying: okay now I'm gonna go is it actually creates I, think a clone of the book or it figures out if you've got the hawk and if you don't have anything I, don't remember the exact details um but yeah. If you do it from the book, then that should work.

A

A

B

A

Me get that a try and apologize. It's not still not working yeah.

C

Yeah, because if you look in the uh the action so in the dot GitHub, so apart from it effectively, it's just running GitHub, so it has access to the GitHub CLI. It forcefully sets the user to the open, Telemetry bot using the credentials that are in there, so that I guess potentially would be the other way to do it. Except it's no wonder authentication here so um yeah do it from before. That'll just make that change, because you'll then have full authentication of that Branch already.

A

A

I'll give it a try yep.

A

um I, don't have anything else for today, um foreign.

C

C

um So yeah I I, don't have anything else, but my update says it all into like I hit some issues that I had to deal with in the last week, which stopped work on the thing and then now I'm yeah planning in releasing Cycles this week.

A

Yeah I also have limited time so yeah.

A

B

C

A

Good these two or Carly, do you have anything that you wanted to talk about.

B

I'm good, thank you same.

A

Okay, great uh well I'll talk to you tomorrow, then yep.

C