Open Telemetry Uncategorized, 24 Jan 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2023-01-24 meeting

Description

Instrumentation: Messaging

A

Good morning of.

B

C

Let's see Santos said it's going to be 10 minutes late.

A

D

B

There's my window.

E

Hey guys good morning.

A

A

A

A

I think I have only one thing um for this week really, uh which is I separated I, have a PR open for separating the events API from the logs API, yep and I. Think it's good to go, but I think I need one more approval before it can get emerged.

A

um Maybe enough, if you don't mind, taking a look at it, yeah.

C

I saw it late last night, but I was sort of madly trying to get the sandbox into a shaper being displayable, so yeah I should well I'm not being in a proverb that should be good. So.

A

It's pretty straightforward, I mean there's not.

A

um Yeah very straightforward.

A

And then, once um once that's done, then I can help. There's the log SDK APR that was has was open last week as well, um and I can help that person with that.

D

We're typing a new folder you're gonna go quick I'm, not going to read all the reviews and stuff.

A

Ram ram, do you have anything else or anybody else talk about? If not, we could maybe look at the sandbox or talk about sandbox yeah.

A

So I could definitely use a walkthrough that uh not because I I did look at it. Look at your PR but I. There is so much it's kind of hard for me to follow and I'm not sure how to how to test it. So yeah.

D

um If I can present my.

B

Small screen here there's the key to Here, We Go and show I, don't think I've actually presented on that Zoom before.

B

Okay is which could be a number um Can people. Oh, let me hit the share button. First,.

B

People see the screen or is it I can see yeah.

C

It's on teams, because I'm doing that through my remote desktop, it ends up being black.

B

F

A

Okay, all I can all I can see, is a picture of.

D

At the moment, yeah and I've got like five screens, so that's my smallest one, every other screen's a wide screen or 4K one yeah. uh Let me get.

B

uh Yeah, let's put the script up here.

C

Okay, so I'm still doing work on it and testing stuff, um but effectively this uh structure. uh Let's uh the sandbox tools structure, uh this script here, the sync reposes is the one that already syncs the main ones and creates the auto merge branch.

C

um This is the one that's doing all the work and effectively the whole script starts at the bottom.

C

um So in fact, it Loops through some config that effectively grabs a copy of the repo I'll I'll, go into more detail, I'm, just giving a quick overview of the whole thing here. um This user is because it's set up to run as the open, Telemetry bot uh locally. It's it's running as me.

C

um It creates a couple of uh working folders which calls this merge thing here. um This creates a copy of the staging repo. It doesn't like having more than one PR, because it creates a PR at the end of this.

C

um It then Loops through. So this is the main thing that this is really getting a copy of the existing um they're going, the existing merge repo. So it's the auto, merge staging and then it starts munching it together to move things around.

C

um It then goes on to effectively so once it's munged the the staging repo into the structure that it's after so it then gets a copy of uh what I call the master. But it's a copy of Main has a remote set up for staging and then effectively adjusts mergers that this here effectively is just doing a git merge equivalent of the decal of that one. So I use Simple get so this effective becomes. You know, git merge, no commitment with all these arguments from this branch.

C

Those old conflicts always resolves in the favor of where it's coming from, um and then this goes and does some package updates um and then sort them to make more nice, because this is using Rush.

C

um But then courses rush to be added uh and then update to the shrink wrap file, which is neither for synchronizing, and then this doesn't commit um if we go back to the staging one, which is a little bit more complicated.

A

So this uh merge so that that part would be run when that would be around okay in a workflow GitHub workflow, when we.

F

B

Yeah bring up the existing one, I mean yes, I'm, just getting a window already.

C

C

So this is the existing one. So, in this workflow is today this Auto stage merging um so under actions. I can effectively do this and this will effectively create a PR. So this is the one that merges the JS and contrib repos into the auto, merge folder um and we can see I've already got the it creates this PR, uh which is sitting here waiting. They ran this on the 7th of December I'm deliberately holding this off, because I want to run this other one for multiple times.

C

um So it's part of the PR that I've got back.

B

In can I quickly see it or not,.

C

It creates this new one here, so this will create a new action called what I merge um into Main and effectively. It just runs this script here. All this other stuff is is setting up the open, Telemetry button, where the secret story in GitHub does that answer that question yeah.

A

C

um At the moment, I'm running that npm run manually locally um to effectively test all this. So if you look in here, this is the the big thing. So this effectively gets a copy of the branch um checks it out make sure it's at whatever the starting point is which by default is head, but I've got this so I can actually um check out different starting points.

C

uh It then goes on to do all this stuff, so this process uh merged. So this folders to merge is that it the thing in the config. So this is the table that if I can shrink this a little bit goes through and says you know: grab the Auto, merge, JS API and drop it into packages API.

C

um It expects it to be open, Telemetry, API, um that's just so that I know my script is working once it finishes merging this becomes open, Telemetry, slash, sandbox API, um because this users roll up it automatically then goes and adds pre-bundling. So it says: okay, the bundle file name will be, in this case, open Telemetry, sandbox, api.js and its namespace will be now this, uh the one the pr I've got at the moment.

C

There's only this one and that's the one I will check in by default, but I am attempting to get the entire thing going. uh All these here, including async hooks I, have I, have building and generating bundles, um then I'm just trying to get the tests going at the moment. The the test for instrumentation are currently failing.

A

C

Yeah but effectively like it, it moves them. um This is the check package name. This is the code that actually just does the git move. um It's a little bit more complex, but it's basically just a git move.

C

um uh Movie package redirect. So it goes through individual files, because I found in uh in the previous one if I didn't move individual files, the end of the complex, uh so this move folder is the move folder that that is also used by the staging one that moves out of contrib and JS into the merge uh folder.

C

That's just that we're using the existing one.

C

So we move it yeah. Sorry.

A

Like I'm, just like so just like stepping back a little bit uh so like there's, there's like it's like a two-step process like when, so you have the packages folder what it will end up eventually, but you have the merge folder, that's temporary yep.

B

Yeah, let me show you my test: folder: let's bring that over.

C

Here so so this is the um this is my auto merge uh test location, so temp is the master temp staging is the staging one so effectively. What we're talking about here, if the staging is a grabs. This, which really just has these Auto, merge, contrib and JS. So this is a complete copy of uh contraband.js um and then it doesn't get move to move the things into the package, so you can see packages API.

C

This is the entire packages API folder, with all the extra bits um added by default, um so I like I, move things around so, instead of being open to learn to create instrumentation, open, Telemetry context, Zone and open Telemetry context, Zone, hey, hey, drop them into a nicer folder, which is what I did the first time around.

C

um So like property, Gators you've got here, uh SDK we've got trades and based, instead of it just helps shorten the name. The only one I'm not completely comfortable with is the instrumentation. This is coming from the concrete repo where this is the base instrumentation package and then at the moment, I'm putting the web-based ones in here so yeah so effectively it comes comes along.

C

um It's a clone of the staging moves. Things around then goes gets a clone of main, which is what this was uh and then does it get merge from the staging the temp and then comes along and starts adding the the extra bits needed.

C

So at the end of the day it you know, like the auto merge. Folder comes in here into main, because it's doing a git merge. Originally I was trying not to to try and minimize the um git merge clashes that can occur, but it was more complicated because, in my staging, I was deleting auto mode, which then caused more issues. I went.

D

Fine main will just have it.

C

So that's yeah, so there is yeah so that moves the packages. So this is this is just a simple ball. Loop effectively, you know just cause the thing, so it just goes through the less processing each package.

C

Checking that the package name is what expected moved it: the transform packages. This is the thing that goes through and says, add sandbox on the front of every package name. So as long as it doesn't already have open, Telemetry sandbox it's here, that's now open until Elementary sandbox.

C

um This goes and updates the uh okay I have a couple of different things. Around package, Jason I want to move things around a little bit, um so this loads, the package Json into memory, grabs all the bits and pieces and stuffs it into this package base object that I've got that I reference, because I need to do that later um goes and updates all the config relative paths and that's because I move things around, so it updates all the TS config references uh removes all of the references.

C

This is really slowing things down and caused a problem, except for any TS config references and updates the karma references, and that's really because they're they've been really relocated, uh then goes and creates the rollout packages so that every everything gets bundled by default.

C

um This stuff doesn't currently exist. uh It does exist checks because the script will run on top of something that's already been merged.

A

um uh When you say it create the creates a lot of packages, it's like part of the merging.

C

um Yes yeah, so so it creates um all the roll-up configurations. So I've got another uh one here. So let's get this up here, so this is effectively the temp folder.

C

um So if we look at API, for example, we end up with this roll-up config, which says: okay go and reference. These I've already checked the base ones in so this is the relative path to the root. It's already checked into Main um these effectively get Rewritten and come from those variables in the package and then the end result is under build. We have a bundle folder and we have all of the different formats here so um where the name comes in is really in this one here.

C

So we've got uh over here we end up with global, so it'd be window.open, Telemetry, dot, sandbox.web API. If you happen to load this particular script directly from the CDN um as opposed to Common JS doesn't have a namespace.

C

uh It is just here. uh I. Think AMD is similar.

C

But this one also doesn't use the namespace, so the namespace is a little limited, but it's there but yeah. So everything ends up having a bundle by default as part of just getting merged. So if we look at the SDK web, for example, we can see here. I've already got a bundle with them all.

D

A

Sorry, it's like I'm just going to start for a second like I, just trying to understand like so the you know like the are we are we like settling on roll up or all right, I thought, maybe that we would experiment with different uh minifications uh and then like this. This script would just like uh merge, merge like the the official SDK with this code, but then it would have freedom to to do to experiment with different uh type of modifications. Yeah.

C

So Roll Up is just a packager. It's like webpack, okay, so really all it does is just generate Global files uh at the moment, I I'm using LG, if I to minimize it. So you can see the the trace web is 154 um and then the minified is 58k.

C

Okay, so you know that's without any of the extra stuff. So I haven't hit the examples, yet um that will be something that I have to hit, but yeah I I wanted a baseline um in my previous efforts. Last year, I found I could create smaller bundles with roll-up than I could with webpack. So all the tests still run with webpack I'm, not rewriting the test to change to use roll up, although that would be a lot nicer.

C

um I did try that originally ages ago and if the web worker ones were being a little bit problematic, um but yeah like for by default. For me, it will have this uh in terms of branches yeah. We can go and do whatever we want, um because remember. Maine is really just how we get everything into this repo.

C

So it comes through the auto merge from Auto merge. It then hits Main and then we'll have branches so that you can effectively you've got a baseline to keep bringing in the main code um so effectively. You merge main into one of your branches um and then the idea is because this is doing this or the staff up front. uh You know in terms of creating roll-up in your branch, if you go and remove it or change it, that should be happening after main.

C

So therefore, your merge should take precedence and you know do whatever you have so, but it was really the case of getting that Baseline so that we know where the bundle sizes are. Okay,.

A

C

uh I restructured the formats. If you know that's in my other project, I would structured the format. So everything else in build is still the same.

B

Okay- let's go back to here.

C

So yeah, so this is the creating of the roll up. So this is pick the roll-up definition that you saw the file that gets created.

C

So it creates roll ups um unless I had to add this flag, because some of the stuff doesn't have tests and when I try to automatically add tests, it just didn't work, so I've got a flag saying: don't even try and add tests, so the comma one. This attempts to effectively add tests to the browser and for a web worker by default and again, we've got the the base files living up here.

C

Unfortunately, there is differences between different packages in the core, repo and concrete. um So there's going to be some fiddling we're gonna have to do after we do the merge, but once we get that that should be fine. There are three compile errors that I I'm already hitting, which you have to fix before I can compile, but yeah this effectively just adds. You know the browser. The webpack um I also added the debug one, so you can actually debug in the browser directly um whether it's a worker or not.

C

um So that's really what that one does this one is all the tests, so this goes through and effectively. If it doesn't already have an index webpack uh or an index webpack worker, it adds them again. I had to add this flag because there's a couple there, which they just don't run in a worker right now, so we need to fix it.

C

um I haven't yet come across one where I need to flesh this out. So that's why I've got it as a to-do. So this is a case of it already has an index.ts, but doesn't yet have a worker, um so I'm going to defer that a little bit later so, but this is really just again creating files and then adding them. You could add.

B

C

um Okay uh and then it goes around and moves scripts. Oh I can move folders, so it moves the scripts folder. So I'm saying the JS scripts folder is the master, um so it moves that to the the root location. It then updates scripts. There's a couple of things that have to be done.

C

um The version update script really has process Exit Zero. On the end. It's um you can get rid of a whole bunch of the the pre-compiled stuff which I do so that's really what this is doing is effectively adding processing to the end of the version script so that they extra tasks of you know, pre-compile just go away and it just always calls version.

C

um It then goes around and moves some additional files.

C

So this is these files here. So again, these are root level files, so it takes uses JS as the master, uh all the base files and just drops them into the root folder. That's all that's doing.

C

F

B

Moves but I miss thinks which I think that was it no wrong. One.

A

So the atom merge folder, that's basically a copy of all the contains, always a copy of the official repost.

B

With all the history, so if I go back and.

A

Then there is a separate step like where we kind of copy this over to the root folder, where which is like the working like sandbox right, yep,.

C

Yeah, so the script we've had for a while uh effectively creates this um Branch. So in this branch is really just perfectly. This is the entire country repo, uh and this is the entire JS report. The only reason this exists is so we've got the complete history of everything, so you know so.

C

uh But that was a bad example.

B

Why everybody got.

A

So this Auto merge folder only exists in in the auto, merge, Branch, correct.

C

Yeah, uh which is what that what the staging script does so this existing action- that's already here uh this one here, that's all it does. Is it just creates the auto merge branch.

A

So uh I mean maybe maybe a dumb question, but uh like just my lack of understanding, so uh why? Why is isn't it? Why do we create the auto, merge folder? Why? Why couldn't It Go like directly into the main, because because of the mapping of the folders or.

C

um Because of all the merge cool things that end up occurring, okay, um it's yeah uh like every time it it affected. If we look at the history of this folder.

B

C

Back to here, um I think he's got all the commits so every time, uh not okay, so every time it does this merge. We end up with this. um You see this here. It's emerging, JS, merging, contrib and then picking up merge issues uh which occur because um we have the same files that were in both of these. So this comes along and um effectively make sure that the the original root Source ones that an entire copy of the files there does lose history in that particular case. But it's there.

C

um You have to go through these three three steps every time, so it would be every merge that we have to do. We have to effect. Have these three commits trying to merge onto the previous set of commits, along with the merging of the dropping locations and adding files, um the merging, so the git merge becomes more complicated because now you're always merging five separate commits with older code.

C

So it's reached just to try and reduce it down and have that git merge, at least from an automated perspective, to say, I'm merging one thing and just go for it.

C

um This one got quite complicated and that's only for the history I. If we go back to the pull request, like the very first one I had down here. This initial creation was the complete manual copy, um which had a script in there to effectively do the manual copying. So, in fact, everything we're doing now with history was here in.

B

B

B

You don't want to collapse. Okay, let's go lie down.

C

um I had this this script here, um originally I did it in straight JavaScript, so I had to like test it all I'm, not doing it in typescript, so it gets compiled before we run it, because this thing was pretty much just as huge and is doing a lot of the stuff that I'm doing now, adding dependencies and I'm actually doing a little bit more now than I did then, because I could manually create the roll-up base in these ones. I didn't have to automatically create them so yeah. So that's why the merge exists.

C

It is just for history and then this extra step is really just coming along and putting it into our final stages, so that we've got a baseline to play with.

F

C

um Okay, so this effectively emerges files. This comes along and then it says: okay, now, let's merge those folders and update all their package references um so effectively. It goes through and updates all the dev dependencies and real dependencies so that, rather than the dependency saying, I want open, Telemetry, API version, you know anything greater than one.

C

um The way Rush works is, if you have the same version in the same repo, it will effectively Create a Sim link. So this is actually because what this is just a Sandbox. This goes through and actually updates those Sim links. So it says I, don't care if you wanted anything version, one we're going to link it directly with what the version is in this repo, um as well as there's a whole bunch of uh dependencies that we want particular versions of which yeah this also rewrites, the the sandbox uh on each section.

C

I have a list of there. We go here a list of packages that says Okay I want at least these packages. So of course, at least these versions, um you know, add the missing ones. This is so that, like the tests and I can go and add, you know all the tests. These are all the build um Cycles. So this is the the stuff that the scripts are about to do.

C

So yeah go back one here.

C

So this goes through the the pencils and the dev dependencies adds. The missing ones adds the common ones that are expected if they're not there and then just Source them for nothing.

A

So it's like every time. Every time you do this merge, like it recreates the package Json.

C

Correct so recreates the package Jason before it creates the pr so that um one of the reasons for sorting it is to minimize any merge complex because it should be able to say oh you've added a new one in the middle rather than you've completely reordered everything. So that's why I sort everything.

A

C

um Sorry, if it changed it, just rewrite the stack of Json, which is pretty much normally always does.

C

um This is the one that goes through every file and updates the package references this one uh file and sync file yeah. So this this actually goes through every TS file and anything that says: import, open, Telemetry, slash whatever. There's input open, Telemetry, sandbox, no, just again the transform packages to do that so effectively loads, the entire content. This is just a regex which replaces everything and then the change of refracted.

C

uh Then commits it so really that's.

C

Pretty much the entire step, but it's it's convoluted.

A

It's a lot I'm, not sure how how I can validate it.

C

um Yeah I know: is there a.

A

Way for me to test it or.

C

um Yeah, if you grab it locally um so like I've, got my.

C

So this is my little uh test environment so effectively. In fact, let's just do it. Let's.

B

Get rid of that? Let's go there. There's my.

C

Let's delete this.

C

It doesn't actually take too long uh where we yeah so like in 10 minutes we'll have this done.

B

C

B

Need to go close.

C

That vs code for my temp otherwise just delete.

A

Is it really two gigabytes of files.

C

Yeah because I've done the npm install, so that's all there. Okay.

A

C

And this is both three points as well. So, but it's mainly in that temp one because that's when I've done the npm and so on.

C

Okay, so now we've got nothing.

C

uh I'm going to factory run this with my little low PR, because I don't want to quite a PR for this, so the first bit it does is effectively just compile the script and then once it's compiled the script, it's now running there things. This is cloning.

C

The um staging. This is cleaning main looking like, because it's saying temp.

C

Not including staging so if I get all this log ends up in the action run.

C

Some of this ends up also in the description of the PR, but, as you can see, there's just loads.

A

So if I run, if I clone this uh and.

D

A

And so, like I just run this script, the way you did and it will create the folders automatically.

C

Yeah by default I've enabled test mode, so it goes back that one directory level, which is why it's like this dot Auto merge. uh It's part of the action that actually does this in the main repo, but uh vs code wants to keep checking it, so it ends up um complaining and not letting me delete the fold line so in in test mode. It goes just back one level.

C

um This updating shrink wrappers if I can just running uh it's brush, update so effectively go and generate this recruit file. So this is where it's resolving all the the links and the versions.

B

If I come back to here, you can see, we've already got our two folders.

A

The temp staging that that's simulating the the merge, merge, uh folder yeah.

C

Correct so this was describes a copy, the merge, folder and then starts moving things around so that uh when it hits main it can do a fairly simple git merge, um which is why main ends up you know both of these should look the same at the end of the day, except main will still have the sandbox tool, so we'll still have all the extra stuff again. Okay, um so you can see. That's done.

C

um I then go into the temp folder, so I can actually type the temp and.

B

A

Sorry, like the 10th folder, it's the main.

C

It is the main one yeah yeah, so temp is what is coming uh main so effectively. It's part of the script. If you don't add that no PR on the end um like this thing here, it will actually create a PR using your username so effectively descriptor will or if you don't currently have a Sandbox branch. uh It works. You've gone credit for you, um as well as the the branch that that users four main to then push and create the pr out. So it does all that magic, so yeah.

C

So anyone can, you know effectively just run this command and then we'll do it for you.

E

Now can I uh introduce real, quick um I didn't want to enter the flow before and I. Think it'll be useful, at least for me, um is to kind of visually look at probably just open, notepad or something like this type out. uh What goes where main become stem and then the sandbox we can spend uh whatever is so map. We can map out exactly how it's it's going to work and.

C

Yeah, so one of the things I do want to finish, doing which I did for and I'm going to get the right.

B

Where's my window gone uh initial.

C

Correction, this one here um that I did for the main staging one.

B

Okay: okay, come on hello.

B

B

C

It looks like GitHub just have a free is in the here. I've got um this thing, so this is what the staging one does. I want to do, the same thing for the um for the script um but effectively it's it's grabbing. This merge, JS and then putting it into this package. So yeah I started doing it, but it's just not quite finished because I hadn't finished the script, um uh but really it becomes uh finished.

C

um One thing I do need to do before we compile the Technologies compiled first, um uh you can go, npm run, compile it effectively. Just calls Rush under the covers.

C

um So Ram, your question is really about where they end up. Landing.

E

um I think the overall flow um I sort of follow-up, but then uh a loose track pretty quickly when I look at the multiple folder maintenance stuff. So that's basically.

C

B

C

I I do want to move things around a little bit more, but okay I tried to simplify it and say that's what this is here.

C

um Let's say where it's coming from. So if you just anything in Auto, merge is the auto merge branch and then you've got JS and down here. We've got concrete, I think this one here is contribute yep um and then, where it ends up putting it into the final destination but yeah. It's.

C

Like even these structures here, which is the original JS repo they're, just painful, you can see, it was like we got packages Trace space, but then I start dragging in some experimental just to drop it into the right location uh for our sandbox.

A

So is it correct to say that basically you're picking out just the packages that are relevant to us correct.

C

Yeah, like originally I, had this I I. You know I I. This will completely compile and generate bundles, but the tests currently use async Cooks, which is known only so when it tries that to run browser and work a test. It fails. So at the moment, I've just commented that out um and where I was going with this one here.

C

So you can see this failed because of these typos um there's exactly three of them, which will have to fix locally once the code gets checked in and then contributing back then so many times now, I can find them all. So we've got no Zone contacts.

C

And they're all typing related. uh This was on 217., so this here just needs to be as any.

B

uh New tools here.

A

Why why is this? Why did this happen? Why do you have to fix this.

C

um Well, this is currently an older Branch as of november-ish last year, so it might be that it's actually already been fixed in in the main ones. um I, don't remember what the last one was about batch. That's it.

C

This one's interesting so effectively, this has a web a browser-based test, but because I'm running it as um um the worker effectively, visibility change doesn't exist in a worker.

B

I can't so it's full.

C

I can also say any, but um so they're the only three code changes that we need for the build to be complete.

C

um So Rush takes care of figuring out the order things. It looks at all the dependencies uh as part of the build you can see. It runs roll up and generates all the the bundles as it goes. So these are already happening.

C

um The ones of the check-in in the config you'll you'll need to uncomment. At the moment. The pr only has the API. If you wanted to do all of them.

A

So this is the second step right.

C

Yeah, so this effect is now Main, um it's part of so it's part of when I reactivate the or activate the the CI tests. This is what the CI test would do. It would actually do an npm, install um and then compile it and then run the tests.

A

And then create another PR or.

C

No, that was just a CR, so so I think the main you know main is is all Now set. The pr would have got created already. um That's part of this. The fact that I went no PR on the end. Here um is what stopped.

C

A

Me come back so like so like the floor. Is um there is some kind of script over like workflow that uh pulls down the files creates, creates a PR, uh creates a PR from like the auto merge to main yep. uh We review the pr.

A

We we merge it, and then this CI script runs.

C

Yeah, the QR script doesn't exist yet because I haven't created it. um So it's even as part of creating the pr the um the script will run so come back here too many screens come on there. We go so like this is the pr that I generated locally as part of the script, because I didn't say no PR.

C

um So you can see this is the content sort of highlights what I was doing um and then you've got everything got merged, um including the like. This is the main staging one that created the staging. So this is the one that actually moves everything around, and this is the one that actually merges it from staging into Main that there was only one file change, because I could read me that I had to do okay, yeah, um but as part of this PR, once we add into you, know the the CI dot yaml here.

C

Even the process of creating this PR will actually cause that to run at the moment. It doesn't exist because there is no code in uh in the repo So. The plan was get the script in run. This once for API then come back and effectively add that CI Target, so then all future runs uh will effectively be validated before you can even check in the pr.

C

uh As part of that, we need to go fix that little issue. um Okay, so you can see 10 3 minutes three seconds to effectively generate all those, um so everything now exists and.

A

C

Like everything now has a the bundle again um with the previously generated code, uh it also has test targets, so you can I normally use rash test, but it's just npm one test runs it so this is now running the test, which is running as long as defined the node, the browser and the web working tests or every Target. So this will fail. The instrumentation run yes, fails, but.

C

Which is also needs to be fixed because the CR test will be running this and it would be over so.

C

But yeah the nice thing about having bundles for everything effectively having browser tests for everything, because not all of these packages currently have browser-specific tests. That's why some of them are failing.

C

And work a test because we do need to get things working, you can see it failed. Okay, oh crap! What do I do now um as part of Rush?

C

uh What it does is that was the web one there's a credit log file, so you can see exactly what went wrong.

C

um I think that one looks like it worked. uh The error is really anything that went to error and loggers. Everything went out.

B

Which one failed.

C

Let's go instrumentation, so a couple of them failed it doesn't it only blocks dependencies. So um there was one of these that didn't work, but it still tries to build as much as I can so.

B

Instrumentation.

C

uh Okay, so it looks like it didn't like.

B

One of the patterns.

C

Okay, so it ran the browser tests, foreign.

C

Like these tests here, I just in fact this one doesn't have work at this. It only here's the browser ones, but this one was a test that was already banned. For some reason. It's failing!

C

So that's what I'm trying to fix it up, but that's effectively yeah if you want to grab a copy of the pr they're the steps to go through which I do want to document the other thing I'm thinking of doing, to try and help a little bit is in this script um like it's. A thousand lines of typescript, um like I, did with some of these other things where I broke them out into support.

C

Functions like I've got Rush on its own I've got roll up on its own there's quite a few in here that play with the package Jason, so I'm thinking of moving those out and effectively adding comments on everything and then creating that little Doodle to try and describe it yeah. It's part of the I do also document uh web.

B

Page tourism, this one yep.

C

um Like this also talks about all the steps that it does, do, that's not that one in the scripts.

C

Like as well as the picture, it goes through all the individual steps, so it really. This is just the merge one. I want to do the same one for now merging into Main.

C

So I would have liked to have been there already, but I'm. Not so that's where we are.

A

So what can I do to uh get this reviewed? Like can I if I just run the script, as you did, gonna verify that the right files are being pulled down. um That I. Can you know, install and run tests?

A

Is that good enough.

C

um Yeah you look over and make sure I'm not doing something that you don't like.

A

C

Other one would be the locations, um then I'm dropping these things into so uh these parts.

C

um So this is the one I'm I'm, not sure about the fact that we put the main instrumentation into instrumentation instrumentation and the ones in the web um is in this. The web sandbox, maybe I, just drop this into document load. The reason it's got web is currently in the Contra repo. It's called web and node, um so I, eventually plant well I'm, taking all the tests running I was going to go. Grab the next country web instrumentation over there they're called plugins.

C

um So that's another option.

C

um I tried to make the scripts as much as possible, config driven so that, hopefully we don't have to touch the main scripts. um Much we just go and say: oh I want to do this now, because what is going to happen is things are going to move from experimental into uh production? So you know their Source path is going to change.

C

Things are going to move around. There are going to be more things here, so this is currently in contrary plugins, where.

E

So quick question on that now when when they do happen, um how would you know folks that are you know, uh focused on uh the rum uh stuff right? You know primarily working on sale, the sandbox, you know what has changed to go update this um you know. Is it an automated brand I, don't think so? Right, no.

C

It's manual yeah.

E

It looks for a source folder if it doesn't find it. There say it's just. It's particular be a no-out.

C

No, that's actually, why I've got this check here. So if, if the source folder doesn't exist or even if it does, if this package does not exist, it will fail, um and that's that triggering point to say: oh something's changed. We need to go and have a look and figure out what what we're? Not so, that's that's why this name is here: okay,.

E

F

E

Stuff's going on showing up. uh That is something that we have to add right.

C

Correct yeah, so the new stuff will just end up being in that auto, merge folder in the final one, so in temp like it will just end up being here, because these two here are complete copies of the existing one. So you can see like in here. We've still got. You know the shim open tracing the all the other exporters, um like all the other experimental stuff, yeah that it's all there. So we could do a manual get move.

C

um You know if you're in a branch- and you want to like try playing with something you can do that, but if we wanted to end up to be in Maine, that would need to upgrade um the config to say. Okay now we want to actually grab this one and move it elsewhere like these, like the fetch one, this one that's going to be where I want to move that one.

E

I think I'm following but they're not going to so an instrument, a new instrumentation gets added in the Upstream uh JS repo, um the country doesn't reference that say uh maybe I'm wrong, but you know. uh Let's let me just go. Go ahead with that example.

E

um The country doesn't have it so the scripts don't even touch that folder. So what it's saying is, after the bi-directional stuff, the merge and move back and we're ready to merge back into main. Is there and well? Actually, you know when you pull it down you end up with um you, don't have the copy of the new one added right or will you um the.

C

New one will be in this, so if, if a new experimental instrumentation gets added to the JS repo okay, it will end up being in here. Okay,.

E

So then, your sandbox, when you go play with that, when you try to add more functionality and start referencing it everything works. Fine.

C

Yeah, it's just that one won't get built because that one's not in the build pipeline, because um it hasn't been merged into paper. It has to be merged into the packages and therefore the the rush Json okay.

E

So when we catch it will be, you know, let's say you know, somebody starts updating it and stuff. You know the fact that it's not being built with your tests will not work and stuff right, so you will catch it.

C

um Well, the code won't get compiled, the test won't get compiled or run so. Okay, um so it'll be the same as like. If someone goes and adds a new experimental uh instrumentation for node like from a web sandbox persecutive, we don't even want to worry about it.

E

C

It will be here like here we have like the open, Telemetry SDK node. This will continue to live here purely because we're dragging down copies of the the two Master repos, but from our perspective, we're not going to build them. um Is this my temp folder?

C

B

This is my merge one.

E

Yeah I think I think I follow that.

C

So because, like for the build effectively, it's got to end up being dropped into here. Saying like these are the only packages that would get built when you say built in Maine.

E

C

E

Okay, okay, so um what I was thinking about? If there's an automated read to basically say here are the things that we're not touching. uh If you see anything new, you know Blair. No, you need to go change, configure something like that and we're just thinking. Yeah.

F

Because 10 years.

E

Is on your face, you cannot miss it that that issue is fine. If a photo goes missing. We know. Okay, we need to update the config to uh continually reference that yeah.

C

The action will fail, yeah.

E

uh Something to think about, but you know, or at least the process defined, so people you know, look at it uh part of their emerges and things they look at this. This older report or something but extra things that they potentially should care about.

F

C

Yeah because, like this config is also used for the other one. So in here like this, is the config that's used for merging um the two repos into that auto merge model. So, um like you know, this is put into JS or this is like Auto merge and this is JS and contract window, and these are the repos. So if you, if we had a third one which we did originally the apio one was originally listed here, um you know you just put in the URL and then you know this is really pretty much.

C

The only config for getting into the auto merge, folder they're getting out of Auto merge into the individual packages. That's where we've got all this extra config now.

E

C

E

As a test, uh Martin was talking about pulling everything down and running them, and you know running your test and stuff would? Would you also suggest you know actually making a change uh in a controlled experiment, so to speak?

E

You know, change in sandbox and then um try to merge it back and make sure it's made it in the right places in um the Upstream JS folder or at least get that all the way to the pr and look at it to make sure that you have all the files are detached are actually going back to Maine in the right places. Would would that be part of the test should be right.

C

um That's all manual at this point so so effectively like the three typos um that are currently failing, assuming they they still exist, and they can't one once I get this going. Okay, I, uh you know someone would probably me will have to go back to the Json country repos.

C

In fact, you create PR's there to do that that exact change um once they're checked in they'll come back around through the the staging one here and then eventually that script will pick him up and then put them back into Main and then, as part of that, we won't need to manually update it um because I'm doing a git merge once we do it once in the sandbox.

C

We shouldn't have to do it again unless someone changes that line of code in the original one, which then would cause the auto resolved result in favor of the source, one, not the sandbox one.

A

So uh quick question: just uh why? Why would it be if, if it was failing for us, why why would it not be failing in uh the official SDK the.

C

Official, potentially because of the version of typescript we're using um or hideous or it was.

A

C

um Because yeah the the typescript errors, so it's either a typescript versioning thing, so it looks like uh locally I'm, probably running uh 494 um and because in as part of the config I, do tell it to overwrite uh where's that config.

B

C

Yeah I tell it to effectively fix at these these specific versions, because this is what I've tested with um it could be that you know the sandbox is using like the latest one, where the main one isn't now. That's my first thought, but I haven't gone back to the JS repost to see if it has actually been fixed in the case of the visibility change, that one is only happening in the sandbox, because the sandboxes automatically created a web worker version of the tests.

C

That's if you're trying to run the test in a worker, not just a browser. So, okay.

A

C

But for the any I I think that's probably a typescript version.

C

um And it's probably a case of his part of getting that visibility change. One back well, I'll probably contribute back the web worker configuration um so that even JS would then be running the worker tests yeah, because at the end of the day we are driven by what contribut.js have in their source code. So if they break something and we import it, we will get broken, especially considering the auto merge script. That's currently running doesn't run any validation at all. It just grabs copies and puts them into that branch.

C

It won't be until this one and the CIS are activated that we'll actually start seeing patterns.

A

A

Well, I definitely have a better idea what how this works. So thank you. Yeah.

C

It's complicated, um which is why it's taking so long.

A

F

A

Look at I'll look at the pr I'll try to test it locally and uh you know I think to some extent. I'm just gonna have to trust that it's working so yeah.

C

The two big changes uh that are happening is it's not using learner. It's now using rush and roll up. um Well, the the roll-up stuff doesn't exist because you, the account repos, don't create bundles, so Roll Up is, is new to create bundles, so I've built with yeah base Baseline squared, but the the big changes going from learner to to um Rush. Instead uh I think the country repo was at least there was a branch created that was you going to use Rush.

C

This, of course ignores those because it's just grabbing the packages, um yeah Russia's, just a little bit nicer.

C

um In my point of view, I reuse, rush for asthma, okay, yeah and then the other one is just should just be the the relocation of the packages um and so again changing the package structure, which I know when I first pointed out.

C

Daniel said he wished he'd done something like this originally, instead of having all these huge long names, because it does cause grief, especially on Windows, um because the package path gets too too deep because after this you then have node modules and then you have they're dragging in the you know, open Telemetry, Dash, API, etc, etc.

A

So once uh once this PR is merged, uh we'll be, will you be able to pull down the first version of.

C

Everything, okay, yeah, so um the reason I haven't uh this one yeah. So the reason we still have this PR open from uh the 7th of December is this was a merge as of the seventh seventh of December for uh Json contract.

C

So what I want to do is get the script in merging with what's already in Auto, merge and then merge this one and then do it again because that'll be then the first real test of how has my auto merge resolving things assuming that works, which it should um it may end up doing some of these, like Auto, resulting in favor of theirs, which there's the same code.

C

um I'll then run this script again like if you try and run this action like here, uh which you should have ability to run this as well I'm ready on being a maintainer like they're, pretty much. The first thing. This thing does um is checks to see if there's existing PR so like, which is also what the other one does as well. It only allows one PR for its task at a time, yeah, so yeah. So again, it's running typescript to compile that yeah.

C

So it's going to clone the first one and then it's eventually going to go. Nope, there's already a PR here so again.

C

um And that's if I had multiple mergers, trying to that's just going to cause greater confusion, so that's sort of why I did that.

C

um So you can see yeah I checked for any PRS by this thing found that there was one already and went. No I can't do anything more because I can't go for a great appear.

A

C

um So yeah so until um where'd it go, it didn't just close it on me. Did it.

C

Let's just get playing up, it was just there. Was it not.

A

I thought it was yeah. There were two right.

B

B

December 7th president.

C

B

Yeah, it's still here.

A

C

Always why was it closed? Hey I'm, gonna, reopen that.

C

Now, instead of force, push okay, there's a problem with that script. Okay, so now I can't merge that one.

C

Every time I've got to close the screen. I have no idea why I closed the pr which is not close, the pr um and because I'm, not the open, Telemetry bot I can't go and reopen it all right. Well, I! Guess that's nothing happened. Then.

C

um Unless you go run it then, because it's down nothing staged so I think I want to have two runs. I wanna have something that's there. I can need to go find why that close, that thing now.

A

C

So yeah, so that's yeah! It's a bit painful.

A

Do I should have waited until you take a look at it before well,.

C

You can still play with this one um so like I guess, I've got some comments in here about what I was doing in some of the descriptions that I've already talked about. uh Actually, that's right. um This one I haven't checked in there was a a bug on this line so that you just need to add uh npm run on the front of this.

C

So when it when it generated these tasks, I forgot to add npm running on it. Okay,.

C

uh In fact, what I'll do let me, um let me just force the update of the pr so that you don't have to do that.

B

B

C

Come back please and again, that's just the API.

C

I I have um Visual Studio in another window that I'm just merging these things into.

C

It okay, PR's, updated. You don't have to do that now.

A

C

Grab a copy and go for it.

A

Yeah I'll do that I'll try to test it I'll, you know go over now that you explain things so it'll go over the script. I, don't know myself and try to do my best, but uh yeah I'll should be able to review it today or tomorrow. Yep.

C

Yeah so I'm Gonna Keep um working to get some some of those like the instrumentation tests going because, ideally I'd like to say the script is done. The only thing that won't be finally validated is that uh extra merge um that I can continue on with other things.

A

Okay, cool right! Well, thanks again for the walkthrough, it.

F

A

F

A

You I'll see you tomorrow, yeah.

C

Okay, it's over cool.

B

All right cheers all right: cheers bye, bye,.