Open Telemetry Uncategorized, 6 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-07-06 meeting

Description

OpenTelemetry PHP SIG Meeting

A

Good morning,.

B

Y'all good morning.

C

B

Give it a couple more minutes, let people file in good morning, mr mcbride good day.

A

Good day, mate, how are you.

B

Hanging in there.

A

Good, uh I guess you didn't enjoy your fourth of july break. Did you stuck at home.

B

uh It got worse because my daughter can uh tested positive so now, she's still with us, luckily nobody's had any symptoms really.

B

But yes, we made cheeseburgers at home, which is anticlimactic.

A

Well, you still marked the day, so that's good! It's a very important.

B

A

B

uh For you know, that's a very loaded question. Brett. A lot of people have different feelings about uh the fourth of july, especially now, but overall it is supposed to be a very important holiday.

A

B

We also had super super horrific rain storms that day, so there were no fireworks. That's normally for a big part of fourth of july.

B

All right, it's 805 we can get rolling with our sig meeting discussion.

B

I will start with the open pull requests amber. It looks like you have an invalid covers annotations. So would you like to speak to that one.

C

Hello, are you asking to me.

B

I know to amber.

B

D

B

You repeat: oh yeah, you uh you have a draft pr open invalid covers annotations.

D

uh Yeah yeah, I was working on it, but uh I'm getting an error, build error which I wasn't getting before. So I don't think it's related to whatever changes I have made. So I'm looking into it.

B

D

B

Yeah, it looks like it might be the same thing brett you were, I think you were talking about sanket about that with the symphony runtime error.

A

Yeah, I think most people are probably experiencing that at the moment, if it's complaining about composer jason files and runtime, um I'm I'm also seeing that today and I suspect most most developers are in latest code.

B

C

Sorry, sorry bob you could.

B

I was just I was saying: do we know where when this was introduced, or is this just a separate.

E

This is caused by composer, they switched the behavior uh five days ago. Okay, thank you, create.

B

E

Pr to resolve this issue in the left tools episode in about three hours.

B

You uh you said you created that pr for this.

E

I will create appear yes,.

B

Okay, but uh can you link that in the zoom chat.

E

um I haven't created it yet.

D

It is it's coming.

E

Yeah it's coming afterwards.

B

Thank you, tobias. I really appreciate I'm sorry, I miss I misheard what you said all right so amber and thank you that should solve both of your problems.

C

B

Yeah no problem uh is there anything else you need with that pr amber after that happens, or is this. It looks like it's not too big.

D

Yeah yeah this was all this bug was sold. It means I wasn't getting the warnings.

B

uh I see I see, what's uh I see what's happening, thank you for that. Thank you for that pr.

D

B

Looks like brett, you have your event dispatcher pr still in draft is that something that you plan on working on.

A

I am, I was actually going to work on that today and then I got distracted by a couple of other a couple of other bugs, but we resolved. I think, last meeting that I was just going to compare that right back to just an event dispatcher which I'll do um and that's why it's sitting in draft at the moment.

B

Okay, I mentioned give me another one yeah I mentioned that that's your work on it this week.

A

Cool. Thank you this week for sure.

B

All right, good, excellent um sanki! You have your uh your pr open. Still do you. Are you blocked on that.

C

uh No, I don't, does the validate part, that's it uh apart from that everything is done and and uh yeah a little bit of code coverage, so code coverage is down by zero point: zero five percent or zero point. One percent.

B

C

B

Don't know how to do that.

C

B

C

A

B

We we talked about that in the meeting last week. It's not yeah the.

A

B

If the coverage changes under one percent, we don't really care at all. We don't have a code coverage number that we have to work towards. It's usually just a litmus test for us to make sure that we're actually writing code. But please don't worry about code coverage. If it's, uh you know, if it's under don't worry about code coverage, if it's under five percent.

C

uh Should we uh add that part into the contributing.md, because sometimes what happens the you know, reviewer might see that the build is fail and they may they may not review the pr just because it is failed because of code coverage.

B

That's that's a great thank you. That's a great idea, um I'll open a pr and add that in there.

C

A

Yeah, I would say it's that reviewer's discretion that you know, um but yes, it's worth worth documenting that slight slight decreases is probably fine. It's just meant to stop people from contributing code without any tests. I think yeah.

B

I will I'll make a note of that in the repair all right, uh the contrib repo just has the one, the one pr open. Still, let's see how many tickets we have that are required for beta. At this point, I think we're down to seven, which is great we're working, we're getting closer and closer to a beta release. So if anybody needs something good to work on, those tickets are the highest of high priorities towards our pay release.

B

Those were the.

C

Fun requests. Can we can you share the screen when we discussing any pr issue, so we again also know about it.

B

Sure uh I'm yeah I'm happy to do that, but I don't think we have anything else that is on the agenda to discuss I'll make sure to share my screen. The next time around.

B

Those are all the normal agenda items that we have does anybody else have anything that they would like to discuss today.

E

I've created a bit larger apr for the matrix implementation. Maybe somebody could take a look at this.

B

The metrics implementations that we said device. Yes, uh the draft the draft here that has eight commits.

E

B

Okay, I will take a look at that. It's.

E

E

I'm aiming to resolve most of the issues over the weekend so that we can watch this maybe next week. If there are no other issues.

B

Yeah, not a problem, I will review I just um I. Whenever I see a pr that's in draft, I don't I don't review it immediately, because I think that people are still working on it, but I will take a look at it.

B

Is there anything in specific? Is there anything specifically you wanted to talk about with that pr or just mention? Oh man, it's a gigantic one and it sort of needs. Certain love.

E

uh Yeah only generally needs some review.

B

E

B

No problem whatsoever, it looks it looks very well organized and thought out, but I completely understand that this is a very large vr and will take some time to review. Yeah.

B

Wonder wonderful.

B

Okay, anybody else.

B

Going once going twice all right thanks for your time, everyone we'll see you next week.

C

Thank you guys, bye-bye bye.

B

D