Open Telemetry Uncategorized, 14 Dec 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-12-14 meeting

Description

OpenTelemetry PHP SIG Meeting

A

I've read I.

B

A

Rick, how are you fine thanks? I was thinking that nobody will join.

B

Sorry, I'm late.

A

I just got distracted.

B

With something yeah no problem, uh I will share the screen. uh Oops oops an apology today, so it might just be you and me.

B

uh Can you see my screen.

A

B

B

um All right, let's flow through it um uh thing, um open requests. Sorry, I'm, quite ready.

A

There is only one with this.

B

A

Yes and I've seen that uh Tobias already reviewed that.

B

uh Yes, yes, so there is a bug in it, um which is what we have code reviews. So that's what I was just looking at, so I'll fix that up, um probably after this meeting get that that one working um what else? Yes, that was the only one and then we've got um issues. There's only that one issue um from me and then there's a brand new one that just popped up in instrumentation, which was.

A

Somebody, okay.

B

uh Somebody who's found our code, maybe since we went to Beta um so one or the other of us can have a look at that.

C

A

Can look at that one yeah I.

B

Think we just need to ask them the question like how do you? How do you know how do you think you're interested.

B

Not found um yeah well I think we need more information, but but um yeah I, don't like which one of this um I'm asking about that. But probably the first step is you know, can you check the.

A

Uhp because currently uh we can't install extension because it's not on this specular storage right.

B

Now we can install it well, so um if they've installed it from.

A

This ah okay, okay, but maybe it would be also good to add some instructions for uh compiling this extension from source code.

B

uh Yeah yeah, if that's, if that's, why we weren't able to to install it um yes, so what do we have so far? We've got something in.

B

In here, but this is just really for building it for Developers.

A

Oh okay, so it's it's.

B

A

B

You have that um yeah, it's it's, maybe a bit specialized, but.

A

B

You're right- just maybe even just this part here, because.

A

Youtube I was thinking about maybe a little bit extending this documentation for uh people that uh maybe are new in in this kind of stuff and because for now uh this documentation, of course, is good for someone who already knows how to how to do that. So how to build extension and so on. But.

C

A

Maybe we can extend that a little bit.

B

uh Yeah, absolutely we could have a um uh probably a. We could probably have multiple subsections on the installation here. Yes,.

A

B

A

B

This this way that I've done it only works, but Joker yes and lots of people don't use Docker yeah, um so we have Pico is, is what this tool uses under the hood, which is supposed to be a replacement for pickle, but it's not yeah I mean it's it's pretty good, um but even that I'm not sure how you I've never used it directly and compiling from Source. Absolutely. Why not.

A

Also I was thinking if such documentation should be on this uh readme in in this.

C

A

File or maybe someone else somewhere else.

B

um Yeah, it's good I, think well, I think it should be here right. Also.

B

A

Yeah I've seen that.

B

um Php Auto instrumentation under.

C

B

And I mean this I good I think I've pretty much ripped it straight off the the redmi, but this could be another. Oh he's already mentioned pickled, but I haven't documented it mm-hmm um yeah, so that could be another another way to do it. um So these are the sorts of um issues. I was expecting when people started using it for beta sort of um I'm, hoping that a lot of the things that come up will just be. We need more documentation.

B

uh Yeah um but I'm very much supportive if you, instead of writing some some improved installation instructions with more options, um because a lot of people do things in a lot of different ways. Yes, yes, um so that's it for our folks um agenda items that you already know about this one. You obviously already know about this one.

B

A

Yeah for you, yeah I, added this, uh this topic I say some time ago, I started. You know, testing this Auto instrumentation with, for instance, WordPress and I, wanted to test it also with a Drupal. But this is something that I haven't started yet and for WordPress we, we don't have uh spans from from this software. Instrumentation I, don't know if you tried the um no.

B

A

With WordPress, but it seems that the WordPress is is very old application, and it doesn't mean it.

B

A

Composer or you know it even it, it doesn't use composer. This is his first.

C

A

Seen that this it's using a composer only for one one of the plugins, if I, remember, correct, yeah and also I, think that it doesn't use this. You know PSR 7, PSR, 15 and.

B

Oh, no, it wouldn't no.

A

So, uh in this case, uh of course, we will not see any spans, so the only way to to do that is to add this hooks by hand.

B

And that's okay, um yeah yeah, so we could definitely write a contract module for for WordPress but but the other, the other interesting being which um you you already sort of mentioned was: if it doesn't use compose auto loading, then how do we initialize.

B

um The the the SDK and and set everything up yeah can you do it with a I think there there is a concept of a like a pre-execution function in PHP, because I I see can can. How do you run code before WordPress starts.

A

So I haven't tried that one, but I can try it, but what I did so far was just to you know uh at one requires statement and and load the hooks.

B

A

So so that was the the easiest things the easiest thing I I could do, uh but yeah we can try something that you mentioned.

B

A

Yeah I'm not sure uh what is the situation on the market and how many applications uh on the market are similar to Wordpress that you know don't use a composer yeah, but maybe some older application, probably don't use composer or maybe.

C

A

They can, uh of course, refactor themselves to to use the use it.

B

um Yeah, if and if it works, something yeah, then.

B

Once you get something working, let's look at whether it's a is that just then it become a documentation being on our site like or we provide a small script like the current auto loan script um and say register registered this as a preload function.

B

um Yeah, so that's part, one is getting Auto instrumentation available and then.

B

um Yes, I agree that it would do absolutely nothing with WordPress at the moment, because it doesn't use any thing that we have already written Auto instrumentation for yes, but but in theory it should work just fine to find some interesting methods from WordPress and apply our own hooks to them. The third would.

A

Have to write them? Yes, that that's true, because I did that for a few functions and I got spawns from from them.

B

C

A

Works but as as we said, we need to add this hooks by hand.

B

Yeah that could be that could be really really good.

B

um What are we talking about? This has come up in the past anyway, someone was asking us if you can instrument WordPress, because it's a very, very popular system, yeah.

B

um If we could Auto instrument it with almost zero effort. um That could be amazing for uptake of open telemetry, because.

B

Having to manually instrument it, which was the answer when the question was asked, was a lot of work and would require modifying a WordPress code base or writing plugins or something for it, which is a.

C

B

Work and and very hard work like you'd, have to be a developer and probably a WordPress developer. So that's true yeah, so that could be a um a very, very popular.

B

A

But probably still to to instrument that um correctly I mean to get a meaningful spans from it. Someone needs to know uh I, think internals of Wordpress. Yes,.

B

Yes, I I agree with you there, yes and I just thought of him yet another problem, which is that if they don't you, if WordPress doesn't use composer, then how do we get people to install the open, Telemetry libraries?

B

Can you compose a install some aspects and not others like how do you? How do you get the code somewhere so that so that it can be loaded.

A

B

Well, you said you got something to work with um where breast didn't you.

A

Yes, so so, finally, uh I think that I uh I used composer with the WordPress.

C

A

But I had to prepare prepare it. You know this composer, Json and so on myself, okay, yes and uh no, and then I have because I I was doing that uh a few weeks ago. So I have to look at it and maybe I can uh share with you some details on on the slack later yeah. What is I did yeah.

B

A

Because I, don't remember exactly uh you know, uh as I said it was few weeks ago, mm-hmm.

B

um I think it's a brilliant idea. I think it's really worth investigating and we could probably also go and um seek help from the WordPress community somewhere, because this is presumably quite or potentially quite useful for for WordPress um yeah, particularly if it if it can work without having to modify the internals of Wordpress. Like that's, that's, that's huge.

B

C

B

Okay, yeah, please please go on with that. I'll be happy to help um as much as I can.

A

And uh um regarding Drupal uh I I've seen that Drupal is using a composer and it also uses uh this uh PSR common interfaces, so uh at least we should have some spans from it, but I haven't tested it. Yet. Okay,.

B

Fantastic, that's really good news, um yeah being able to Target a couple of big popular um platforms like that um really exciting to to to think about mm-hmm.

B

uh Excellent, do you have anything else for for the agenda or anything else? You wanted to talk about prismac.

A

I, don't think so. The only thing I can add that I plant also add some more comments into this C extension uh I think that they would be used use useful for someone that is new to this uh kind of thought.

B

That would be yeah. That would be great yes, because.

A

B

Encourage others to be able to work on it because yeah I, that was, that was what I found anyway I couldn't I, couldn't understand what was going on, so I wouldn't be able to to contribute to the code.

A

Yes, so so at the beginning, also for me that there was some challenges, but uh you know the the best thing is to just start working on some issues. So then you can learn uh fast, yeah.

B

What about um like, were there other techniques that you could use as a developer like? uh Can you attach a c debugger to the extension itself and sort of Step debug it like that or or do.

A

You just yeah, so I was uh you're running the the PHP, because I I have a debug version of the PHP itself and I run it in the debugger and so so I prepared. For instance, we had these tests that Tobias prepared and I changed the test into little um PHP application and then I run it in the debugger and so in the debugger. You can do you know, step by step and test.

B

A

So that's something also I could uh um you know describe in the I, don't don't documentation or something like that? I.

C

A

Read me would be um good good place to to add such thing.

B

Yeah I, probably in this document or something linked from it,.

A

Yeah, okay, development.

B

Would be yeah, yeah, I think so I think so uh yeah. That would be. That would be incredible because um obviously, you've had to learn. Learn a lot about it now.

B

um But yes, if we can, if we can make it easier for other people to to help and to contribute, then I think that's that's good for our project.

A

B

B

Next, uh that's the next thing: I was going to try and work on was to um yeah update that demo application, because we can sort of better show off our Auto instrumentation now and also remove a lot of code.

A

B

uh Because everything was manual but again so.

C

B

uh Excellent, all right, that's it for me, nothing.

A

B

From you, yes Let's, uh let's call this meeting done. um Yeah, congratulations to to us and to everybody else for uh finally, getting a beta out I think it took about three years. Bob's probably got a better idea, but um there are definitely some files in the repository that are three years old. So it's a.

A

B

Long time, yes,.

A

B

Foreign enjoy the rest of your day and I will see you I'm not sure whether we're going to have a meeting next week or not we'll we'll see when we get it but I. Imagine a lot of people are going to Beauty.

A

Holidays, that's true, I I'm, not sure. If I would I would be able to join.

B

That's fine: you have uh earned a holiday and not enable my permission, but uh you know that's quite fine. If uh yeah, we may end up just skipping a beating or two um all right, yeah over over the sort of Christmas New Year's holiday period yeah, but we will post something on on slack about it if any decisions are made. Okay, okay, excellent! All right! Thank you very much for coming along tonight today appreciate it. Thank.

A

You Brad see you soon see you all bye, okay,.

C