Home
Contribute Contact Us Browse all meetings
Home Contribute Contact Us Browse all meetings
Open Telemetry / Uncategorized / 17 Aug 2022
Open Telemetry / Uncategorized / 17 Aug 2022
Previous Meeting Next Meeting
⏯
Add meeting Rate page Subscribe
youtube image
►
From YouTube: 2022-08-17 meeting

Description

OpenTelemetry PHP SIG Meeting

A

All right.

B

Hello.

B

How's everyone doing this morning afternoon.

C

Evening.

B

Yeah, I think you're really quiet.

A

How am I now stunning right.

B

I mean you're pretty quiet to begin with, so.

B

As an in your personality,.

A

Yes,.

A

Trying to think of something clever to say, but it's it's pretty late here.

B

Oh you're also very clever, usually but I'll chalk, that one up to sleep deprivation.

A

Thank you.

B

All right we'll get going in one minute. Does anybody have anything to add to the agenda notice that nobody's added anything.

B

Now we can go over that things.

B

All right we're at eight of five just start, taking a look at things. We have open.

B

All right, uh thank you missing, retries, on exporter, this one has a little long in the truth, but we'll see how that's going.

B

It's nice, it looks like you reviewed it last night he hasn't made any updates so we'll leave that, as is.

B

Sean's d3 propagator for p3 single header. I think this is the last one we need for beta. So this is important that we get this one wrapped up.

B

First, oh um tobias, uh should I ask you a question about this, a couple of questions about this one? Would you mind addressing them.

C

Yeah, I'm not sure about the first one, because the spec isn't explicit about this case. It just says that you must attend both formats, but not what should happen if the first format is present, but invert invalid.

A

Yeah.

B

Sometimes the spec can be like that. We can always ask the other. We can ask in the specification channel if we want to I'll I'll, follow up and ask about that.

B

Make a note about that.

A

I think, on the other question uh kashan had I spoke to him today, so I think he's just going to move it into contrib or the contract directory of the main repo.

C

Now the question is: if we should name it contrib or extension, the spec users extension for rp sided extensions and contribute for sdk side. So maybe we should follow this.

B

Seems it seems like a good idea to me to follow the specs whenever possible.

A

Yeah, so what are you proposing, instead of having also adding an extensions directory into the main repo.

C

That it's.

B

What are the other things.

B

Doesn't look like they happen good example there real, quick.

B

Well java is java, definitely is a very good uh sake to follow, because they're probably the furthest along, and it had a lot to do with respect so we could follow. We could definitely follow the job way. Of course, I looked at the two that didn't have it. Thank you. Brad.

A

That's right, that's where they have their propagators. Both looks of it. So that's a good prior art for us to rip off.

B

I love prior art this one. This person still didn't sign their cla, so we'll leave that, as is amber, has your uh force flush pr going. uh It looks like this one's ready for review and he made it looks amber. It looks like you made all the changes that uh tobias had mentioned and uh looks like he did a bunch of stuff yesterday. Is that um is there anything else or is it just ready for a review.

C

uh I have removed the changes of a bad spam processor. I believe tobias, has made the changes in.

A

Bat span.

C

Processor, uh so I've only put the changes for simple span: processor.

B

Got it okay, so this pr is ready for review. It appears yes, okay, perfect.

B

Yeah, tobias, this is your most recent pr, sir. um Is there anything you want to talk about with this one.

C

Not really, um it needs to be reviewed. The code is a bit ugly for the sync version, but I don't think we can much better while following this back, this aspect.

B

Got it I will, I will review both 787 and 788 today.

B

All right, those are the open, pull requests in the php repo. Let's look at the contrib repo.

B

Oh, the symphony symphony instrumentation bundle. I think right, so we could ship this right. Should we ship this.

C

We can keep it open for a bit longer, mr considering changing the structure of the configuration so that we have a general http server configuration instead of configuring. This just for the kernel.

B

Okay,.

C

And we should make the sdk bundle compatible with the rp bundle, but this should be just a minor change. Adding one service area should be enough. I will look into this at the end of the week. Sounds.

B

Good.

B

Yeah, those are the only ones that are left there. Let's get some bugs.

B

No, this is the uh I remember reading this, but these yeah. I think that there's nothing. None of these are death, bugs let's take a look and see if there's a label required for beta.

B

So I think that I always thought this was done between that.

B

We decided to make this not required for beta. That's right, okay, I'll mark that, as not required for beta.

B

And I think that sean's pr is the last thing that we need before we have a data release, which is great.

B

uh Brent looks like you added more code, reviewers.

A

uh Yeah- and so I mean probably that in an official capacity um um I haven't seen to you for a couple of weeks, so it's just it's a little slower to get someone to officially review and sign up on a patch. um I was just wondering whether we might consider uh putting the call out to officially showing- or at least.

B

Yeah absolutely yeah, I'm always happy to add more viewers. I think it's difficult to find people that are interested in being reviewers. If anybody on this call tobias amber if you, if you all, want to be co-reviewers, I'm more than happy to um to sign off on that or if we have other people that we know that would like to be code reviewers. That would be great.

C

uh Sure, actually, I'm not that experienced right now when I feel ready, I will surely let you know.

B

Sure that sounds great.

B

And brett, I'm sorry if I haven't been uh quick enough for you, if you get stuck just please let me know I'm very happy to review stuff. I think I just have been caught in the fold in a new company transition. So please just ping me if you need something reviewed, I'm happy to do it immediately.

A

Okay sure no worries.

B

Yep.

B

All right, um I guess the other thing we have to talk about is once kashan's pr is merged, then we'll be ready for a beta release when, after that happens, I will uh the process for starting a beta release releases to get another another sig to review our code, just in a base form to make sure we're not missing anything egregious and then we'll do a bit release so figured everybody would like to know the process for that, and I know that that milestone is huge and important.

B

It couldn't have been done with everybody on this on this call today.

A

Exciting.

B

Yeah super exciting yeah um all right well, does anybody have any anything else, I'd like to discuss on the call today.

A

uh I just mentioned psr22, which just the tracing um standard is is moving along again if anyone's interested.

B

That's right.

A

Yes, yes, all the all the actions happening in discord, um yeah yeah- I. What do I say it's that the the people involved in it, I think, are almost happy with the interface that we've covered with, but I I've never been through a pool seat before so it would still be, could still be a long ways off and could very much still get rejected or whatever happens, but.

B

What's the process for that, like brett, that you just you, send that psr to the people that be it in php land or like I'm, not really for sure, if you're new.

A

That's a great question. um Look like, I think it I'm not familiar with the process, but I think it sort of goes to a vote. You know, there's a there's, a committee or you know, people with voting rights on on.

A

You know new psr, so so step one was, you know, get a sponsor which which, which has been done and a good sponsor. That's been involved, um yeah and I think internally within it with anyone who wants to you know, have input, um propose the the specification um and interfaces and whatever uh and then when it's ready. I I think it goes to goes to a vote.

B

That's cool well, keep our eyes open for on that discord, room to make sure that we, uh the progress, is making that's really cool thanks for sharing.

B

Anyone else.

B

All right! Well, if that's it, then uh we'll adjourn for today, thanks and we'll see y'all here at same time, someplace next week.

A

Bye everybody thanks for coming.

C

Bye.