Open Telemetry Uncategorized, 29 Mar 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2023-03-29 meeting

Description

OpenTelemetry PHP SIG Meeting

A

B

C

D

B

How's everybody doing today.

D

Oh I'm, just too bad I'll be tired. I think I keep doing stupid things. I've got another pull request here, just like the detective fixing something.

B

D

Don't know how's.

B

That old, saying, God third time's, the trim.

D

Yeah, this time for sure.

B

All right, let.

D

A

B

We're all done no company secrets.

B

All right, y'all can see.

C

My screen just.

B

C

B

All right, wonderful! Let's do this all right.

B

We have a lot of lakes to open at the beginning of this meeting now.

D

Yeah we do yeah.

B

That's good I guess all right two of the pull requests. These are both from Brett nice move the create releases script, that's the place by so this is just a removal I'm just going to merge this, because red PRS are the best PRS.

D

B

Appreciated doco cleanup.

D

So this one does need a bit of looking at and there's two related who requests one here, where we're removing lots of things and one over in open telemetry.io, where I'm adding certain wonders.

B

Wonderful I'm gonna put both of these on my review list for today. I've.

C

Seen that you removed a lot of stuff from these dogs yeah.

D

And I may yet want to remove more as well. um uh It was a long time ago, now, probably more than a year ago, but um someone was asking us to move all of this, uh all of our documentation, almost of it out of the red me and into the official source, which is open toflammatory.io, so which.

B

Makes sense people are going to read that faster than they're going to read or report I.

D

Hope so yeah yeah, so I made um like I'm all for removing more of just for the time being kept the structure the same and just pointed off. But you know it's It's Quickly getting to the point where everything is just a pointer to somewhere else in the photometry.io. So perhaps we can remove even more.

A

B

Is always good.

A

B

And we have contribute as five PR's.

A

B

Academic, you have this one laravel boot, hooking yeah,.

C

So this one is ready for review, so you can look at it. Okay,.

B

C

Putting it in like.

B

You my kids, getting paid today. That's a good thing.

D

uh I can look at that one too I just been seeing lots and lots of uh changes, so I haven't, haven't bought it yet until it stabilizes.

B

All right, uh Symphony, adding HTTP client instrumentation login, gets.

A

B

Disable a lot of implementation looks.

C

B

Both have commented on this one already. Yes,.

C

B

C

Wanted to add was additional comment uh regarding this lack of of Spun and.

D

Yeah so I think he said he did that.

C

He did that, but the in uh other place and I think that in this particular place it would be also useful to have a comment because.

A

C

Confusing I think that's that's my opinion.

D

Yeah fair enough.

B

All right, I'll wait for him to finish that up wherever electric looks like you already approved this one. Yes,.

C

But the Brett also suggested uh and.

B

He has to sign the CLA.

D

Ude all right, let's go away.

B

Got away fixing get split, can free again looks like this one's approved. Should we just merge this one.

D

uh Well, maybe just if you look at it as well, yes, okay, okay,.

B

That's easy enough.

B

I'm willing to accept that risk.

B

Enabled or disabled out of instrumentation looks like you guys have commented on this one as well.

D

Yeah I think there's still a little bit more to do on this one, not.

A

B

Do here then, they're.

A

Available again, I remember commenting on this one.

C

So I, in fact, I added here all the Watchers of that Scott plant had in the original Library, except that the redis one, because uh I think that we can postpone it and that that later it requires also to prepare to think about. How can we test that.

B

D

C

And now um another thing we have to think about is this configure configurability about uh the spans that we would like to maybe filter out because, as we uh talked in the last meeting, there will be more more spans and some of them maybe will not be needed from the one user perspective and the other will will uh we like to have them. So we have to think about this configurability.

D

C

That's the issue that we also mentioned with this. um You know local levels for spawn or something like that.

D

C

I was just thinking.

D

About that the issue in the spec repo- um maybe a teacher, is very helpful or illustrative, then so, if you were to like, if you could run this against a laravel application and just grab a screenshot of here's, a massive um auto-generated Trace, um just just and just drop that into the drop that into the issue, so that um um people can maybe get more of an understanding of of where we're coming from our use case.

C

Yes, okay, so in this case I, don't think that there is. There are many uh spots in in for this laravel case, at least what I've seen so far. But this is uh something that we've seen already with a slim framework right, because there are yes, this middle words that are um invoked one by one. Yes,.

A

C

We have a lot of spans uh that are coming uh as a result from from framework calls and that's something that we have to think about.

D

Yes, it is, and hopefully they can solve it at the you know, spec level, so that we just have a you know a specification to follow, but um but yes, the prospect changes can take a long time as well and I haven't seen any activity on that issue. For probably two weeks now, you.

C

You know because I was thinking about something like to give a user um a kind of configuration where he could say that he doesn't want to have particular uh span or call.

C

So that's in fact how you resolve this problem with Slim So, you removed I, think Slim uh from the uh you you remove it from the installation right, so that the auto package was not installed in this case as I. Remember yes, so this that's! This equals uh to I said it works as a disabling. This this you know this functions from from instrumentation.

C

D

Does but it's very broad because you can only stop everything the instrumentation does that which.

C

Is not what we always want? Yes, so so we I think we should think about something that would allow us configuration but selective configuration.

A

B

Thank you. Configuration is always good. What kind of selective configuration are you considering.

C

Here, uh what what kind you you.

A

C

So um I was thinking about something like uh you know, to give a users a set of functions that he he can hook into and then maybe he can decide if he wants to hook there or not. Something like that.

B

With environment variables, or some other way just like to have it be functionality in the library it was like in case the user.

C

um Maybe we can I, don't know, read some kind of file.

D

C

A

D

The setting that we that's come up today, we've got um until PHP, disabled instrumentations I think it takes a comma separatedly still turn these things off. We could actually do much the same thing same with DOT notation. You know, um like disable, slim Dot middleware, and that means something to the sleep middleware thing you can check.

B

That feels like the PHP, where to do it.

A

B

All right, yeah.

C

B

You have any more actions I have to take on this.

C

So my plan is to I will investigate that issue further, and maybe we I will have something on next meeting, so we can then discuss that yeah.

D

And that's that's separate from this laravel. Yes,.

A

Let's progress.

D

A

B

All right, so that's all the contribute.

A

Hello requests.

B

uh Instrumentation doesn't have any um discussion, need an example yeah. That's pretty old I wish that these releases were oh I can flip through those in.

A

A

B

There any is there a specific I know: we have Auto instrumentation and price. Maybe we should wait on this.

D

uh I could also Point them to Scott plunkets library that um that apprecially makes me yeah.

B

Do you have a do? You have a link on to that, one for sure.

C

I I think it was on on this original pull request that I created uh so.

A

There is a link uh yeah.

C

B

Okay, so I'll mentioned this in here also uh here. This is religion.

C

A

A

D

This one looks like it's done: yeah I think we looked at that one last week.

B

That's right, I completely like that. Thank you all right agenda items Brett uh you! We talked about the documentation, move.

D

uh Yeah we did yep um just in case you guys didn't know about it. um You can find that link there to network live, which is the generated um open, Telemetry website, with my changes um yeah, it's just probably an easier way to um see. What's see, what's going on excellent.

B

Yeah, it's one of the best parts of netlifo.

D

uh Yeah I wasn't really aware of it before just recently. We.

B

Use that for some microsites at our day, job and it's just super Pleasant to work with.

B

Cool I'm sure that that gets that's part of my review for today turn.

A

This into the link.

D

All right, yep and then that's that second one is the one you just approved, so hopefully that jumps working its way through now and it's successful tickets, but uh then I'm just going to and disable the old open, Telemetry open, teleflammatory package that just change a source to to this meta package, and hopefully that means people can can install that again, it'll sort of just give them the latest of it. Sensible collection of about packages sounds.

A

B

Did you all ever hear back from the pickle people at all a never-ending Saga yeah.

D

uh It's someone mentioned, like some other um Discord group that we could ask on, but I haven't yes, PHP dot, C or something.

B

Php dot, C phpc.

D

A

B

Right, so you think we should ask in phpc or why.

D

B

Complete a few steps before you can talk. Okay,.

C

So that's the Discord right um I'm, not there yet so maybe I should join.

B

A

B

It's very good so.

A

D

Say it is actually pretty useful. A lot of um you know it's well established PHP community members do hang around us Discord, so.

B

We'll try I'll try there in the cycle continuous.

B

Those are the things that we had on on our agenda. Does anybody have anything else they want to bring up today, yeah.

C

I have one question.

B

C

Have you maybe had a time or uh Toto? You know to reproduce this problem with SEC fault on.

B

Oh my God, oh my gosh I completely forgot about that. That's I'm putting that on my list right now: okay,.

C

So, by the way I'm going to return to to this problem, but probably next week, I will try to uh to one again reproduce it on my okay, where.

B

uh That was an open, Summit, Church HP control. Instrumentation. Oh sorry, instrumentation! That's right! An issue! Yes,.

A

B

I will try to do that today, I'm, so sorry, product I, completely scared.

C

My mind: no problem, no problem.

A

D

uh Yeah, just the only other one for me is um when do we think so, I take it or I I understand it before we can call ourselves generally available. We do need a peer review of our whole, set up by someone else from a different scene.

D

um When do we think we're ready to to do that.

B

It's a good question: I think they were probably closer than we think.

D

I think so, yeah.

B

D

I'm pleased to see you, you know a few small bug reports and questions coming that indicate that people.

B

It's almost it's really easy. It's almost like. That's exactly what you want right. You don't want zero bug reports. That means nobody's tried it nobody's using.

A

B

But you don't want to slow bug reports because we messed something up fundamentally.

A

A long time ago,.

B

B

So we're sailing away. We can. uh We can ask the we can ask him the open, Telemetry um maintain our sick meeting any time for that review, so I'm happy to do that next week. If you want me to.

C

D

I think so, yeah I see I see getting a green teak there. It doesn't mean that we have to release ga immediately.

B

No, it doesn't no, it doesn't. We think, hopefully, that point out. Hopefully they point out some flaws in our library.

D

Perhaps that's.

B

What we're always hoping for always a six Six Sigma thing, constant.

A

D

D

It's continuous quality improvement.

B

Continuous quality improv- that's, it sounds like you're working in an industrial Factory yeah, which uh matter we kind of are just a different kind of factory.

A

B

Okay: okay, if, uh if nothing else, then we can adjourn.

A

B

C

D

Nothing for me all.

B

Right, we'll catch y'all on the internet, see you next week.

C