Open Telemetry Uncategorized, 23 Nov 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-11-23 meeting

Description

OpenTelemetry PHP SIG Meeting

A

B

A

How are you thank you? Fine thanks and you yeah.

B

Very good, thank you.

A

B

That's good, it might just be you and me again. um I know Bob's not gonna, be here tonight. So.

B

A bump usually waits till five past, but he happens to just get started now. Richmond.

A

B

Excellent uh I'll screenshot.

B

Okay: let's go.

B

um So I've got one PR in the main repo um which I've asked Bob to review and uh I know that the device um had a couple questions so he's at least had a let's look at it, so I hope to get that merged.

B

um Maybe tomorrow, um if there are no, no new, no new issues raised.

A

B

It um we've also got uh one very simple: pull request for um contrary, uh which was just to change the dependencies, because it was trying to install attacked version um and couldn't do uh today or at least couldn't do easily.

B

um uh I know. We've got a new issue that you raised. Yes,.

A

Yes, so I discovered that there is memory leak when we are trying, uh you know, throw exceptions from this boost post and I'm currently investigating it. This is not related to my recent changes. We.

B

Have this problem.

A

Before and yes so I'm currently looking at that.

B

Yeah, that's interesting um and thank you for pointing it. um What it made me think of is that we probably really need a debug build of PHP. Yes,.

A

It was cool, I, think yeah, um because because you know on unrealist builds this, uh it's not visible. In fact,.

B

Yes, yes, yes, which is not good! um Yes, I've, been putting off doing anything about that, because um there aren't any existing maintained. Docker images of debug builds of PHP will have to build it from source, um but that's what we have to do.

B

um I can either create a job to sort of build and tag um PHP from source and then use that is their job, but maybe building PHP from solar system that slow I, don't remember, but anyway, I might um I'll. Take a note for myself that that's something that we.

A

I, don't think it's so it it will take a few minutes, maybe maybe in even less than a few minutes, because we can try to build it on a few cars. So then it's it's quite fast in.

B

Mind yeah yeah! Well, you know the first thing to do is test it out and see. um I mean I know come I, do build it from um Source locally in our Docker compose build so.

A

B

Not it's not that it's not that hard! It's not what I don't know how to do it just see how fast or slow it is in um in gitlab, CI.

B

um Any new issues- oh we do, but we have.

B

I think we call this a bug: um I haven't even hadn't, even thought about it, but.

B

It's not that I, don't I, don't think it's in it would stop us going to going to Beta um this one yeah I, don't think it's going to be small, but I. Don't think that would stop a skeleton beta either, but it's um just something I noticed when I was reading. The spec is that, um shall we accept the word true or very spellings of truth and not all of the other things that we currently do, and it's a must.

B

So we agree um yep, that's a lot of priority, though um so uh treasurement did you did you have any updates that you wanted me to to notice.

A

So I can tell you what I will be doing next week. So now I'm focusing on this uh on this memory league and then I want to fix. Also the last unit test that left it's about um duplicate, hooking into interface and then probably I will also maybe try what what is the I will check. What is the coverage of of our current unit test and maybe I will try to add more tests and Implement these gaps that we that I will find.

A

We will see if we will have some gaps and basically, uh probably that's it for the extension at the current and we will need more tests. I think um end-to-end tests, probably.

A

Also I was thinking about trying to to to write this extension in C, plus plus, as as I found that there is a library for that and I was thinking. Maybe it would be easier to to to do that in C, plus plus, as there are some abstractions over a memory management and so on, yeah, so I was thinking. Maybe the code would be easier to maintain with in C plus plus, but that's uh that's something that maybe I will try in in free time.

B

A

Yeah yeah that.

B

Would be interesting um uh and look I guess: we've got that. We've got a good well fairly good um set of tests now to to know whether it works or works or not.

A

B

um uh So you mentioned um unit test coverage. If you work at how to do that, um um that could be like if you can look at how to easily generate that. That would be really interesting to be able to generate um some sort of output from as part of our local development, and maybe even our um like, have it reported on in in our CI pipeline mm-hmm.

B

uh Yeah that would just be a that would be a nice bonus um for me this week.

B

um uh I think we're getting quite close to being ready for beta, so I'm, actually planning on um using sort of Auto instrumentation um in my um State applications that I maintain in my day job as like a pre-pre beta test, or you know a big test of everything that we've done lately.

B

um You know in a real world application uh just to see if I can find any last um bugs before we sort of um start taking.

A

A

That's good I think to test it on on something that is used in the production. So that's very useful thing: yeah.

B

Yes, um yes, hopefully I'll find any lots of small bugs or use a building issue. Well, hopefully I don't. But um yes, yes, whether.

A

That will gain.

B

Some confidence, uh that's all from me, um do you have anything else that you want to talk about tonight.

A

Maybe one question I have uh what would be the process of becoming? Let's say, maintainer of this C extension.

B

uh Sure so to be a maintainer of the extension I think you need to be a maintainer of um open telemetry PHP. All of um but there is a there is a process.

B

um I can find and Link it to you, but from memory it's um you put in a proposal.

B

um uh You need sponsorship from existing maintainers, which is Bob and I. Okay, uh and then you basically need to point to your. You know existing contributions, which is only small. It's like you need to link to a number of um pull requests that you've made and issues that you've raised and commented on, basically just showing you doing things for the project which I think you've easily done enough um if you're interested uh yeah yeah. So so that's, that's! That's the process.

B

uh Okay, yeah, I'll, I'll um I'll find a link or ask Bob about it, but um yeah that that that's that's in a nutshell. I did this about one year ago. Now um so yeah it was it wasn't. It wasn't very onerous um and I think that you would easily meet the requirements um yeah just long as you understand it, I think you.

B

Well, I think technically, you you'd have to be a maintainer for like the main repository as well, um but if you were mostly interested in in the um the extent contain um you know, that's that's probably.

A

I'm currently interested in maintaining extension as I made some contributions to that already and I haven't done yet the contributions to to other reports in the regarding PHP. Of course. Yes,.

B

A

Yeah, maybe when I will have some, you know contributions there. I can try to also push the process for becoming I at least maybe approver there or something like that. But.

B

A

Yeah, okay, so currently I'm mostly involved in uh you, know in this extension, except the work that I'm doing in go instrumentation. Yes,.

B

A

Where I am already a maintainer, but uh so so that's why I am interested in in this extension. For now, yeah.

B

I understand uh so it's probably gonna be easier again for you. If you're an existing maintainer in a different um in a different sea.

A

Yes, so I'm I'm in go instrumentation maintainer, currently excellent.

B

Okay, um all right leave that with me, I'll I'll message both the other maintainer about it and just find find a link for you to to follow um uh yeah yeah that that shouldn't be a problem. I think: okay, okay, get that happening pretty quickly.

A

Okay, thank you, so you will send me uh some link or or I should.

B

uh Yes, I will I'll send you a link. Oh.

A

B

We'll send you a link, so maybe in the next one to two days: okay, okay, well Alice! It depends how quickly Bob's.

B

um That would help me out.

B

A

Right, that's exciting.

B

B

All right leave.

A

B

A

Okay, excellent.

B

Okay, uh anything else from you, Chris make.

A

No, that's! That's all excellent.

B

Okay, thanks very much for coming along and I'll, see you again soon.

A

B