Open Telemetry Uncategorized, 30 Nov 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-11-30 meeting

Description

OpenTelemetry PHP SIG Meeting

A

Hi Bob, hey Pacific! How are you fine thanks? Did you I'm doing? Okay?

A

Okay, that's good.

B

Hello favorite.

B

B

C

All right, it's five: after should we get get to chatting.

B

Let's get over here all.

C

Right, let me share my screen and I can drive the Dead.

C

Can y'all see my screen.

D

Yes, yes, well, all.

C

Right cool, take a look at open, pull requests; none! That's that's fun!.

E

C

We have 555 posts, congratulations everyone and it's a trip repo, but I saw this earlier. You have, um let's finish off PSR 18 Auto instrumentation is this: uh is this ready for review? Yes, I will take a look at that later today, it's going in my queue, let's see and then instrumentation.

C

This looks like there's a build debug image, an instrumentation. Is that ready for review as well.

E

A

So, regarding this one, because I looked already, I did um for me it seems that it's still some kind of intermediate step, as uh we still need to build um this extension and then around this test right, correct or.

B

A

So currently we are building only PHP debug version of PHP, and then we also need to to build this extension and run tests.

B

A

B

Yes, so because building PHP is fairly resource, intensive I have made this basically into a weekly job to which is also what we do over in the main PHP read book. So.

D

B

Week we build yeah the latest PHP debug image store it in a Docker registry, okay, and we we can just use that every time so there's also a change to no gamble, which is the Builder, runs on every pull request and every merge.

B

um So that will run against that pre-built Docker image.

A

Okay, so from this perspective, this pull request is complete right. Yes, okay, okay, because I was thinking that we need to add something here. You know to to run these tests.

B

No I'm, not that already happens.

A

B

This is an extra step which will build the debug image for use by the the the already existing tests in.

A

Build.Yaml, okay,.

C

There is that we have this PHP version set in stone here and then up here. It's.

B

No, we should remove that now. That's uh that was hard-coded to what was the latest version. Well, a sensible geekbone I should say. um But yes, please take a note of that. No I'm rude.

C

I love your bathroom there to find um identified in the most recent version of PhD. It's fun.

B

uh Yeah yeah thanks. That was my probably the highlight of my day working out how to do that technically.

C

Jq is great: yes,.

A

All right, okay and now I see it I missed this uh content of biltiam, but everything is there so.

B

Yeah, uh the only thing we miss out on this one which I I can take up in some other way, but we can't build it on eight two until A2 is released um because.

C

B

Yeah what it was supposed to be yesterday, uh it's now the 8th of uh December.

B

It got pushed back by I. Think two weeks.

C

E

C

We have any open bugs foreign. Oh yes, uh I saw this one Marco's finishing.

B

C

Like you're, collaborating with him on this.

B

uh Yeah yeah, he hasn't been back since I yeah like it's not fundamentally broken I, don't think, um but I don't know what um uh yeah it's clearly something wrong here. So I'd like I, would like to like to know.

C

um That's what do we call that pedicac probable error between keyboard and chair? It could be yeah yeah, it could be okay, um those are all the open, PR's and open bugs. The only agenda item that we have for today is uh what's the required for beta. Do you all want to talk about that.

B

uh Does anyone go before me.

B

No um yeah I think we don't have anything now before beta um we've seen a flurry of activity from me in the last sort of week or or two uh just trying to close off everything that I can and everything that I need needs to be done.

C

Yeah you've been doing an awesome job. uh Sorry that I was a little less available than normal, but I was just like. Oh another, PR, oh another Pro, another PR, that's great.

B

uh Yes, yes, and so the only thing that I would like to do is just basically do a pre-beta myself. um Okay um I've got a an example project in my day, job which is actually the whole reason. I was here in the first place, um so I'd like to just instrument that and make sure it works, see if I can find any lost bugs there and then, as far as I'm concerned, we uh we could step later.

B

Maybe we do it in the coming week.

C

Is in the upcoming week.

C

B

See exciting objections.

C

uh Objections for me.

A

B

B

Yeah, oh, we should probably take a moment to formally welcome preacher. Make us our newest contributor, officially, as of today or yesterday, all.

C

B

Thank you. Yes,.

A

B

Much for volunteering.

A

uh Thank you, it's great to work with you guys. It's.

B

A

It's great to have you.

B

Here I am I, I, barely understand the fixes you're making to the extension, but the fact that they're already tests there kills me with confidence.

C

um Oh, but I was just looking at this. um This is this protobuf thing still stuck.

B

C

B

Yeah uh sorry to decide: no, the the issue has been emerged. Are it just? They just haven't done a new release for.

C

uh There's one 16 hours ago.

B

uh You're in grpc Oh.

C

Shoot that's right. I should be in uh jrpc PHP, right, I,.

B

Know you should be protobuf.

C

Oh yes, uh what's the URL for that I, don't know yeah there's so many of them.

B

He gets a product I think it's Google, Creator buff, okay,.

B

um So there have oh that's pretty old, yeah 21.9.

B

um Yeah I I expected this all you know, even if there was a 21-10 it might not be in that and and it would actually go in if they're doing anything like semantic, versioning that'll actually be a new feature and we'll go into 22-0.

B

uh If you would ask the question, maybe just Shake something loose over in Google land, yeah.

C

I can uh I'll make a follow-up to pick my Google contacts about that.

B

'd be great, it all might just happen at about the same time. Php82, maybe a week and a half from now.

C

Now it's yep that would be lovely, hopefully.

C

C

Anybody have anything else they'd like to bring out today.

A

I I can only share a review. What I plan to do next few days so extend the coverage of this extension and also I plan to look at the pull requests and the issues that we have already in the whole PHP and start reviewing them.

C

You're talking about the the ones in the open, Telemetry, PHP, repo.

E

C

Sounds like a plan. Thank you for working on that.

B

A

Think I've got one.

B

um Sorry I'm, but you go first.

D

Yeah right this build image, it is for the PHP uh instrumentation. You know that uh the C code- basically, yes, if we have to debug, so that will be done by GDB, like uh in the basically the CLI mode, where we debug an.

B

Extension file, I, don't think or possibly, but no the debug image just has a lot more.

D

Debugging, as in no.

B

Not that sort of debugging it's just a debug build, has a lot more checks. Insertions in it I think um I will certainly notice that it reports memory leaks that a regular build of PHP does not, and that's probably the most important thing it's doing at the moment.

D

Yes and if we have to uh suppose we have installed the extension and we are working on a new framework where we are intercepting some functions so how we will debug the uh extension. Basically, the code, which is written in C.

A

So sometimes maybe it will be needed to uh to have a debug version installed on the I, don't know customer site and because, uh as you know, it contains uh additional um debugging stuff inside it. So then we can get a stack trace, for instance, if there there will be crash or memory leak or something like that.

D

B

So I I, don't imagine anybody. You would step debug from PHP over into into the extension um we.

D

B

The extensions are fairly well tested.

D

Okay, okay, then it's fine, just I was curious, whether if we are working on a new framework and if something is failing in the extension side, then how can we basically.

A

Yes, sometimes it's hard to process, you know to get to the root cause.

B

Probably reading stat choices and.

A

B

Cool dogs but report yeah yeah report report, the weird Behavior reproducible test case, yeah I.

E

B

Auto instrumented a couple of things and not fair to any issues so far. Fingers crossed but um yeah.

E

D

Happened if something comes yeah yeah all good. Thank you.

B

uh Oh, that's right. I have one more thing: Bob, um which is I, think the maintainers in the auto instrumentation repo, uh just a list of users and not a a group, so prismex not I, think a maintainer in that repo. Yet.

C

C

Transition Oh shoot, that's not sure.

C

So you're saying that there were, uh you said that there was a missing group or something.

B

Yeah I can just see your desktop too. Oh.

C

Sure they're on the screen- oh eight hours, doesn't all right. You see it now.

E

C

So we're looking to see um it doesn't look like I have uh I, don't have admin access in this.

E

C

Can ask for that.

C

You don't know what you mean you're talking about like um like you're talking about. We need a group like.

C

I can never remember where that is, but I know you're talking about like uh you. Can you have like your group, uh your tagged group of users.

B

Yeah, oh, is it just good, is it just the code on as well? Maybe that's what I needed to.

C

It could be, but one second, let me authenticate here.

C

Yeah you're talking about this.

E

C

uh I will um I'll see if we can get uh admin access for the instrumentation repo.

B

That would be great.

C

C

All right anybody have anything else: I want to bring up.

D

uh Not today we're joined after a long time, yeah.

D

Yeah I'll take up the task from uh this week. Maybe sweet yes, thank you. Yeah thank.

C

You much foreign.

A

B

Fabulous thanks all goodbye. Thank.

D