Open Telemetry Uncategorized, 15 Jun 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-06-15 meeting

Description

OpenTelemetry PHP SIG Meeting

A

B

A

A pleasant surprise.

C

Hello, kashan, hello,.

C

Hello, everyone.

D

A

We have a full house.

A

You g'day uh so uh just for your benefit, tobias. If you haven't ventured these before, we usually wait till about five past for any uh latecomers and then I'll kick off.

B

All right we're starting to get some extreme temperatures here, we're on the other side from here.

A

uh That's that's great for you. We have we're in the middle of an energy crisis and uh just as everyone wants to turn on the heating because of an arctic blast,.

B

Well, that's different. It was 30. You see here yesterday, so the other.

A

Side of that spectrum, yes,.

A

A

All right, I've got five pass, so let's get going welcome everyone, it's good to see so many people here today, um let's run through the agenda, which is uh first time, we've got open and pull requests.

A

We have a lot eight um they're in various stages of needing review, um I'll run from most recent um one of mine for event, dispatcher.

A

Can I share my screen, I reckon I can.

A

Nothing too incriminating.

A

A

Okay, can everybody see that.

D

A

Fabulous okay, so the first request is, uh is one of mine, which was uh event dispatcher, which I've based loosely on um on um on this one. That's been kicking around for a while. um It's really just it's a waiting. It's a waiting review, there's plenty to discuss um and and emails, hoping that you'd be able to find some time to have a look at it. Just because of you uh deep knowledge of event systems.

D

Yeah- and I can I can do today- I was away a few days or I didn't take a look at anything to apologize.

A

Okay, that's great so a couple of people have been across and have given um some feedback, but there's I'm sure there are changes. The improvements to make so uh that'll be most appreciated.

A

uh This one's been hanging around for a while. uh I think dr luke had issues with our cla and we haven't really heard back from him um whether or not he would like to sign it, but we can't accept the contribution. I think it's otherwise good to go uh without that cla so like we'll just hold off on that for uh a bit longer and see if his feelings change.

A

Maybe timo you could have a word with him he's a german. I think he's been wise, so uh conscious of our privacy.

A

um We've got uh one from kishan about updating uh quickstarts, uh let's go on.

D

Yeah, I'm sorry what to do. This is blocked by me. I'm sorry this! I should remove the block you can. um The only issue actually I have with it is that it doesn't resolve the tickets associated with this.

A

Yeah and- and I feel like that's just where maybe dr luke's, pr of just scrapping um at least 50- fixes that problem by just removing that um that quickstart and replacing it with the much better um uh example app. That.

D

We have yeah anyway, I can, I can remove the block, then you can decide what to do. Okay, that's great! Thank you! I'm I'm personally tired of this toxin.

A

Yeah yeah, I I think we've been trying to be very polite, um polite about it, but but I think, having having some better um example, documentation is just a a more politically pleasant way to go. You should say this is now deprecated. It's been replaced with this other thing um and and it's gone away.

B

Nothing's stopping us too, from if dr luke's is whining and complaining about the cio, there's nothing stopping us from somebody else, opening the exact same pr. I don't think that he'd have a problem with that.

A

uh Yeah yeah I'd be happy to be appreciate that one that's actually.

E

I can incorporate those dr luke's changes into my ipr as well. Basically, I just removed the symphony uh documentation file and provided a link to a different readme. I guess.

B

Yeah, that's perfect.

A

Yeah, that would be perfect if you could do that. um Yes, please do that sure. uh So we've got this one from yakuti, which I think um she's been getting some help with. um So that's still very broken.

A

um It's a draft. Well then, I keep going there.

A

uh Kishan, it's you again uh was there anything you wanted to talk to about.

A

ah I know what this is for so kishan, and I were talking about this and and we've got the side track with a side quest which was to implement a propagator factory um so that we can, uh with a bit of part of the spec that we missed up until this point.

A

um Did you want to talk to that at all.

E

uh Sure, actually, uh this is for implementing uh b3 single header propagator. The reason why I kept it in draft is this is similar to trace context propagation. There are four hyphen separated values. I am having difficulty in understanding the there is one parent span id parameter, the last of the parameter, and I am having difficulty in understanding that and what you mentioned about the propagator factory and all right. So currently we have two propagators trace context and b3 multi.

E

Both of them are implemented in api, and uh I asked brad about uh implementing the like. Where should we implement the propagator factory? uh We talked about it and I think sdk is the right place to implement the propagator factory, but I am still not sure. Where uh should we move all this propagator implementation out of api into sdk.

B

I think that should certainly be the long-term gold, and I think it needs to block you on this pr, but maybe it makes sense to do them at the same time,.

A

Yeah, I think, if you wanted to do it in two stages, just put the factory in the sdk um I yeah, I I. I can't think of any reason why the propagators should be in the api um according to respect.

C

They have to be part of the api right today, because um without installed, sdk propagation should still work, even if no sdk is installed quite sure.

A

I can't argue with that, um so what about our factory then? um So the idea was because there is a there's, an environment variable, that's defined, for you know which propagators you want to use, um and so we need to invent a way to actually have something generate propagators um and we're used to factory for similar things um previously, um so that you can define one or more propagators uh in an environment variable and have the code spin up and use your propagators.

D

Okay, then just implemented in the api, and um we have a look otherwise that's easier to um it's easier to move it to the sdk and if it shouldn't be better than the other way around.

A

Okay, that seems fair. Are you happy with that? Kishan? Yes, yes, okay, great.

D

A

uh Am I right to go on tv.

A

No, no, I didn't understand anything. Oh okay, thank you. um So this is another one of yuk jeez, which the ink was really. um I think it was pretty close.

B

Yeah, it was, I think, that she, I think.

A

B

I think that nevaeh approved it a couple days ago. I think.

A

B

Could merge this as if we want to.

A

We can manage that all right. I will. I will um I'll do that after meeting uh yep, that's great.

A

uh No kids, not with us today. um This is still a drought.

A

It's just back to.

A

Yeah we'll need to we'll just check this out. um I will try something up um just to just give them.

B

A

To um see if we can move this one forward uh and this one I it's just been much stale, I'm not I'm not sure if uh cuba is coming back.

A

Yes, I'm not sure if you're not coming back to do this or not it's, it's not being touched for many weeks now,.

D

Yeah, I mean that's, that's the same thing. Your pr is.

D

A

All right, uh that's it new issues. uh We don't have any new issues since, since we're maintained has created a bunch last week uh and in open telemetry control, uh just something's been kicked around for a couple weeks.

A

It's a work in progress.

A

B

I think it's it's relatively close. I think it's relatively close to done. I think that cedric just hasn't had time to do it, so we can wait on him. I guess it's not blocking anything currently.

D

Yeah um yeah, that's uh nice to have. She comes up with something good, but uh what about my pr? Did you ever close? It.

A

uh Do you have a pr in country.

D

I'm not quite sure I didn't finish the uh well. I can. I can have a look like yeah.

D

B

The butt actually worked surprising.

D

Interesting, okay, then just leave it like that. I will reopen it when I.

A

Okay, um does anyone have anything that they want to raise or talk about today,.

D

Yeah so um I've finished the last um bits of this uh instella command so that um I think we thought no. I haven't been here last week so on this command that will install all the different packages of which are defined in the repositories or from the composer files and creates local references so that so it's basically validating that you can install the packages with all its dependencies on the local um uh packages which are in the same repository. So that's basically what it does. um I have yeah, I'm nearly finished with it.

D

Then I will create a pr and then we can use it in the um ci process.

D

That's wonderful, thank you yeah, and so there will be a few little prs once I'm finished with that. So um for changing the commands- and you will see it if you have some time right or walk to click some buttons today it would be nice.

B

I have time to click buttons: okay,.

D

B

Yeah uh the one, the thing that I wanted to bring up today is: we have good news. We are down to 10 open issues for required for beta, which is great. I think we just got to start pushing them pushing through those.

D

Yeah and then once I'm done with that, I can um work on the stuff that I have still on my table. I think.

B

It looks like we all have something assigned on that uh in the required for beta grouping, I'm going to add that to the google doc just so that we always keep that front of mind.

A

Yep great idea.

A

um I won't minute that I was given unofficial approval to do some open, telemetry work um in work time, which is my suppose, my my university's contribution to open source great, that's cool.

A

Yes, I think I would get a little bit more done.

B

um Yeah, that's great news.

D

Yeah, what about um because we still have an unresolved meeting, so what about we need? Do you have time tomorrow the same time uh you and I yes, yeah. I think I think I do yes, okay, then, let's just meet tomorrow, then we can talk about all this conflict stuff. How are we possibly yeah? Okay, good good night.

A

B

A

Okay, once give me twice all right, we might be doing.

B

Awesome thank you for leading today, brett.

A

uh That's all right: okay,.

A

All right, thanks for your time, thanks for coming everybody, maybe.

E