Open Telemetry Uncategorized, 15 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-07-15 meeting

Description

Instrumentation: Messaging

A

A

A

A

B

B

C

B

Yeah, let's do it do you? uh Do you mind sharing today.

C

Yeah I'll share today.

B

C

All right can everyone see.

C

Yep, uh we'll just uh go through top to bottom assume, contrib again, uh instead of core. It's definitely a more busy one and I want to try out our new uh opinion code owners, workflow.

C

All right so, first one here something with data dog and an M1 Mac, maybe a test.

C

Someone was running a test locally.

C

um He took care of himself priority, two three on this one. What do you think.

B

um Probably a three with with it being a test on.

C

On a very specific architecture, agreed yeah, sweet.

C

Add host tag, some metrics on the service environment.

C

It looks like maybe uh Pablo's already taking care of it, so I'm just going to slide to him.

C

This is going to Ping, uh see.

C

I'm, just gonna get all these notifications for something he's already working on foreign.

C

All right, uh syslog receiver I, see some comments in here. So maybe.

B

That was just me: adding the uh the label twice accidentally.

C

I already like this workflow.

B

Yeah poor Dan on vacation yeah, getting pinged.

C

B

C

uh uh Let's see probably priority two.

B

um I mean if it's, if it's not working- oh it's probably higher, but I, don't want to hire I, don't know if this is like a user yeah either issue or if it's the receiver for everybody. That's why I just pinged down and let him kind of take it over.

C

If you want to just not put a priority label on it, I kind of hate going to this meeting and not prioritizing something yeah.

B

C

Know that's the problem with using priority as our triage label instead of the actual triage label. Maybe we should change that.

B

Maybe we need a like P unknown to make an answer that we've looked at it, but we don't know what to do with it.

C

I'm just going to do that right now,.

C

Can we make, can we make issues in this UI I can't remember yeah. It's probably over here.

C

You want to do that.

B

Like yeah, or maybe maybe priority needed, or something like that, to make it very clear that that's what he's waiting on, let's.

A

A

C

C

Is this person in this meeting right now.

B

Nope, okay, I should probably can you add a note to them. I I meant to Ping them earlier, but I totally forgot just add a note about attending the triage meeting and we can probably go from there yeah. It's not me, I'm, just a fly on.

C

The wall today I.

C

Sorry I missed that. Did you say this? Is you Matt.

A

No I said: that's not me, I'm, just oh okay, yeah, today, um I'm sort of engaging with open, Telemetry, broadly and just kind of doing a lot of listening. First uh I'm, one of the co-chairs for tag observability and see on stuff.

C

I have a link to this would be the best way to link to this meeting, because it's definitely not in our Sig anymore I actually have no idea how I found this meeting. Is it in the Hope intelligent group, open photometry, public calendar yeah, but there's no good easy way to link to it.

C

I'll look forward in community, then let's go look over there.

A

I've been engaging with the hotel profiles, effort as well, and so I wanted to learn more about the collector's current state processes. Workflows like the project in general, so I figured I'd just listened to triage for a couple weeks: sweet nice.

C

To meet you all nice to meet you as well I'm, just going to link to this calendar I hope it's on here. Yeah.

B

It's on the Google Calendar for sure, okay, foreign.

B

Just mention that if the time doesn't work for for them, we can always find a way yeah useful.

B

More than happy to welcome someone who is interested in triaging, oh yeah,.

C

What time is this meeting actually at it's at 10 and Pacific time? Is that right, I'm in Mountain, Time yeah? That's right, I'm not going to put a priority on this because it doesn't seem relevant yep.

C

All right per process, counters.

C

I think this person might be a neural customer.

B

Is is golden metrics.

C

That's a term yeah yeah, although I don't think I, don't.

B

C

I'll be honest with you since I've joined you where, like all I've done, is open, Telemetry, so I, don't know it probably very well, but I. Don't think these are golden metrics, but they could be.

C

C

Like, depending on how old this person is historically like.

A

Over the last even 15, 20 years, golden metrics always used to just kind of mean whatever the relevant Salient metrics, that a team is looking at in more modern years or recent years. Golden metrics is like you know, as it relates to you know, response count response lately, that's how we use them. No, that's the vernacular, but this person could just be like I care about these things right process level instead of microservice level,.

B

Yeah I think the Google SRE book is where I first heard the term golden metrics.

C

uh Let's see so adding metrics to receivers is pretty standard, so same problem with this.

A

Oh I see yeah, he says there. These can be considered. Process should be like should quote, should be their golden metrics, so he's making reference to the Google definition as an analogy.

C

Yeah I mean more more metrics that the host metrics receiver collects the better. In my mind,.

B

You want to add, like help needed on there.

C

Yeah I think that's a good one.

B

Good first issue.

C

I do always like all of the labels. Oh those are the good ones. Yeah I do like uh reaching out. Well I'll let the code- oh, it's Dimitri, all right he's out so I'll I'll reach out and he's dead.

A

Well, depending on, depending on what they want, I, don't know if I'm speaking out of term, but this could inadvertently dramatically increase the scope of the host metrics thing, like you know, like you, can have quite a lot of processes, and so, if they want to track metrics, another receiver might be the better place. But again one of the enough.

C

Host bundles in.

A

All process info as well, but.

C

um It does right now and and the uh it also has the capability to have metrics be off by default and then enable them when you want them. uh So I think this can still fit into the host metrics receiver. Interesting.

B

Yeah, there's there's different scrapers, depending on what metric you're interested in that you can turn on. So this could just be another one of those.

C

Hey there is a process scraper right now as well. There's a.

B

Process and a processes great.

C

All right, let's go, keep going poor Dimitri's got he's going to get pink so much because he's cutting around so many things all right. Let's see, processor filter this one's been getting a lot of changes recently, which is cool, I. Think a lot of people like this filter.

C

This sounds like an enhancement, not a bug, and that's so they use the right template foreign.

C

Pretty standard enhancement to the capability right.

B

Yep I, don't think so.

C

B

uh Without the enhancement label on there, too do.

C

We have one of those.

B

C

This should uh we should update the template, so it just adds this. If we're going to use the feature template for things right, yeah, foreign.

C

I love being able to just throw the process filter on there and then know that this is about to happen. Oh okay, well, PPM Sumo is gone but boost Chicken's still around yeah.

B

Yeah, it's definitely nice to not have to go and manually search through the code. Yeah.

C

B

C

B

It motivates us to add the right component label so I.

C

Got them all added uh I made a I think I submitted a PR for it, but I added a make file entry to this. That goes through and does it programmatically for all of the six things that we had labels for uh so we've got them all now. There's like 70 extra labels now we're up to like 200 and something can.

A

You send me a link to that. I need that for this project, I'm working on called landscape, Dash graph.

C

Yeah it's somewhere in here, it's cool uh off I mean I'll ping. You in later here it is make make file Target for trading component labels, some of the stuff that we've been working on recently by the way Alex the pinging code owners, the maybe allowing co-owners to add labels generating labels like this I was talking to.net maintainer, and he said that they would like to use those tools as well, so he was thinking. Maybe we should move these to I. Think there's like a generic open, Telemetry tools, repo, isn't there.

C

Some of this might be the build tool over there.

A

C

B

C

A

Tag contributor strategy, I can provide notes to it, but this was an active topic of discussion this month, like in two or two meetings ago. There's a work stream there to create tools for project maintainers and contributors to do specifically this, but they don't have an implementation. They've just defined the need, so this could be yeah. They can also disseminate it broadly across foundations.

B

C

B

C

Sweet well that case take a look there's a couple. Other drawers out here that are adding on to this. Paying capabilities. Take a look at those two. Some of them might be a little noisy uh and when it comes to like the amount of actions that are generated but could be useful.

B

I I will say, though, be be warned it's just a bash script. So you know yeah tested.

C

Yeah yeah I submitted that to make change log, one I was like well, it uses GH, so it shouldn't work. If you don't have right permissions but like I can't test it because I have right permissions, so maybe someone else can test that for me, for my own personal use, done it better than perfect. Thank you. Yeah uh see where were we we're down here? Attribute processor? That's a that's a great processor uh group at the zero with actions.

C

I don't follow, but I have reached out to this person and slack like they wrote they posted in the uh I think they showed up in the Hotel collector slack recently asking something about. This could be missionary remembering.

B

Yeah I mean this seems like just a figure.

C

His panicking right.

B

C

Yeah I think it might I just want to make sure it's not they're a bad regular expression that they used.

C

In the screenshot that they posted in a regex analyzer at the bottom of the initial comment, there's a regex analyzer that says the question mark is: oh I, don't think. Go knows how to do. Isn't the question mark like look at look ahead or something I know that the go doesn't know how to do look ahead. So this might not be allowed.

C

I can't remember it's working over here, though, so maybe it's just a bug. I, don't know.

C

I have no idea what to put the priority on this, because I can't tell if this is a the user issue or an actual problem. Some of you are new unless someone's got an idea, I'm going to put Priority needed on this.

B

Fine, we can mark it as needed. Okay,.

C

Grace Chad hey this: is you yep uh what priority would you like.

B

Like three sweet.

C

And I think that Trace gen is under Tools still there you go.

C

Add connection time with the client example. That's a so just the example. Demos.

C

This feels like question: maybe someone I wanted to use an example but isn't see the example is actually wrong, which is always possible or they're, not understanding. It.

B

Yeah I think I think the question that the first comment raise. That's probably what happened but I.

C

B

It kind of goes aside from the the issue that the user encounter, which is that thing they probably ran into like the grpc timeout, which is something like 60 seconds or yeah. Even longer so um I mean I, don't know if this is a real bug or not, because what they're suggesting is. We should fail sooner well.

C

Sooner yeah I mean I can remove the bug label, throw on it enhancement and or question label. We don't have a code owner for this, so.

B

C

Kind of up to us.

B

B

Yeah, like what did you expect to see expect the connection time I would I suspect it would eventually get a connection timeout that just takes a really long time.

C

Yeah uh is there actually don't know with timeout? Has to sorry, that's not he's proposing adding that.

C

This is a hard one.

C

I mean there's nothing wrong with adding a timeout to it so like we can throw it on enhancement instead of a bug on this and say help wanted or something.

B

C

Think that's fine I'm.

B

Just looking up the default timeout.

C

B

Oh, according to otlp metric grpc, the default timeout should be 10 seconds.

B

C

B

We have a different timeout in The Collector yeah.

C

We're just going to throw a low priority on this I think yeah. That's fine!.

C

C

C

C

Yeah I mean this seems like a please.

C

Underscore create to set I guess I, don't really understand what is being asked because I don't know this receiver at all. uh I don't feel like it's a bug.

B

Symmetry really the owner for this receiver I feel like that's incorrect.

C

I think so too: oh damn it foreign.

C

It didn't get it right.

B

For me, this exact receiver.

C

Why would it do that? Because.

B

It matches on receiver, slash Prometheus, oh.

B

I mean it can't because our labels don't match this right.

C

There this label should be exact now.

B

But still so what about Prometheus.

C

Oh well, that's my own fault, dang. It I added the wrong one. Whoops, sorry Dimitri.

C

B

Is it's just a missing? It's a missing receiver word after Prometheus that.

C

Doesn't yeah yeah because this is receiver forward, slash Prometheus receiver, so I need to update this label.

B

Foreign I mean we should be updating all of the labels to have the full path if we want to ensure that that isn't going to do a substring match on other stuff.

C

Our pattern's been to is to drop with my code owner's file, go there's our patterns yeah. So this one is just kind of this is kind of a weird name. It should be.

C

C

Yeah, our label is Right technically based on our pattern. Isn't it.

B

I mean sure, if you're talking about a pattern that we use in some places and not everywhere. Yes, that's correct, yeah.

C

Because our label pattern is drop, the word receiver and move it to the front.

B

Right yeah, it doesn't work in this case, though,.

C

B

I suspect, there's other cases yeah.

C

Probably I'll just ping them manually for now we'll come back to that.

B

Yeah I mean maybe we should just put the full uh directory name in the labels.

C

Yeah like should it be, should it just be considering Super Saver forward slash, should it just be a Zipkin receiver, Prometheus receiver, like.

B

B

C

Would solve the problem? Yeah and I think we went with this pattern because it's how we do our pull requests and our issues, but the reason we do that for the pull requesting the issue is so that when you come in here, you can quickly read the word processor, first right or whatever first so that you know what exactly the thing you're getting into but for the label. Maybe that's not necessary.

C

Yeah. Okay, we'll fix that later.

C

Should delete this I'll.

B

Leave it I feel like the the side effects of it have already happened, because the email has been filled with.

C

He's not even supposed to be doing no photology stuff right now, we're just constantly taking him.

C

Did I not oh I, didn't actually put any labels on this uh I'm gonna put priority needed because again, I have no idea. What's what's actually happening in this issue,.

C

I think this is the same problem.

C

Yeah I'm gonna I'm, not gonna, put the I might not put the label on this one. Oh.

B

It's it's got a remote Prometheus from remote right. This is probably oh.

C

So this one will work: okay, yeah.

B

It's a exporter.

C

C

Now I'm, like now, I'm paranoid that it's kind of ping the wrong the wrong code. Owners I gotta, sit here and wait for it.

B

I should have had like a a clause in there that if there's no owners, just pink Dimitri.

C

Yeah that I'll I'll prove that if you throw that out there, foreign I think aneurysm is definitely the code owner for this one.

C

uh Logs transformed.

C

That doesn't sound right. That would be a big bug.

C

Oh, that's not true, I mean it's probably true in what he means, but like it has the signal.

C

The fact that Dan said he's not aware of this processor needing storage makes me think that something else is happening.

C

But I don't know this. If this is actually a real bug, that seems like something that's pretty important.

B

Yeah, it looks like it's already fixed, though right, there's a PR that says fixes. Oh.

C

B

It says fixing, but it just missed the uh the keyword of fixes.

C

Oh so sweet so I can just say at uh I mean, should I just close. It yep closing.

C

C

Cool those are the best ones.

B

Yep and we're at time, oh.

C

Sweet uh thanks: everyone uh I'm gonna, go change, all the label, names I, guess Alex! Let me know if you've got any other ideas uh and then anyone else thanks for uh showing up and then there's some PRS out there that are around triaging. That uh could use some eyes thanks. Everyone. Thank you. So yeah.