Open Telemetry Uncategorized, 8 Mar 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2023-03-08 meeting

Description

Open Telemetry Meeting 1's Personal Meeting Room

A

B

B

Let me share my screen and.

B

Put the Tom and just say that you're going to be.

B

C

B

Can let me close my uh sorry for my windows, yeah I, think probably we can start with the specs.

B

I did have had a quick into the open, specs issues right now, I mean I, don't see anything burning which we for which we need any immediate changes or no like the first one is to declare the otlp stable.

B

I mean that's more of a cosmetic change uh just because of otlp grpc and otrp HTTP both are stable, so it's more of more because of that I think it's uh declaring it uh TLP as it holds, expects to be, but that does not directly affect us. Allow adding links after span creation. This is still under discussion. I mean it's not yet merged, and this is something which would be important, because this will break our APA. Our API and probably I think we should continue to follow this PRN.

B

Make sure that the current log Bridge APA SDK does not prevent future addition of the end user facing log API I mean this is important from C plus plus perspective and I think this is only important from people's perspective, not for any other language, because most of the languages have their own standard blogging framework user facing login framework.

B

So probably some of the people are kind of not in favor of supporting the end user facing log API as part of this tricks, um so I think it. This needs uh probably could that as C plus plus Community, we should also put our words here. I mean I I'll comment on this, because I think this is important from C plus plus perspective.

B

If specs comes up with a end user facing log API- or at least it does not stop any other language specs to come up with their own end, use any other language to come up with their own, their own end user log API I mean this. The spec should not block, but for any language which does not have their standard login framework to come up with their own API.

B

So that's something important I think from C plus plus perspective, not for other languages, so yeah I think probably I'll comment on this, but yeah feel free to add your comments and views on this.

B

Schematic units should use UC um case sensitive variant, yeah I thought initially that this may need some changes but looks like it's only for the semantic convention. The units for the instrumentation I think it's should not directly affect us now.

B

So, apart from that, I think, let's see any any earlier inspects issues which we want to discuss.

B

Okay yeah: this is already done. Rename.

B

B

Okay, I, don't think this needs any change right, I think.

B

Okay, probably I need to look into uh if it needs any change in the naming at least.

B

Okay, I think probably I'll just mentioned this with this anything first selection item on me. Probably let me see.

A

B

Should we quickly look into the pr everything that we want to discuss.

B

Open television, page adjustment and that looks fine I had a quick link into this and.

A

Yeah, so it's some documentation but uh Patricia.

B

A

B

B

Add Mark as a maintainer, a thanks Mark for watching for this um and.

B

I mean I I, don't see uh in general any issue, uh but probably I think it needs more wider discussion. uh Among Us uh in general I mean among all four of us, so I mean the concern I see as of now is that I mean if we see our current, we probably will go ahead.

B

I mean there are four active members as of now asan, Ming, Tom and Mark you, and the only thing I see, is that if all the four active members are maintainers- and we don't have any uh probably any active approvals, although we as a maintenance, we have been doing that approval. So that means there is no active approver uh in C plus plus community, uh so that, from that perspective, I think I just see some concern here. But that does not mean Market is not something directly uh for the fitment of being a maintainer.

B

I I. Think that's not something that probably which I'm talking about it's more about that. If all the poorer maintenance and all and being I mean everybody being maintained, would mean that everybody will try to give the direction to the projects. Lots of people are trying to uh your directions, will not be a healthy uh setup for the community, so one option could be: let's I mean, as of now I think we all probably seems for be doing fine and looks good to be a maintainer.

B

If we should have some kind of rotation- probably let's I mean I, don't know whether that's just something I've been thinking. uh If, if one or two of us can be approved for some time, and let other two can be the maintainers and then probably have a rotation of that, that's something could be one of the options but feel free. I. Think I'm I've been thinking about this for some time how to really do go forward on this, but feel free to give your thoughts on this.

B

How can this be done in a more amicable way? It's okay.

B

So but yeah, let's discuss that I mean I, don't think we is something we should. We can decide in this meeting, I think probably let's discuss and that uh in that PR, which you have raised uh I mean in case. We want to discuss it there, and uh so probably, let's discuss it, there I will and and that's that's my thought would be I think it would be important, as a maintenance probably would giving more I mean. As of now. My concern is like right now for Matrix I, don't think we have.

B

We have more people who are giving Focus to probably giving a direction to Matrix area. Also, and also in the logging area also would be something I think one at least as a maintenance I mean not for new Marketing in general. We should start taking more focus on that areas, because I think, as of not traces, are more kind of stable. You know there are not much of the issues in that in the basic cases, signal, mathematics and logs I.

B

Think probably I had some concerns, as of now uh so probably I think it would be good one of the areas where we we all can as a active contributors and as maintenance Google can start focusing, but.

C

Yeah regarding this I think.

B

First of all, thanks a lot for your contributions. You have been doing, I mean I, don't I I do see uh being you as a maintainer in the right direction, uh not something which I see. This is a concerning, but probably as I say, it's more to discuss, I mean who should be there. I mean I mean having enough right enough people in both maintainer and the approvals.

B

Please feel free to add your comments on this or or add it in the pr I mean, as you want to talk.

A

um Just an idea, maybe Mark could take over like logs part ner.

A

Well, they'll so well, three main parts to look at for the functional part which are Trace metrics and robes um I'm, also looking at other things in general, like the build.

B

A

We clean up in general uh security with uh TLS things like that yeah.

B

A

Also, some orthogonal things which are not not only functional.

B

A

Matrix and logs yes, we can. We can specialize in in some areas also.

B

Yeah I think it's totally not not to not know not to I mean the work which you have been doing. I think definitely that's very important um on those areas from instrumenting convention, DLS I think those are very, very important areas. I mean ABI, tooling and I mean not don't want to say that those are not important ones, I mean along with locksmetics and places so um but yeah.

C

B

This I think over the call I mean, let's, let's see if one of us I mean I I, just want having a uniform uh distribution across both maintenance and approvals that that should be my. That would be my concern, uh I mean uh so we'll probably discuss it here and I. Think, let's finalize it in the next meeting, or probably some sometime next week. How do you want to how do we want to proceed on this?

B

B

But but thanks once again for watching foreign.

B

B

I mean I, don't probably probably been fixing I mean fixing the automatic convention manually could be one option, but I don't think we should be doing it. I think if it's many convention that right now, anyway, experimental yeah.

A

Yeah, if we do it manually, but it would be.

B

It would be taking a.

A

B

A

We we have time it will only become blocking when the cemented conventions for metrics are finally in respect, but it's it's not there yet. So we can read.

B

Yeah exactly now so I think, probably it's good to wait for that. You know during context, and and this is specific to CPS place or other community or other teams or would also be facing.

A

I was the first one to notice, but interval is also impacted and everyone else should be impacted.

B

Okay, I think, then probably it won't take much if it's in general. All other teams are affected, then probably foreign.

B

And make it contain all symbols immediate. Now this.

B

I will have.

B

To look more into this somehow this the problem which it is going to be it is solving I mean I use. This setup I mean all the time like building grpc as a state as a static library and OTL pre-cpp as a dynamic Library, and the problem is basically coming and that scenario so I mean at least I was not able to reproduce this, but again the original or sort of the issue. He says that this is fixed with the changes um and I mean in general.

B

The changes looks okay to me, because if we are trying to link a static library with to a dynamic library and that Dynamic library is not using any of the symbols from static, Library I, don't think those symbols will get added in the dynamic Library, so I think. Theoretically, the changes looks fine to find, but I don't know why I was not I'm I'm, not getting this issue, so probably I think I have not been reviewing because of that material. It's like probably uh we can review it and let me see it one more time.

B

And there was another similar issue raised for Alpine, also and I tried these changes with uh to see if that fixes the issue in Alpine, but I think the issue was still coming so yeah, probably so. That means both are the different issues. This one is different from what the other people always.

B

But yeah I think it's probably have to need to look more into this.

B

Yeah yeah ebi capture.

A

Never be merged uh I'm working with a tooling for the API track, and but tuning needs to compare two things so uh I'm doing a build with a current version and was to those two PR where to capture Arabia as it existed in in one zero and one seven. So.

B

A

Was just to execute something in CI and upload a file at the end. Okay,.

B

It's not going to work, it's just to have a base same base, probably.

A

B

Compare here yes,.

A

And one seven is because this is when metrics went to ga.

B

Okay, uh add Force Plus for all log record exporters in Spanish exporters um yeah. This is the change, looks oh, this is done for span. It's portals on smoking, okay, yeah, fine, I! Think that this looks um in general. It looks okay, I mean two or two to the extent where I even viewed it.

B

um If you can just look in general, okay, I just wanted to have a more closer look on the implementation for async is for async HTTP exporter, LP, async exporter, part how the force plus is happening. It's not bit query sure about those changes, so I think that's the reason why I'm not have not reviewed till now.

B

Yeah, but probably I will have a look under these on to those in these changes as well. At least the icing part. That's not very straightforward. I, don't see much issue in the rest of the changes. It just adds a dummy, Force, post, flash method for all the other exporters, but I think for async HTTP exporter. It's doing some cancellation before doing the flush or some something like this. Probably that's htvc.

B

B

Yeah I think this is anyway nothing. It's blocked and I think it's blocked already so yeah you can keep it uh from it. Primitives exporter, sanitizes invalid characters yeah. This is I! Think yes and it's with you and whenever you have time your rest are the old ones.

B

And I think this is still not worked on the TLs.

A

B

And I think there's one one con concern and it's a valid concern and I think that was something probably I have to be aware of this. This PR uh I think probably it was my mistake. It should not have been merged before the release.

B

I I did merge on this, and this is kind of breaking change and at least I have been facing this. This issue with some of my eight libraries now, because.

B

As those I mean, the build of those libraries was assuming that open Telemetry would be installed as part of their own build, but now now I see that's not happening. So I have to add this symbol. This semic option to install open Telemetry, so I think this probably would be a breaking game for others. Also and.

A

B

Is it because of.

A

A default which.

B

Yeah, so uh in law with, if we do make install if you was installing open Telemetry by default, I mean. But now, if we do, if we do a default c c make of uh you know, maybe we default cmic with open, Telemetry and I.

B

If I try to do say, make install, it will say that there is nothing to install just because everything is guarded with this option and all the install rules are guarded with this, so we have to explicitly enable open Telemetry installed as on and then only you can install Ubuntu yeah, but I think this guy is correctly mentioned. That uh default should not be on, but I think we already.

A

B

Release and if we again do a new release that will break the earlier release. So let's keep it, but we can add it as in a release summary that this is something which is going to break if any of the builds are. Assuming that open Telemetry would be installed as part of.

B

It yeah I think that's all in the PRS. You know for the issues you can see right here.

B

Unless somebody has seen that quickly, Global log Handler usage may lead to undefined Behavior yeah I. Think old has rightly mentioned that we should have I mean first of all, yeah I mean should not be using uh Singletons in general, uh which is which is the right um which, which is rightly mentioned here. But then again uh we have tried to fix all the scenarios where this can cause a problem by ensuring that it gets cleaned up uh after the shutdown and at least the shutdowns are not going to use this.

B

Those scenarios should have been covered now, but probably let's, let's hear more from him if he is still able to reproduce any of the issue with log hand, that is not available when trying to do a log internal problem.

B

Yeah I think this is below it's locked here. This is yeah this we already have a PR for this, and I was talking about another issue with alpine, which is this one Linker edit when facing so I thought, probably both are similar, but it looks slightly enable.

C

B

Matrix SDK I think this is something which we can start now, uh probably I think it's with me, but feel free whenever you want to take it up. Otherwise, I can take it. Take this, as that would be it to also detect API EBA, non-compliant changes and integrate with CI yeah. This is the thing we already discussed that add unit automatics into instrument, selection criteria.

B

Okay yeah: this is yeah I've got it yeah, so you we should be using unit also as part of the instrument. Selecting the view. The correct view for instrumentation View.

B

um Okay, this this is for the Avi breaking changes, yeah I. Think probably we thought that we'll wait for this. One uh I will probably have have a API breaking release when there are enough API, open, Telemetry, API, breaking changes which are going to break the open, Telemetry API, so yeah. Okay, probably we can um create for that. Blue one I know that there would be one more issue which would be ABI breaking I'll create a issue for that. uh That was basically for instrumentation scope. The get Tracer will be modified.

B

uh Get results should should be able to take the attributes for instrumentation scope, so that would also be a API breaking change. I'll create a issue for that. We need it both for Tracer and Matrix, so it would be a Avi breaking change, definitely for both the both the races and Matrix I'll create an issue for that. We'll probably mention that in this foreign.

B

B

But this doesn't know this is just a placeholder. If, if the next release does not have any area will have been create a new issue for the next seven days.

A

Yeah, so it's it's just a placeholder uh so well for the links uh in Trace. We still need to wait on respect to see if there is a breaking change or not, and for other things. Yes, we um it would be better to put all the all the changes at once in the summary is.

C

A

The meantime uh we also need to to have some tooling to verify for API, vibi, check and stuff, like that, so that we already will returning when this happens.

B

Install necessary header files only basically.

B

Yeah I think an organization it has wanted and we already have a PR for this. This we need to review it.

B

Yeah Tom I think just have a look into this issue or you have to do something on this.

C

B

Out of boundary exception, this is on me, I think I have to take some time to fix it. Ringing error we already discussed, we Move the Jagger exporter. Okay, we do we have the timelines. Now. It's.

A

Well, I will now that we just release I will submit appear for this. One.

B

B

Okay, uh this is I, think probably it's okay, I said Mark here. So in this probably nothing urgent, nobody wouldn't want to see and I think Tom. You were talking about this. This was the issue which you were probably uh were discussing.

C

Yeah yeah I think so yeah.

B

If you, if you if this is something which you needed urgently, probably you can pick it I mean in case just see the priority. You see the priority. Anything is okay, yeah separate text path carrier into your this again, it's the EBA ebi could be a potentially where we could change and itself wanted.

B

ah This is kind of blocking I, don't I, think uh yeah I think this should be maintenance block if it is still open.

B

Okay, I think we don't have anything here: okay,.

B

Okay, with this also mentioned Help Wanted conflictive movement library- is already installed, so probably that's very possible yeah. This should be fixed I. Don't know why it should be equipped because I can I can take it over here.

B

Only have it in I'll probably fix it.

B

And it's totally fine to fix it, just because Exemplar is right now behind feature flag, so I don't think it should break anything.

B

uh I don't know we have to still do anything, but I am supposed to comment on this well I'll see how to comment.

B

Yeah I think that's, that's all I'm, not sure yeah. This is I, think probably have a look as on whenever you have time. uh This is with ovent when you arrested the old one, probably if not discussed we do have to do cleanup when I keep on talking about that. Probably I have to take take time for that hello, yeah and probably let's go back to the business item.

B

Okay, nothing pressing this meeting convention yeah, we already discussed API check. Also, we discussed okay, yeah I. Think this also we discussed correct me. Mark I mean if you want to add anything more or want to discuss anything more on these.

A

uh No items and just warning that uh the next two weeks, it's a weird time for for the meeting between Europe and the states, yes yeah,.

B

Yeah thanks for adding it. um Hopefully it should be fine, I think it's getting people for for you guys. So hopefully it should not be issue, but just let us know because it causes any conflict.

B

Separate login API from hotel log back and API uh yeah.

C

Yeah and it's just that awesome.

B

C

Yeah country I think in our local header. Actually we mixed the backend API and all the like, we say, frontender API exposed to user, like the user, is free to use either like email log record, that's supposed to be back in API or other log method. We put that in one class right and according to this bag. The the backend API is I think only for internal implementation in that form should not expose it to user right or application.

B

uh It should be exposed to users. These users will not be the the end user. These users would be somebody who is developing uh a.

C

Backend uh exposure or a vendor yeah. Yes, yes,.

C

B

C

Application to the developers should not it's not supposed to call them directly right like to call new log record and emit local record like that. Yeah.

B

C

B

I mean we don't stop them from using I mean we don't stop anyone any end user to use this as a logging API, but I think they should know the limitations if they are going to use it. Yeah.

C

We don't need to like prevent them from calling, but I think in concept. We should like say in separate namespace or separate header file to say this is public and some internal.

B

Thing you can, if you like,.

C

To call that's.

B

Let me know if you want to be official, we should reopen it. uh Let me see.

B

And we're going to reopen it because I think over and said that we don't need to do any changes, but probably I think as you're saying that we may have to okay.

C

B

Change the name: okay, move it to different namespace. Let's reopen.

C

Okay, let's continue to discuss.

B

B

Please add your comments. I think, that's probably fair enough. We we can keep it under API, but have a different namespace that also definitely yeah.

C

B

Be some part of the options we can do it here.

C

Okay, thanks yeah.

B

Okay, yeah anything else.

B

If not I think thanks, everyone for joining uh have a good rest of the week. See you next week, thanks.

C

Everyone, thank you. Everyone bye.

A

Thanks everyone bye.