Open Telemetry Uncategorized, 16 Nov 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-11-16 meeting

Description

OpenTelemetry PHP SIG Meeting

A

B

uh Hello prismac: how are you.

A

Fine, thank you and you I'm.

B

A

What's what time is on your side.

B

uh It is just past midnight.

A

B

Pretty late, it is yeah yeah, daylight.

A

B

In the US is very bad for me,.

B

We'll make it a quick meeting because it is bedtime in my part of the world mm-hmm.

B

A

Feeling it's just.

B

Going to be you and I today.

A

I've seen that you approved this pull requests on a PHP instrumentation in PHP.

B

A

Could you merge it because.

B

Oh yeah, yeah I um sometimes leave it because I'm not sure if someone else wants to review it.

A

Oh okay, okay, I.

B

Think the tests pass I.

A

Think that's yes!.

A

um So I didn't broke, you know the code, so everything is passing and it's also this one additional test is also passing. So, yes,.

B

I, did you add a new test as well.

A

No I haven't added a new.

B

A

The test I mean the test that the top buyers has wisdom. Yes,.

B

uh This test- yes, yes, uh yeah, that's on by me, let's oops school should merge that right now,.

A

Done? Okay, thank you.

B

A

If someone will have some additional I, don't know comments, uh we can add another PR to.

B

Yeah, of course, yeah.

A

So so I think that it's good to solve this one by one and making very small changes.

B

ah Yes, I, agree, I, agree and um because because tobiasis went some group failing.

A

B

It's it's obvious to me when they're not failing.

B

um All right, let's get started, uh we'll just try and get through this get through this quickly. I think um so. Open pull, requests, uh I've actually just put one in this morning, which is still a draft, um but I've worked with some feedback on it's to.

B

um It's to remove this sort of like a an undocumented dependency between uh the SDK and and con trip, which is where all of the different factories for for everything are sort of known um yeah. The SDK needs to know about all of contribute to be able to be able to build them. So this breaks that out into a a registry um which sort of works but uh yeah wait for some feedback uh there, which I haven't really asked for so I, don't think anyone's noticed. Yet um you know everybody contribute.

B

We've got one pull request from you. I saw that you have updated it.

A

Yes, so I uh implemented your suggestions.

B

Okay, um I'll take a note to to look at that. um This is where what would pin it somehow that I'll just uh write down on a piece of paper um but I'm going to do that um uh either after this meeting or or tomorrow. My time.

A

B

B

So I'll do that um it looked like the tests with violin, but it wasn't anything to do with your code. Yes,.

A

So the tests that are failing, guy related to a AWS I think yeah.

B

Yep, it's not a problem. um I might have to have a look at that tomorrow. It's probably because we did a release, it's a breaking changes in it. uh The other day.

B

New issues um so I had an issue today, which was just a speck of what it's being like a small one for somebody to take on. um We also got the other that was two weeks ago.

B

um Okay, that's to do with the symphony SDK, which I I, don't personally know a lot of symphony. That I am I've left a note there um I'm, hoping that Dr Luke can look at that and hope to solve his own problem, because I, don't I can't fix that uh and then one that came in uh oh just a few minutes ago.

B

um I'll send you a quick look. It looks legitimate, but I haven't really haven't really looked too much further than that.

B

And then we can hope that someone picks it up. Otherwise, I'll attempt to fix that uh in the coming days. Okay,.

B

um Required for beta we actually uh as far as I know, we don't have anything oh, except for we do have one thing for beta, which is what to do about our versioning, um Bob and I have chatted about that and um sort of started, a discussion on on slack, um which has a really got a lot of traction yet but um yeah.

B

So that's that's um in progress. Okay, um apart from that, I, apart from the sort of one word request that I'm looking at um I, think I am I fixed everything that I want to fix before we consider uploading, so um I feel like if I once I get this. um This pull request merged uh we push on to to Beta.

B

uh Is there anything that you wanted to talk about.

A

And now I, the only thing I can add to is that I will be continuing work on fixing this to those but I'm fixing this test that the buyers are dead. So I think that we should have all these fixes in few few days from now. So then, probably we will be ready to push this extension into background I think, but.

B

A

Maybe maybe we will have to discuss that um with Tobias and so on. Yeah.

B

Yeah definitely um yeah. Where did you say, push it into.

A

I mean this: is this uh storage, for that is used for PHP extensions. It's pecl right.

B

Yes, yes, yes, yes, yes, sorry, I, I, yes, I do know what you mean. I guess pickle is probably where it should end up.

B

I agree: um yep, that's yeah, we'll push it through push it through beta, um and hopefully it gets lots of testing uh from people very soon. um Maybe what we'll do is um which allow me to tag a new version, all right. The versions don't really mean anything at the moment, but um I can certainly protagonally release of the auto instrumentation.

B

Library or extension, but I suspect people are just installing from Maine anyway,.

B

um Yeah, let's leave that um all right, so there's nothing else from me.

B

um There's nothing else from you. I will um um actually I've probably got time to look at your other pull request. Okay,.

A

B

After this meeting.

B

Oh all right! Well, we might be done yes, excellent, quick meetings, a good meeting. Thank you for coming along, so I didn't wasn't here all by myself, president I appreciate it.

B

Okay, all right, I'll, talk to you during the week.

A

Okay, thank you. Okay,.

B

A