Open Telemetry Uncategorized, 13 Jul 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: 2022-07-13 meeting

Description

OpenTelemetry PHP SIG Meeting

A

B

Everybody good morning.

C

Actually, it's 5 30 p.m. In india, yeah.

D

Yeah, so it's always difficult to uh determine what to say so I I I take a page from brett mcbride who's on this call. He usually says good day because he's australian he's good we're in india.

A

uh I'm in gujarat, do you know mumbai.

D

Oh, very uh not enough to be dangerous.

D

I said I don't know it enough.

A

Okay, I am on the western side, western.

A

So our office is in bangalore, so you might have heard of bangalore. Yep.

D

Yeah, the first company that I worked for, I had an office in bangalore too.

B

D

Hello good morning, good afternoon, good evening,.

C

Hello good day, everyone good day.

D

All right, it's five pass for me. I guess we can get started good day, everybody. Let's take a look at all the openings that we have.

B

D

Can you all see my google docs window, yes, cool, all right, so open pr's? I have a handful of open, pr's right now, uh bret your event, dispatcher one is, I think it's uh about ready to be reviewed yeah. Yes, yes, it is okay. I could take a look at that today. um Nevaeh um auto product shutdown.

D

See looks like you approved this one bro. Are you waiting to merge it for something.

E

uh I think it's back to under discussion. uh Yeah.

D

Very good, okay, let that one ride a little bit uh the metrics implementation. It looks like it's still. A work in progress. uh Exporter for metrics looks like still a draft um sean's b3 propagator. I would expect that this one should be ready soon, but not sure and sankey looks like you had some open dialogue with team out.

C

uh Yes, uh so I can see uh some comments from tobias and.

C

Tmo, so I'm trying to resolve okay.

A

Sounds good, so I have a question regarding that vr. Can you go a little bit up.

D

Is there a specific part, you want me to search for.

A

uh Yeah, so uh I guess tobias is saying that I need to remove all the catastrophes uh from the policy interface.

A

Yeah, actually, the the reason I have kept it here is because I need those uh methods in the uh exporter side. So uh anyway, I'm using the instance of uh police retry policy, but I am using the uh you know the reference of the retry policy interface. So if I don't have this camera setter inside the interface, I am, I won't be able to use it in the exporter side.

A

I don't know if it makes sense. Yeah.

F

But the um exporter should receive already configured policy and not configure it itself. No sorry, I didn't get that um the user will inject them already configured retry policy into the into the exporter.

F

Which can be done in the constructor? There's no need to have these setters.

A

Yeah I I can, but uh I mean uh what I'm saying is that I need the getter at least I can. I can remove the center. That's that's true, but I need the getter, because I need some values inside the exporter using this retry policy interface, reference.

F

The only cutter that should be required is the get delay getter. All the other values should be not gonna run for the exporter. I think.

F

Sorry should only require access to the computer delay and up to all the configuration values.

A

uh No, but I mean.

F

Should we try the other methods are not used in the exporter.

C

Okay, okay, sure sure yeah. I got it very much yeah sure I'll I'll change that.

A

So we will have to uh so. The interface have will have two public method uh delay and uh get delay, and should I try next.

C

Awesome. Thank you.

B

D

Okay, tobias, I sort of just scrolled through your pr's. I'm sorry did you have anything that you wanted to add about the automatic shutdown or the metrics implementation.

F

um The multi-shutdown I'm currently writing it to make it as an opt-in. The user has them to specify that he wants to use this behavior.

F

Which should is the best solution, I think, but yeah as an example, I would would be used. This would remove all this magic. That could be surprising for our user.

D

Yeah would what do you think these uh you said it's surprising for these. What do you think these would expect in this case,.

F

uh Again, please.

D

I said you said that this would be surprising to a user. What do you think that user would ex would expect.

F

That uh exporter shutdown, when he called shut down instead of get sometimes getting shut down on script and sometimes not.

D

Yeah shutdown has like a pretty explicit contract in my brain, but that could also just be my perspective, but I agree with you.

F

For example, I always use it in a symphony bundle, um setup on boot and shutdown in bundle, shutdown, so yeah, I guess most applications have some specific boundaries for setup and shutdown. I think that's very.

D

Seems reasonable to me.

B

F

And for the matrix implementation um would need a general review. Okay, I'm still working on some points, but overall it should. The concept will stay the same.

D

Got it yeah this um I think, brett gave you a review already. I noticed that you had some tasks up here, but these don't look super super necessary for a few, so I can give this another. I I read through this once, but I can give us a pass through with a more fine-tooth comb today.

E

I also have time to go over to go over that one again uh right after this meeting.

D

You, like my task queue up here. It's just pinning tabs for review.

D

All right uh do we have anything in the contributor still that instrumentation around all, that's it um bugs. I don't think we squashed that one new open book, but that's about it, uh has one about.

D

All right, nothing, nothing increasing insanely like that. I think.

E

First, one's just being fixed the covers.

D

This one yeah that's right.

E

Just merged it.

D

Okay, so should we close those, do you think yep closed all right? We only have three bugs that's pretty cool.

D

Then um I think we only have five tickets left required for beta, which is really exciting, looks like um I think only two of them are unassigned. So that's extra exciting! Well, we'll uh I'm going to make a note about that in the channel, because that's something that's worth celebrating and evangelizing to try and get help for the for these last couple of issues.

E

I think I can take one of those and just add a comment and close it, because the error handling one. um We discussed it's configurable enough because it uses a psr3 logger and that's what that's what java does so we can turn things off at filters, control, lock levels.

E

Or you could do it right now.

D

I'm all about efficiency rep.

D

Do it all right? It's done! Okay! So now we have four issues required for beta, that's very exciting, and only one of them is almost unassigned. So I'll make a note about that in the channel, because that's something we can emoji dance all around.

B

D

So those were the the normal part of the agenda. Does anybody else have anything they'd like to bring up this morning afternoon evening.

D

Going once doing twice all right: well, thanks for your time, y'all, we'll uh we'll catch! You on the internet, see you next week.

E

B