.Net Foundation Design Reviews, 24 Apr 2018

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: .NET Design Reviews GitHub Triage

Description

00:-03:-55 - Approved: SignedCms extensibility to support external private keys https://github.com/dotnet/corefx/issues/26406#issuecomment-384009048
00:05:10 - Approved: Add FileSystem.Watcher.FilterList Property https://github.com/dotnet/corefx/issues/29273#issuecomment-384014580
00:22:43 - Approved: Public setter for System.Diagnostics.Activity.Current https://github.com/dotnet/corefx/issues/29207
00:32:59 - Needs Work: Consider Span(char) overloads on Regex classes https://github.com/dotnet/corefx/issues/24145
00:34:07 - Approved: New Zip LINQ Tuple Overload API https://github.com/dotnet/corefx/issues/16011#issuecomment-384022447

A

Kathy, let's get strength, we will show up at some point.

B

So you still find pursue the item, I suppose right which one, whichever I, got to see a list. Everybody.

C

B

One of the last ones.

D

E

F

See you see is private.

G

D

H

I

Is Billy what you don't see? What time's the invitation.

C

I

Was like Hannah three two hours.

A

Before oh good um see my psychic, so what does we have in life? Yeah see mr. here there's a constructor. You want to add.

F

Maybe should be named private keys. Thank you.

F

Does anybody care if it's a default, which would look like for my existing constructor or just make it a proper over its proper overloaded? What does know.

A

F

F

Can't think of a reason why we make the last thing be an optional parameter, but I'm just playing.

A

Devil's advocate so you're, not client, there's no property. That would expose it afterwards, all right. So what happened? What actually happens with the deposit, but does it get sorted it Igor?

A

D

So why don't we just close it.

F

You create it to pass it in to sign into the objects.

D

It just seems good everything else get at it.

F

It's easy enough to add a like read-only property, but it is a.

F

Of course, now we need to make the property.

A

D

This is fate, let you type this shows up. It'll be so you have to move to it.

D

D

It seems check that so I think that, as do it, who.

F

Come up with the name, public property, yeah.

A

Exactly what the put that I got a name right, I think this would be weird document to this. Only is that, if you get this one absolute and then it just.

A

J

And I, don't think people started doing the commercial Scripture still reward the effort. It's.

K

Clearly worth the effort, all right, sorting, key.

D

L

D

L

On the call to write.

D

L

Ever it is on the column. Yes, you want.

A

To talk to that.

L

One because, since you pilot before we have more context, sir.

A

Hello: egg yeah. We hear you just speaking yeah.

M

Should I, like briefly describe the API yeah so like in, like the phone I use filesystemwatcher to like to monitor any changes to the to a particular file system or, like particular part that that a user has supplied and currently like, we can filter?

M

We have like a filter property which helps us to like filter the files in the file system to look through like, for example, if we just want to take a look at or t like dot, txt file or dot CSV file, we can just add a filter for set the filter property to do that. But if we want to look like if we want to specify more than one filter like if we want to look for two extension or some other combination of regular expression, we are currently not able to do it.

M

So what I like we can like go from work around around this issue in two ways either like in the event handler itself. We, like we, we manually, do that in the event handler thing or we can like set up the multiple instances of filesystemwatcher and like and and stitch them to the same event handlers, but that's not optimal, because we still have to manually. Do it and we diffuse the purpose of having the filter property in the first place.

M

So what I suggested was to like that, have a filter list where we can specify a like collection of regular expression, which needs to be monitored which which needs to be monitored for, while watching the, while monitoring the file system.

L

It's not regular expression, it's the it's! It's not even the windows.

N

Standard, it's the simple matching. There's the question marks in them right. The answers so does given like API.

A

Supported, or do we basically sorry invitation just motivates the user.

N

So it was just it was just changed. We got from the 22.1 stuff, we have our own match or what we did already actually for for that. But now it's a non allocating one and we just made the change for the windows side to the filesystemwatcher to not allocate until it's gone past the filter there's an open issue, that's an routes working on for doing the unix side as well. So this is a particularly noisy thing for our partners, like.

N

A

Get that but I'm trying to get it. Is it like it's? The truth'll is the native concept on the other line pal watching ape. You know we.

L

Don't know but like we're.

N

Getting back a buffer and that allows us to walk through the buffer and not allocate a string that isn't gonna be used or necessary. Oh.

A

If you have like directories like you know thousands of different file extensions, you don't have to do creative gymnastics to do the filtering.

N

A

N

And that is explicitly a problem to give you to give you one concrete scenario that I don't think Anna root knows about, but you know they.

O

N

Have a whole bunch of problems with a watcher you know, one of which is that you know that buffer has to be pinned for the white time of the watcher, so they were having problems. They were starting up so many Watchers that they were fragmenting the heat movie.

N

Is they they changed that, like five or six years ago to like move the walk move like a shared watcher of the stack of the directories and now they're running into a problem where they're getting so many events that it's actually choking the system as well, because you know people's cache directories and stuff are showing up and we're allocating strings for everything which is less than ideal.

N

This is part of a you know, a moving forward. There are other things that can be done but like this is a simple one and there's also a prototype polling watcher, which is you know, the different characteristics where we just you know, look at the the state of the file system on a regular basis and that's something Christoph had come up with and we have a community member working on that right now in in corvex lab.

N

But it already has this pattern.

L

N

Someone manage it and you can speak to it, but I prefer filters.

M

Yeah we were using like.

M

System, diagnose dirty diagnostic process, so I just you are using the same convention there. We were using arguments and argument list. So that's.

A

Why I change I don't have.

M

Any preference we.

A

Use list because the problem is arguments, the regular proof was already taken by the string property right. So in this case you don't have that problem. It seems Jeremy spoken like yeah for collection.

P

I will just use a plural for the you know for the most part, but I mean like Wes, just asked whether we should use everywhere else in this process might have a basic, a search pattern or something like that. Yeah it's already. The existing one is filter. Yeah, there's already something off faucets right.

N

And sadly, there's also another filter.

Q

Wow because I see some of our start off PDB and other there's a sexy like well, but I think that was in this pipe yeah.

M

Q

Should be started I'm like yeah, you could look for just dot XE, but you wouldn't get any results. Okay,.

R

So I was wondering.

N

Q

A partner is just extension, based. No that's why it's just a it's just the same verb, wildcard that you would get for the enumeration stuff. It's standard wire players, not regular expression, whopper right. Yes,.

N

Admitted to be super specific because we had our own implementation or copy of the of the matching algorithm, which is the one I then moved into a file system. I specifically made sure that this one is the simple matter, so it doesn't have any of the weird DOS matching behaviors. It's just question marks as one characters. It's the simple matter. We may expose the more complicated one later, but I doubt anybody would really want it.

Q

All the filtering ourselves correct you over we're just basically getting all notifications from us and then we'll turn incorrect through the OS.

N

Does have no, they don't actually work, do they they don't have. They don't have filtering for file names, but I think they might have filtering for different types of events, but I may be remembering that incorrectly we we do filter that too, and so that may just be. They have no filters, but in any case you know, there's the UNIX stuff to think about, as well as which also passed stuff in a buffer, at least the normal UNIX max.

A

You provided is that data reason whether property needs to be said. It I think it should be I.

N

Don't think so either, particularly because Android wanted to derive from collection, I believe was this plan so that he could change things that are added as they're put in.

L

Selling impossible.

A

Sitting because I mean I mean you can still make it work right menu, but you said you just unsubscribe from the old guys and whatever, but like it's okay, if you want to derive that you're kind of screwing yourself. Yes, because there's no way you can enforce particular type in everyone, so.

E

Yeah I would not make it.

A

Edible I will just make it only that's it.

N

Bro yeah and, like my other suggestion, was to add a constructor overloading to it.

N

M

Like I think, the constructor now makes sense like if it's the property is more suitable, then we will have to add.

S

M

N

Top of that, if you I don't you'd, have to do some gymnastics there yeah.

M

N

You'd have to have the conditions in there for the you, don't want to instantiate one of those things and then throw it away, because somebody sets it as well. Yeah.

M

Like I did in the code, but the is really messy for the sector property but like the moon, the constructor will be a breaking change like I tried, adding I never able to like, as you suggested in the comment, but still it with the null call was ambiguous.

M

Like that's what that's the reason that I move to the set around you? Rather just it's just a read-only property.

N

So our current constructors are empty string and string string, yeah.

Q

So you're doing distinct for our partners like yes and company, but there's no way that, yes, is that are going to get this change, we're not gonna. Add it's.

N

Not no, it's not true because, like there is a there's, a sidecar thing that we're discussing with them to basically provide a Microsoft file system. Internal thing is a temporary thing for the next videos. We.

Q

Think that this is gonna really be much better than them doing the filtering themselves. Oh yeah, why? Why do you, how occasions, underneath that we change process and washer that watch what's up if we change filesystemwatcher to do less allocations, yeah yeah, it's using span underneath right now, yeah.

N

Well, I just said the windows, one is the UNIX. One has just needs to be finished, but I just changed the windows one last.

Q

Week, so, even if they did, even if yes attempted to take this day, we're all set to take a dependency on the slow span, correct, put allocations or.

N

What's killing them, so it would be because the it's not just this thing, but there's the there's the enumeration as well.

Q

So I have some theories about whether or not BS can really success by taking dependency on it and this what yeah, but barring that I, don't.

N

Have issue at I free, the trigram is to win, they can is, certainly you know still questionable. You know there is. There is a plan that like or a possibility that they made get some of these things through the mechanism I mentioned further than the next version, but it may end up being two versions. If that doesn't fly for I quit the way we expect it to still other people can use it for sure.

N

A

We got them two constructor so like the problem is with now it is ambiguous right. It seems like there's these a lot of people that used to all of the text to the strings at least another framework.

A

The question is we care and then even if we do our scientific talent, then what do we do with an implementation? Maybe try to construct this filter because in the end of the day, like collection of tea doesn't have an ad range. Even if we give you the iron will overload it's not that you can do substantially better I! Guess right, you just do a normal for loop and then you just add the items sure.

N

I guess that's a rational questions. It's we don't have an ad range. Do we collection, like.

A

It is weird, though, because the collection of tea I think there was another item at some point where somebody talked about that, adding that ability I mean it make sure the detection of doing maybe did enough for I. Don't think we know.

M

We don't, we don't have an ad range.

A

And it is very weird because they're.

J

Their money there used to be maybe a constructor that allows you to pass. It I think that it's actually true yeah.

Q

So you can basically pass in an affray or whatever compound olicity initialized.

N

Well, one of the things that we can do is like is we can look through the rest of this the options and things that were looking at adding for the polling watcher. Then we can just table like adding a a constructor until we have like more arguments.

N

It's possibly or I want to change the matching type or allow you to specify the the explicitly specify the casing matching matter fact, that's probably one that we will add because right now you cannot you're stuck with the default.

N

Like changing what type of match like, we only have the two right, but like the more useful one is the is matching the is whether or not it's case sensitive or not.

N

In that one we probably would want to add it's really relatively trivial to do, and one can see people really caring.

N

So I'd be happy with just like cabling that one and.

L

He added one more eigen is later yeah.

A

I guess there will be a separate program.

M

There there is one more point about using how to interpret the filter property once the filter list. You still.

D

M

Like Dan was mentioning like Valerie, we should return the zeroth element or just set a return, an exception. If there are more than one filters, I.

A

I would not do that I would say you can either decide to I mean in this case it seemed that you can route through this perfectly right. If somebody sets the filter, you clear the filters that you set the filters to the to the one item and somebody's adds more than one filters.

A

M

I should just return the first period. Somebody has added more than one filters. I.

Q

Think you need to make a list, so why can't we just do sort of like a delimited thing, the starting there on the filter stream? That's a string property right now. You can do start.

N

At P to be Center cause you get really.

Q

Long ones leave after like splitter.

N

Q

Well, but you can split it behind the scenes in. However, you want efficiently whether do we need to expose to syrup parallels a second one here. There's.

N

A lot of places where well, actually, we probably would because every single character is valid and in UNIX outside of the null character, so it would be really kind of hard to delimit it. Yeah.

A

I mean it's true, though, like following questions like I'm thinking. If you look at the file dialog, for example, like this other property, there is a string and it's basically pipe delimited right, and this is crazy thing we have. The first item is the attention. Sorry. The first item is the description that you see in the dialogue, but the second one is the actual list of extensions I. Think they're, like I, think semicolon did or something, but that the list itself is piped.

A

Limited I mean like there is some priority, although I always printed things like that, because it's kind of like you know a me elevate, its embedded because it were too lazy to give you a collection. um What.

J

The club I- don't this- is just simple stream, so there's no lecture day, the Union Assoc well, except for the part, is Jeremy said when you want to search for fun like by itself escaping yeah like yeah yeah,.

N

As a matter of fact, a matter of fact that the filter algorithm the take is takes escaping. So, if you like there, there's no there's no character available to us to use.

Q

So I mean there's always easy dilemma new schemes double pipe. Is you know pipe things like that? I also.

F

Just embed bolts.

N

The way Windows does it list of strings dominated by two nulls, all TSP, you know I, you know they're, generally speaking this. This API is really tolerant. It allows you to set things to null and whatever else so like I'm, totally fine with, like the one weird case being that if you have filter set and you get filter, you get the zeroth element outside of that I. Think, with what mo suggested makes sense.

N

Is that if you good, if you actually set filter- and you have filters- is that you, your collection, becomes the one item you know set the zero. You really have to try hard to make your code not right. I,.

Q

Just don't like the fact that we have two properties and people weren't necessarily know, but usually one or the other, essentially I,.

N

Understand that if we didn't have, if we had something well, both of those minor concerns like if we hadn't, if we had a rational delimiter, that we could use in this case, I'd be less disinclined to have it and the other one is like really trying to cut the number of allocations down. So if you build a really ridiculously long list, we're gonna split it all up and then allocate, which is entirely possible.

N

Q

Allocating anyways, if you put a filter list, somebody's okay. Well, we're not allocating new strings is that's the thing we have to do. Somebody is when they're putting it in bliss sure that they're doing is they're doing it. One suppose was doing it a second time. Oh I suspect we would only ever allocate them again once they if they reset the filters.

Q

N

So they could still be like 20 30 40 of these.

F

L

No more that starts the washing process right. It's immediately washing right, no.

N

L

N

Events, the naval reasoning, events.

L

Does it, but this they do have to call this every time or is it already armed know if it's not on until you didn't enable bridging events, then maybe we could actually do what we did on process and just say if both were set.

N

And I thought about that, but like given how tolerant this API is about getting knowles and other things. That seemed a little odd to get very aggressive.

A

That you know you have I mean another thing: people will actually pass this guy around and they'll create the property directly. So maybe it doesn't matter that much.

N

That's my expectation to I. Don't, like you know well, I, can see somebody like taking arguments were for asserting a process and like manipulating and all the way through, I think it's much much rare to like people to be passing around the file system. Water.

A

M

If we like are tearing the list, should we keep the first element list like the star while character star, or we should just tear the whole list and set it to no.

N

M

N

In him, that's an implement like as it stands right now. If you set the filter to null, we set it to.

M

P

N

Should never be null, you should always have yeah, there's star or whatever they specified is the first item. Okay,.

P

A

I just would never change the Bayeux, you assign the property. That seems very weird if I said hope with you too now, and then I merely read it back and it's not as soon as that seems kind of weird. No that's the way it already is, which is.

F

Nothing like behavior.

F

H

Guess that's sort of the behavior. This would be yeah time to get out the prime machine again. Yeah.

A

I went crystal just in case all right.

T

A

T

Think so the bottom line is that, especially when you.

T

Hello, this Sutter didn't a lot before.

T

Down there, that I really would like to have it like as I separate rare API, but.

B

Controversial I.

A

Mean Ted current and you have a currency really weird.

R

You could hide a different method, but the capability to set the car is.

A

A

Mean there's nothing more than a pilot property that is incedible I mean.

A

What's the current design for turn like is, that is that supposed to be thread say.

O

It's from local, so it's a saying is a.

C

O

Oh sorry, yeah, okay, yeah.

C

F

O

F

That's actually why.

F

You can embrace no because if any, if any of the methods read it more than once, they can now shear across the center. So anything that ever reads this needs to make sure that it's only reading it once inside of it, because if so I don't know what the API is. But if activity has, like instance, that runs out current is the top-hat. The method reads, one current and then the bottom half reads a second that was actually not thread safe, and that means a static violated. The thread safety sure.

F

Why do they change those balls? Oh because it's because it's okay, so they would have been G all right now, I guess if they call it callback yeah. If some of the stupid things like I'm sure like it's the thing that they could have before when it wasn't set up Oh.

U

Get me but I think we gave it up, did.

H

U

Static assignment.

A

Y'all know people can just give them rope. Alright,.

S

Alright, so now can.

T

You take the the bottom, an American missionary from Stevens out. That seems.

T

R

U

B

Wrong I think it's um here's. The training.

A

How to be in a schedule, profession, step.

V

F

Just used it, he made a batch data for each. Oh, my.

V

Does it have to actually this much fun he can run into it? It's an enumerator you have to. You, can only.

L

How you can enumerate enumerable.

A

Yes, yes, is it compiled.

L

Item into the call.

A

So that's the problem they've proposed is that that's the only way for H, which makes.

F

It extremely ugly well because so you can for each so the enumerate the innumerable pattern. Oh!

F

No, because the numerable pattern is, it will call they get a numerator that has a return type that has.

J

F

A

Think the only thing we could do is talk to this compiler grants and ask them to change the rules for the compiler or say will pull me not because they already have to match like seven or eight different shapes of the diluent. So that's already complicated as hell, but like you could imagine the world. You know this method called get made you do later or something that it will prefer that over getting so.

F

The only way that do it is if there was a property that returned a destruct value that wrapped this that had a get a numerator that returned the enumerator. Okay, do it with the second, oh.

K

A

Say a particle with that code here.

F

Like if they added a if we added a property on concurrent dictionary, called like valuable all I just returned a numerator of this, then you can now for each value. It gonna mean method right sure, I mean it just needs to be a a callable thing that returns the new Internet.

F

No, no because it would need to return. We need to return.

L

To destructor this, yes, we have another struct that would all it had to have a good numerator method.

A

F

You would have concurrent dictionary to each a value, a new world and the numerator. It.

H

Have um that but yeah if we cared about making.

F

B

F

A

See what this day.

A

And if that's what we have to do so PA this one collection, type, I, don't think it's that much, but it is very. Unfortunately they go on that hat from adult.

S

There's something to prove a PSI, but it seems to be working again well before.

A

It was it, this is always the screen where it's like I think depends on your name.

F

You would email go to it first, that you warped it up.

F

Of course, not even answering me.

K

A

These flags willing, on the methane.

M

V

Well, you know you around the property in business, yeah, there's point to the methods, but I don't know. Maybe they have. We have Grover mapping, but.

S

F

Well because it looks like reflection, has method, semantics attributes, so that's admitted system, reflection, mode yeah, so.

E

I mean that that.

F

Means that this attribute is a theoretically apply to something, and since it says it's a target or razor remover said it or other that public.

A

The interview tends default non-reserved to reserves. Three wizard for reserves mask especially.

F

Suggested it says that the getting underscore, who knows that it is a I.

K

Thought that's what I thought. So it's only it's on the property definition.

A

There's a property accessories English gives you essentially get her.

F

That's the forward rare, so that's from the property. What method is the operation of get then? Apparently the semantics is on the method. There's an attribute that says: I am again that doesn't necessarily I thought. There's a method could actually potentially sure I.

J

Don't think the most languages.

J

Dear, you wouldn't be a getter and setter, but you couldn't do it.

J

Forget it from one of the properties.

A

So like so the way it works in IL. Alright, you have, you have the method, definitions and then you have probably definitions and those are effectively there's another table between the basic gives you they accessor us right now and so I thought. Because of this mapping, you may set up an end-to-end mapping between the properties of the events right, so in theory, metadata would allow you to say, there's one method, and it's swerving like these two properties over here, because.

C

They're just associated with.

A

Each other so I, don't think they're the actual wall there, together or cetera, is actually on the property. Oh I think it's only accessories themselves.

I

In veneers, the.

U

Three to five.

G

F

No, the Google for poor.

F

Tech made a national pool three three five.

G

What Eknath out that.

F

Goes offline, okay, hello and welcome to LACMA international org. This site is temporarily inaccessible. Let's say translating in French I speak Bonjour, Bienvenue,.

O

All right, then, get ready good options. Let's keep that one we do busy.

O

T

Basically, I think shortcut to create tuples from two lists of Hawaiian marbles. That point we.

O

Already have X's things that thingy, oh my god, it's already yeah perfect, take it. We need enumerable and forever.

O

They have done the bank discussion under this code is a.

O

D

T

Anymore, like those yeah, sorry the last one, then the regex is probably with the result. Disbanding yes all right. Oh.

O

E

A

Tell you online right, yeah.

C

K

Does they do yeah.

C

If you look at examples, you see that if you pass the option, it removes the empty empty strings from it.

A

So we already have it screen, one will be done so already xsplit, but we don't have projects with options. Is that it exactly yeah? But what is you like.

C

So the current behavior is in the table below the output column. For example, when you split one two, three, four, five, six, you yeah, you will get multiple results, because if there's no, no nothing on the left and nothing on the right which it can splits, then it's just a pants and three pants, an empty string to it and expected behaviors, usually that you just get the element back. If there's no delimiter.

A

Starting very super pattern and then you say: use the input which.

O

Could be peter-patter could be a vector E Plus, which case.

O

Why the second.

T

Flaw in the one two three four five: six: those empty strings on each side, always it's like before. Oh it matches this regulars can use. You will speak for votes after the trick.

O

Maybe you're right why the spectra is e plus give you empty street at the beginning, at the end, because.

T

O

T

Matches something and gives you off before and what's after, if you'd have this exact, the same whole string, then it's kind of crap, a behavior that it gives you the empty I'm dis drink in the beginning, at the string at the end, but.

W

There should be plus can't match.

T

The t-shirt that's.

W

Like it doesn't.

T

W

It matches the entire string and then gives you an implementation is like. Oh give me whatever was before the match and after the match the fact that it happens new, nothing which means empty string. It just returns that which is crappy. Oh so you're, saying effectively the behavior currently is. You will return.

A

Multiple groups always, but we will always include one for whatever, was before, and one whatever was after the pattern and that can still be empty straits.

C

Yes, that's the behavior.

O

C

It's similar to a string split, because spring split also has two options. You.

S

Have the option to basically exclude empty streams.

T

Focus constricts, so, looking at just this one example, the default, it makes more sense. The.

F

Problem is on this, the top row. You can tell that you meshed in the middle all right, then you can't tell the bottom two.

F

So if you call split- and you get back to things- you don't know, if you had a prefix or a suffix like a she's program here,.

T

Just trunks all they're, like you at least one to match and which one do you think always index one and it's always the match right. So what I understand I think? Why do you so? Why you see you can't take those apart, bummed.

F

It like I, guess I, don't understand the use case of the API, but if split right now always gives back three things, then the match is the middle. Will.

C

Not be just, it will be I'm, not not just free things, and this the free things are just in this example. You can also get five ten or whatever, so you get the amount of splits in the pilot in limited.

F

Right is it always every other one was your match and every other one was an index. So what does that do? That would give you.

A

O

The four six one and then you write, know this like deep loss. But ABC is the prefix yeah.

F

So every other one was your match and every other one was not yeah. So this is useful. If you get rid of the empty string, you don't know if you miss any trauma so much is it the person? Is it that.

W

Means you like.

F

Your people want to use it and they want to call it. They think they can extract semantic information just looking at it once you can't tell what your data is lost for that.

T

S

Would you use it.

C

It's like I would say it's the same, like string split, I I wouldn't divides the data just by by the index, but I would just use the overload if I don't want to care about the empty entries. If I just want to shout without empty strings, I would use it.

F

I'm looking at that table, it tells me that I would never understand how to use this API I. Think.

A

I think you're confusing two things. Basically, so what ends up happening is think of think of the regex. In this case it was this one right. So basically, what you're saying is these guys here are logically your separator right, yeah, so replace this with a comma yeah yeah.

F

A

W

Called zetaclear, so you don't you.

F

Don't care about this, this thing at all wait! Well, the problem is the commas, are semantic elements in the array, so what I care about it? They aren't the commas but I, don't know which ones aren't the comments. Well, because.

A

We're still asking you all right because basically will be it. So what you really would like to get, then is this yeah now I understand, yep I think that's.

J

A

Having ones in there so the way it would work right now is actively it's every other item right, yeah.

P

F

Q

Do you care about only the not matches you see.

S

It's like another.

Q

Good option for the regex but options: it says that the things my daughter, but it's drinks, it's the things that match by the water here essentially so.

T

Because what you're gonna do, for example, let's say you have like two millimeters call command semicolon so you're in the regex one of those, and you don't care about like hey, you know like in strengths but like if it was at the beginning or at the end of journalist districts I mean it's still. You know.

F

Symmetrically valid.

C

One more thing which is important this if you don't use the brackets. So if you don't use a capture group for the limiter, you won't get the result and you won't get a result.

Q

C

So if you just use backslash T plus, you won't get the numbers at all till.

S

You get all the.

T

C

And suffix and you'll get in not just the prefix and stuff yeah, the prefix and suffix of each and.

T

Is it okay if it returns, and it is array in that case, is the host works.

T

It'll return to be only come on and you just flip them come on and.

U

You're skating, like you're, doing up this Jay, get anything at all.

Q

What, with this new option, you would get it down to today's if you get any string string string that split if.

F

You go string that split against the empty string and tell it to split on comma that ignore empty. Do you get back null or the null array, the empty array or iterate with the industry? And what do you can have it has a conical mine there I see me get it empty.

T

Right back what, if you just want empty.

T

Yeah, so those are good corner cases to cover and make sure it becomes are some business trips but examples even if.

F

We think whatever tricks but does cuz, then you can normalize your yeah.

F

Yeah so I guess, if the normal use case, is you get a new string, 0 you're, getting a few.

F

V

F

U

A

Then just something that makes it just all right, I think the autos time now.

A

Feeling productive already thanks guys online.