Ethereum Cat Herders EIP Editing Office Hour, 13 Dec 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: EIP Editing Office Hour Meeting 8

Description

Agenda: https://github.com/ethereum-cat-herders/EIPIP/issues/197

A

Welcome to EIP editing office, our meeting a I have shared agenda and chat again here for reference of people. uh So we have two authors here. We can start with PR number 6059 over to you. Sam.

B

All right, so, let's just share my screen here.

B

C

B

So I think 6059 is basically good to go um just a few grammar things and, like uh a comment about the word, propose in the I think it was in the abstract um just because it's not a term I'm familiar with and um I think if you're introducing something in your PR uh or in your proposal, you need to Define it before you use it. So just that and then it should be good to go.

A

Okay, that's great I, just I hadn't seen the last comments. It was just a few minutes ago right, yep, okay,.

B

We'll get that done and we'll let you know, sounds good awesome that.

D

Was fast thanks.

A

All right, uh the next one is uh pull request, which is waiting to be merged into a final proposal. The number is 6076.

B

Sure, let's take a look.

C

E

B

B

Okay, so let's just putting it in HTML, fine.

B

Yeah, okay, that all seems good and then so what was the rendering error here? So this is 45 19.

C

B

Oh yeah, it just doesn't pick it up here, but it does here. That's really weird.

B

Yeah well, okay, so now, let's just see how the discussion is doing.

E

B

B

Comment was resolved.

B

Yeah, okay seems fine to me.

B

E

B

Hear: okay, yeah.

E

B

If you want to um I'm just curious, if you want to merge it first as like, as last call without changing the deadline and just make sure it renders correctly, and then we can move it to final um just because once it goes final, we generally don't allow changes. So it might be best to make sure everything looks good before um before going to final.

B

um But if you're, if you're sure it'll look good, then I can merge it like.

D

Sorry for I have a very bad level of English and.

B

Can you repeat more slowly, please, oh sure, sorry. So, uh once the proposal goes to final, we no longer allow changes. Yes, um so it might be a good idea to um make the HTML changes without changing the Status to final.

D

B

In different pull requests or uh yeah, so here I can, um if I do this and then do.

C

Do that and then.

A

A

We may want to change the last call date again, because this is already December I'm.

B

I'm just suggesting we don't change anything just so we can.

E

B

It renders correctly and then like later today, I can move it to final okay.

A

But for moving it to final, we might want another PR right, yeah.

B

We will definitely want yes, yeah, so it'll be like we merged this one. With this suggestion, and then we make sure it renders correctly and then a new PR to move it to final.

A

All right so yeah Javier when it is merged, you can immediately create another pull request to move it to the final status yeah.

B

I just want to make sure everything looks good before we go to final.

E

A

Any more question you have Javier.

D

B

No I think yeah I think I. Think this, um because I remember reading this, uh like initially I think it's you know, it looks great I think you've done a good job on it. So yeah foreign.

A

Thank you I think we have three more proposals which are waiting to be moved into final. The next one is six zero. Six, two PR number 6062.

A

B

B

E

B

B

Must point to a Json file that can confirms yeah, so this needs to say.

C

B

I think otherwise. This is fine.

C

B

Right so we have 57.57.

B

Oh nice I mean I'm. Okay, with this.

A

Yeah, we have been waiting for this proposal for some time.

B

I love moving my own eip's to final, it's great okay,.

A

Congratulations: yeah.

B

481, so what's this one last call for six months should be final already yeah. Probably what do we got going on in here.

C

B

Yeah, okay, so let's just eats some.

B

Some help here so.

C

This needs to be foreign just.

B

C

C

C

C

C

Okay, oh God, damn it so. The author needs to be removed.

C

C

B

Then that's called deadline. Http.

C

Remote foreign.

B

To a particular commit.

C

So then we need a paranoid.

C

C

B

I can't suggest on this one.

C

um That's fine, that's fine! Let's be changed! It's fine! It's fine!.

B

It's the actual thing: it's like.

B

Yes, capital c.

C

C

C

C

C

B

Is that the right one, let's find out nope, that one's merged it is 1691.

B

B

There's that most we need yeah foreign.

B

A

So yeah we have now three more review proposals. If you.

C

Would refresh that yeah.

B

C

B

All right, what's going on here, it's review status, yep.

B

Approved what needs to be changed here.

B

Now is this a okay, so this is four nine three eight.

C

B

A little get no data, so that's easy enough and.

B

That's infuriating it's one line too far away. Okay, so.

B

Okay, then we have um so you're linking to 4844 and let me guess 4844 probably has dependency on 4938. It doesn't. Okay.

C

C

E

A

So a question here: some uh this eapw bot is a designed in a way that for required section proposals which are in final starter should be there or in any uh active status. Is it.

B

So it's like there's like levels here: I can pull it up here. um So.

B

Here it is so it's a kind of says here, like a final EIP um can link to sorry a last call. Eip can link to last call final withdrawn living. A review EIP can link to review that, like it kind of defines like an order uh of which they're allowed to link to each other. So as long as um you're in the same level or or below you're allowed to like do it.

A

um Another follow-up here: why withdrawn? Because where John may or may not have reached towards the final status right.

B

So withdrawn is is terminal, so once it's withdrawn, you can't take it out of withdrawn again.

A

Right, but can we have that and have that proposal in request section, because that okay.

B

I mean maybe maybe we shouldn't but yeah- uh that's probably uh but.

C

What can you withdraw Optical draft, or can you withdraw after review? You.

B

Can withdraw whenever you want yeah whenever.

A

Yeah yeah, so that's my concern here like withdrawn. uh That does not uh like it is an abdominal status, but it does not specify that proposal has uh reached to the status where it should be and it is eligible for being. You know in the required section.

A

I mean maybe maybe a different uh discussion for a different day, but.

B

Yes, it's yeah, that's something that we should probably make a rule about like an active EIP. You shouldn't be able to depend on a withdrawal.

C

B

Yeah yeah, it's interesting, yeah that'd be worth it like an issue somewhere. If you wanna write it down, what is a living uh living is what eip1 is so it's like eaps get updated, yeah.

B

They, don't you, don't see many of them: okay, okay, well,.

A

Thank you for sharing that was interesting to learn about.

C

B

All right, so that's easy enough.

B

C

That was 30 61.

B

60 31 rather now point four four okay yeah, so this is the one that needs to happen. First, um what's the problem here.

C

B

Okay yeah, so it's just a.

B

Yeah, so I should go back to the other one and remove that comment.

C

What's this one.

B

I hate that you can't.

B

Delete comments: if they're attached to a pull request, it's annoying; okay, so 4844! So why isn't this one going ahead?

B

So status change? Okay, this.

C

B

Okay, so if the only problem is.

B

Yeah, so it's a similar thing.

C

C

C

E

C

B

B

B

All right, so that should help.

A

Maybe we should look into 1691 if that is a blocker.

B

Yeah I can't uh I can't merge it. It's my proposal.

A

Okay yeah, then we will discuss it tomorrow. Let's see if any other editor may watch it.

B

Yeah I don't actually know why um nobody's approved this. It's really short, um okay, so we're moving to draft.

C

B

Yeah, okay, so it's just missing.

E

C

B

So 4K checks based on timestamp.

B

So, what's going on with this one.

C

C

B

Yeah, so access doing a pretty good job on this one I, don't think yeah.

D

B

Just still being worked on, so we can move over that one universal router. What is this.

B

All right, what's going on here,.

C

Okay, so we can assign this.

B

uh Wait we have a the markdown thing, we're supposed to use now right, let's go and find that.

A

B

um Well, for now, I'll just do this and then I'll.

E

B

It out, but I remember: um Matt was talking about creating a hack, MD file to just keep track of the number. Oh.

A

Number, yes, that's right!.

B

Okay, so this should just be 20.

C

C

C

B

B

C

C

C

Okay, motivation.

C

B

C

You need four ticks.

C

C

Let's see it's okay, you probably want to make this.

C

Okay, that's what it says.

B

The contract you versus Reddit.

C

Okay, that's fine and then.

B

B

B

All right so there's Universal router.

A

So uh Sam it looks like author for a pull request. 6076 have made all the changes that you have suggested. If you can maybe take a look again yeah, you can probably merge that.

B

All right, so so, why didn't you merge now? Because.

B

Okay, so over here my little.

C

Clear pan Pips review I think.

C

B

That I think this should just merge yeah and then we will take a look at how it looks when it's rendered.

E

B

To see the pages deployments anymore, they always they always disappear.

C

B

Okay, we'll have to come back to this.

C

A

All right so just to make sure the next step for the author here is to if everything goes, fine and the page rendering as well, he has to just make another pull request to make the status change to final yep.

B

Assuming that everything renders nicely exactly.

C

A

We we have been joined by another author and the pull request. Number is 5135.

A

In the draft status, it is.

C

C

E

B

B

The standard did you have any specific questions or um should I just go through this.

D

uh uh Thanks Sam, uh you can just go through. One particular question is about calling calling the these ratings a token uh or just ratings.

B

um I think if you want to call it just ratings or whatever that's up to you, um I I do see where panda is coming from, but as if you just tell them, um you know we'd like to keep the name ratings.

B

um He should clear his review um because, like we, we can't force you to pick a certain title or something as long as it's descriptive um so yeah, just if you want to go with ratings, just you know say so on the pull request and yeah.

D

B

uh Yeah, so just um in here, whenever you use your own EIP number um just use like this proposal. Instead, because um that's.

D

C

B

B

Yeah, that's what you're getting these like uh these errors here is just because you're referring to yourself.

D

um Right, yeah, yeah I'll, remove all that.

B

Yeah P20 good good good. That looks good.

C

B

I, like the new name new operator, is uh it's a good change.

D

B

And I think um you know I. Think rating is a a decent description for something like this um I think it's more generally like uh more well known than experience points um so yeah I think that's that's fine!

B

D

Also, you can have a negative rating, but you can't really have negative experience points yeah.

B

You can't it's like unlearning something yeah, no.

D

B

Good, it's good, okay! So this this is actually quite a bit of changes. So I'll add this to my list of things to look at offline, um just because I, don't think I'll be able to get through it um on here.

D

um Yeah I can get through some of the basic things though, and throw in another commit. So you don't have.

B

Those errors- okay, yeah, so yeah, just put it on my list of things to look at um and I- should be able to get to it, either to later today or probably on Friday. um Yes, I. Don't worry too much about getting a commit in like right away.

D

Sounds great thanks, Sam and.

E

D

E

It's okay, then,.

D

Then what would be the next step.

B

uh So what are you in you're in draft right now? Are you in draft yeah? Okay, so um I'll probably grab a so we've started like a new peer review program, um so I'll probably grab a volunteer from our list and assign them to your uh your proposal.

B

um Hopefully, they'll have some useful feedback. I I, don't know if they will um and then uh whatever you're ready like. If you think the proposal is uh ready to move forward um like you're not expecting any more changes, you can just submit a PR to change status, to review um and that's a decision that you make um when you're ready and then we'll approve it.

B

It shouldn't be a problem assuming everything else is fine um and then uh try once you put it into review, try to collect feedback from other uh groups or organizations or individuals who might be uh interested in this proposal so like who do you expect to use these ratings? um Who do you expect to display them?

B

Do you expect wallets to care about it and try to get uh reviews from those kind of people and once you're, satisfied and and think you have a solid um proposal, then you can move forward into the next stage after that foreign.

B

D

B

In the discussion thread.

D

B

Yeah we try to keep it all in one place, um and this is this is like once you go into review. This is when you try to get other people to try implementing your EIP, so you might reach out.

E

B

Like you might do like an open, Zeppelin, PR or something like that, like um yeah, that's pretty much the the process.

B

You want to get everything worked out in review um before you go to final, because once you go to final, you can't change anything so right, yeah.

D

All right, yeah I've got a couple. Some folks have reached out with interest to to start using it now that it's almost they're, probably not going to be many changes. It'd, be you know, maybe they can get started trying some of those things out. Yeah.

B

Exactly and then, if they have any feedback, you can incorporate it back in, like a big thing is when you have like other people, implementing your standard, they're going to have questions, and then it's really good to get the answers to those questions back into the the document.

D

Right, yeah and that's what the process is for right: yep.

B

Ideally, yeah cool, so yeah, just just to reiterate one last time it's. This is like a u driven process. So when you're ready to move it feel free to move it, we won't touch it. If you don't so.

D

Cool well I'll, um then I'll get that committed and and wait for any more uh feedback from you and then probably move forward uh next week or depending on how close to the the holidays, things get maybe even or.

E

B

Yeah all right, um yeah I know it can be a slow process. So, thanks for bearing with us yeah.

D

No problem thanks.

B

Sam no problem.

B

A

Right next, one is from stagnant to draft yeah.

B

Yeah this one here: okay,.

B

Yeah, so this is just waiting for validator errors, so that can just sit there and then we have 725 improvements.

B

Okay, validator errors: okay,.

B

So they may have fixed them: okay, starting to draft simple summary to abstract.

C

Okay, yes, and consists.

B

B

Y, so does keep 725y.

B

All right, this needs to be in split view, because this is a lot of changes.

B

C

C

B

Okay, erc735 X, okay,.

B

And x and then Y and then Y is interface Okay. So we can go up here and we can say.

C

um Substandards.

B

B

um Generic execute function, ERC.

B

C

C

C

B

Okay, this channel requires ERC business should be.

C

B

And then we need to see you're gonna see one seven, three.

C

What are they linking to.

B

They aren't linking to it at all, I guess, yeah.

C

um So, let's edit this p173.

C

Okay, you just put this in.

C

C

From six five times.

B

And there's an additional references thing.

C

So, between six five.

B

C

Cool there we go.

B

Oh actually, there was one other thing.

B

Okay, so it's 175.

B

B

B

Okay, interesting one of these.

C

Fixing things good comment down.

B

B

It's actually number three customer use tokens against customer errors for common token applications, I think they.

E

E

C

B

I can't say standards for common tokens, foreign.

B

Structured errors for common tokens actions.

B

So clients Implement their scheme, expression.

C

C

C

C

Which were very reasons, custom arrows.

B

B

Okay: okay, okay,.

B

B

Rules backwards, compatibility, revert, strings.

C

Reference implementation.

B

Yeah I mean that's, that's awesome, so.

B

Cool and that's probably all the time we have for today.

A

All right, uh Sam I just wanted to let you know, um maybe you can take it um offline for proposal. Four five, one: nine, uh the pr number 6076 that we have just merged Arthur, has created a new PR 6124 to move it to final okay.

B

So it did render correctly.

B

There was this one here, I think: okay, okay, that looks good.

B

Yeah, that seems fine to me all right.

A

Let's go so the pull request number is six one. Two four.

B

B

Cool well, congratulations.

A

Right well, thank you, everyone for joining. Thank you Sam for um taking our time to help all new Authors. um Okay. uh So for the next meeting, I uh I I spent the calendar, it is planned on 27th. So do we want to keep it or do we want to have it in the new year.

B

um I mean I'll try to show up so feel free.

A

B

Keep it I, don't know if we'll get any anybody coming, but.

A

All right so we'll try to keep it on 27th. Thank you. Everyone.