GitHub Open Source Friday, 18 Jun 2020

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Finding Good First Issues in Next.js - Open Source Friday

Description

Tim Neutkens chats with us about Next.js. Learn how he got his introduction into open source and how you can too.

Join bdougie and friends live for Open Source Fridays at https://www.meetup.com/GitHub-Virtual-Meetup

More information: https://opensourcefirday.com
Schedule: https://www.twitch.tv/github/schedule/

As always, feel free to leave us a comment below and don't forget to subscribe: http://bit.ly/subgithub

Thanks!

Connect with us.
Facebook: http://fb.com/github
Twitter: http://twitter.com/github
Google+: http://google.com/+github
LinkedIn: http://linkedin.com/company/github

About GitHub
GitHub is the best place to share code with friends, co-workers, classmates, and complete strangers. Millions of people use GitHub to build amazing things together. For more info, go to http://github.com

A

Perhaps I guess one of his little exercise. If we grabbed an issue, could you talk out loud like how you would approach it, perhaps in like maybe give someone like sort of a underhand pitch yeah, so perhaps maybe I'm not sure I'm.

B

Not sure yeah, okay, so the first one was a pretty good one to walk through because it's like adding a new functionality to the create next step. Okay, absolutely.

A

B

In this case, this person created a bug report being like hey, I, went to basically send E, or this example, to create next step with the value of default. To basically pick out the default example right so previously like what we did and like older versions of next was like. We just gave you the default example, but.

A

B

We basically ask you like hey: do you want to install this example, or what do you want to use the default value, and this is where, like this broke, basically for his use, guys because you wanted to use like dissing CI or something like that, so it should basically I just select default when you do e default, so I, basically like bypassing that check for hey. Do you want to create a example?

B

Do you want to use an example, yeah.

A

B

Basically, I replied like hey we'd, be happy to like add this functionality e e default, so someone already created forecast for this yeah. This is actually yeah. So this is like some like contributor that is pretty active on the projects and that tries to help out a good first issues, given that we don't have that much time, it actually might make sense to like go into this like for requests cuz. It basically shows like which changes were made to make this happen, and it wasn't made by me right so yeah.

A

B

You go into the dev you, basically because it's only one file so create next up. Is that package right that.

A

B

Great next up, yeah, that has an index OTS, which is the create next step command and then what it does is basically it checks is, like example, is scepter, so you have create a create app with the example parameter on line 171 yeah bird 72 now yep, but basically, what it dis allows you to do is provide like which example has to be installed.

B

So what is like, if you don't provide an example it just those fumes that is the default template, and so basically, what James, if I remember correctly, did, was yeah.

A

B

Moved out the check for that to check if it's a string and then obviously it's the same code, then basically he added in the extract check so example, if example exists. An example is not default, then provide example and otherwise do undefined.

B

So what this means is that if the example is set to default, it will be undefined, so it installs default. Template awesome.

A

And like this seems.

B

Like super approachable.

A

To you as well like yeah,.

B

It does take like knowing, where.

A

To go what to look, but the solutions seem pretty straightforward.

B

Yeah so overall like this is just like what a one-line change right, but even if it's a large has changed like it's generally like in one or two locations that you have to like make these changes so yeah. This is a great for request, that's done by an external contributor, and we still have to review it, of course, but like overall, it looks pretty good.

A

Awesome yeah, so I appreciate you walking through that to you as well. That's in a yeah be helpful for a lot of people to see. Not only did we walk into this and like see how packages work and see how the testing works too, as well cuz, it's a lot of times like I, can open up a PR, but I have no idea how to get the test to run so like knowing, yet where the tests live and sort of like some of the hoops you have to jump through. That's super helpful yeah.