►
From YouTube: Code Review Weekly Workshop - Aug 18, 2023
Description
In this session we talk about some things that came up during our code reviews.
00:00 - Intro
00:55 - When there's a hidden reusable utility that can be used
15:15 - Change to prod code to help test code
B
B
B
So
I
wanted
to
share
what
was
going
on
beforehand.
I
want
to
share
the
utility
and
then
I
had
a
question
about
it
to
share
what
was
going
on
beforehand:
yeah
I'm,
trying
to
figure
out.
Maybe
if
I
do
something
like
this,
like
going
from
version
three
to
version?
No,
no!
No!
How
do
I
do
this
maybe
compare.
B
Sure
yeah
yeah
that'll
do
it
okay,
so
there's
a
lot
of
logic
around
so
looking
at.
What's
going
on
here,
took
me
a
little
bit
to
to
figure
out
the
intent,
but
some
things
stick
out
to
me
like
and,
and
then
I
see,
comma
separate
list
and
I
see.
Oh,
this
is
a
whole
bunch
of
logic
for
like
based
on
how
many
code
owners
they
are.
B
Do
we
show
just
one
do
we
show
you
know
Alice,
Alice
and
Bob,
Alice,
comma,
Bob
and
Charlie,
and
like
that
whole
thing
and
I
just
happened
to
run
into
this
problem
many
many
years
ago
and
I
was
like
we
got
to
solve
this
once
and
for
all
we're
creating
utility
for
this,
so
that
we
could
just
reuse
it
and
not
have
to
redo
this
logic.
All
the
time
do
I
happen
to
know.
B
A
B
B
B
B
A
A
A
B
B
B
So
like
there
is
a
way
through,
like
JS
doc,
can
we
can
like
document
the
function
through
the
comment
following
following
something
here,
man,
you
see
this
is
five
years
ago.
That's
this
is
the
last
time
I
used.
It
I
knew
in
the
back
of
my
head
five
years
ago.
Oh
I
know
I've
done
this
before
that's
so
wow
I
can't
believe
it
was
five
years
ago.
I
thought
it
was
just
a
couple
years
ago.
B
B
We
wouldn't
have
to
fix
this
if
we
just
use
something
that's
already
tested
specifically
for
this
thing,
the
so
the
one
of
the
takeaways
just
like
with
code
review
is
those
are
opportunities
for
knowledge
sharing
and
sometimes
sometimes
the
knowledge
needs
to
be
shared
broader
than
the
immediate
context.
But
it's
like
oh
yeah.
We
can
solve
all
the
things
and
make
it
more
maintainable
and
stuff
in
one
go
with
this.
B
Right
so,
but
that's
clearly
not
like
a
perfect
system,
but
I
know
like
that,
helps,
but
I
do
think.
A
page
like
this
is
super
helpful,
so
I'm
I
was
thinking
about
this
and
I
I'm
inspired
by
the
low
Dash
Docs,
because
we
use
low
Dash
all
the
time
and
it's
this
grab
bag
of
all
sorts
of
random
utility
functions
for
and
I
think
I
really
I'll
use
this
for,
like
I
need
something
with
like
keys
and
I'm
just
able
to
search
for
like
the
whole
thing.
That's
like
if.
A
You
could
ask
for
like
Community
contributors
to
help
document
some
of
these
methods,
because
I
know
that
documentation
Mrs
are
like
pretty
big
in,
like
the
oh
get
started
in
open
source
like
help
us
with
documentation
is
something
that
I've
heard
a
lot
when
I
was
not
contributing
to
open
source,
because
I
was
too
nervous
to
start
anywhere.
Like
start
with
docs,
it's
not
that
bad.
A
B
B
That's
commented,
don't
include,
everything
is
commented,
only
include
the
things
that
are
specifically
meant
for
reusability
and
then
maybe
then
we
can
also
have
like
more
categories
or
something
like
that
of
like
things
that
we
could
put
it
into
I.
Think
that'll
be
helpful
at
the
findability
of
all
the
reusable
things
in
our
code
base.
A
B
Yeah
but
like
I,
like
I,
think
I
used
to
feel
like
utility,
util
modules
isn't
good
or
like
utility
functions
weren't,
but
as
long
as
they're
like
pure
functions
that
are
kind
of
outside
of
any
domain,
it's
pretty
nice
just
having
a
whole
list
of
you
know.
These
are
pure
functions.
I
can
keep
reusing
to
kind
of
expand
upon
my
language,
but
yeah
no
I
want
to
share
this,
and
this
kind
of
thing
came
up
multiple
times
in
code
review,
where
it's
like.
Oh
we
we
gotta,
we
got
another
way
pre-existing
way.
A
That's
like
the
key
is
when
I'm
like
how
do
I
do
this
I'm,
not
sure
people
often
go
looking
in
the
code
and
the
more
that
you're
able
to
convert
things
over
to
like
using
the
consistent
utility.
If
this
is
like
this
is
the
way
we
want
to
do
things
I
feel
like
it
will
slowly
increase
the
percentage
of
people
that
are
like.
Oh,
how
do
I
you
know.
I
know
this.
Ui
piece
works
the
way
I
want.
Let
me
go
look
at
what
that
code
does
yeah.
B
A
So
that
was
an
interesting
one.
Cool
yeah
I
feel
like
it's
a
new,
a
new
developer
here,
I
was
constantly
looking
like.
How
do
they
do
things
here?
Having
that,
like
that
override
each
lady
was
the
one
I
remember,
first,
learning
about
and
being
like,
okay
I
suggest
it
to
people
all
the
time
he
reviews
I'm
like
please
add
this
because
it
yeah
it's
like
a
little
safety
net.
A
B
B
A
A
A
So
I
was
reviewing
an
MR
and
I
went
through
this
in
late
in
my
day.
So
I
was
pretty
tired.
It's
a
back-end
Mr!
That's
for
you're,
adding
it's
like
migrating
elasticsearch
data
for
our
code
index,
which
is
all
the
the
giddly
blobs,
and
it
makes
it
difficult
because
we
end
up
having
to
do
everything
mostly
outside
of
giddly.
A
We
don't
want
to
like
touch
Italy
when
we're
trying
to
update
data
because
well
a
I,
don't
know
how
long
that
would
take
to
re-index
all
of
the
code
that
we've
indexed
in
elastic
and
B.
It
might
have
it
very
bad
effect
on
the
performance
of
Italy.
If
we
try
to
do
that,
so
this
isn't
about
that
particular
part
of
it.
But
I
was
looking
through
the
code
and
I
came
on
this
change.
A
I,
don't
know
how
to
hide
this
thing.
Maybe
I
can't
I,
don't
know,
that's
fine,
so
there
was
a
equal
method
that
was
added
and
at
first
I
was
like
I.
Don't
see
this
equal
message
being
used
in
the
code
like?
Why
did
we
add
this?
Because
I?
That
was
the
original
comment?
I
left
because
I
was
late
and
I'm
like.
Why
do
we
have
this
equal
method
added?
If
it's,
if
it's
not
being
used
and
then
I
came
back,
I
was
looking
a
little
bit
further
and
I
realized.
A
It
was
in
to
support
an
issue
in
one
of
the
specs,
where
let
me
see
yeah
except
this
one.
Yes,
so
we
are
trying
to
add
the
capability
of
filtering
out
archived
projects
from
the
results.
So,
if
you
archive
a
project,
then
you
search
for
code
in
like
a
group
that
that
archive
project
won't
come
back.
B
A
A
Hopefully
that
makes
sense
and
I
think
what
I
after
I
looked
at
this
further
I
think
what
was
happening
is
we're
trying
to
check,
search
results,
saying
hey.
We
searched
with
the
archive
flag
added,
so
it
should
give
me
back
an
archive
result.
How
do
I
know
I'm
getting
back
when
I'm
supposed
to
get
back
and
the
equality
stuff
is
not
passing
so
I
think
what
this
person
was
trying
to
do
was
change.
What
equal
does
so
that
the
tests
would
pass
and
I
was
like.
A
It
has
a
lot
of
things
that
it
gets
initialized
with
yeah
and
changing
what
makes
it
equal.
It
doesn't
necessarily
mean
that
it's
equal
equal
and
the
reason
why
that
makes
me
nervous
is
like
we're
having
a
lot
of
indexing.
Integrity
issues
where
someone's
like
my
file
is
not
up
to
date
in
the
search
results
or
I
click
on
in
the
search
results,
and
it's
actually
gone.
A
Something
like
that
so
like
making
sure
that
the
content
of
what's
in
there
I
think
is
like
oh,
this
is
like
I
was
nervous
about
changing
that
because
we've
been
having
so
many
issues
with
like
you
know,
we're
essentially
like
a
consumer
of
all
the
stuff
in
giddly
in
the
database
and
making
sure
things
are
actually
actually
equal
yeah.
So
that
was
going
to
be
my
my
I
guess,
like
I,
don't
know,
do
we
override
things
like
this
often
in
git
lab
I'm,
not
sure
it's
a
good
question,
but.
B
A
A
A
A
I
guess
that's.
The
biggest
thing
is
like
we're
fiddling
with
it,
because
the
test
is
not
passing
so
my
this
is
what
I
was
hoping
to
work
on
this
morning
was
like
there
should
be
a
way
to
mock
some
something
in
some
way
to
use
an
instant,
double
and
say
like
when
this
thing
is
called
because,
like
the
problem,
that's
happening
is
not
that
the
the
things
aren't
equal,
it's
I
think
the
object
IDs
are
not
equal.
I
was
able
to
get
it
so
that
all
the
fields
were
equal.
A
A
It's
not
the
same,
but
also
I
feel
like
there's
some
like
Ruby
magic.
That
happens
when
you
get
active
record
objects,
and
it
says,
is
this
active
record
object
equal
to
this
other
one
like
I,
have
project
that
I
found
by
id1
and
I
have
a
where
Clause
that
gave
me
back
project
id1.
Somehow
it
knows
those
are
the
same
thing,
because
these
are
like
plain
old
Ruby.
A
Not
the
same
yeah,
so
yeah
I
think
what
I
was
my
thought
was,
you
know
maybe
like
try
to
do
some
creative
stubbing
to
make
it
work
and
that
I'm
working
down
that
path
now,
but
I
guess
yeah
I
was
just
trying
to
be
like
how
do
I
like
how
do
I
phrase
it
and
I
think
what
you
said
was
really
key.
It's
like.
Let's
not
update
the
code
in
support
of
a
failing
test.
We
would
rather
try
to
get
the
test
working.
B
B
A
B
B
A
B
A
I,
don't
know
it's
very
base.
Oh,
let
me
look
at
the
I'll
put
my
code
up
on
ten
thousand
things
that
I'm
trying
to
do.
But
if
you
open
up,
oh
I
already,
have
it
open
how
smart
of
me
okay.
So
this
example
is
like
super
basic.
This
is
all
it
is,
is
make
a
search
Does.
It
include
the
archive
results,
change
the
field
now
Does,
it
include
the
archive
results,
turn
the
feature
flag
off,
that's
supposed
to
like
make
it.
B
B
A
A
Yeah
like
how
you
tell
to
me
how
I
want
to
know
something's
equal
is
that
I
mean
the
person
that
did
this.
They
did
a
good
job.
Trying
to
check
they're
like
checking,
is
the
same
path.
They're
checking
that
the
project
in
the
group
is
the
same,
but
also
the
content.
To
me,
the
content
of
the
result.
That's
returned
is
important
because
that's
what's
being
displayed
to
the
user,
so
that
data
piece
should
also
be
checked.
A
A
B
The
the
interesting
thing
is
this
would
fail
on
possibly
things
that
should
pass.
That's
true,
because
you
could
have
coming
from
a
ref
which
is
the
commit
hash
and
then
coming
from
a
tag
which
are
actually
technically
the
same
thing.
Oh,
but
this
would
fail
Okay,
so
it
yeah
it's
a
hard
problem.
We
probably
don't
want
to
make
assumptions
on.
A
A
Yeah
I,
don't
know
this
whole
I.
Guess
it's
like
this
I
don't
know
if
this
constitutes
as
like
monkey
patching,
but
always
when
it's
like
very
I
feel
like
it's
just
the
far-reachingness
of
A
Change
Is
Where
I
get
like
a
little
like
queasy
when
I'm
thinking
about
like.
Could
this
cause
problems
and
then
how
hard
would
it
be
to
debug
if
this
caused
an
issue
like
you
know,.
A
B
A
Mean
you
have
a
really
large.
This
is
the
migrations.
Are
this
is
a
test
and
then
the
migration
itself
is
yeah.
The
migrations
are
wild.
I
didn't
even
get
a
chance
to
check
this
yet
because
I
wanted
to
address
well
I
looked
at
this
and
I
know.
This
is
based
off
of
other
migrations
that
are
like
very
similar.
A
A
A
B
Not
as
much
no
definitely
not
as
much
yeah
but
like
I,
think
it's
just
interesting
to
you
said
you're
like
at
the
end
of
your
day,
like
you
see
an
MR
and
like
you're,
it's
really
easy
to
see
some
lines
of
code
and
being
like
okay.
Well,
this
just
in
I,
don't
think
even
consciously
you're,
just
like.
A
B
A
A
I
was
like
I:
don't
see
this
equal
method
being
used
anywhere
like
I,
don't
understand
why
this
is
and
I
just
left
the
note
and
went
back
to
like
look
through
other
stuff,
because
I
kind
of
like
glanced
to
everything
left
some
though
it's
almost
like
okay,
I'll
go
back
and
look,
and
maybe
like
I
missed
it
because
it
was
late
in
the
day
and
I
was
like
you
know.
I'm
tired
I
also
didn't
want
to
finish
the
review
without
providing
like
some
sort
of
path
forward,
because
I
feel
like
already.
A
B
A
A
B
A
B
Yeah
I
mean,
and
that
would
be
I-
think
that'd
be
interesting,
I'd
love
to
hear
more
like
was
this
really
just
added
for
tests.
It
seems
like
that
is,
but
yeah
I'd
be
curious.
If
maybe
there
was
another
another
intention
behind
it.
I
know,
though,
that
there's
like
people
coming
from
different
different
language
backgrounds
like
there's
some
languages,
that
just
lend
itself
like
that.
B
B
A
B
A
B
Would
be
asked
in
how
it's
going
to
be
compared
to
be
equal
was
important,
but
yeah
I.
This
was
before
I
started.
To
really
appreciate
explicit
and
simplicity
in
code
and
I
was
like
everything
was
you
feel
like
you
could
encapsulate
everything
into
the
object
which
is
very
difficult
to
do,
but
yeah.
That's
that's
an
interesting
problem.
Cool
catch
thanks
for
bringing
up
yeah.