Home
Contribute Contact Us Browse all meetings
Home Contribute Contact Us Browse all meetings

GitLab / Code Review Weekly Workshop

Add meeting Rate page Subscribe

GitLab / Code Review Weekly Workshop

These are all the meetings we have in "Code Review Weekly W…" (part of the organization "GitLab"). Click into individual meeting pages to watch the recording and search or read the transcript.

18 Aug 2023
In this session we talk about some things that came up during our code reviews.

00:00 - Intro
00:55 - When there's a hidden reusable utility that can be used
15:15 - Change to prod code to help test code
  • 2 participants
  • 35 minutes
programming
gitlab
code
debug
methods
helper
utility
tweaking
reviewing
context
youtube image

11 Aug 2023
In this session we talk about code review!

00:00 - Intro
00:35 - Sometimes reviewing in the terminal is easier
05:10 - A thoughtful review question on test coverage
09:45 - Enforcing responsibilities and avoiding leaky abstractions
16:12 - Question about punting on a question to maintainers
25:30 - Pair reviewing on some dependency updates
  • 6 participants
  • 58 minutes
validation
reviewing
testing
checked
processes
approvals
removals
changelogs
repository
maintainer
youtube image

4 Aug 2023
In this session we pair up on a code review!

- https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127921
  • 3 participants
  • 39 minutes
processing
merge
comments
complicated
wow
review
project
fail
insights
pipelines
youtube image

7 Jul 2023
In this session we talk about some random code review topics.

00:00 - Using the Web IDE to diff email files
07:20 - General tips on reviewing email MR's
14:35 - Discussing approach with rename emailsDisabled to emailsEnabled
  • 5 participants
  • 53 minutes
emails
email
html
web
sending
outlook
hamel
editing
submitted
id
youtube image

16 Jun 2023
In this session we talk about some code reviews!

00:00 - Reviewing a change to high traffic modules with technical debt
08:55 - Reviewing an MR that transforms with `render_ce` vs `render`
30:12 - Pair reviewing on a HAML Pajamas Component refactor
  • 3 participants
  • 51 minutes
reviewing
concerned
notes
updated
contributions
important
issueable
dangerous
deprecated
smr
youtube image

9 Jun 2023
In this session we talk about some topics pertaining to Code Review.

- 00:00 Intro & Reviewing error handling situations
- 13:50 About a large MR review renaming a DB field
  • 3 participants
  • 29 minutes
errors
message
guidelines
reviewing
maintainer
careful
bug
worries
handling
graphql
youtube image

5 May 2023
In this session we discuss some topics related to code review.

00:00 - Intro
00:20 - Best way to knowledge share hidden rules
06:12 - Diving into sufficiency of specific policy/ability checks
17:50 - A non-blocking follow-up situation
26:50 - "What if author wants to do follow-up themselves?"
35:57 - "By default do we feel like MR's are a battle?"
  • 4 participants
  • 50 minutes
reviewing
concern
ai
issue
notice
improvements
handbooking
process
gitlab
smr
youtube image

28 Apr 2023
In this session we talk about finding issues in a code review and pair up on a review.
  • 5 participants
  • 47 minutes
reviewing
reviewer
programmer
comments
workshops
conversation
lets
mods
discord
games
youtube image

21 Apr 2023
In this session we talk about some topics pertaining to code review. We also pair up on a review.

00:00 - Intro
00:30 - Mocking gdk as gitlab.com for testing sourcegraph
15:00 - Pair on a MR review
  • 6 participants
  • 50 minutes
sourcecraft
debugging
repositories
sourcegraph
updates
dependencies
backend
gitlab
graphs
workshop
youtube image

14 Apr 2023
In this session we discuss some topics pertaining to code review.

00:00 - Intro
00:20 - How to optimize review process looking at the docs?
24:40 - Imposter syndrome with reviews?
37:30 - Pair up on a review!
  • 4 participants
  • 52 minutes
reviewing
review
reviewer
guidelines
assessing
documentation
testers
inspection
technical
maintainers
youtube image

31 Mar 2023
In this session we discuss some code review topics and pair up on a code review.

00:00 Hello!
01:00 Finding who has approved when approvers are reset.
06:00 Let's review an MR

https://gitlab.com/gitlab-org/gitlab/-/merge_requests/112892
  • 3 participants
  • 48 minutes
approvals
approver
approves
approval
approve
approved
checking
reviewer
commented
patches
youtube image

17 Mar 2023
In this session we discuss some topics pertaining to Code Review. We also pair up on a review.

00:00 - Diff'n diffs
13:10 - Code is clearer than words
22:05 - Pair reviewing a BE GraphQL MR
  • 4 participants
  • 51 minutes
commit
commits
revisions
redo
merge
transfer
curl
resolvers
batch
git
youtube image

24 Feb 2023
In this session we discuss some topics pertaining to code review.

00:00 - Testing MR diffs on target branch vs. MR branch
07:00 - Is it usual for UX designers to create MR's?
13:30 - Handling community MR's that need to wait for something else
21:47 - Viewing full-stack perspective of a change
39:41 - On over-communicating and mentoring, while not offending
53:20 - "Assume they are Super-Smart"
  • 5 participants
  • 59 minutes
testing
reviewing
cssiness
maintainer
status
diffing
careful
disabled
visually
mrs
youtube image

10 Feb 2023
In this session we show & tell some lessons learned from Code Review and pair up on a review.

00:00 - Leaving things better than found, and non-blocking comments
08:06 - Finding existing utilities in the codebase
19:00 - When is there too much documentation?
32:05 - Pair review
  • 5 participants
  • 44 minutes
refactoring
constant
specification
testing
reviewer
debug
replicate
graphql
existingly
maintainers
youtube image

3 Feb 2023
In this session we talk about some topics pertaining to code review. We also pair up on reviewing an MR together.

0:00 - How to write easily acceptable MR's? Is there a preference standard?
15:55 - Should MR's have 1 or many commits?
20:40 - What makes an MR a joy to review?
33:00 - Pair review
  • 5 participants
  • 57 minutes
contributions
comments
gitlab
reviewing
collaborating
annotating
project
maintainers
editor
thinking
youtube image

27 Jan 2023
In this session we talk about diffing diffs, labeling MR's, and handling very cognitively complex MR's. We also pair up on a small MR review.

00:00 - Diffing diffs
16:13 - Labeling MR's
28:00 - Handling very cognitively complex MR's
37:32 - Pairing on a new feature flag MR
  • 3 participants
  • 50 minutes
updated
versioning
rebase
debugging
commits
refactoring
reviewer
maintainer
push
diffs
youtube image

6 Jan 2023
In this session we answer some questions and talk about some tips pertaining to Code Review.

We also get to pair review on an MR.

0:00 - Discussion
42:00 - MR Review
  • 5 participants
  • 53 minutes
gitlab
testing
reviewing
coverage
editing
patch
interrogators
software
maintainers
ruby
youtube image

25 Nov 2022
In this session we pair review on a community MR. Thanks for contributing to GitLab!
  • 4 participants
  • 34 minutes
packages
version
redesigning
reviewing
registry
users
workshop
contribution
hey
revealing
youtube image

4 Nov 2022
In this session we talk about reviewing code comments, MR profitability, and improving our code review efficiencies.

0:00 - Reviewing code comment
7:45 - Discussion about review processes and efficiencies
22:48 - Question about MR collaboration culture
30:15 - More observations about the MR
35:00 - Hidden UX issues with the preexisting behavior
  • 3 participants
  • 46 minutes
query
comments
filtering
reviewing
pushback
approving
pinging
smr
concern
merge
youtube image

21 Oct 2022
In this session we discuss some interesting code review topics and pair on a database code review.

0:00 - Intro
0:35 - Reviewing when you cannot recreate the issue
5:30 - Catching issues caused by historical data
10:45 - Discussion about Exploratory Testing
17:50 - Pairing up on a DB Review
36:30 - Q: Do we review MR's with broken pipelines?
39:20 - Q: Pinging multiple people on MR's?
45:37 - Q: Ping issue authors on MR's for reviews?
  • 6 participants
  • 52 minutes
fixes
issue
safari
reviewing
merge
versions
glitches
noticed
bugs
developers
youtube image

30 Sep 2022
In this session, we deep dive into dependency updates and security and how this pertains to code review.

- https://github.com/ossf/scorecard
- https://youtu.be/gJGbS8UELGw
  • 3 participants
  • 34 minutes
security
dependencies
updates
dependency
repository
monitoring
concerned
important
github
reviews
youtube image

23 Sep 2022
In this session, we discuss a number of issues pertaining to reviewing code at GitLab.
  • 6 participants
  • 50 minutes
tweaks
reviewing
considering
issue
hacky
danger
touches
guideline
unintentional
smr
youtube image

16 Sep 2022
In this session we discuss approaches to community contributions and identifying testing gaps. We also pair on a gitlab-ui MR review.
  • 7 participants
  • 48 minutes
discussion
reviewing
commented
having
noticing
regarding
changes
insightful
decisions
merge
youtube image

9 Sep 2022
In this session we talk about reviewing dependency upgrades, changes to GitLab's reviewer and maintainer roles, and we pair up on reviewing an indeterminate MR.
  • 6 participants
  • 47 minutes
reviewing
updates
important
concerns
packages
dependency
patch
gem
repo
suggestion
youtube image

2 Sep 2022
In this session we discuss some topics pertaining to code review!

0:00 - Code Review Show & Tell & Questions
27:22 - Code Review Pairing
  • 7 participants
  • 58 minutes
reviewing
mri
mris
mrs
removing
testing
significant
modified
process
reproducing
youtube image

26 Aug 2022
In this session we showcase some of the best outcomes from creating follow-up issues. We also discuss how to approach reviewing areas you are uncomfortable with.
  • 4 participants
  • 56 minutes
comments
discussion
contributions
contributor
reviewing
suggested
concern
annotations
helper
pushback
youtube image

19 Aug 2022
In this session we discuss some best practices pertaining to code review. We also mob-pair on a code review.
  • 7 participants
  • 58 minutes
tester
reviewing
showing
introduce
interacted
contributions
finishing
workflows
configuration
ahead
youtube image

12 Aug 2022
In this session we discuss a sundry of topics pertaining to reviewing code at GitLab.
  • 7 participants
  • 1:00 hours
discussion
reviewer
insightful
redesigning
workflow
developers
chat
code
behavior
sharing
youtube image