GitLab Code Review Weekly Workshop, 21 Apr 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Code Review Weekly Workshop - Apr 21, 2023

Description

In this session we talk about some topics pertaining to code review. We also pair up on a review.

00:00 - Intro
00:30 - Mocking gdk as gitlab.com for testing sourcegraph
15:00 - Pair on a MR review

A

B

Right thanks for hopping on the code review weekly Workshop, uh uh we have some things to talk about pertaining to code review.

B

um I've got uh interesting thing related to revealing uh these Mrs I get pinged on regularly involving Source graph um I. Actually just now well, I was trying to close out all the windows. I managed to do that. I close out all the windows, including the agenda doc I didn't want to close out.

C

B

I'm back okay. Well, let's do it! So let me share uh my screen here, so we're looking at the same thing and every once in a while I get pinged on these dependency Updates.

B

This is our uh iteration with Source graph, which provides the like code Intelligence on blob and Mr views when you click on whatever uh whether it's like a um like a keyword or function name, you can see some descriptions and references and links to um going to definitions and references for various code, things so very cool uh feature, uh but we use Source graph, um we kind of partner with them for this, and they provide the code for that which hooks into their um which hooks into their backend.

B

That's when things get interesting, Source graph has both sourcegrass.com, which I love using for doing all sorts of code searching stuff which I there's probably many recordings of me popping in sourcecraft, um but you can also just self Host this thing. So when I run into these dependency updates, let obviously the goal is we want to make sure that you know this works and nothing breaks? Sometimes things are broken and.

B

So I want to test this locally.

B

Unfortunately, I can't test against sortsgraph.com locally, because sort of scratch.com doesn't know about my local domain, and so it won't. It won't accept my requests and service crafts.com will only um any sourcecraft server will only give you data for things it knows about, so it it knows about gitlab.com, gitlab or gitlab.

B

So, if I'm looking at a certain blob here, it knows this repo with this commit on this file. Source graph I knows this. I know this I've already indexed it here's data for it. If I try to like use it locally and I pass it. You know a URL. It knows nothing about, it's, not gonna. So what I used to do is follow Source graphs, documentation for spinning up your own source graph server that hooks into um spinning up your own source graph server.

B

It has to index your local gdks repositories and then, when it's all set up and ready to go now. You can finally test out this integration bit, um but that whole process is dependent on Docker and on our Mac computers. We don't really have Docker anymore, so then it becomes a matter of okay. Do I whip out one of my Linux computers and try to update the GDK and get Source graph? Yes, yes! Yes!

B

That thing is what keeps me picking these Mrs down the road a lot and then it dawned on me and I thought. Wait!

B

Can I make my local GDK looklike.com so that I can can just talk, to.com, sourcegraph.com and.

A

B

C

um Before we dive into the local solution, can I chime in with a question yeah. Please.

D

C

I'm aware of one of those features that is pretty underused, I'd say but um open Mrs I need to double check this, but aren't we having these development environments spinned up where you would basically be able to give this a spin on.

B

Anything yeah like you could do a view app or something here.

C

um Yeah I need to need to double check, but that might be one of those UK use cases which just comes pretty handy, like I, think these kind of things are super underused, since they are pretty Limited in terms of functionality like you kind of screwed, if you have to update a feature flag or whatever it might be, but for such a use case just like a dependency update that might be kind of a quick solution.

B

So that the challenge is I need to um I need to manually test this out um and it's not necessarily about getting the GDK slash, gitlab server running because that's a solved problem, but it's about getting a valid source graph server running that knows about that environment.

C

Okay, so too many dependencies for the view app thingy.

B

Right- and so we don't even have like so like part of our and I'm gonna- not be using these terms, probably correctly, but this is something that a um git lab admin or some I.T admin of a customer of ours. They would have to set up their own source, Craft Server, it's not part of our Omnibus kind of thing or whatever so um or somehow make their server now into.com and um like Source graphs, has a lot of really great solutions to this, but for development environments me testing out locally.

B

It was great when I was like oh yeah, I'll, just spin up my doctor container and stuff, and everything goes well, but since I don't have Docker anymore. This challenge, all of it to say, I, was able to make getlab.com on my browser.

B

um I was able to make this uh hit my local GDK, uh which was great, and so then, as long as I had a project that was real. uh So it's such that it mirrored like the same path that sourcecraft.com would know about. I was able to test this out. It was like oh yeah, so it worked so I was able to get. uh What's the picture here.

C

So you've bravely been playing around with the ETC host or how did you shoot.

B

Yourself, yes, so Etc house is needed, so I'm gonna I'm gonna dive into what what all was needed.

B

um Yes, Etc host was needed, um I don't think I have anything but.

C

For my understanding, it's it's a while, since I touched this thing, it's basically like a local DNS, isn't it it is kind of the domain resolution on your local machine. Yes,.

B

Etc is like that yeah, okay, so we updated for normally everything has GDK test, but I was like yeah. Let me just do this with gitlab.com I had to do this at a certain time, though, if I did it too early in my process, then like running GDK reconfigure, which tries to reach out to getlab.com started to fail at me and stuff. So I was like oh gosh. The.

D

B

A

B

Step is uh updating in the yaml, the host name from gdk.test to gitlab.com, and then I was able to use, make cert to just make a certificate. I am already running https uh locally, so I was just able to make a certificate for gitlab.com.

B

And so I just updated these and I kept everything and everything was great.

B

Then I hit GDK reconfigure and it's good there's one more problem to solve, which is um this port I can't make 443 the default https port, um because that requires pseudo access and I didn't know how to dive into the bowels of GDK to figure out how to give nginx pseudo access for this good point yet so, instead, after doing all this, which I'm not going to write I'm just going to quit, Barrel um I said after doing this, all of this I ran GDK reconfigure once it was reconfigured, I, started it and and and outdated the etc, etc.

B

Host uh I had to look up. How do you give 443 access and Mac without root and uh there's a really cool? um There's really cool utility, but I've completely forgotten about it. So I just found it on a Google search and I would recognize it if I saw it again, but um it was basically some sort of networking tool that similar to like IP tables or something which just told your local computer, anything coming in to 443 just internally pipe it to three. Four four: three and.

E

B

Just lets me hit locally I can hit both getlab.com or get lab report three four, four three and and it works so uh I didn't know if that was gonna all work out, but I was surprised that it did so um I guess isn't really helpful to a lot of people. But if.

D

C

Ever did it sounds easy.

B

As pie, though, like it was, it was a lot easier than I thought it would be if.

A

B

Needs to ERD integrating with something and they need their local GDK clients to respond positively to gitlab.com in a way that, like certain Integrations, are looking for this URL, uh it's possible. That's I, guess the main take away.

C

Two small questions on this: do you see any tooling or something we could come up with to make this easier, like I need to write documentation.

B

For it, that's.

C

Okay, yeah- that would probably be a start like I, see the like this this to to actually achieve this. What you just reported! It takes a lot of back background knowledge for sure, and also quite a bit of work, as you just mentioned so. Making this easy, I would probably like I would have had Fair troubles with this Mr.

B

Yeah, it's it's! These! These Mrs I I are locals, set up dependent and that's the most difficult thing with them. Is you.

E

B

Set up this other service, they're they're Docker container is fantastic, but.

D

B

To set that up in a way that you can actually hit in the network, you need to set it up with https. So it's like all of those steps.

E

B

Be a challenge um so uh but I had that, all that solved locally, but now I, don't we can't use Docker on Max anymore, so that was that was disappointing. We.

E

B

I, haven't I, haven't taken the path looking into Rancher and other kind of Darker run times would be the other option.

A

B

D

C

B

Share that really random tidbit.

C

um Yes, thanks for sharing one one more kind of follow-up question: just do: are you aware of any other dependencies that gitlab is having? That would be like similar and complexity to update.

B

That's a good question.

C

Because, hopefully that is, that is not the the usual like dependency updates. Mr are never the easiest, but um usually there's basically just our code base as a consumer, in best case, even maybe a death dependency. So it is kind of run the pipeline across fingers. But that is that's probably already quite a bit that you have covered by just doing so. The.

B

Thing that makes this this one uniquely challenging um I. Think I, think that I mean all of this setup is probably comparable to like.

B

um Elasticsearch is a pretty solved problem in GDK, but I'm I'm thinking, maybe setting up some of our security tools, certainly setting up like the um pricing uh like the customers, app and and stuff related that has, you know, has to deal with credit cards and, and things like there's some developer instances of like integrating that you need to.

B

Those are some challenges. The thing that unique makes this uniquely challenging I would imagine. Other kind of um other kind of third-party Integrations challenging is when the third party thing needs to know about your app and most of the time it can just live inside of it, and it just responds to whatever data it's gotten in our in this situation is like no. These are two separate things that are independent, but our talk should have commute some background communication with each other, which is the case with sourcecraft.com.

B

Because Source graph, like just Source graph, indexes every public thing, uh so you can see like here's all these GitHub repos. How can I look up? Oh yeah, and then here we go. Here's all these gitlab repos, and so you can create your own local instance of this and won't have whatever repos you can specify where it's going to look for things whatever, but.

A

B

Good stuff, pretty.

C

Random yeah thanks.

B

For letting me share that uh cool all right. Well then, the the next thing I got is a um Amara Peron. uh Does that sound good, absolutely.

C

B

All right, I haven't looked at this, so I'm not entirely sure. What's going on, but I am familiar with uh these workspace.

B

uh Mrs, this is part of our newly named IDE team working on the remote development feature. Where not only can you spin up the web ID, but you can spin up the web ID with the terminal and all sorts of goodies.

C

The web IDE with a terminal like this is not not the vs code. Singing This is the web IDE with the old web ID no.

B

This is the new. This is vs code with the terminal.

C

A

B

Any lots of other kind of editors too, so it's very exciting cool solving solving the hard problem of um providing uh out of the box workspaces for projects, so contributors don't have to set things up locally. That's the large ambitious goal which uh there's a lot of great work on, but we're on the front end. So we don't have to solve those hard problems.

B

um So this is a follow-up to one of the Mrs I guess I was creating this thing, I'm going to read the context first, um actually before I do anything I am going to assign myself as a reviewer. So when I was looking for this, it wasn't assigned to me. Oh I can't assign it because I'm not signed into gitlab.

B

uh David just pinged me, but I didn't actually get to be assigned as a reviewer.

F

B

So let me pause sharing my screen. You can sign in to get loud, so I can sign myself in I can assign it to me as a reviewer mm-hmm.

A

C

B

My screen right.

C

B

Not doing anything, you don't see all.

C

B

All my passwords aren't showing up on the screen screen right now, right.

C

Absolutely yeah, no just kidding um economics.

B

Like no, it's fine, don't.

E

F

B

Right resume sharing here we go all right now, I'm signed in and move our heads. um This is a view app thing that you're talking about exactly yeah. It's it's really helpful, uh I like using it. It can be difficult, though I always forget how to like change, feature flags on it. Is it even possible it is? You can use the API to do it, um but I forgot how I've totally forgotten how to I.

C

Would that's interesting, I'm pretty sure that it's the first time I'm hearing this and I am if.

B

C

Surprised if you're having docs for this future.

B

Maybe yeah I mean, if you're an instance, admin there's an API endpoint that can be used to like change feature flags, at least that's how I've done this in the past, but I've but I've forgotten, yeah.

C

Gotcha and it's yeah it is, it is honestly not not really delightful to use as if in your running running against barriers, pretty soon right. So that is what is keeping me away from using this feature, mostly right.

D

All right, okay,.

B

uh It's on I'm gonna check out the changes locally. Oh I might need to fetch the latest.

B

B

Let's get the latest changes, so maybe I can check this out.

B

But before I dive into the code, I'm, probably wanting to just get the overview of what.

E

Is changing um great.

B

B

Okay, so looks like we're changing some graphql files and then we're just modifying files. Okay, uh a whole lot of stuff: let's see what happens.

B

Fetch's cluster Agents from the Project's root group sends all the required parameters to the workspace create mutation. We handle a missing Dev file.

B

Workspace is created it navigates to the workspaces list.

B

B

After this change, the workspace creation UI works with the real backend API implemented here. Okay, so.

B

Here's where I'm at with these are Mars um because I've been paying on a chain of the works. This remote development feature that we're fleshing out, which.

D

B

Under a little bit of pressure, because we're trying they're trying to hit Milestone dates and deliverables- and um let me go back to uh pre- oh obviously, it's great when I can check it all out and test it myself.

B

Some of this requires like setting up if I was going to test it all in integration. Some of it requires setting up like kubernetes agent stuff, and it's like I, just told you how far I we just talked about me. Setting up Source graph like I, don't want to have to set up all of these things. Well,.

C

If you already have your Linux machine out and.

B

Just I know I know, but you know, what's actually ironic is if I had like kubernetes and and Rancher setup, my source graphs will probably what's.

C

Up all your problems, I know I know so.

B

um Instead, I'm kind of just looking from the front end and I have ran the front just this, because these are now being built in parallel to the back end and the front end so I'm. Looking for like run in specific issues of debouncing inputs, are we resetting the state like when other things in our form are changing and like looking for front-end specific issues, so I I'm not quite able to test out the whole picture yet, which is okay.

C

But um for those inputs and things that you just mentioned like, are you able to actually mock this UI, some somewhere or yeah.

B

To some extent so, and sometimes I'll, like just turn off certain, like checks and the code, so that I can keep going forward just to test it out. um So there's two user facing changes. It looks like that's great. Dev files are required on a project. The UI redirects, the user, to the workspaces list after workspace is created, nice, okay, oh nice, and here's all the instructions we're doing that's great great um and so I won't need to actually I.

B

Don't think that any of this is integrating with the real backend yet, which is totally fine. uh But let me go ahead and run.

D

Bumble Bumble.

B

B

Or Yandel and barn.

C

Let me just quickly skim through those things to reproduce this. The features like easy license, yep it should be doable without to yeah and.

B

Then any prerequisites, yeah I, think we can hop there. Anyways okay,.

B

ah Man I hate this, but I guess I, guess it's too late. He.

C

A

C

B

Yeah, oh, but I, guess it's fine I'm, not too worried about it. uh I do find it interesting. One thing is sticking out to me is like oh I didn't realize we're changing the name of this file and, like there's some level of convention here to the kind of file it's expected to be so.

B

um That was news to me.

B

For instance, let's just go look at source graph file. It looks for anything that's called Dev file, so it looks like.

B

B

All right, I, don't I, need I needed to.

E

Start with devcloud.

B

So you get this and then there's a whole bunch of gammels.

B

All right and then I need it to potentially end with a DOT or not.

F

E

All right, these are all folders.

B

Yeah I guess that's mostly these Yama ones, I guess we don't necessarily have a DOT debt file, okay, cool, all right and I. Guess it's fine, I'm, gonna trust that that we intended it to be that file.yaml! That's fine! Okay!

B

um Here we have mock done me, data we moved, which is.

B

Which we don't need anymore, I, guess I, guess we're just talking to the real back end. Now, that's.

E

B

C

Is pretty cool? um Let me double check for a small thing.

C

um You comments who says like slash what column dummy data to support development um if you just on the left, scroll down a little yep that might be worth cleaning up as well.

C

B

I was still having dummy data in there. I think this is still I think that it sounds like we still have this level of dummy data.

C

ah Okay, I didn't see that in the uh small diff I'm, seeing on the other.

B

Yeah, it doesn't make sense. Okay, this was just um we. We created a dummy, a dummy hook for the workspace, create mutation, but I guess.

A

B

Guess we're all good now um it group all right. Let's look at this view file.

B

Okay, all right some background to this um file, so I see that there's changes here probably could be potentially wise to um look at the scope of what this component was like before, and his component was a renderless component, encapsulating.

B

This uh worry uh-huh, which is cool.

D

B

I, what's sticking out to me is okay, it's a nice little renderless component with no state.

B

Why are we setting this Dot? You know.

C

Well, what's one.

B

R, well, we don't have any reactive state in this component. Good point.

B

So, for instance, setting this that group half will actually not trigger any change like that. This needs to refetch, because.

B

B

ah But now we do have the state.

C

So that does then make it a stateful, but still render this component am I. Getting this right.

B

Yeah and I guess it's I guess that's fine!.

B

Like we used to just you know anytime, this Corey did something.

B

We make some calculations and then just submit those calculations and we're done. But now we have this chain of calculations happening.

B

Or this chain of queries.

B

And so all of this is only consumed by this create, let me see how this gets consumed so here.

B

D

B

Right uh yeah, we didn't even have to update this thing at all, because this is where we referenced, that little query thing, and so we just pass in a little project path and then, whenever there's a result, we get that bag.

B

But what's challenging here is we're. Gonna have two queries. We have two queries.

E

B

Oh I see what's going on.

B

B

Oh I, see what's going on. um My concern was that we would emit results twice. You know, because I see a line and emit results here, yep and then I see a line emit results here and it's like. Are we going to emit results while we're still waiting for results and, what's going to happen to the UI, when we do that.

D

B

But we only ever call this query when we have a group path.

A

B

And um then we don't emit the results. We wait for this query to do its thing.

A

D

B

So what do you? What do you think of what's going on here? How are you, what are your thoughts on this.

C

um It's a lot I'm currently thinking about. If there is any like the point you just met made with the emit results twice, if that, if it could tweak the architecture to make this a little more obvious, because that is definitely something to stumble on that, definitely would be one thing and another thing with uh which I saw, which is completely optional.

C

Let me just quickly double check if this is the actual file or if it is somewhere else in the summer um somewhere, it is basically taking the error, input and returning it into uh GL alert, which is absolutely fine to do, but um you're.

B

C

With this problem, yes, that is what I'm about to say feeling a little bit like a one-trick pony here, but um we could. um We could leave an optional comment um that we could enhance this. Just that's a good idea.

B

Where is where does that happen? Did.

C

You decide um yeah, let me quickly search.

B

For it, oh, is it probably in the error Handler of this thing? Yes, yes, yes, yes, yes, yes, oh.

C

um Here and when we.

A

C

One free that is what I'm looking for so that looks risky to me when we're doing it, I see.

B

It I see what you're saying um I will leave that as an optional comment. That's that's a good idea of that's good, just something to think about all.

D

E

C

B

Oh, what we're gonna say.

C

um I was just um planning on coming back to the actual Clockwork query, so I'm not to get too distracted too much about this of chance. Yes, yeah. Let's do that.

B

D

B

I'm going to leave it as a thought, non-blocking.

D

B

I'll leave it as a question.

E

Okay, are we guaranteed that this errors.

E

B

Is? um Is user friendly.

D

B

I know someone who.

E

Knows how to make errors user friendly.

B

D

B

uh Man, I was trying to think of a plan because I was thinking like he has a knack for this. I was like that's not yanak. You.

F

B

I can't do it, uh he goes by.

E

D

I'll, take that.

B

um Wants to be a thoughtful Improvement.

D

E

E

D

B

The uh other yes getting back to here, you I think you mentioned about not it not being obvious. Yes, um I agree with all of that. It's like yeah. This is.

B

This is not obvious and I would like to put out just like what could possibly go wrong here, and one idea that I have is this query passes.

B

But this query fails.

A

B

We, the main consumer of all, this, is going to lose all that intermediate state. That could be helpful or used for something, and if we need to retry, we would just have to somehow retry, maybe all of it or whatever.

B

The other thing is uh what, if, while this is loading, we get a new project, full path.

B

You know what I'm saying so, if this loads, we get another project full path and then this thing is going to emit.

A

B

Then maybe this thing fails or whatever, like.

C

So we would end up with having a defined uh project path, but an undefined group out.

B

Yeah possible I think possibly you could get really interesting. um So.

B

Let me look at this: get group cluster agents group.

E

Id cluster agents.

C

F

E

C

I getting this right, but this component is doing, is basically doing two queries kind of merging the answers together and then passing it along.

B

Yeah and I see well hey. We used to do this before what oh, but it's because we're looking for the root group. It has because of subgroups we're interested in only pulling from the root group.

B

Because projects does the graphql query, have a does? The graph have a um I.

E

Was trying to break things, let me clear out what I was trying to break.

B

Let me get a query.

B

Projects, project type, do we have like a root.

E

E

Look for group there's a root I'm going to move our faces.

E

Is there there's not a root group? Okay, it's just fruit. Does group have a reference to like what the root group is.

C

Okay, so just for me, you're, basically trying to um explore our craft career and or create endpoint to see if we can get the information by just in one query instead of two. Yes,.

B

Yeah yeah and nothing's nothing's coming out um I I.

B

Don't know what I don't know, what comments to leave here because clearly I read this and it didn't make me feel good and that's a flag to me of, like, though right I'm I am concerned about uh I am concerned about how this is. This is split up and not a cohesive thing. Wild.

C

Idea, what do you think about leaving apartment for a non-blocking follow-up thingy for the back end to actually like? If there was a need for this kind of information, then we it'd probably be a good idea to have a query and querying two endpoints at the same time, with all the risks that kind of involves um it's not the greatest thing so as as a Band-Aid as a first iteration, whatever this might be an acceptable solution, but on the long run, yeah.

D

C

Is not necessarily what comes to my mind when I dream about clean coat.

B

It's such a way of saying it all right.

B

You know at night and when you're you're cuddling your babies and you're telling them about clean code. This isn't I, don't want to scare them. This is the one I bring up. This, isn't the path I'm referring it.

C

B

Right uh some proof um uh to prove what's going on with the double query.

B

um Behavior, um are we considered adding a root cluster agents um similar to just saw the word root here? Root storage statistics.

B

E

Similar to root storage statistics.

B

And the backend, which would.

E

Pull uh from the current group, if it's a root group or.

B

Find the root root.

E

And pull from now.

B

E

Only have to have one.

E

It only has to uh part to be once report. Okay,.

B

uh Yeah, so it's definitely a thing uh here: um I I, don't have a really great suggestion, but I am just gonna just voice a concern about it of um and I think.

B

um Are you concerned about any fragility here now that.

E

uh These queries are a bit dependent on each other.

C

Yeah that that 48 line Looks slightly magical for me and I'm wondering if we're having this covered by tests or something.

B

Maybe we can leave some comments.

E

Describing the dependency here.

B

um And how line 48 was.

E

Expected to trigger the.

D

B

Here's here's a scenario. uh The scenario is.

B

Project full path comes in from then we.

E

Trigger the project details, query sales, details free which triggers the.

E

Successful triggers.

B

B4 B 3 is completed.

E

A new project, full path comes in.

D

E

Admit results will potentially contain some outdated data based on a race condition.

E

Thank you. This is the thinking emoji.

B

E

Do you think any thoughts on making this more cohesive? That's.

B

My big, that's, that's all. That's the best I got I wish I had a great suggestion to do here, but I really don't.

D

What do you think.

C

um I think that it is really really hard to solve this um as an atmosphere sticking to the double query. So therefore, I'm with you that um wow.

C

D

B

Right uh I know when we get off the call it's gonna dawn on me, I'm, like.

B

Anyways all right, it looks like I'm deleting this fragment now.

B

um Do you have just five more minutes? I think we can.

C

Finish: yeah yeah, absolutely.

B

uh I think we're deleting this fragment now, which I find to be. Oh, because when we create the workspace, we're not going to return the whole workspace.

A

D

B

Get group cluster Agents from positive.

C

Can you help me with the with the app client we just saw and the if we go back to uh yes, uh so it's a security augmentation, it is imitation, um it has the ad client so therefore I assume that it stays mocked or is this like.

B

You're right, but we got rid of the mark. That's a really good point. It was a really good catch. I totally just blew through it.

C

Well well, I'm still having questions, though, like oh, oh I'm, not not still sure like this. This could be just staying within the mock option. A option b I know that it is how do I put it kind of a fancy view, X alternative more or less to actually do some states.

B

C

Know that this.

B

Is just I know.

C

B

Is intended to stay in the mock, but we've removed the mark. Okay,.

C

B

Think something is something is off here: okay,.

C

This is not a good, uh a new State Management machine. This is actually something to be forgetful.

B

C

B

Yeah yeah yeah is this: um is this mutation still client marked I.

E

Saw we got rid of a mock in the init.

E

uh But it's still a client here.

B

And I think we got rid of these um because I having worked with um debugging issues with this feature, um we've implemented subscriptions so rather than like I, create a new one and then I have to do the Apollo Way shove it into the Old Quarry. Somehow uh we implemented subscriptions, uh it's.

E

B

So that was pretty, that was pretty fun, so I I'm not super concerned about that because it was like. Oh if it's working then I'm not worried about it.

D

Especially at this stage, so, um okay.

B

All right we're almost there uh yeah. These are just queries, doing their query things um these they're just messages, I'm, not super worried about those right now uh has Dev file used to be true, and now it is a null should we make it false.

C

To give any kind of feedback, if this would have to understand outcome that we're changing the initial state of this, it's.

B

A good question um I would guess assumed because everything else is falsy, but.

B

E

We want to keep as that file, as always a Boolean.

E

Do you really want the best to be false.

D

I, don't know all right.

B

Results we get the data, a workspace, create errors, I see and we don't need to visit previously I guess we were visiting this URL, but now we just push back to the router, that's great, and so the last bit are these specs. This is going to be the most complicated fact. The query one this one which is testing out. Oh, this is just mock data.

B

D

D

B

Yeah I'll take a quick look at the specs and then be done with this, so um cool yeah. Thanks for your help, Yannick that's helpful. I'll go ahead because I have another meeting right now and I think the wisest thing to do is rather than let the review just sit. I'm just gonna submit the review, as is so that Enrique can respond to things as I'm still looking at this back since.

C

Awesome sweet that was good fun thanks for sharing and I'll catch you soon. Thank you, Yannick appreciate it all.

B