►
From YouTube: 2022-11-30 Code Review Weekly
Description
No description was provided for this meeting.
If this is YOUR meeting, an easy way to fix this is to add a description to your video, wherever mtngs.io found it (probably YouTube).
B
A
C
Yeah
I
was
interested
in
pushing
the
editing
commit
messages
forward.
If
it's
possible,
I
was
wondering
if
we
are
at
all
interested
in
that
feature
and
if
we
do
want
to
get
this
into
gitlab,
what
can
be
blocking
this
feature?
What
we
might,
what
being
might
need
so
I
was
interested
in
your
opinion.
First.
A
Yeah
I
left
like
a
couple
links
down
below
and
I'll,
be
it's
it's
not
one
that
I
hear
come
up
often
or
haven't
heard,
come
up
often
recently,
so
I,
don't
I,
don't
think
about
it.
Much
and
from
what
I
recall,
I
think
there's
some
there's
some
reasonable
concerns
about
like
how
do
you
model
permissions
I
think
around
who
can
edit,
whose
commits
and
then
how
are
you
actually
editing
those
commits,
because
that
effectively
would
like
make
a
new
commit?
A
And
now
you
need
to
go,
get
approvals
and
sort
of
do
all
of
these
things
over
again,
it's
sort
of
like
an
interesting
thing.
The
one
that
does
come
up,
though,
is,
is
commenting
on
Commit
messages.
Lots
of
people
want
to
review,
commit
messages,
especially
in
projects
where
commit
messages
are
more
important,
like
the
giddly
project
is
a
good
example
of
that
gitlab
like
they
actually
use,
commit
messages
to
be
useful
and
so
like.
A
They
want
to
review
those
to
make
sure
that,
like
you,
could
catch,
spelling
or
comment,
like
you
know,
sort
of
the
same
line
by
line
comment
thing
and
to
me
that
feels
like
an
easier.
A
Nothing
that's
been
merged
with
that,
and
then
the
other
one
I
put
in
is
part
of
the
use
case
of
like
editing.
Commit
messages
is
because
they
want
a
good
commit
message
when
it
goes
into
like
the
default
Branch
and
one
way
to
handle
that
would
be
to
fix.
Who
can
edit
squash
commits
right
now?
Only
maintainers
can
set
the
message
that
is
a
squash,
commit
in
a
project
and
I
think
the
reality
is
like
whoever
the
author
of
the
EMR
is
should
probably
be
able
to
set
their
squash
commit.
A
That
would
make
more
sense
since,
like
if
they
actually
had
a
commit
and
squash
them
all
locally.
They
would
be
able
to
set
this
the
commit,
and
so
maybe
like
another
potential
one
worth
exploring.
Is
that
one
right
like
who
can
maybe
we
open
up
the
like?
Who
can
edit
the
squash
commit
to
make
it
more
permissive
to
sort
of
like
a
wide
range
of
people?
I.
C
A
Potentially,
it
comes
with
like
similar
impacts,
but
we're
not
like
rewriting
get
history,
which
is
what
I
think
would
be
complicated
with
sort
of
that
that
first
one
but
I'd
be
happy
to
sort
of
know
like
what
you're
thinking
here
or
where
you
think
the
value
is
and
being
able
to
edit
them
or
whose
commit
messages
you'd
want
to
edit.
So.
A
B
Reword
a
commit
it
does
like
an
automatic
rebase
or
you
can
amend
the
last
commit
so
like.
Is
that
something
that
we
should
do
in
our
UI
I
mean
I.
Think
it's
solid
if
someone
would
want
to
because
that's
something
like
like
the
issue
that
starts
I'll
link.
To
has
it's
something
that
you
could
do
on
your
local
Mission.
You
could
go
back,
you
could
reword
it
commit.
You
could
do
a
rebase
on
top
of
it.
B
You
could
like
push
all
that
stuff
up
or
you
could
just
demand
the
last
one
stuff
is
possible
and
I
think
as
far
as
permissions
are
concerned,
if
you
have
right
permission
to
the
repo
I
think
you
can
do
it
to
anyone's
commit
or
something
like
that,
I'm,
not
sure
foreign.
B
C
Would
like
to
add
like
why
I
was
even
like
interested
in
the
issue
in
the
first
place
from
the
top
of
my
head,
we
have
ripples
like
two
ripples
that
we
use
commit
linking.
So
basically,
if
you
do
not
have
a
proper
chemist
structure
as
a
message,
it
won't
let
the
pipelines
run.
So
if
you
have
this
wrong
passage,
you
won't
have
linting,
etc,
etc.
And
basically,
if
you
want
like
to
fix
a
single
line
in
the
project,
you
can
just
use
gitlab
UI
to
do
that
and
push
the
change.
C
E
I'm
I'm
kind
of
surprised
that
this
is
a
problem
that
so
many
users
have
uploaded,
because
what
you
just
described
sounds
very
git.
Lab
gitlabby
is
in
how
we
work,
because
we
used
to
love
for
everything,
but
I'm
surprised
that
so
many
other
people
are
using
gitlab
to
edit
things.
Instead
of
just
using
the
command
line
for
everything.
B
I
think
this,
the
small,
the
small
fix,
is
like
where
starsoft
said,
like
the
one
line
fix
or
the
one
bit
of
text
fix
I'm,
almost
always
on
my
local
computer.
If
I
just
want
to
fix
one
line
in
in
a
file,
I
use
I
use
web
ID
because
it's
just
I,
just
don't
wanna
I,
just
don't
want
to
start
like
a
local
thing,
and
this
I
think
that's
the
point
of
what
Stanislaus
is
saying
like
if
I.
D
D
I,
don't
think
it's
super
useful
for
I'm,
going
to
say
power,
users
or
folks
that
live
on
the
CLI,
but
yeah,
especially
the
folks
who
are
doing
small
docs
fixes.
Oh
yeah,
we
get
into
some
fun
when
they
make
bad
commits,
so
we
teach
everybody
how
to
squash
and
make
decent
squash
messages
just
to
get
around
it.
A
Is
that
Amy
is
your
experience,
the
git
lab
or
get
lab
project
like
the
main
gitlab
project,
because
the
commit
rules
there
are
like
a
capital
letter
and
then
very
character,
length
specific
right?
So
if
you,
okay
yeah
it's
those.
D
Rules
or
any
side
project
that
I
pushed
to
and
I
forget
that
I
need
to
use
commitments,
conventional
commitment,
I,
gotta,
prefix
it
with
DOT.
Is
it
dog
or
dots,
can
I?
Remember
no.
A
I
mean
doesn't
even
have
further
thoughts,
I,
don't
I'm,
not
sure
I
would
be
prepared
to
like
say
we
should
go.
Do
that
or
dedicate
time
to
to
any
of
them
without
sort
of
thinking
through,
like
all
of
the
use
cases
there,
but
but
I
I
don't
know,
I
could
be
convinced
either
way,
I
guess,
I,
don't
I,
don't
really
have
a
strong
opinion.
I
think
the
the
conventional
commits
thing
is
interesting.
A
The
way
that
Tomas
deals
with
that
in
the
vs
code
project
for
Community
contributors
is
we
just
squash
and
you
can
set
the
merge
request,
title
to
something
that's
valid
and
then
because
you're
squashing,
the
squash
commit,
gets
checked
and
then
that's
the
the
commit
message
that
the
lenders
use,
and
so
you
can
rerun
pipelines
like
as
soon
as
you
change
the
title,
and
that
is
like
the
the
easiest
way
to
work
around
it
in
both
of
those
projects
is
to
just
edit
the
MR
Title.
A
You
know
I
wonder
like
I'm
like
thinking
through
that
and
because
it's
that
the
other
options
for
like
would
be
like
pre-receive
hooks,
but
I,
don't
think
those
exist
on
gitlab.com.
A
You
could
use
like
a
left
hook
configuration
but
like
pre-received
hooks
would
allow
you
to
like
enforce,
commits
and
I
know.
We
have
customers
that
do
that.
There
are
a
lot
of
customers
that
enforce
commit
standards
via
pre-receive
hooks,
so
they
won't
even
like
gitlab,
accept
it
without
the
valid
commits
or
whatever
else
they
want
to
have
happened
locally.
First,
and
so
you
know,
I
wonder
if,
like
the
better
Solutions
are.
A
Preventing
people
from
getting
in
the
situation
versus
like
letting
you
bail
out
of
it
once
you're
in
it
like
I,
think
there's
maybe
Merit
to
both,
but
but
preventing
people
from
getting
into
bad
situations
is
usually
usually
better
than
putting
them
there
and
then
making
them
figure
out
how
to
fix
it.
E
A
Yeah,
if
you
had
a
pre-received
hook
on
the
repository,
it
still
follows
the
regular
git
paths
and
so
yeah
if
they're,
if
they're,
if
those
hooks
were
configured,
it
would
be
enforced
there
as
well
I
believe
but
I,
don't
think
I
want
to
say,
like
you
cannot
do.
A
There's
a
difference,
between.com
and
self-managed,
because
then
I
think
yeah,
the
the
git
server
hooks
doc
say
it's
for
self-managed
only
because
they
run
against
like
all
git
and
so
there's
no
way
to
like
segment
it
into
like
a
group
thing
I
believe
because
they
have
to
go
on
to
like
the
giddly
nodes
is
where
those
hooks
land.
F
Yeah
on
that
note,
I
remind
this
reminds
me
of
a
recent
discussion
we
had
when
we
wanted
to
do
editing
of
commits.
He
was
because
that
delivery
team
was
before
we
had
to
commit
Trail
stuff
about
the
releases.
F
The
change
log
changes,
so
we
had
the
discussion
and
we
ended
up
landing
on
not
making
it
easier
for
users
to
do
something
that
has
potential
and
destructive
actions
by
changing
the
history
without
them,
realizing
that
so
there
was
a
bit
of
some
ux
business
there
that
we
needed
to
account,
for
it
reminds
me
about
like,
if
I'm
making
it
easy
for
me
to
reward
to
commit
essentially
I'm
changing
that
commit
I'm
changing
the
history
somebody
has
that
can
be
checked
out.
They
need
to
be
aware
of
that.
F
A
All
right,
no
one
has
anything
else.
Then
it's
good
to
see.
All
of
you
welcome
to
December
almost
early
welcome
to
December
almost
the
end
of
the
year
and.
A
And
yeah
we'll
see
you
all
next
week.