►
From YouTube: Batch Loading not working for Whitespace changes
Description
An overview of the difference of loading the same MR with whitespace changes toggled on and off.
A
Hi,
my
name
is
kai
armstrong,
I'm
the
pm4
code
review
and
I'm
just
going
to
talk
about
largemour
and
some
of
the
requests
we're
seeing.
So
let
me
share
a
screen.
A
This
is
an
unreasonably
large,
mr,
is
what
this
is
called,
has
1500
files
they're
all
very
simple,
but
it's
1500
files,
and
you
can
see
in
the
network
tab
that
this
is
making
requests
through
our
batch
controller
for
diffs
and
I'll
check
this
setting
here.
A
A
You'll
see
that
these
requests
keep
coming
and
I'm
actually
able
to
scroll
the
page
as
we
go
and
fetch
sort
of
diff
content
in
each
of
these
requests.
It'll
take
a
while,
but
we
will
get
all
of
this,
but
the
page
is
usable,
more
usable
than
we'll
see
in
a
moment
in
sort
of
this
state,
while
we're
loading
all
of
these
diffs
in
so
that
request
is
going.
These
are
all
happening
in
the
background.
A
A
A
Go
away
and
it
didn't-
and
it
seems
like
when
we
make
this
first
change
like
this.
We
do
sort
of
it's
tough
to
tell-
and
I
don't
know
if
this
is
because
the
page
hasn't
loaded
out
completely
there's
tons
of
posting
out
source
graph,
but
if
I
now
with
that
off,
if
I
do
a
shift
refresh
on
this
page,
so
we're
basically
going
to
start
over
and
see,
although
it
looks
like
I've,
alright,
let's
try
this
again
see.
If
we
can
get
this
to
shift
refresh
for
us
there
we
go
so
it
did
it.
A
You
can
tell
it
made
the
request
with
a
the
w1
in
it,
so
it
made
the
main
request
and
then
what
you
see
is
you
see
one
of
the
other
javascript
that
has
to
load?
You
see
the
disk
metadata,
so
this
is
the
first
piece
that
tells
us
that
we're
going
to
go,
get
death
diffs
and
then
we
see
one
diff's
batch
request
and
then
we
never
see
any
more
dispatch
requests
and
now
what
we
watch
this
page
do
is
sit
here
and
spin
and
spin
and
spin
and
spin.
A
A
It
was
the
first
first
request
for
five,
so
it
should
have
returned
five
disks
and
we
should
have
already
loaded
everything
in
with
the
metadata
to
like
build
headers
and
give
it
a
place
to
process,
and
instead
we
don't
even
see
that
and
what
we're
going
to
see
is
this
request
take
sort
of
an
inordinate
amount
of
time
here
and
what
I
believe
is
happening
is
where
we
don't
have
the
batch
disks
and
we're
now
processing
this
request
back
out
to
gili,
and
we
made
one
request
and
gilly's
going
to
give
us
all
1500
files
back
in
a
single
shot
and
then
we'll
reprocess,
those
back
to
rail.
A
A
If
we
look,
there's
not
even
really
any
requests
being
made
anymore,
we're
sort
of
in
like
a
total
blocking
request
at
this
point,
everything
around
us
is
loaded.
I
can't
because
of
this
request
I
can't
even
yeah
so
firefox
is
running
too
slow.
It
wants
to
cancel
it.
A
A
A
It's
mad
again:
maybe
if
we
stop
it
it'll,
it's
gonna
keep
trying
to
process
every
question
background.
There's
the
icon,
so
there
it
came.
It
finally
came
in
all
of
those
requests
so
now
we're
up
to
73,
because
we
now
ask
for
some
icons
now
that
we
have
these
diff
containers
to
hold.
But,
as
you
can
see
like
it,
it
went
and
it
took
forever
to
get
all
of
them
in
didn't
make
the
batch
request
and
then
it's
still
going.
A
So
that's
what
we're
looking
at
here
we're
trying
to
figure
out
what's
going
on
with
this,
but
maybe
this
will
help
debug
this
a
little
and
we'll
go
from
there.