GitLab Create Code Review Group, 14 May 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: GitLab 14.0 Kickoff - Create:Code Review

Description

Kickoff for the 14.0 release of GitLab in the Code Review Group.

Planning Issue: https://gitlab.com/gitlab-org/create-stage/-/issues/12823
Release Board: https://gitlab.com/groups/gitlab-org/-/boards/2159734?scope=all&utf8=%E2%9C%93&label_name%5B%5D=group%3A%3Acode%20review&milestone_title=14.0

Defining Large MR: https://gitlab.com/gitlab-org/gitlab/-/issues/327128

Remove Support for WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/228685

Create new comment on MR Diff in VS Code: https://gitlab.com/gitlab-org/gitlab-vscode-extension/-/issues/342

A

Hi, my name is kai armstrong, I'm the senior product manager for the code review group here at git lab and today we're here to talk about uh the upcoming gitlab 14.0 release and what the code review group will be working on. So let me share my screen: we'll jump right into some issues, so in 1312 you might have remembered that we talked about um large, mrs, and how large and mars were going to be an area of performance improvement that we were looking at over q2.

A

um We'll talk about a couple issues, maybe that we're going to work on. But what I do want to touch on is that we've defined, where we're benchmarking this for the purposes of these tests, and so- and we think this is a really important data point so that we're all talking about the same thing when we say a large, mr and this data was based on taking the 200 most active projects, as measured by the number of mrs in the last 90 days over gitlab.com.

A

And so we looked at all of those, mrs and sort of dialed out what the high end of the percentiles were. In terms of emergency question, how big is big when we're talking about this and so at the upper end in the 99th percentile? What you can see is the file count is 128 files, and so it's a pretty significant jump from even the 95th percentile to get to the 99th percentile, and so we're looking at mrs that are, you know in this 100 to 128 file range is where we're talking about the line.

A

Count is another important one here and so you'll see at the 95th percentile we're talking about 1300 almost 1400 lines when we get up to 99th percentile we're nearly 12 000 lines so about 10 times as large, uh in terms by the number of lines being changed in a merge request, and so we're looking. You know again in this 10 000 to 12 000 line change range is where we want to talk about.

A

You know the performance improvements that we're looking and the impact we're trying to have on a merge request, and then the last one is number of commits number commits is a little more challenging to deal with in testing, but the 95th percentile is 16 and the 99th percentile is 89.. So it's another huge jump between both of these.

A

um Our test, mrs will have not quite all the way up to the 99th percentile that we're working with, but they're they're pretty close up to here, and so um we are testing against a real uh merge request from the gitlab project uh at an older point in time, and so um we've we've got some. You know sort of benchmarks here for a real project with real activity and real sort of um you know all the all the other pieces that come along with that.

A

So that's what we're talking about here for testing I'll link this issue below, so you can see sort of all the conversations that took place and how we arrived at this and take a look at our sample. Mr, but that's what we're talking about when we're talking about large and mars. We know there are teams that have mrs well outside of these numbers, or um that this isn't large for them, and they don't.

A

You know they work in smaller, mrs we're targeting these, because even the improvements that we make, because we're trying to stay away from user experience, tricks or hiding or different workflows would benefit smaller, mrs as well. They'll even benefit the larger ones, but this is where we're focused in terms of our performance improvements.

A

The other one that I want to talk about is a reminder that uh we're removing support for uh whip, wip, prefixes and merge requests to signal that the merge request is not ready to be merged. We switched over to the term draft, that's been in the application for quite a while now and so draft will be the only supported term moving forward for merge requests.

A

The last two things I want to talk about is the vs code extension. So over several milestones, we've been working on creating a complete code review experience inside of vs code, and we are finally here fingers crossed everything goes well, so we're looking at um two issues to get this across the line. One of these is tracking changes of the lines in the diff inside of vs code.

A

um This is this allows us to keep track of what we need to the positions that we need to be able to have to make comments on the merge request.

A

So this is a the final sort of prep issue and then the big one, um the only thing we don't support currently on merge requests, which that other issue will enable is to create a new comment on the diff. You can already respond to comments if you open a merge request in vs code. If there's an existing comment, you can respond to those comments. You can you know, comment in the threads.

A

This will allow you to create a brand new thread on a piece of code from vs code and then that output will be replicated up into the merge request interface. So I'm I'm really really excited that we're finally going to get this across the line and delivered here so um keep an eye out for this. This will ship during the 14.0 milestone it'll ship.

A

In a vs code release, uh we release vs code extensions, usually about two to three times a month, so um keep an eye out for this to hit and we'll make sure that this is uh a big one that we're that we're promoting and we're excited about. So that's what we've got upcoming for 14.00 for the code review group. If you have any questions, I'll put links down below, feel free to reach out in issues or comment or tag me and we'll take a look thanks.