GitLab Create Editor Group, 30 Aug 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Web IDE Maintainer Onboarding - Aug 2023 4/4

Description

In this session we pair up on an issue around including the current username in the generated branch name.

MR: https://gitlab.com/gitlab-org/gitlab-web-ide/-/merge_requests/232

A

All right, thanks for hopping on this last session of the web ID project maintainer on boarding, uh we're gonna dive into a another issue than the one we've been working on. So let me close some of this stuff.

A

Okay, um so we've been working on fix opening from the commit- and we did this for the most part I'm going to wrap this up on my end and then hopefully sign it to one of you all to review and merge, um but I think for us to spend the most of our get the most usage out of our time.

A

Let's dive into a separate issue, this one's pretty straightforward, um but it's uh going to require a different set of changes for sure is um previously the old web ID when you are creating a branch after making a change, it defaults, the default Branch name that we kind of generate includes your user ID right now that doesn't happen. Let me open up the web ID real fast, so we can see what what does happen all right, we're pulling all of the files from the main gitlab project boom great.

A

So if I make a change to our philosophy uh and I go to commit to New Branch, this leave empty to use Master Patch random characters. uh This normally contains the username in the default Branch name as well. So that's what we want to somehow pull from the gitlab context. What the current username is and throw it into what the default Branch would be.

A

um Okay, so we'll we'll check that out.

A

All right, so let me go ahead and get the web ID project open. Let me make sure I'm on clean, Branch, okay. It looks like I'm behind a little bit, so let me update on so now I'm on the latest of main. That's great, okay, uh everything's clean! So let's create a new Branch um I'm just going to call it.

B

Add username to default Branch.

C

A

Cool all right, let me go ahead and start the web ID over here. So running, start example.

B

Push this over just a little.

A

Bit: okay, all right: it's building everything all right! So right now, there's no um there's no concept of what the current username is at all built into the web ID. So we're going to need to get that from the gitlab session context and the main mechanism for injecting things in from the outer gitlab context into the web. Id is through the config, so I can kind of assume we're going to need to update our config that we.

A

Get, and so um we talked a little bit about uh the difference between there's a client, only version of the web ID and a remote version of the web ID this remote development, one vs code. When you start it up you, you can give it um you can like connect it to a vs code server through like SSH and stuff, and when this like remote config.

A

These are like vs code parameters for we're going to start up vs code, but it's going to run through a um we're looking for a vs code backend so that you can actually run the terminal and have whatever kind of environment extensions you need that's needed for our remote development feature offering it's not to it's related to the web ID, but for the most part, a lot of our development lives here, because when we don't have a vs code, server we're connected to we kind of have to make everything on the client and so I.

A

Don't think um I! Don't think that the remote config thing is going to need the username information. um I, don't often really touch the remote config thing a lot, because it's just meant for that. One little bit that we needed for remote development, and so the question is, should I add this username property to base config or client or client only config and I'm thinking, oh I, like that picture, that's a cool picture uh I like that it was like a it. Looked like a monster.

A

Cake I'm, gonna I'm gonna, assume that you're telling me about it.

D

Yes, he's telling you all about the mying and.

C

A

It looks real, it looks really cool I, like it I kind of want to throw I, want to throw my Pikmin at it. I like it all right um well, because remote config is not going to need the username I, don't want to add it to base config so base. Config should only contain things that both the configs need so I'm going to opt to making this more specific by default and I'm going to put username here.

A

I, don't know if we like username being camel case or all lowercase uh I have no idea, but I'm going to put it here and I am G to say that it's optional, because so far we've been running without it, and so I don't want to introduce like a breaking change. So I'm going to leave this as optional um say the current username for the hit lab contexts. This um is.

B

Used for things.

A

Like generating uh default, Branch names and I'll add a link to the issue, all about adding all of that traceability to everything, because I'll forget: um okay, cool, um let's see if we have uh see if we have this.

A

Running I go over to my terminal yeah. It looks like we built everything successfully. So that's looking great um right, I'm G to move all your faces over all right. Okay and I also have the GDK running. So we should be able to start from here.

A

ah Maybe I don't have the GDK.

A

Running yeah looks like I: don't have the GDK ah come on? Why aren't you running all right? Let me go ahead and start the GDK. um So in the meantime, instead of connecting to the GDK I'll just connect to gitlab.com- and this should work, it's going to throw the warning that I don't have right access because I didn't provide access token to it. That's all fine.

A

um Great I'll provide a token to it once the GDK actually starts up all right, I want to somehow test the username stuff in this example app. So somehow in here, I'm going to need to inject I want to inject the username.

A

So all of this, like configuration parameters for setting up this web package, that's decoupled from the main git lab project. As you can see, this kind of grew in scope since it first was developed. We got this check box here and we have this thing here like so I, don't want to just keep, adding and there's, obviously, probably better things we can do.

A

I don't want to just keep adding fields to this thing, although I could another thing that we were doing to inject values into the example app- and none of this is super documented, but here's where you can find it is in the example package in the web ID component. This is where we like set up the config, so you can see where these things come from.

A

um So if we go to start client.

A

Only uh we're passing in a bit of the config. We spread those properties when we are calling our start method, but then we also get some config values from Cory parameters and that's kind of a simple way to inject Fields. So I think that's where we're going to throw the username.

A

So you can through the example app you can test what happens when we have a mer request, ID and we have like file paths, and these are the kind of query parameters we get normally from the um in the actual project itself, uh but I think I'm just going to throw username and I'm going to put at the bottom, because I don't really quite know where else. To put it.

C

A

Get username yeah, so we just do something like this. This partial thing is super cool. If you're not super familiar with typescript, if I didn't have this correctly, it would start yelling at me. So this is ensuring that I'm only returning part of the keys in here, but they have to be keys in there. But that's kind of cool um typescript super smart partial is like a built-in typescript. uh What would they call it? um It's like a utility type kind of.

C

A

Okay cool, so let's, let's do that, but let's also go ahead and consume it so that I can I can get the full feedback loop, while I'm testing this thing out so I'm, jumping into where a lot of the runtime logic of the client web ID lives, which is in this vs code extension. This is our built-in extension, which is the engine that runs um like getting the file system and loading all those vs code, specific stuff. We need.

A

uh Okay, but we also get.

A

um So the activate command- that's exported here. This is our entry point into there and I kind of all. What I want to do right here is I want to just get the config that we started. Things with and I want to show message the username want to see if we can do.

A

That um there's some other things in Flight right now and other mrss I know are going to make this easier.

A

um So one of the ways this is set up, I'm I'm I'm hesitating because I'm right now trying to think of what's the easiest thing we could do at this moment, but one of the ways this is set up.

A

uh This function only runs once uh we call this initialize with progress which calls initialize. But we have this function then, like this initialize function, uh that gets um you see that gets referenced here when we do this register reload command, because after I've made a commit or after I've made a change, we kind of need to like reload everything that we just got, um because sometimes, when I make a commit, a other commits have already happened underneath me and there's even like file system changes.

A

So after I've made a commit on the web ID, we kind of need to get the latest of stuff, and so current way of doing that is: let's dispose everything and just start over, and so all of that lives in this initialized function. It's like okay, we're! We either just made a commit, or we just loaded. We are starting all this stuff up and we call our mediator commands, which is we have this weird start, one which makes all those initial fetch.

A

Requests, but what we don't have in this scope is reference to the mediator command that just Returns the whole config and in a separate Mr. That's in flight I've I have added that here um and I'm thinking. Maybe we want to just do the same thing, which probably be the easiest, or so that's one option rather than here we have a start that we're referencing the media commands.

A

We can just have one called get config, and then we can just get the username clearly from there or we update start to return the username that we need from the confi. What's your.

D

Preference I suppose if we have or if we have an inflight Mr, which is doing the changes, can we like strip out the change like we like cherry pick, just that, like that set like subset of changes.

A

It's a good idea: yeah.

C

A

It's really small too, like we can even just redo it here, because it's the um so let's, let's do that here. um um I, don't want to add to start, uh which was my concern.

D

But and even if we're doing like the quick and dirty thing, could we either use local storage or even like yeah, like either local storage or like process, the cve Brom.

A

So that's that's an interesting question, so um the vs code extension runs in a sandbox, so it does not get any access to the outside session. So but with the exception of we can write things to like a vs code, specific storage um but I'm still not like super familiar with that it might be possible. But for right now it's kind of the config is the thing that holds everything.

A

um uh So we already have the meteor command for getting the config, because um the vs code extension project needs to use this. uh The only difference is we're not calling this from our web ID extension, and so we just need to add a reference to this in um the our vs code. Extension web ID package, where we have our mediator thing here: I just need to add one where I'm export get config and yeah, let's just copy what I had going on in in a separate.

A

A

Here this has been.

A

Okay, all right, yeah, I, I, updated some stuff with some types, because um yeah yeah yeah for some reason this these types- we're referencing just a very small subset of the config, but we actually, let's just use it- to return the whole config, so I'm, going to update we're going to manually copy some of these changes over I'm going to start here with the types one so in mediator, command Source types: uh let's go there. Mediator, commands Source types, uh so I'm adding a reference to this.

A

This is coming from that interop package, where the um what the the desktop vs code extension is going to expect in the web. Id, environment and I am saying that the this full config, which contains this extra thing, which is that's kind of a code smell, but it's fine right now. um It's going to extend both client only config and interop config interop config is just a subset of that client. Only config, which we could probably update our interupt to do that as well.

A

um But typescript is smart enough to just be able to resolve all this, so we're so we're kind of cool and if any of these properties start to get out of sync, we'll start getting type errors and we'll be able to resolve it. um But now that I'm doing that, that gives me the confidence to make this change and not feel any negative effects.

A

So here where I'm doing get config, this is an interop command that the separate repository is dependent on, but because I said that that full config extended the inop config I can replace my inop reference with this one and feel confident that we're okay and we are so um that's me kind of explaining some of this pipe piping, changing that I'm doing here. um But since everything's, compiling I feel pretty good, uh then the last thing we do we want to do. Do you see what just happened?

A

This happens to me a lot I'm here and I click on a file, and it takes me to the very.

A

C

um um I don't see this happening like on Chrome, though, so maybe it's.

A

Firefox for I mean never happened me uh before I I use.

C

A

Maybe that's a good point. Okay, all right! Here's me adding reference to getting the config um in the our web ID vs code extension. It needs to call the um mediator command, so we're going to add a reference to our git config.

A

Command here, when we're importing these different types, I want to make sure I'm referencing the same type that we used to declare that command and then here I'm going to actually have the function to get the config cool all right so now, I can get the whole config pull just the username bit from it and use use that as I want and not worry about um further selling. All of the business that start does um okay.

A

So let me hop up to the top of this, and let me see if I can do this equals wait, get config! We good yay, we're good, all right, okay! So then I'm just going to drop into here. If username, let's do something like wait: vs, cod., window. show information.

B

A

Hello yeah, just what do you think you're doing username, uh okay, cool so now, I should be able to see that com in. Let me go ahead. Question.

B

E

Yeah I I'm not sure if maybe I'm wrong, but I. Remember that you said that if you don't have a username, this will set a default username an empty string. So maybe you will always have a username right.

A

Oh, that's a good question, um that's a really good question and in JavaScript empty string is falsy, so I can check.

E

A

So I'm I'm guaranteed it's going to be a string with a length greater than zero. At this point, but yeah, that's a good question and you're right, I default did it to an empty string um and so I need to be able I need to not just do and for that reason, you'll see I. Think throughout the code is like I'm not going to just do a specific baliness check because I'm concerned about it actually being there so I'll I'll do more permiss of just I want to do.

A

The full truthy check make sure this isn't actually string, yeah, um good question, um okay, so I'm here, and no, no, no, no, okay, all right, okay cool! So I should run this I should get no message and everything loads. All right, I get no message everything loads. Okay, great! So let me then add: username equals.

C

A

See, oh look, hello, Paul.

C

A

We're we're cooking with gas.

C

A

Cool all right, so this isn't what we wanted to do. We actually want it to be used elsewhere, so when I am um generating that, why are you still loading? Oh, it's still loading because I waited for that message once I. So that's an interesting thing: did you see what just happened? um The way these vs code messages uh work when I await one of these calls? These are asynchronous calls and they will respond.

A

It's possible for me to provide like different set of actions to it and they'll respond with the key of the action that was taken or something like that. But if I want to just fire and forget a message, I shouldn't await it since I awaited it. Nothing else was loading until I Clos this out. So then, once I close it, then everything else will load um some quirks with the vs code.

A

Api of like when you see us sometimes we'll need to wait something, and sometimes we want to just show a message and don't wait for it. um So you'll see that that and because we have an eslint rule about hey, promises must be awaited. You'll see us saying uh this thing doesn't really work, I, don't know why that's a suggestion um but you'll see us just disabling for this line and saying something like we want to fire and forget here something like that: um okay,.

C

A

uh We prob, probably already greed.

B

A

We don't want to come across it's too friendly.

A

uh Okay, let's see if we can actually get um the okay. Are we actually running now? Are we gonna be okay? Gdk come.

E

A

Oh, but it is wait, is it pulling it's not pulling from it if I do GDK that so I have the same project and ref in my local.

A

Gdk I think it's GNA time.

A

Out come on GDK, you could do.

A

It you know, uh sometimes the GDK really puts the GD in the GDK.

B

uh Right, let's restart.

A

B

All right yeah, this is GNA.

A

Be right now so I wanted to do that, so I can get to the um I wanted to get to the menu where I'm creating a new Branch, because that will help me find where it is in the code, but I'm going to go ahead and sheat and we'll open the GDK. Here. It's not cheating. It's I mean we'll open up the web ID here, uh uh I'm just gonna I'm, not g to wait for the GDK to.

B

A

Okay, we good we're.

C

A

All right started making changes committing to a new Branch. Okay leave empty. To use. That's the thing: I'm want to I'm, going to look for leave empty to use, leave empty to use all right cool. We got this cool thing called prompt, Branch name all right. We've got this thing called generated, Branch name, okay, so I think. The change here is probably pretty straightforward, where we can take an optional parameter of a.

A

Username and how do we want to do this, something like uh how do we feel about turn Aries Maybe, not maybe in this case it's okay.

D

Yeah I think this is pretty straightforward, so it's fine.

A

I thought it' be easier than like uh um what am I thinking. I thought it'd be easier than somehow like shoving it in the middle of it when it has.

D

Well, I suppose, if you shove it in the middle, if it's empty, if it's falsy say m% m% empty string, maybe oh now, then you have to deal with like the.

A

We have to still comp the like, Hy and stuff yeah all right. The one question I do have, though, is I want to make sure we're consistent with how the old web ID was doing this um so I'm going to look for uh look for username inside of IDE follow IDE files in the current project. uh Not quite oh wait here we go yeah. Look at this okay, oh it looks like it starts with the.

B

A

Okay, so we will um start ours with the.

A

Username, uh oh man, a lot of me is okay. Yeah I'm gonna have to I. I was like uh all right. I'm GNA do something like this. We have suffix equals username, username pop otherwise.

B

A

And then we can just return.

B

Suffix ah I spelled suffix okay,.

A

Something like that.

D

Prefix now as well, because you moved.

A

It around prefix, it's not you're right. It's not the.

B

A

All right, um okay, cool, generate Branch name, that's kind of doing the thing we wanted to do now: um prompt Branch name now that needs the.

C

A

Okay, so all right, I'm going to pause real fast I could.

A

Like one option is generate Branch name, this thing calls the mediator or like even this one. This calls that mediator command to get the config and to get the username and like doing all of that, but throughout all of this you can see there's some pretty poor, State Management of like we want to have a nice single place where our state lives and I would love for to not tie everything to that, like state store where our state is, and um that might so I um for the meantime.

A

uh I, try to just leave like the main entry point that glue code is the bit that runs as separating like our separating like our business logic from the bit, that's actually integrating everything. So that's one of the reasons why I'm opting to use parameters instead of just coupling this to the config, although maybe that's a totally acceptable approach, I just without thinking about it. I'm like. Let's try to avoid that, if possible, if it makes sense, um who knows it might not make sense all right.

A

So now, let's see where we use this thing, uh let me go to references of prompt Branch name, get Branch.

B

A

Okay, okay, yeah: we do this a couple of times. Maybe I do want to call the config from here. um What do you.

D

C

D

I suppose what areas are we calling it and do we have config accessible nearby? Currently because it looks like we're calling like a helper.

A

Be we're going to be another like we're. Gna have to go another layer up so like what I'm imagining is. The option is, and so this is a big to-do for developer experience level. Ability on the project is. We need a single source of Truth for state and this package, which we don't have, and so we just pass all the parameters down. But we're going to need to probably do is something like: okay, we're initializing, Source control, we're going to have to add to this list.

A

Here's the current username and like freckling, all of that down when I have uh another. You know work, that's been sheld but I'm going to unshell it hopefully soon is we want to create things that are able to reactively. You know, watch State kind of like you would expect with like view components, we can do that from this context. It's just takes a small amount of set, but yeah we're going to have to like do the props drilling down a handful of levels and that's not desirable I kind of thinking.

A

Let's just throw this into here. What do you think.

D

Yeah I think I think having like view like State Management, where you can have like well I'm thinking of like react and more familiar with react where we have like providers and consumers, though. So if you have something that's providing at the top level and then something much like further down can consume it. I that be great down the line. But for now, given the way we're doing, States I think it's probably okay to drill drill through.

A

So well so yeah! So what do you do? You think we should handle this through passing a parameters down the the stack or should we can should we just directly fetch the using name from the.

D

Config, oh, so, are you proposing up for we just pass the config in to the function.

A

Well, we don't even need to pass it in I could just call the mediator command from here, like from prompt, Branch name. I could just call the mediator.

A

Command to get the username.

D

That's probably fine, yeah I, don't know yeah, I, guess yeah I, guess we're not being explicit and I'm sure like with config, do have any secrets or anything sensitive in there or is config always like data that, like is sort of known to the entire plugin.

A

It is Data, that's known to everything it um technically can contain, uh for instance, in the example project when I'm giving it a token, the config will contain the token, but this doesn't happen in the actual running instance of gitlab, because we don't use Focus like this. We just use the main browser session. Naturally like so there's, it's not going to contain any secrets, so it should be fine. We already have like this. We're already have this command for doing this.

A

um With that being said, we do have it in the pipeline to move away from the whole mediator commands because we've, you know, we've uh architected the vs code approach for how we can authenticate requests seamlessly without needing that um using they have like their secret storage and like authentication providers and stuff.

A

um So the goal would be a moving away from mediator commands but like what she said about yeah, we want to have some sort of store that has state that provides something and then other things can declare themselves as like, hey I'm dependent on the state I want to like hook me up with it. Maybe this kind of maybe this kind of code makes that dependency clear of like hey. All of this needs to be hooked up with the current username so like when we do that refactoring.

E

B

E

I think it's okay to have it there uh and then you have. Maybe if you need that usern located in other components, then you can make it available from the in the initialize, but now that you only need it here, maybe it's okay to have it there, instead of reing all the passing the argument.

C

A

E

A

Yeah I I think it's going to make it the dependency of things a little simpler when we refactor things down the line. So, let's, let's maybe try that out.

A

um So much so much love I want to do this project I'm, so glad we're gonna have so many maintainers that can reveal all the refactoring MS uh cool I like it. Let's do it. um Hopefully we can abstract State into something that can be easily provided injected.

C

A

Made reactive and easily PR yeah, so I actually have I, actually have a branch for this. It's just I think I stopped because I was in this um kind of elaboration phase with it, and so I had touched a whole bunch of like what what's the ideal, State and and um I really liked the approach. I just haven't. Okay, now that I have some sort of Ideal I need to find the iterative steps towards that.

A

So we don't just have one crazy, huge, more uh okay, but let's let's go and do this, but it does bring me to one thought: is we get this config every time we call Prompt Branch name, but here's the deal.

A

I mean every time we do this. Are we going to execute this command and wait for it and stuff like the config, should never ever change? So what do you all think of you know just memoizing this.

D

D

Right is: is there actually a memoize function already, that's awesome.

A

I think because we're using low Dash so I think it's just like boom. Let's just do it so um all right. This is mem wise, because the config.

B

Should never ever change okay,.

A

Cool um at least I'm at least I'm making note of my assumptions.

A

uh All right so yeah, if we go back to where we're at we added the username there. um This was updating the mediator command so that it's oh wait. This is our vs code extension so that we actually have this in our list of reference mediator commands we update generated Branch name, it's clear. This is like a. Let me go back. Let me make this wider. It's clear.

A

This is utility function that should not reference any kind of commands, or something like that so like hopefully, that's clear how this is a bit more glue codyy than the generate Branch name function here we reference, get config, that's great, and then these are updating. Just those types and I think I think it's going to be it um cool I just had I just had a crazy thought, though. Oh no is it possible for a username to contain characters that are not allowed in a branch name. Do we even care about that?

A

We might care about.

A

That I think a username actually I think it's allowed for a username to have a dot in.

C

It um what what kind of characters are not allowed in a branch name.

A

I think a DOT is not allowed.

C

D

I think a DOT is allowed because you can have dots and tags and I think.

C

A

Yeah May, oh maybe it is then that's great.

C

D

Oh, oh yeah, there's actually a git command for it, so you can do get check ref formats and it'll. Let you put in a string and it'll. Tell you if it's valid or not valid. Oh.

A

Cool, so it does.

B

A

Allow a dot, yeah, oh cool, all right! All right! Here! We go! Yes, all right, we're in all right, um adding my username G to make a lowercase letters just for fun all right. Let me add I'm G to stop pausing my screen, because I need to open up one password where I have my um I have my pokon in okay, we're back to sharing.

A

Boom all right, I start making a change. I go here, commit to New Branch.

B

Wooo there it is.

A

All right, I press enter and we've made the branch what's wrong with you. Oh it's because I'm not signed in to the git lab instance. I was uh now. We should be good. A yeah, sweet, okay, cool. Let's try, the let's try the no username use.

A

Case um the no username use case- oh I, got to add the token back all right. My one password should be.

C

Available all right.

A

Pop all right: let's try this again make some random changes so that Source control lets me do some commits me. A new Branch cool I didn't provide a username. We didn't blow up.

B

A

Important cool and I keep calling this again so yeah, that's it's! It's happening great I love it. This is it generating a new yeah, it's generating a new little thing. Every time, cool, awesome, all right, I think that's about it. um So I think now we can actually probably push this up but, let's say maybe add some tests. Maybe before doing that, so we could do some test coverage and then call it a day and then all become maintainers and hopefully improve upon the quality of the project.

A

um Iteratively yeah, there's not much Behavior. That's changed! That's going to need um that's going to need testing I, just see it in generate Branch, name and prompt branch name. We don't test the example components because that's just an example thing like we could, but it's not worth it.

D

A

Is not the right answer, but it's kind of what I mean um I think we have a test for here. So.

A

um Yeah I'll I'll: let's, let's trying to copy the pattern of the tests here and see if we can uh see if we can add test coverage for that file change, we have pretty good test coverage. I forgot how to run the just coverage um example, but it's like in the upper 90%. So we try to try to keep everything pretty well unit tested um because we're still lacking like integration testing, which we'd really love to do um of like have Cyprus or something like that running through uh some of the use cases.

A

We have like end to end coverage on the other end of the scale and we have like feature spec coverage um after everything gets run into it. It'd be nice to have some integration coverage on this project itself, so that we have some more immediate feedback when it looks like something isn't going to work in that regard, but that's fine um all right.

A

Let's, let's try this thing out: we're not passing any arguments to it. I added the line to it. I'm gonna run just I'm run Watcher on this.

A

File cool all right: it worked if I.

A

um Yeah, so when I call that mediator command, uh we expect it to have been called great. We can add an assertion that it's U mem wise, um maybe that's a wise thing to do.

A

uh Get config is minimalized, so I'm going to do something like I expect to PS code commands execute command not to have been called. Oh, that's, maybe kind of assumed by the other test, but that's fine.

A

um And then I will um I think this is mocked, so I can do vs code, commands., execute command.

A

Mock uh resolved.

A

B

A

Yeah I'm G to add this is like our test config. So we'll return our test config the result of.

C

A

Config I got to make this there.

B

A

Okay, so I would expect this to only have been called once to have been called once and I would expect Result One to be result. Two.

B

And I'd expect Result One to be.

A

Task didn't get called at all ah didn't get called because it is.

A

Memoized yeah I didn't get called because it's mem wise and it's called in the previous.

A

One, um that's fine, uh yeah.

E

Poli station in there in in the it.

C

A

You say it again.

E

Yeah I mean if you are going to test the get config the memorization and you have it already memorized. Maybe you want to clear the memorization in that look.

A

I think you're totally right, um so there is uh I forgot how low Dash does this.

D

Looks like there's a a resolver argument which Returns the cash key.

A

Yes, I'm going to look up mem wiise in our uh test files, um because I know I've done this before. uh Oh no, don't tell me it can't be that's the only one. Oh my goodness! That's disappointing! um Okay! I know I've done this before, but yeah you're right there's this thing called um all right: I'm going to have to open up the the file so we're here in b code extension web IDE mediator. Here we go all right. This thing returns a yes.

A

It returns like a MIM wiseed function, so you're right I should be able to do something like this, and it should be smart enough to know that I can do get config.

B

Dot cach clear. Yes, yes, yes, yes,.

B

A

Right, yes, brilliant! So if I was smart, um I could would probably do this in a after each for each. You know clear.

B

Memorized things keep test.

A

A

uh Yeah I, don't know why cash I don't know why clear would be optionally not available, but oh well. It looks like it's there cool great um nice, so we added that test. uh Let's go to generate Branch name that should be fun and.

C

A

Right subsequent calls are not equal man, that's the that's the pesting out. It's not a purely deterministic test there.

A

uh um So I guess we want to test. um It includes username when.

B

A

Generate Branch name main username, uh lpsum and I'll copy. This thing.

C

A

Ipsum I'm running the wrong.

A

Test um there's some cool like vs code, just extensions um I, just don't have them installed because uh they don't work well on the main project which has so many tests, so uh the chances are, they would work nicely in this project cool. We did that one. Then this is the last one. We um let's check this one out all right. Let me close our other tabs. Let me open this one up. Okay, so something that's already happening.

A

Is we're mocking the generate Branch name in this unit test, which that totally makes sense, I kind of see that we're going to need to probably do the same thing for like the config mediator.

A

Command the the new thing that we added here so let's go ahead. Excuse me: let's go ahead and do that um so I'm going to mock this, and that lets me um uh that lets me do something like this. So when I I'm getting all of my mediator commands in my before each I can do something like uh get config mock resolved value. I g do something like this.

B

A

Not going to like it, because um it's expecting it to actually be.

A

A

um And so I don't think I have a full config I can actually put in there, so I'm actually going to just cast it to a config since we're just in testing land. Sometimes we'll just do partials but then cast them to the full type so that Jess doesn't start complaining about it.

A

um uh We could do something like this. This might be smart. um Have my test, conf and actually say this- is partial of a full fake, so I'm actually have some assurance that I'm doing uh uh fer.

B

Let's just call it Lauren user.

B

A

Are you upset, oh just because you're not used, you want to be up here. Okay, so then I'll put test config here um that way. I know if I'm providing something that's not actually part of it. I can get some early feedback on that, because I moved it to its own variable and gave it a type I'll get early feedback if I'm doing something. That's not.

B

Matching the type.

A

uh All right, let's run this test, hopefully everything's still passing cool.

B

A

So here we've hardcoded: this is the generated branch that we're doing so that's not going to change, but what I think I want to add is just like. Okay are we calling generate Branch name with the username that we expect? That's I, think a little bit is what I'm expecting we would do so it passes username to generate Branch.

B

A

Expect vs code or no expect generary Branch name to have been called with uh I, don't know what you're gonna be called with. What.

C

Are you called with.

A

So, let's, let's Let It, fail and see: okay, where' test main come from. Oh that's, the test, Branch test branch and then test config.

C

A

Cool great we're at all the test coverage. This is ready to go um so I'm going to commit this push. It up, create an MR I'm, going to add thanks to you all, um but then I think I'm actually going to sign it to one of you to merge pretty soon so that'll be fun. Well, thanks for all of your help and participating in this project and participating in these sessions, it was awesome hanging out with you all this.

E

Month, thank you for everything.

D

Thank you, I'm G, to go design the neovim session to look exactly like yours, because this has been fantastic. Oh brilliant.

A

Yes, yeah well Al. This is all inspired from what Tomas kicked off with the vs code uh extension. So, um if you're looking for more type script, projects to be maintainers to um I, think there's there's a ongoing need in the vs code. Extension for maintainers as well. So uh awesome thanks everybody, and if you have a chance to play, Pikman 4 I highly recommended it's lots of fun. All.

E

B

E