GitLab Support Team, 24 Nov 2022

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Working on a Pajamas MR - Support coding office hours

Description

Working on a Pajamas MR - Support coding office hours

See https://docs.google.com/document/d/18_jSEx9Wnzm2H7xd7xuQi3cEsFO7ER6inbNBitEKd-A/edit#bookmark=id.nvff0q1zkhe6 for notes

A

Hi everyone, my name, is Anton Smith, I'm, a senior support engineer and the support department here at good lab and today I'm just going to show a couple of the folks here how to do a pajamas Emma, so the Mr that I've or the issue that I've decided to work on today is this so use the pajamas button component for form submit on this haml file right here.

A

So luckily, for us, there is a link to the actual source code on what we're actually changing today and just scanning this Hamill file. I can see that there's a submit button, so that's likely what we need to change and then we want to actually look at what we're changing it to so something like.

A

Changing that to that by the looks of it, so it's actually pretty it's a pretty simple change, um but the thing is you got to make sure that the layout of the buttons and stuff look right. I recall when I did the avatars in the last pajamas party. Some of them had custom styling, and it can look at that wonky. So sometimes you do have to play around with it, but um yeah luckily, for this example, I think it is quite simple, so we don't have to worry about it too much.

A

But um probably the next question is we. We need to actually find this in the UI before we can actually do anything, because we can make the change in the code, but what's the point, if we don't actually see it reflected in the UI, so um generally, what I do in order to figure out where it is, is, if you just look at the folder structure, so I mean straight away.

A

I know it's in the admin area under the settings area, but because this is a partial view, that's the underscore at the start, so a partial view can be part of you know a normal view, so there's a bigger view somewhere that this is encapsulated with them. So we just need to find out where that is um so.

A

I'll just show you how I find oh, no I won't use that one I'll show you where I find things now there are multiple Pathways to finding stuff that you need, um but this is just the way I do it. So what I'm going to do is I'm just going to search for that um specific view in the code and just see if I get lucky.

A

Okay, I've got nothing so, let's just try searching without the okay, so a view has come up and we can see it's an application settings network.

A

So if the memory serves me right, there is a network tab in the application settings, so we can quickly go over there. Okay. So this is my GDK.

A

And what was that? The settings network yeah just wait for that? So I haven't loaded this page before foreign.

B

Just close a few of these.

A

All right, so if we go back to.

A

Did I close the tab, I actually needed I did.

A

All right, so, if we go back into here, um one of the things that are good to search for is just the names of fields or descriptors, so that to me kind of looks like some helper text.

A

um So hopefully we can find something on the page that kind of resembles that um oh there you go so that was nice.

C

A

Easy, so this must be the guy or the lady, depending on how you refer to buttons. This is what we need to change right here.

A

So um one of the helpful things here is when you're running a GDK or you're running routes in development mode. It will actually show you um the paths of partial views right there, so you can see that that's this actually matches the file path here.

A

So, yes, I think we're in the right place. Any questions so far.

A

All right, you don't have just a reminder. You don't have to wait for me to ask feel free to interrupt at any time. If you have any questions concerns, if you want to be rape me for doing something wrong. Alvin thanks Billy!

A

Please do all right, so um this looks pretty straightforward so um because, um when I make changes to the code in real time, this is also another strategy to actually figure out if you're in the right place, so sometimes I, just like deleting things and then I, just refresh the page and then see what happens.

A

Other Engineers I know will actually just change titles to things or you know, change, color or something, but yeah I, just prefer deleting stuff, so I believe it was under. Where is the limits stretch.

A

So if you recall in the code, I actually deleted the button and now it's missing from the UI so pretty sure we're in the correct spot um so yeah, let's uh just bring that back, um save the file, so that was a control. S command s, we're saving it and okay search search search.

A

Okay! So that's there now! Okay! So at this point we need to go back to here and oh, no, that's the wrong way.

B

A

You can see how I quickly Lose My, Places and issues just open the link again. Okay, so see the parent Epic okay, so we've got two examples that we can try out. So we can either try changing it to this, or we can try changing it to this now.

A

What I'll do is I'll copy both in lines, so we can examine them both. So there's that one and then there's this one.

A

So I'm going to be aware of when you're editing, hamiltonpots the indenting does matter, so you have to actually get them in the right spot, um yeah just one of the quirks, but some okay. So what we have here is this is the original um I? Don't think? That's a comic, but I'll just put it there anyway for now and uh to change too, and what we want to do is we need to get rid of this one and change it to one of these so straight away.

A

We've got data attribute, so I think that this is probably going to be the one we choose simply due to that, and we just need to make sure everything matches up. So anything in data needs to equal. What's in here, so it looks like that's true.

A

Don't think we need the class name, because we don't actually have one here that matches up, but I'll just try it with both and see what happens so with and without disabled. True, you don't want to disable the button, so we might actually remove that.

C

A

What I'm going to do is, let's just make the change.

A

And I'm going to get rid of I'll lay that in just to see what happens, I think that's just going to show us a disabled button. Anton.

D

Didn't you just change the class I.

A

D

A

So um I believe so, let's get loud mt5. So it's that's a layout class now you can see here um in the example, remove the CSS class to start it as a button and add the pajamas button to true. So you can see that these class names, while they do exist in the CSS file, the cut I kind of like to think of them as deprecated. So that's why I replace them.

D

I see okay, okay, yeah, so are there sometimes uh classes that aren't like like? Is there a way to tell if there's a class? Well, this sounds like such a new question. Now this sometimes CSS classes, that I mean are there some guys crosses that aren't CSS classes.

D

A

Yes and a good example of that would be, you know in JavaScript, so sometimes you would refer to a you know: a collection of an array of different uh Dom elements using the class name.

A

So sometimes you might see that but there's actually no CSS rules binded to that class. Does that make sense.

D

Yeah, so um is there an easy way to tell if it's a CSS class is that the GL dash button.

A

Yeah generally, no there's no there's no easy way. Unfortunately, um most of the times if it is a special CSS selector. Oh, if if it is a special class, that's not being used in CSS, it should be pretty obvious. Like it's not going to follow this naming convention, it will be something it will be a functional name.

A

So if it said something like search button table, you know that's a very functional name, so maybe it wouldn't have CSS roles and I mean the other way to tell actually now that I think about it is if you go into here so I mean if you've ever played around with the developer tools.

A

uh Let me just select the actual thing. You can see all the CSS rules here. So, um for example, there might be a rule that says um you know that search box table or whatever, and if it appears here and it actually has CSS rules, then you know it's actually got CSS attached to it.

D

ah Got it got it yeah? Does that help yeah? So if you clicked on this button like if you on over here in the developer tools, would we see that the GL dash button? Okay? Yes,.

A

So you can see the GL dash button here.

D

Yeah, okay, gotcha.

A

Yeah and I mean for those that have never used this before it's actually a really good way to just have a play around with the web page, and if you want to you know just um you know: do mock-ups um live so I mean you can just start. You know clearing out things and doing whatever. So, if I wanted a background, color or something else, I, don't know tooth, like you just change it immediately or if I want to. You know give us.

A

It's been a long time since I've done this border, color I, don't know! Maybe if you make a white and then just order.

A

A

Let me just undo those changes now. I think I've already saved the pajama I've already saved the pajamas code, so.

A

Should be able to refresh it now and if I go back to the search?

A

Okay, no, that's funny! The button looks different.

A

Oh because it's disabled, that's right, so um you know.

A

Prison Anton just realized that so we just remove that.

A

I did sober, didn't I.

A

Let's just make sure.

D

hmm What's going on here.

A

Data disabled do I have to actually interest on them. Oh, what the I don't.

D

Know so, what's that, what's that, what what? What is that exclamation for.

A

Oh no I was just surprising. My cable wasn't working, but it turns out they can't type anything in here, but numbers for oh yeah, because that's a new Merit there must be numeric control, yeah type number.

A

Okay, so the button itself seems to be working, but.

A

Yeah, for whatever reason, I'm, not sure why it's um doing that normally, when it's a pajamas element, it should wrap it and it should say it's a pajamas element.

A

A

We've done everything correct pajamas. That was true.

A

Did I get the ending right? Let me just let me just revert everything. Yeah the engine tank was on the horizon level.

A

Yeah I select, uh they may just remove this class name and just see what happens yeah. So you can see um it can take a little playing around sometimes.

D

Maybe you've got maybe you've got caching turned on or something oh. No, that's not right. No.

A

No, it's disabled.

A

So the background color of the center is this.

A

Where is the if I revert it? Where was the color coming from?

A

Let's just put both buttons on the page, then we can actually compare them both and there we go. So what makes so. This button is different because it's got these GL okay, so the GL button is where it's getting its colors from.

A

A

So we kind of want.

D

To maybe maybe that's the new theme that that normal one that you're looking at right now, maybe that's the new theme.

B

There's somewhere in the design system, that shows us what it's supposed to look like.

A

A

A

uh Every time I think about this I just think of bananas and pajamas.

A

Anyone watch that maybe it was just me when I was younger, are.

B

You thinking what I'm thinking all right, yep.

A

I think I am V2 or something like that. Isn't it.

B

That's it so they look like what you saw.

A

Maybe we need to add these classes. Button confirm so button confirm seems like a bootstrappy class.

D

It's also got GL button in there as well.

A

Yeah, so that's why, in a little confused because we're getting conflicting.

A

um Okay, so it's oh wait. That's not even the bootstrap website.

A

A

So this one's just a button primary.

B

A

I'm not sure if it actually uses bootstrap under the hood, but that's normally what I refer to anyway, when it's using a bootstrap like class.

A

All right. Let's just add that in just see what happens so.

A

Income bone confirms: let's go back to here, I.

D

Think the GL button one was there.

A

D

On GL button class was there.

A

Yeah, it's just that it's saying, remove it so I'll go there trying to see I'm just reading in here. um Normally they have examples in here.

A

But they haven't got any yeah. I might just have to hit them and I'll just explain to.

E

Them yeah, if you look at um the original issue like for this particular file um example, one removes the class altogether and just replaces pajamas like and just has pajamas button equals. True.

A

Give me a sec. I've lost my uh Australian foreign.

E

A

But then pajamas button is true right at the end.

A

Let me try. Example, one.

D

Why would either of them be different? I mean they should have the same effect right? Why would there be two different results for the two different examples.

A

Because one has a data selector, so I think it was the main reason why But to answer the question I have no idea. That's often the mysteries of development. Sometimes you just have no idea how it actually does stuff behind the scenes.

A

Yeah there's something yeah. So now it says, pajamas been true.

D

Maybe your GDK doesn't recognize the pajamas button.

D

Well, it's probably running on a Mac. So what can you say right? Oh.

A

That's Apple silicone to you mate, but yeah, it's better than those Dells that they uh distribute out there.

A

um So I just update I just updated my GDK today, it's it's! Basically, um you know 30 minutes old, so I'd be surprised. If this wasn't working.

A

um This new behavior is only available. The problem with a custom form Builder.

A

So if the submit button as part of a form, four then changing wait, a minute did I miss a step.

A

Is there a form for ah there is that's why it's not working ah I skipped right to the examples, so, okay, so what I need to do? Oh won't that be funny. If that was all that was.

A

There we go so. This is why you should read instructions fully all right, so at least it's actually doing what we want it to now. Okay, so let me just get rid of donation mean that anymore.

A

So we'll leave The Styling that they've um proposed in the examples but yeah you can see it's not a macro issue Alvin. It was just my uh silly nature that I didn't read um bar up enough.

D

No, no, that's fine, I mean people with Max, usually don't read about anyway.

D

I just could think hey. um I was just wondering Anton. So, even though, even though both of those examples are the same, I mean they have the same result, why they look so different they're like different in functionality or something between the two examples.

A

D

Time when we'd want to use the second one over the first one or.

A

Yeah, so it really depends on the button that you're replacing, so you can see that a very basic button might just look like this. Originally.

F

A

Probably search for a couple if you'd like, but um you can see in the code here, it was actually a more complex example because it included a data right element as well. So I think anything in the data array will just insert some additional attributes in the Dom. So.

A

Yeah, so you can see it's an additional um element there and um now that I know that the pajamas element is working. You can see that there's. This comment where the um pajamas component is actually being pulled in and.

F

A

Into this template, so we know it's working now.

A

um The other thing to do at this point is actually just test that you know the form actually submits and it does, but also um we want to check and make sure that um the layout is, you know more or less the same, so what I normally do is I'm going to revert my changes really quickly and I'll just rename this to old. So we know the difference.

A

So this is the old button and then that's the new one. So it's just making sure that you know the padding is all right and things like that, because uh you know because we're replacing it, we need to make sure that the UI is still the same. So we can see that the pajamas one has added uh some padding or a margin yeah, it's added a margin of 16.

A

padding of eight and then I guess it will have pad. Oh no there's no margin under it. So, okay, so these debts, and then we could just check the old buttons see if it's more or less the same, so the field sits there notice how this button is not adding padding on top.

A

Or margin I should say: oh sorry, I always interchange those two terms so yeah. The only difference with this button is it's just not adding a margin on top so.

A

Yeah I can't edit that oh okay uh 16.

A

What was that one yeah 16., so you can say more or less is the same now, but um because um the pajamas component has padding on top I'm kind of like well. If it was there to begin with, maybe I should just leave it, oh because the component does that I might just believe it the way it is and I'll just point it out in the Mr that hi um the button has added an extra 16 pixels on top.

A

Is this a problem and then I'll just let the ux reviewer decide, but from that perspective I mean it's all done. uh The Next Step would actually be creating the emails.

A

D

uh Just another quick one: it said that the the issue says that you should try and create five changes per Mr right. That's.

A

D

A

D

Want to do five of these before creating yeah.

A

It's definitely for sure, so, I've only done one today, because um you know it's just a simple. You know we only got an hour um but yeah you you're right. So ideally you kind of want to commit yourself to um at least five, and the reason for that is. um You know we want to be efficient with CI minutes, uh which is probably the main motivator as well so yeah um I can just go ahead and create the Mr.

A

So you can just see what it looks like, but I'll go back probably tomorrow for next week and just add that before so you can see it doesn't take too long, I mean once I actually read the issue properly and then add you know the bit up here. Then it starts working um now. Unfortunately, for me, why is my redo? Not working?

A

Okay, I'm gonna have to just manually add those changes back in. So just give me a moment and let's just fix this up.

A

And that you know that's.

A

Not just make sure it's pajamas and yeah, it is.

D

A

So I think at this point we can just go ahead and create the Mr one side. So we'll come over.

A

Oh I hate how it doesn't matter.

A

Okay, just give me a sec.

D

Why is your structured out single.

A

Oh, it's just every time you update the GDK, um so the GDK will run the DB migrations and it generates that DB structure, dot SQL, but um the repo itself. When you clone the gitlab project, it already has a DB structure. Sql and sometimes uh you know, the file differs when you do a GDK up there and that's why it's in my um staging uh that we'll get yeah it's just one of those pains you have to live with. Unfortunately, so I need to add this file to my Global.

A

Get ignore, but I just haven't gotten around to doing it. Yet.

D

I'll be cool thanks, Anton, no.

A

Problem at all keep the questions coming. Alvin I, like being kept on my toes.

A

So what I'll do is I'm I'm just going to quickly share an email that I've done in the past, so just to give you an idea of what's actually involved so um yeah as Alvin pointed out. Ideally, you want to do five in uh five changes, um so five issues and then consolidate them into a single Emma. So yeah one is CI minutes, because that reduces um the spin there and also it's more efficient for a reviewer to check five little things. Rather than have five emrs with five little.

A

You know one little thing in each um and what I've actually done here is I've actually taken screenshots of the change before and after so you can see here, for example, oh, what did I change there? Actually I don't need to actually look Place image thing like um okay, so there's a so. It must be the Scott this one here, so you can see it slightly changes um and that's just because with the pajamas um components they just have standardized sizing avatars.

A

So that's why it changed and that's why it's really important to have these uh screenshots side by side. So then, whoever's reviewing can actually see what the differences are. So I'll be doing the same as well. um This one I think it's that image there and I mean you can see it barely changes so that one's okay too, but um what I need to do?

A

As you can see, there are a few changes there.

A

um You basically just have to add all these labels um now. Luckily, for these types of front-end changes, you don't actually have to worry about specs or anything like that. So if you're someone that doesn't like specs very much I mean these are the changes you want to do so um so what I'm going to do um change.

B

Our UI testing is done by people with their eyes.

A

Yes, all right, we do also have some automated tools like capybara, that will do some collect tests and all that kind of stuff, too make sure it actually works.

A

um What's that system or functional testing I believe it's called functional testing yeah, so we do have those tests as well. That will run so if, if whatever your change does breaks, anything I mean you're going to know pretty quickly anyway and then I think they're, all capybara will actually take a screenshot and we'll show you what it actually looks like as well, which is kind of cool too, and that will be in the artifacts of the CI job exchange search, form buttons to pajamas.

A

uh And I just put it into the master branch.

A

uh Naughty naughty, all right, um I guess: I could just checked out a branch um like bit branch.

A

What will I call this I'm? Quite Anton pajamas.

A

A

Oh, you can see I had Avatar pajamas at one point times.

A

Now that's my autocomplete freezing up on me and this buttons all right so yeah. um What I can actually do is.

A

So maybe I won't create the emails today um by the very least I'll push something up. So it's kind of giving me some commitment to finishing it off now when, when you push something up and the GDK, if you've set up lift hook, it runs a series of chicks to make sure that everything is actually fine. So you can see it's doing a lot of linting here does some dot checks, but generally yeah it will only check what you've actually changed in your branch.

A

So you can see that's why it says nothing for inspection here um now. It will also give you some heads UPS on things that you need to be aware of, so it saves a change. Lock is missing now for something like a pajamas email. You don't need to worry about the change lock, so you can just ignore that message, but yeah you can see. It's actually done. The push now down here.

A

Oh yeah, while I remember what I'm going to do is if I go back to here once I find the issue again.

A

I will assign myself to it right now, so no one else takes it.

A

So yeah um generally with Pajamas um issues, you want to assign yourself to them like pretty quickly because you'll find on the day that everyone, just you know, picks and picks what they want really fast and we're actually in a very um lucky position in you know asia-pacific or Apec, because you know we're online before everyone else. So the pajamas bar party is you know a day earlier for us getting a close. So we we can grab all the cool stuff yeah.

C

A

A

um Any thoughts, questions album. Do you have anything hard for me? I need harder questions. Alvin.

D

Well, well, why are you picking on me? Did somebody had to be here.

F

A

Don't know I think uh we just really tried. So you know I'm going after you.

B

've got time for another talk sometime about actually getting the GDK ready for this and setting up left hook or do we just need to read the docs ourselves and work through it.

A

um I mean we do have a little bit of time. Left so I mean we can't go through. That now see I'd like.

E

I was gonna, ask the same thing thanks Mike for asking. If that was too much of a new question that I shouldn't be asking in this session.

B

Yeah I'm always a noob.

E

If everyone would just be like, oh my gosh cat, like do you not even know, but yes, it's a good question I think, because for someone who is just getting started, is there like a smaller instance? You know just a simpler instance that we can spin up, not necessarily one that's got all the bells and whistles that we probably don't need just for the pajamas um look.

A

Yeah sure um now there are two ways I'm aware of that you can spin up the 11 environment toolkit, so one is using.

C

uh You can't not talk yet let.

A

Me just uh kind of familiarize myself um it's in here somewhere, I, typically just use the one line- installation, um that's.

B

A

You can use gitpod as well. I've, never done it this way, but I think I've heard other support, Engineers using it and it's pretty straightforward um yeah. So you can see you go into the repo you go get pod up. Well, you have to create a gitpart account and Link it up and then yeah you just wait, seven or eight minutes and it's actually really easy. I.

F

Might just chime in if that's okay from a minute on um there's, maybe a couple of weeks ago, maybe a couple months ago, I did a small presentation with a few people in Ginkgo about doing bug, fixing with um GK in gitpod I've just provided the link in the chat for anyone. That's interested, you have to be logged into the unfiltered account to see it, um but that might be useful for anyone that wants to like go through it. Basically just goes through the steps.

F

That's on this project, um but I I find get point is very useful to have it just order deploy to the cloud for you, so it might help.

A

Okay cool, so anyone that's watching this video. This is where this um is in this URL right here. Oh yeah, thank you Ben, um but yeah. If I go back to uh I, keep losing my place, I think it's uh it's near. It's nearly the end of the day for me, I think I need to knock off soon. That's um GDK.

D

um To say it's almost food o'clock, 30.

A

O'clock I think it's sleeper o'clock too I've been um I'm. Just really sad, I've been up since five.

C

A

Yeah, you can see I'm stumbling over my tabs today, probably a bit worse than normal, okay um yeah. So the one line did you go over one line bin.

F

uh I, don't think so: let's just get pod yeah just get pod for this one.

B

I've done the one line: installation it's easy, the first time but I've just updated. My Mac and everything's broken so I'm gonna have to work out how to upgrade.

A

Did you upgrade from like upgrade the OS or did you change.

B

It yeah upgrade the OS, which means, then you have to upgrade the xcode select, and then you have to do a brew upgrade which breaks everything and then um you have to put it all back. I think actually what's happening. Is it might just be that it's been a while since I did GDK? So when I do the GDK doctor, it says you need to install a new ago mate. uh Now you also need to install a newer postgres too.

B

So it might just be ASDF install this that and the other end will be right.

A

Yeah um generally I remember the last time: I upgraded the OS and that's the main reason and motivated I haven't upgraded my OS now because of that, because it breaks everything I know, there's a I think there's a GDK reset command. If you haven't tried that um that might be worth trying, yeah so running, the doctor is also the pristine. I actually had to run that just before the call um which actually fixed it for me, um but that's something here: GK.

A

Doctor reset, oh there's, a reset data which is clean up.

A

um Yeah I mean the one line, installation you know it does work. um You can also do the simple which I think I did originally, but if you just want to get up and running, I I would suggest us watching. Ben's video um because get part I think is really good for people that just they don't want to screw around.

A

They just want to get coding as quickly as possible, but um and saying that if um you have any trouble kit, Mike or anyone else on the call sitting, either of those methods up I mean feel free to reach out um I'm sure anyone will you know I'm happy to join you and figure it out, but yeah I'm sure others would be Keen too.

E

Oh, thank you. That's.

A

All right and yeah, likewise, um if you're working on a pajama, zmo and you're, all stuck I, mean feel free to just reach out in that pajamas migration day, Channel or also you know, feel free to reach out to myself or you know, yeah I I think there will be a group of us working on the pajamas um emails this year.

A

Oh this, this decision, I hope because um yeah, Alvin and I were going to work on a couple together last time, but I think um we had a lot of tickets that just kind of popped up and we just didn't have time: hey Alvin, so this time around we're gonna have to do something.

D

A

Right um yeah, we can make that a group, um you know events as well. Maybe we just all hang out in a room. We don't necessarily have to be talking or sharing, but just if anyone star core needs to bounce ideas, we can definitely um arrange that. But yeah um we've got a couple of minutes left. Does anyone have any other pending questions, thoughts um or thoughts for next time?.

A

I see a woofer on my screen.

B

Decided to come in did you actually there's two of them? There.

B

You know Lottie and the black and white one is Taiko.

B

That's it I've had enough I'm heading out again.

D

A

A

D

How much time do we have left.

A

uh Three minutes, but if there's something that we want to dive into I mean I'll we'll we can figure it out.

D

Oh no I wasn't like there's only because I was like. Oh it might. um You know like if you just quickly went through another one. Instead of with all the explanations just this time, just do another one like a button. One do you know what I mean, but, but only if we've got time, I.

A

Would probably say we don't have time: um okay, yeah, because I've got to yeah. No, that's fine, I mean yeah, it's fine. um There are a few other things that I need to check up on anyway, but um you know, as I said, um you know when the pajamas day comes around or even if you want to work on them earlier, we can definitely set that up.

A

If you want to just break the link smash a few out but yeah.

A

um What I'll do is on the day, I'll, probably just I'll just book in all day event or something and anyone can just jump in whenever they want I, think that would be a good way of doing it.

A

That's yeah um good.

D

A

Yeah, the only other thing I was going to suggest is for next time. If no one else has any thoughts.

A

I was thinking about doing a different kind of um code exploration, so this is just a bit of insight into next time, so for those that are familiar with the zendis download router, it's an extension that I wrote a wee while ago and there are a few pinning issues that need to be worked on, mainly because Google are moving to a different, manifest version next year and as a result, it's going to break a lot of existing Chrome extensions, so there's kind of a bit of a motivator for me too, as a maintainer get everything fixed up for the next year anyway.

A

So we could probably pick one of these. So if you're familiar with javascripts I mean this will be right up your alley, so one of the things I've actually been wanting to implement for a long time. Is this feature here? So if you're in a ticket? The idea is, you know every ticket comment. You know you can download all the attachments at once, but more often than not.

A

If you're working with a customer that submits multiple gitlab sos's in each response, but you kind of want a way to categorize them on disks, I think this would be a perfect way to do that. So, if I download all the attachments in a ticket comment download it to a separate folder within the parent, so we could use dates or something along those lines and I think that would be a really valuable feature. So.

D

A

Oh, what's that um I think we can wrap it up unless anyone has anything else.

A

All right, thank you for joining.

F

um Enjoying it.

A

No problem at all enjoy your respective days and we'll see you around. Thank you. Everyone thank.

D

E

Yeah bye, everyone bye.