GitLab Support Team, 16 Feb 2023

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Adding a UX improvement - Support coding office hours

Description

Adding a UX improvement to the LDAP group sync button https://gitlab.com/gitlab-org/gitlab/-/issues/389647

MR https://gitlab.com/gitlab-org/gitlab/-/merge_requests/112119

See https://docs.google.com/document/d/18_jSEx9Wnzm2H7xd7xuQi3cEsFO7ER6inbNBitEKd-A/edit#bookmark=id.h2af88o1hfon for notes

A

This oh hold on hold on.

B

It's recording.

A

Wow, whatever happened to cut Center, okay.

B

A

B

Hi everyone, my name, is Anton Smith I'm, a senior support engineer here at gitlab and today I'd like to take you through uh a small ux improvement with the l-dep group sync. So um this was actually brought to my attention by Alvin, um where he is creating an issue and had a discussion with the auth team on the best way to address this and I. Think we've come up with a very small iteration that we can do today.

B

So Alvin, um there's no pressure on you mate, but um did you want to share the issue briefly? Go through it and tell us what the problem is or would you like me to do that.

A

um Okay, yeah I can I can do that. So the issue is that when you configure group links so I'll just share my screen because it'll make things easier, make sure.

B

Be cleaning up your desktop.

A

Yep yeah, just making sure I've not got anything, um not sure I'm trying to find that issue.

B

Three: eight nine six, four seven.

C

A

So let me see my screen.

A

So what's happening here is that when you configure ldap group link, so in this case I've configured all the group Links at the group level, when you click the sync Now button, the status of the button changes to show that it's syncing right, um but there is no logic. Currently that tells the customer. So there's no logic to change that. Syncing state is back to synced or whatever.

A

So in order for the customer to know that the Sync has occurred, they have to go and manually click the refresh button which I just did in the video, so I just went and clicked the refresh button in the video, um otherwise it'll just stay there. Thinking until the you know, until you close the page and open it or whatever the problem with this is that sometimes the sink actually does fail. So there is actually an issue where the.

A

So, if you look at the ldap troubleshooting logs, we do have an issue where the sync buttons is now stuck.

A

um And so the issue here is more that the customer would not know without refreshing the page. The customer would not know whether one of the groups that they've applied one of the ldap groups that they've applied to this group membership is actually broken or whether the Sync has completed.

A

So what one of the easiest minimal, viable products that I discussed with Drew was, we could add a note near the button to say: hey, please refresh the page to get the current sync status.

A

So that's what Anton has offered to show us how to do today.

B

Thanks Alvin, so I'll just share my screen, um so yeah we'll talk about um that issue that you've brought up today. So thank you for doing that, and yeah I just put a notes um where we've got that documented about the stuck button and the UI now I forgot to pre-face this at the start of the call.

B

So um you know I'm, definitely not an expert when it comes to these kinds of things, so I'm still learning rails myself, I do have a background in development, so I somewhat know how to be dangerous, but of course, I'll do my best to answer any questions along the way. So if you see something that I'm doing it doesn't quite make sense or you'd like a bit of clarity, please feel free to interrupt me and we can go through that.

B

So, um of course, all with all things, given the first thing that needs to be done is um in order to write this new feature or Improvement. We need to actually enable open ldap in your GDK, so I've already done that, and if we go back into here sign out, there is.

D

A new era I've never seen before.

A

What held up alt only on callback pie, yeah ldap mean okay, so the ldap that's a weird callback path. Did you change that? Maybe no.

D

A

Shouldn't be so usually the ldap alt is used when you've got multiple ldap configured.

B

Yes, there are multiple ldaps configured, I believe, but this is strange because this is the first time I'm actually seeing this message.

B

um We can take a quick look at the um what I've done. Okay, so um just just um the context that was not planned.

D

Let's go: we want to open GDK Foster the code.

B

Okay, so we can see here that, um because I've got a loopback address for GDK test, I've set the listing address there, I've enabled open ldap, but what we actually need to look.

D

At is um okay, I believe it's, the I need to get rid of that. What's.

B

It called so under the get live folder. There should be another. Oh.

D

Show me everything.

B

I think that's a good lab.

A

Well, I mean you know, Chuck.

B

Norris can.

A

Diffuse the Bomb by cutting the wrong wire. Oh.

B

Yeah you can right hold on so I'm already in the GPS, so you'd be weird. It should be in another file.

D

I'll just default to the docs. So what we need to do.

B

Yeah our case under gillib confidently.

B

Okay, so, somewhere in this file, it's going all funky. So.

D

B

Yeah, so there are two configurations so we'll just go back to this okay, so hold on.

D

Can I see I.

B

Hold on I'm trying to find the main Outlet on folks.

D

D

I believe this is it.

B

ah Some reason I was thinking it was under the CR key, but it's not so. We can see here that we've got one ldap server defined Port 3080, but that's it so I'm a.

A

Little I saw I, saw ldap out there and on I saw an ldap old, just search for ldap. What is it hyphen, Alt hyphen alt there you go so you've got an alternate ldap thing configured as well. Okay, right! That's what it looks like to me anyway.

B

um I guess I could just remove it, and that would be enough right.

A

Yeah well yeah.

B

As I said, this is strange because it wasn't doing this before.

D

Okay, so let's choose.

B

um I believe we must restart. We don't actually need to reconfigure.

B

Okay, so that's normal, just gotta wait for everyone to start.

B

On Alvin, here's my uh where is it my favorite uh plugin.

D

A

B

Don't have to click the refresh button; it just does it for me.

A

Yeah I mean you know you could just watch the Pokemon there.

B

A

B

What why why do I need to look at logs when I can just use this, so it looks like it's working now, so that was the problem. So thank you Alvin, but let's just make sure um we can actually sign in with an adobe user. um Otherwise.

B

Strange I I, don't know why that's going all funky, all of a sudden, um I suspect I'm going to have troubles logging as a regular user.

E

B

Or not, we might be able to continue the test, regardless of the the change but yeah we'll just see how far we get. So, what I'm going to do um so I'm not now deaf expert either, but I am somewhat informed on what needs to be done. So I think we just start off with a group and then we want to add some.

A

Group links to that group yeah would that be right? Yeah I mean you might have a existing group.

B

No I was just going to create a fresh ldap group, just so it's clear what we're doing okay yeah.

B

So the idea here is weird: it's under ldap, synchronization, I, believe and then we have to create a link here right.

A

B

A

um Yes use the ldap group scene, not the user, Builder yeah, the.

B

Groups right, yeah, okay, so that that's all I need really isn't it. How.

A

Hold on what version of get light do you have? The UI looks completely different. This.

B

Is um this is bleeding edge, so 15.

A

Oh wow they've changed. Oh my God that looks so much nicer, so so.

E

A

In previous versions you have to like, uh you have to start typing a few characters, and then it brings up the groups where this one is actually Auto populated the drop down. Yeah yeah, that's cool man. All right.

B

Oh cool, that's that's nice! Something new! um Let's add that. So we've got a group link and I. Imagine we're going to have a button now on this page, okay.

B

So this is what we're after Okay, so I guess. The next step is um when we click on this. um It's probably not going to work because something's broken with the ldap, but you want to display like a string here, Alvin that says refresh the page to get updated or you know we'll come up with the wording yeah, so yeah we'll need to do something there. So, okay, um if we refresh that now, oh okay, so it actually worked, but what we can do is we want to basically use that as a placeholder.

B

So generally, the next step is: we need to figure out where this um button lives and the code now it can either be in the Hamel templates or it could be an avoo template based on the behavior we're seeing here and that we have to manually refresh the pages most likely a Hamel template.

B

um What I like to do is you can use control shift F to find things in files in vs code that I just prefer rip grip um so, as you can see, I've just typed in a I've copied and pasted the string from that page and I'm just trying to locate the file. So you can see that we've got a hit on this Hammer file here.

B

D

A

A look at it, that's a that's a different era, though that's a different message, though, isn't it.

B

That's true, um I guess, I'm, just starting at a higher level.

A

B

You can see that this text here matches um the text in this model here and if we keep going down, if we read on, we can see a render sync button. So that's just telling us that there's another file that we need to look at and because there's no folder path. It means it's in the same directory. So yeah. Coincidentally, we can see it's right here. So here's where all the magic happens, so the successfully synced button or the successfully sent just now seems to map to this text here.

B

So this is a variable, that's being inserted into the string. So uh essentially, what we want to do is let's just I haven't tried this yet so this is either going to work or not work, but essentially we just want to do this, so we don't need all this stuff here, but I'm not even sure. If we need that, because we're not gonna have a variable in here to transform. But um Alvin did you have any ideas on what text you would like in here.

A

Yeah um refresh the page to view status or something.

D

A

View sync status.

D

B

So I think that's a good one, um so that should appear beside pending sink.

B

Oh, no, don't we want it with syncing.

A

Well, that's weird, that's the weird thing because in your one it says spending sink right, so it changed from syncing to pending sync right. So.

E

A

If you go back to the thing and click on the sync button, sync Now button, it says bending sync.

B

Oh no now saying slinky.

A

D

A

Anything only happens when you first add a group link.

B

I'm not 100 sure.

A

The previous one, when we look at if we look at the um the pre, the preview, the first time you click that sync Now button. It said pending sync.

B

Yeah but then did the page reload.

A

No, you reloaded the page, okay.

B

So let oh okay, so now that I'm doing it, it's actually going to show the changes I just made.

B

Pendings: okay, that's weird.

A

You see, is it alternating between the two body, things, that's how they can.

D

B

Let's try it again. Well, good news is the change actually worked.

D

A

B

A

But you remember just now right, just like two buttons two button presses ago, it was saying syncing instead of spinning sync.

B

Yeah I imagine I'm saying that if there was a large number of group links to synchronize, maybe we would see this on a refresh. Would that be a fair statement.

A

Say that again, please.

B

So maybe we're only seeing the pending sync, because um you know when the page refreshes it's just waiting for it to kick off and then there's only one group link with one group. So it completes very quickly versus.

A

B

A

Well, because just a few button, a few presses ago, it said thinking, do you remember.

B

No I, don't I wasn't paying it. Sorry.

A

That's right, but the first time when you edit the group link, it said pending sink and then afterwards, when you clicked it the second time it.

B

A

B

A

um I think we have to give it a bit of time, so maybe like give it like. Maybe there's like a timeout or something so.

B

Okay, well at the very oh, well, actually, look, there's actually a user here, so maybe the first time we did it. It actually took a bit longer.

A

Right yeah, you can't do it doesn't use it, but if you remove the group link, okay, okay, so let's remove the group link yeah and then remove the user.

B

I'll remove the user completely from.

A

Yeah, no, no just go to group memberships. No! No.

D

All right, gotcha, I'm, Latina.

E

B

And then add the group link backed into the sync again yeah.

D

Okay, I'm with you now thank.

B

B

I think it was group one wasn't it.

C

B

On the upside I'm learning a bit about ldap today,.

B

No stop ping me.

A

Okay, but this time it is pending right, okay, but just.

E

A

A while give it a while because last time, the first time you clicked the little standing and then the second time you clicked it, it will sync now, but we waited a couple of minutes before doing it.

B

Oh okay, but if we wait a couple of minutes, why not just show this.

A

No I mean the the sync button changes to syncing instead of pending sync, okay,.

B

Oh you mean like stay on the page for a while. Yes, yes,.

A

D

A

I, don't I, don't know why.

B

I I I can't explain it either. ah I clicked on.

D

The wrong page.

B

Let's try that again so remove.

A

B

Oh I thought you wanted me to go through it again, but wait.

A

No I just wanted us to wait for like five or ten minutes.

B

A

That's all right, I mean now anyway, so.

B

Let's just try it one more time so under the members.

D

Remove settings.

D

Build it some transition.

B

Okay, so we've got the group link here and let me just clarify what we're going to do. You want me to click. The sync Now button. Do I refresh the page or do I wait.

A

um So it says the last successful sync was one minute ago: yeah.

D

A

um If you just refresh the page, does it still say one minute ago, it feels like it's been longer: huh okay, yeah, okay,.

B

So you want me to click this thing now.

A

B

And then what do I do at that point.

A

So it's a spending sync.

A

I do know that if we, if we were to go back and look at the reporting, we would see that at one stage it said syncing instead of painting sync I'm.

D

B

A

How we triggered it.

B

That's fine: how about how about this? How about would it make sense to have this on both um the states so both sinking and pending state.

A

B

Yeah, well, we can just do that. That to me makes sense right.

A

Yeah, why why is there two anyway? What's the difference between ldap group, syncing and ldap sync started.

B

um If I were to guess um so we can see that there are two.

A

B

um Yeah, so sync pending is probably waiting for the underlying sidekick worker to kick off the job, whereas sync started as the jobs in progress. So I guess that's why I was saying earlier that um you know we would see this initially and maybe we just lucked out that it went straight to um at executing.

B

But when you have a larger set of group links, you're, probably more likely to see the syncing.

A

B

um Of course, I'm only making uh educated guess here, I've never actually seen the behavior myself yeah, but would that would that make sense? With um your experience, Alvin.

A

I, don't remember seeing the sync pending I've only ever seen the sinking button but um yeah it kind of makes sense.

B

Okay, we can push on um if you're.

A

Happy: okay, yeah! Let's, let's put.

C

B

Okay, so um the bottom line is that this is a very small um ux Improvement that will probably make a good difference, so it's working, which is great, um but what we need to now consider is um not. Everyone is an English. um You know, reading person so anytime that we add strings to the UI. We need to consider translations so.

D

You don't want to translate, instead of so.

B

I think, in our case we are already halfway. There.

D

That's not the page I was looking for must be this one here. Wait.

A

Hold on hold on, did you say not, everybody reads: English.

B

Well, you know so in terms of git lab gitlab supports multiple, you know it's multilingual, so it could be French German. You didn't know that yeah no for sure. So.

D

B

Literally, did an MR with you, where we had to update this exact localization.

D

Through strings using, GDK literally went through that bar with.

A

You I'm just I'm just surprised that not everybody in the world reads: English like what I'm being cheeky. Sorry all.

B

Right all right, just just talk to my grandparents, foreign.

B

Because we're inclusive, um but we can so so. We've got a page on Internet internationalization, I hate, saying.

D

B

um The idea is we're editing, a Hamill file, so let's say we want to say hello world. We want to write it like this, so it's an underscore Open Bracket, so I believe we're already doing that yeah underscore Open brackets. So technically that should be um supported, but I've never done this before.

B

um If I keep reading, it'll probably tell us how to generate it. I assume, there's probably some special.

E

B

Talking about the gitlab.potflow right, that's.

E

B

It's part of GDK uh I'm trying to find that as well, because it's definitely not on that page, because I've never seen that page in.

D

My life, um what.

B

About this one Kenneth, would it be this one that doesn't ring a bell, but it could be I mean it does say it does exactly what it says, we'll give it a whirl away, yeah uh the one the page I always found was in the handbook, um not.

D

B

Okay, if you find something please share it.

D

Yeah cool, thank you so.

B

So, as we all know, support Engineers the right tusks can take a long time to run so not any different here.

B

Oh yeah, that's the same command, oh sweet cool! um So did you see that on a different page, just so yeah, it's in the designers step-by-step guide to code changes, okay and their handbook page.

D

um I just crept for it.

B

So I'm just trying to find the actual.

D

Link: okay, cool. Thank you.

D

Yep here we go Step 11 on this dock.

B

Is where I've always found it, which is very I, would say not the place that you would think to look. But that's where I found it because.

D

I'm, not a designer.

B

Okay, finally, we're you know awesome so I'll put that in the stock as.

D

Well, so we have another reference as well.

B

What is it called designers?

B

Oh so, okay for ux resources, okay yeah, when.

D

B

Making changes in the UI like this was the kind of the guidelines on how to do it. Yeah. No, that's very helpful.

D

Thank you, um I've just lost my post units.

D

B

B

D

It's done a whole lot of.

B

Stuff so, as I was saying before, I've never done this before so I guess we just wait now, while we're waiting for that to run. um You might be wondering if we need to write specs for this change now.

B

I wasn't 100 sure myself, but um what I did was I got in touch with the auth team, just to bounce a few ideas off them, and they told me that if I'm only just adding a string to the template that I shouldn't actually need a spec now normally what you would do in this case, um especially because we're adding text to the screen and what we want to validate that it's actually being displayed when we want it to be displayed, we would write a feature spec, but interestingly, um there's no feature spec that exists for the sync button, or even the not specifically this button here or this page.

B

So for now, I don't have to write a spec but um we'll see how it goes in the review process of the reviewer wants me to write one or not so yeah any questions so far.

B

um Kenneth, do you have any idea how long this takes to run? uh Oh there, the the trigger, was you asking me? Oh okay, clearly you're magical! Thank you! Kid yeah I, just wanted to share I did find Alvin's uh Mr. That I did with him in which he did up the gitlab.plot file all right, so he must. He needed to have run this command.

B

Just wanted to share that.

B

D

B

To get my pot all right, do you remember Alvin classic Alvin.

B

All right now the whole world can see cool okay. um So that's pretty much all the changes we need to do so um Alvin. Are you 100 happy with um the strength that we're going to apply here.

B

I'll, take your silence as a yes, so um yeah I guess we can just come at it up, push it up and uh create Emma. How.

A

Long have I been muted I've been I've, been talking this whole time.

B

Oh you've been muted the entire time we haven't heard anything from you.

A

Oh, my God, okay I was just gonna say foot like does that? Does that sentence make sense like Anton? If you go back and show that page for someone who hasn't doesn't know the context, yeah sure um does that make sense? What like oh.

B

Nelson's thinking.

A

Yeah, that's what I said like you have to wait a little while so maybe, if there's already something in the queue in the sidekick queue, then it'll say sync pending or pending scene. But if there isn't anything in the side Q then it'll do syncing.

A

um But anyway, the um no no yeah.

B

Now it's! But why isn't this text showing when it's syncing, odd and save the file come.

D

B

Get it together, get it together. All right, um yeah I just wanted to show the text um album, but carry on. Oh there we go, but now I'm saying now.

A

Okay, so like redneck, if you see that that text, do you see yeah like right next, disjointed Roger Knack? If you see that text, do you know? Is it easy to understand.

C

Hunting sinking like uh wait for wait for sin.

A

C

A

You look at that whole thing um like if you look at this whole thing here, what would you do.

C

Remember this book, I'm, really using your life, cannot be add or remove it, because that affirmation in okay lab could update one user at a time. Let's get up, cached results.

C

Or this setting may take up to show in the list below people are given gets access.

A

B

I think it's specifically, this part wrote in it. So if you were to read this text refresh the page to view sync status, does.

C

That make sense to you, yeah, okay,.

B

D

That a hyperlink or not text, oh no, this.

B

Is just a little text? Is it just my screen, but that looks like a hyperlink like the color of it. uh It is kind of like a Bluey color. um So let's color the colorsology, this color here RGB.

B

This color yeah, it's the same color, that's I, don't know I personally find that confusing, but I don't know I, don't know. If that's between scope of your change right, it's also possible that um this might be interfering.

B

Let me there we go.

D

Oh, that makes it worse question mark.

A

I'm colorblind, so it doesn't really matter to me. Oh.

B

That looks nice, it looks nice, but they look very much like links all right. I'll I'll, just I'll, just put it back to what it was, but yeah yeah. Well, yeah, I, don't know if that's within scope for your change. No.

D

B

B

So, let's try it one more time: yeah, just an opening sync, but that's okay! So um Alvin did you have any other thoughts.

A

um I think it looks good refresh the page to view this thing status. Okay,.

B

I liked it a your command there, you go all done so we need to. We basically just need to push it up, so wait.

A

Now that you've saved that other change, do you need to do that touch? uh Do you need to do that regenerate closing again because you've added another text line of text? That's.

B

A good question: the thing is, this string is technically the same as this string, so I would imagine a translation for that would apply to both but I'm not to to be honest, I'm, not 100, sure I mean it wouldn't hurt to run it again. To be honest with you, the other thing I'm not sure about is if we need that HTML safe function because we're not transforming or you know, concetting any strings in there.

A

But they did, they didn't transform the stream they did the HTML save from that other one.

D

B

And yeah the the string isn't like a hyperlink.

D

Or any form of HTML element, it's just literally.

B

Text, that's right, so would it be, would it be fair to say we don't actually need it.

B

um Yeah, because it's not a variable or anything, it's always going to be that static test. So too I I feel like we shouldn't need it, but in the worst case the reviewers would all would should note to.

D

You, if it's needed or not whatever.

B

D

B

True I mean if you'll yeah, because I'm just hoping there was a easy like just.

D

B

Some of the other codes see if there's an example, yeah.

D

So you like that one.

B

B

D

A

If you go back to the the ldap sync file yeah this one, so they did oh okay, never mind yeah,.

B

They've done it here, because they're, including all this other stuff, so.

D

That variable is.

B

Going in there so I think it's going to be okay to get rid of it yeah if it's not. This is what the review process is all about.

B

Yeah I agree: someone, that's a bit smarter than me will tell me what I'm doing wrong foreign.

B

Yeah sorry just give me a moment.

B

D

This is interesting.

B

So I'm just going to use um you know this is probably Blasphemous but I'll use the GitHub client for a gitlab very cheap, but you can see that all the changes are being made. um This is what we've added um I'm, not sure. If we need to include all these Locale files, um I thought we only needed to include the pot file.

B

D

You yeah I agree with that: okay, cool, solid.

B

Yeah, did you did you? Did you actually do a get pull before making this a uh your branch? I did oh okay, interesting.

D

B

Let's take a look at this page to see: if there's anything, okay, you don't need to check in any changes to the local language get led by portfols. So we just need to merge the portfol.

B

Is your client not respecting get ignore.

A

B

Look at that, what did you do? I did nothing, I swear, I, swear, I did nothing must be some, the command must have just completed.

B

Oh so maybe it creates these files and then it just combines them or something. Oh right, it's in the middle of doing it yeah that makes.

D

B

Right all right, all right so.

D

B

Ones we don't actually need because they're not actually part of the Mr, but we do need these two, so um I do need to create another Branch. First though, so what should we call? This? um We'll just call words. Sync.

B

Improve refresh all right, add refresh message.

B

I pressed tab why you should just switch dash dash C, yeah.

D

I guess I'm interested.

B

Yeah I need to um get with the lingo I think so git switch does um both at the same time creates the branch and switches oh switch. Dash C does okay.

D

B

Does the create so.

D

B

Is essentially the new version of checkout, so if I execute that that would create a branch called hello and then check it out, yeah, okay! Well, that's cool! All right! I'll! Keep that in mind! It's the new version of git checkout, Dash B right.

B

Okay, that's cool, let's go and it's um I'll. Do it.

D

D

B

Now we don't actually need to go into too much detail to come out. um I'll just call it this for now now there are a few other things we need to do before. We push it up that I'm just remembering.

B

So um there is um the trailer, so it's a changelog entry. So basically, this is what I forgot to add. When you create any kind of new change and gitlab, we need to add a trailer, so we need to add change, lock changed or whatever it's called. In our case, we probably just need to add I would say it's not a it's not technically a feature.

D

B

Do you work another yeah because.

C

B

Like a UI maintenance thing, okay- and it's not just.

D

A year, though, what? What did.

B

We do no depth, isn't it.

A

I thought ldap is open to everybody. Elder.

B

Episode, it is but group links in particular is then is that an ee feature? uh Yes, okay, so we need to add this ee equals true on the end as well.

B

D

B

Yeah, okay, so I'll check that on my group. Links on that no.

A

I just checked.

B

Yeah yeah, but it's just for the recording, so people can see. Oh.

D

um I'm on the wrong page, no.

A

No, there was okay.

D

A

D

A

The way to the top all the way to the top and you'll see there all right right at the top, because.

B

This applies to everything, okay cool, so all we need to do is we just need to add this in this, but change that to other easy so um because I've already created the commit I have to um edit the command.

D

B

uh Do you want an easier way to do this, or do you just want to go through your way now?

B

um What was your suggestion going to be Kim git commit dash, dash, amend that just amends the previous, your previous commit I've been doing it the wrong way. No.

D

B

Only works for your last commit so the way that you do it is actually right in that it's more generic for or commits in your git history. This only affects your most.

D

Recent commit okay.

B

Okay, thank you. um Yeah I've, just um as a Dev I've always used the rebase command for amending, commits and yeah.

D

B

Just never occurred to me to use that command, um but yeah. Thank you. um I think it's really cool how there are different ways to um achieve a task.

D

B

Interesting tidbit.

D

B

Okay, something just went: what did I do?

B

Okay, I, don't know what happened. What are you eating.

D

B

Know what happened.

D

B

Press Ctrl k.

A

um Oh Anton, because this is vim right, if you do that immense thing, I think it loads Vim. This is not nano anymore.

B

No because the first was boom will I be able to type press Escape, oh yeah. It is.

D

uh Just press U several times, thank you. ah Yeah.

A

Escape yeah I'm.

B

E

C

B

C

B

Vim easy mode or something I, don't know. Oh it's because I've got um shortcuts.

A

What the heck I've.

B

Got yeah I've got um a custom keyboard layout, so it's probably there um I'm not cleanly setting the correct key combination. So what I'm going to do is I'm just going to close that go new terminal, I'm going to probably open up item.

B

Yeah hold on so let's open up item and just do it in here so.

D

B

Okay, so I won't press. The key combination I did earlier and that's not what we want to.

D

Do it don't worry, we'll get there we're doing it live it's fine.

B

Yeah we'll do that. Okay, if I press Ctrl, K now yeah that works in it, then so um watch uh other.

B

um Maybe I should change this to a more descriptive message. Would anyone have any thoughts on what I could write there.

A

Add a refresh the page message to the linking button.

B

A

B

Sounds like way longer than 50 characters. Yeah add refresh.

A

No never mind yeah, add refresh message to wow. That's hard man.

B

Wait: what, where are you adding it.

B

All depth um group sync page.

A

Button, no, no! That's fine!.

B

That might be fun, um so we can leave it at that now before we actually push it up, we should run lift hook on it to just make sure that anything I've done is not going to break um any of the linters or RoboCop.

B

um This also saves a lot of time when you commit and push something and you're waiting like hours or not hours but eight hour for all the tests to run, and then it fails and then gonna make a change and do it again. So there is a lot of value at running the lift hook test locally. So this is actually just the Alias um I. Think I might have mentioned that in previous calls, before all right.

B

Yeah, so you would install it.

C

B

Yeah run it manually, so you would run that so my my Alias is just basically doing that. Okay, um any questions before we move on.

D

um We're at a point where I can just push everything up.

B

I, don't have a question but I have a interesting tidbit about git commitment, amend.

D

For you again, yeah sure.

B

If you have only a single commit in a repository, you can't rebase it because there's nothing to rebase on with a single commit, so you have to change it with Git commitment. That's on a fresh repo right! Yes, like a.

D

B

Commit in the repo right, yeah yeah, yes, yes, I- think I've run into that before. Actually yep I know exactly what you mean so yeah. It's actually helpful to know both situations as a result, yeah, because um with the rebase command for those that aren't aware, um it's it's definitely a lot more powerful.

B

So if you wanted to squash, commits interactively um or reword multiple commits at a time, I mean you can definitely do it with that command, um but you'll get you're referring to interactive rebasing, which is like rewriting history, yeah, there's also another form of rebasing, but you don't have to.

D

B

No, no definitely I mean we could talk hours, I I think we can talk a long time on different ways of doing things, but no thank you, Kenneth for sharing that I learned something new today, all right, I'm, just wary of time, because I've got another call after this, so I'll just create this really quick um just so everyone has an idea of what we need to fill out here so um now.

B

D

Be a uh just trying to think what would it be feature.

A

Like feature, if you type feature enhancement or Internet enhancement, no training, yeah.

B

I, don't think, there's a few there's nothing specific for this.

D

B

The default just pick default, no I assume it's just using the default already, but yeah, okay, so basically I just need to fill in all this stuff here. So um screenshots are easy. We just take pictures of what we did there, but what we probably want to do is I'll just write some stuff in here. Real quick um closes.

D

I've got a lot of things open, close I.

A

Don't think it closes, it depend on it temporarily. It temporarily.

B

A

I, don't think it actually closes the issue. It's a MVP right.

B

No no yeah you're right the word closes, doesn't actually generate an action to close the issue once the Mr is merged. It's just um I'm just saying that this Mr will close this once it's like it's, it's not actually doing anything, it's just the way I'm wearing it.

A

B

So you could, you could write, addresses yeah whatever you want. I I just pick closes.

A

But it it doesn't actually close the issue, though I.

E

A

No, no, no! No. What I mean is that the issue will still remain open because.

A

B

I'm aware of that element.

A

B

um I'm just trying to remember what the word was called so oh I should just look at the template pending signal, so.

B

So now Earth pending sink.

B

Suggests to them that they need to manually refresh the page right. So would you agree.

A

With that Alvin, yes, yes,.

B

So screenshots um I probably should have taken a screenshot while I was doing it so.

D

So we'll just do that.

B

Okay, how does okay, so what are the steps? um The holiday look like one um set up ldap with um group links to um and then basically we want to start a manual sync right. So.

A

Yeah so go to go to group members. um The group members page here go to the group members page.

A

uh No, no, not not a group members Pages. The group members so group members not possessive um right, no apostrophe, members, um page and click on sync uh sync: Now button click on the sync Now button.

D

Okay, so sample below.

B

It's awful and fill this in a bit more later,.

D

Okay, so that's very big.

B

A

B

Is just sorry, okay,.

A

I think I think that's fine, because it's not a very big change. It doesn't require a lot of like.

B

No you're right, it doesn't so um before we submit it. um I typically will add the milestone, I'm, not sure if it's going to get merged um by the cuttle plate. So the cutoff dates like the the 19th or the 20th. So maybe I'll just leave the Milestone alone for now and let the reviewer do it, but what we do need to add is labels, so in your case I'm just going to pretty much rip um what's here.

B

um So it's bug, ux.

D

I think if you choose the current Milestone, it will just roll over to the next one if it's not merged by then but I. Don't remember, it is the case or not.

B

I think you're right it does do that. um I I mean, let's, let's add it.

D

Let me just add these last few, so sections.

B

Yeah, if you don't add it, dangerbot will complain at you. Oh yeah, as it does a type.

D

D

Now that was the other one.

B

I won't hit the self-manage um I've all had this one support team contributions, because we.

D

Belong to support and.

B

That's pretty much yeah, that's it.

D

B

No you're too kind of, but we got there um so this um obviously there needs to be a lot of pipeline, a lot of jobs to run to vet that everything's okay. Now at that point, there will be uh bot message that says: hey look at the reviewer um roulette dashboard or whatever it's called so you can assign someone to review it.

B

So I'll do that once all the pipeline um once the pipeline passes, hopefully everything's, okay, but then yeah from that point on it's pretty straightforward now, in terms of who would review this change, um you know, you've got multiple teams, you've got ux, you've got front end back-end appsec, in this case, this particular change would probably I would probably pass this on to someone from the ux team. First um to confirm that they're happy with the message and then it would probably go to the front end team. Then it will go to a maintainer.

B

Then it's merged.

B

Then, from my experience, if you change some text of the UI.

D

They'll also ask the technical writers to review it, make sure it sounds fine. Okay,.

B

I didn't know that. Okay, that's.

D

Just from my experience.

B

Like you generally, the reviewer would do it.

E

B

Yeah all right um do you need to hop off, but does anyone have any quick questions before we leave?

B

Yes, why are you so awesome, Anton I, don't know I I think it's. uh You know I'm only as awesome as the people that I'm more around. So you know I hang around with a lot of awesome people, especially.

D

B

So none of us are actually physically around you, so that's why you're able to maintain being of a high? Oh.

D

No, no, no, no.

E

D

No, no, no, no.

E

No, no, no, no you're.

B

Here in spirit you're, here in spirit, thank you.

A

All right, okay,.

B

A

Thanks Anton thanks Kenneth.

B

See you later thanks, everybody bye-bye.