►
From YouTube: UX Group Feedback: Threaded discussions
Description
Marcel van Remmerden shares a visual redesign of our commenting threads.
https://gitlab.com/gitlab-org/gitlab-ce/issues/32452
https://gitlab.com/snippets/1858469
A
So
let
me
start
off
with
what
we
currently
have
if
you
are
in
a
merge
request
and
you
review
the
changes
that
are
being
made,
you
can
see
that
there's
a
couple
of
comments
on
different
lines
and
if
you
open
this,
one
see
that
there's
no
easy
way
to
add
a
new
discussion.
So
whenever
people
have
different
suggestions
or
even
different
comments
to
make,
they
have
to
do
all
of
this
in
this
one
threat.
A
Let
me
zoom
out
to
give
you
all
better
overview
like
this,
and
then
priority
was
set
to
something
else.
This
issue
kinda
went
to
the
backburner
a
bit,
and
now,
one
year
later,
I
picked
up
again,
first
her
to
update
the
designs
to
what's
now
different,
there's
a
couple
of
slight
changes
like,
for
example,
no
gray
area
here
anymore,
as
you
can
see,
but
while
I
reviewed
all
of
the
differences
between
what's
here
and
what
we
currently
have
from
the
pattern.
A
A
This
is
what
we
currently
have
as
a
normal
discussion.
There's
one
main
message,
three
replies
and
then
the
button
for
reply.
This
button
also
has
a
problem
that
it
looks
disabled
and
also
looks
kind
of
lost
in
here.
So
what
I
came
up
with
is
this
first
I
removed
all
of
borders
between
the
individual
replies
and
changed
the
design
for
how
the
replied
is
currently
being
displayed.
A
This
also
works
for
when
you
expand
it,
and
one
nice
feature
that
comes
automatically
with
it
is
that
as
soon
as
you
submit
it,
it
will
stay
in
the
same
place
before
there
was
a
slight
difference.
First,
the
profile
picture
had
to
come
to
its
place
and
it
would
expand-
and
you
can
see
that
now
it's
already
at
the
place
where
it's
going
to
stay
so
taking
this
NBC
for
all
our
discussions
and
applying
it
to
how
we
are
going
to
change
the
design
for
multiple
discussions
for
one
line
in
merge
requests.
A
As
soon
as
you
open
it,
you
could
see
the
different
discussions
that
are
ongoing.
You
can
see
that
you
can
either
reply
in
here.
You
can
see
the
different
replies
that
are
collapsed.
Currently
you
can
expand
them
if
you
expand
them.
It
looks
like
this
and
you
can
start
an
entirely
new
discussion
as
well
right
from
here.
A
A
B
Is
what
you're
saying
is
that
this
conversational
format
will
be
replicated
everywhere,
that
this
type
of
pattern
exists
so
I
know
issues
would
be
an
example
of
that.
It's
not
just
gonna
be
on
merge
requests.
It
will
also
be
on
issues
I
like
seeing
your
head
nod,
that's
wonderful
and
then
just
real
quickly.
I'll
give
you
some
positive
feedback,
which
is
the
visual
elegance
of
removing
the
borders,
is
so
nice.
Thank
you
for
addressing
the
boxes
in
boxes.
No.
A
A
This
is
all
possible
within,
like
just
the
catalog
of
CSS
changes,
except
for
adding
this
profile
picture
here,
but
I'm
sure
this
will
also
not
be
such
a
big
problem
and
as
soon
as
we
move
from
how
we
display
threads
and
discussions,
which
already
is
in
our
instance
sheet-
and
this
is
what
we
want
to
go
with
in
pyjamas
as
soon
as
that's
coming
in
it
will
already
be
improved
as
well.
So
it
works
both
for
the
short
term,
but
also
it's
a
preparation
for
the
long
term.
I
have.
C
A
question
Marcel
so
down
below
where
you
have
the
text
area.
There's
a
button
below
that
says
start
new
discussion.
Is
that
a
current
implementation
that
we
have
where
we
have
the
call
to
action
open
and
ready
to
be
clicked
on?
Even
if
you
don't
put
any
text
in
the
area,
that's
sort
of
confusing
me
like
it's.
It
seems
like
an
active
button
ready
to
be
clicked
on.
Even
if
there's
no
text.
A
D
Have
a
couple
quick
comments:
the
first,
which
starts
with
the
word,
commented
so
I
think
to
the
right
when
I'm
looking
at
Mark
Johnson
at
M,
Johnson
commented
two
months
ago
in
this
in
this
wire.
So
here
we
say
commented
commented
commented
over
and
over
when
it
seems
like
that's
just
implied.
I
noticed
on
the
right
that
had
been
removed.
Is
that
something
we're
planning
to
do
is
take
away
that
what
arguably
could
be
considered
unnecessary?
D
A
A
very
interesting
point-
and
it's
actually
something
where
there's
currently
a
discrepancy
between
what's
implemented
and
that's
what
you
can
see
on
the
light
and
what
we
are
planning
to
do.
According
to
the
pattern,
library
and
the
instance
sheet
that
we
currently
have
what's
to
the
left
is
99%
of.
What's
currently
in
the
pattern,
library
I
haven't
changed
much,
except
for
applying
it
to
this
context
and
adding
the
visual
changes
that
I've
made
for
the
boxes
and
for
the
reply
field.
A
D
A
related-
and
it
probably
also
applies
to
the
pattern
library,
but
a
belated
comment.
I
don't
mean
to
do
the
pun
thing.
It's
just
happening.
Naturally,
progressive
disclosure
right
so
you've
inspired
me
by
removing
the
lines
because
they're
not
necessary
what
about
the
actions.
So
why
can
it
be
that
when
I
hover
over
a
particular
comment,
then
I
see
the
action
icons
but
like
do?
D
We
need
them
always
visible
like
that,
because
in
theory
I'm
going
to
hover
over
the
comment
thread
and
then,
if
they
they're
showing
or
would
have
run,
act
Rhian
and
it
just
fit.
You
know
our
pages
have
a
lot
of
content,
and
so
it's
thoughts
like
this.
That
might
be
able
to
have
like
broad
impact
and
say.
B
A
I
think
it's
a
great
point
and
I
also
already
talked
with
Joey
about
maybe
moving
the
developer
tech
inside
of
the
popover
for
the
user.
This
is
totally
something
where
I
feel
like.
We
could
have
a
lot
of
impact
where
we
could
make
things
a
lot
cleaner
and
a
lot
of
places
at
the
same
time.
I
think
this
are
all
great
ideas
and
we
should
totally
open
an
issue
for
how
we
display
discussions
and
comments
in
general
because
yeah,
as
you
mentioned,
there's
a
lot
of
ideas
and
there's
a
lot
of
potential.
E
Quick
question
I
really
like
the
indentation
that
you
have
on
the
M
are
kind
of
version
of
it,
that's
being
considered
for
the
first
issues
in
general
as
well,
and
I
understand
that
on
the
M
ours,
it's
like
one
of
the
reasons
why
you
have.
That
is
because
you
can
have
multiple
discussions
like
on
the
same
line
code
and
whatever
it
is,
but
I
find
that
just
like
visually.
That
would
really
have
you
been
with
issues
just
because,
even
though
you
think
you
don't
have
the
same
use
case,
yeah,
sorry,
I
kind
of
said.
It's.
E
A
On
to
some
degree
and
I
can't
take
any
credit
for
this
idea,
because
this
was
all
already
and
the
patent
library
and
Charlie
mentioned
before
this
was
actually
Annabelle's
ideas.
So
she
really
should
get
a
lot
of
credit
for
that,
because
I
also
think
this
is
a
big
problem
right
now,
where
we
can't
really
make
sure
which
comment
it
belongs
to
which
conversation
with
which
discussion-
and
this
is
all
taught
because
we
are
using
so
many
different
boxes.
C
F
Would
also
talk
with
Annabelle,
who
worked
most
recently
on
this,
because
I
noticed
that
there
are
lines
between
each
system.
Note
here
and
I
think
we
I
mean
we
did
get
rid
of
them
on
the
actual
site.
So
I
would
just
have
a
conversation,
I,
don't
think
she's
on
the
call
right
now,
but
have
a
conversation
with
her
about
what
is
the
newest
design
versus
what
is
in
the
pattern,
library
and
what
is
because
I
think
it's
all
kind
of
mixed
up
right
now,
so
it'd
be
good
to
kind
of
get.
A
One
issue
Chari
also
already
mentioned
in
a
previous
call
that
we
had
was
that
there's
going
to
be
a
couple
of
problems
here
for
how
we
do
mobile
view,
especially
around
this
area,
and
one
first
idea
that
we
had
was
moving
the
box
to
the
left
and
aligning
it
with
the
profile
picture.
But
then
the
profile
picture
would
also
not
line
up
with
the
other
profile
picture.