GitLab UX Team, 17 Feb 2021

Previous Meeting Next Meeting

⏯

youtube image

►

From YouTube: Reviewing a merge request that requires exports & email review (Design coworking)

Description

A high level review of merge request that requires a review of CSV exports and emails.

A

Hey there alexis here, so I'm looking at this, uh mr that I thought, might be fun to review together. It's a little more complicated because it involves looking at emails and exports and csvs in gdk. So let's look at this and try to do this together. um So first, I just need to look at the branch.

A

I've already checked this out, so I just need to move to this branch and I have gdk running. So all I need to do is say, get check out this branch awesome. So it says I'm up to date with the branch, which is what I would expect.

A

If I restart boca host um it should work. Hopefully no surprise. Is there okay cool? So it looks like it's all right. um So I've now switched that branch. But I know just from looking at this before that.

A

There's some future flags so to open up um or to enable feature plugs with open rails console, and we do that by typing in real c or release id there's a few ways to do it, and then we wait for a second for it to spin up, but then we're just going to enable these feature flags here and um I just pasted them up here to be so.

A

I can reference them as well, but once this is running we'll paste them in here, and this is going to enable the feature flag, you could also disable the feature flag by saying feature disable. Instead, so let's enable requirements and then we're going to enable um import requirements, csv oops. So we can see the csvs awesome. Okay, so we've enabled both of those. Now I'm going to type exit to get out of rails console. So I don't get trapped all right and I'm going to open up a project to look at requirements.

A

Because I know this um change is to requirements awesome, so you can see two requirements here. I'm gonna go ahead and export them to a csv, and this is where it gets a little wonky. So where did that go right like I'm in gdk, it's not gonna send to my email.

A

So then I got to figure out how to review this, because I don't know where this went. I needed to look at it in an email, um but I'm in gdk. So the way to do this is that I need to tail these um rails background jobs.

A

So I'm just going to say: gdk tail rails, background jobs. I have this kind of like stored somewhere, so this is where it's helpful. If uh you're working on an mr and then you know, there's a bunch of commands like this- that the reviewer needs to remember just put them in the description for people like me, who kind of just.

A

I don't do this stuff every day, so I forget it. So it's helpful to have that handy in a description, even in an issue. Description but more relevant would be an mr description. So all right, there's all this stuff. um It doesn't really look like anything but I'll show you how to work with us. So now, when I export I'm gonna, say expert requirements, and I should see something change over here.

A

Yeah, okay, so it's doing it, it was just a little slower and I was being impatient all right. So what you're gonna look for really here is your name, so my name is alexis. So I see my name here and I see this kind of file. Oh I'm gonna go down because did I do ah anyway? Let's go back up sorry about that.

A

Gonna look, but you know what I'm just. I saw my name, but now I've lost my place, so I'm just gonna do that again, because I can cool just wait for a second awesome, all right there we go so there's this kind of a location and you're going to copy this starting a file and that's referencing html file. That's within um your gdk, so I'm going to open up a new tab and just paste all of that in here the entire thing. So what that does basically is shows you what that email would look like.

A

So you know, let's say I'm a user I just exported, and then I would open my email, and this is what I would see so then you know same same thing. If that was a user. I would then open up the attachment, because gitlab told me this would be sent to me as an attachment, and I would open that and awesome. So this looks like what I expected. I see um the expert here, but let's kind of play around with this because we know this is about customizing these uh csvs.

A

So let's first we'll create another requirement requirement 3, and we just want to test out that um that I'm able to both customize the csv and that reflects any changes we make so change. I'm gonna create that requirement.

A

um Let's change this requirement again, um I'll just add emoji cause I like them and say uh alexis changed yet again for review. Okay, something like that. Oh I can't spell review. Oh my gosh, all right there we go. I don't know it doesn't even matter, I'm just being silly all right, cool see, it changes awesome all right.

A

Let's see if that updated, and I only want to see title and description here and maybe state so I'm going to export the requirements and then we're going to look over here to see where to find that new export all right. Let's look for my name, I just saw it and then it jumped away.

A

Mm-Hmm, you know what again I'm just going to do this again, because I'm impatient you can make this terminal bigger, but I'm just not so.

A

All right cool so again we're just going to pop a new tab, and here is my new export, I'm going to click it to open and download my export.

A

Oh, this looks like the wrong one, or is it the wrong one.

A

Oh, it's because I did it twice, of course well well, at least we know it reflected the changes, but let's then customize the csv again. Okay, let's say I just I just want title and description. It's really not useful, but that's fine. I just want the title and description of these requirements and again.

A

Oh, no, okay, I'm not making the mistake of being impatient again. Let's just find, let's just find that file. Where did it go? I think it was this one.

A

All right, oh I don't know if that works. Oh, I don't know what I just said, but I saw a link for one second, oh no. I did something silly all right.

A

It's friday, it's okay! It's been silly, sometimes right, all right cool. I think that did it awesome.

A

All right, yay, okay, see so it did customize the csv like I would have expected. I said all I wanted to see was title and description and all I see is title and was in description, cool all right. So that looks good like I think the scope of this, mr, is filled and fulfilled, and we'll keep iterating here to make this look better and better, but I think I can go ahead and improve this.

A

So awesome y'all thanks for uh working on this with me, I'm just going to go ahead and say control c to get out of this and then gdk stop to make sure my gdk is stopped and not running on my computer and make it overheat and run slow.

A

So remember to do that remember to stop ddk, but otherwise. I think we're good thanks for running through that with me. Y'all talk to you later, bye.